D21661: add snoretoast backend for KNotifications on Windows

sredman added a comment. In D21661#476571 , @pino wrote: > In D21661#476156 , @pino wrote: > > > how is snoretoast actually used here? you are requiring the library for building and linking, but

D21661: add snoretoast backend for KNotifications on Windows

pino added a comment. > This comment was removed by brute4s99. This comment was: > updated wrt review by toscanos Please do **NOT** remove your own comments. Other than being anti-social (imagine how easily you can twist conversations), in this case it's perfectly useless, as

D21661: add snoretoast backend for KNotifications on Windows

pino added inline comments. INLINE COMMENTS > CMakeLists.txt:112 > +if (TARGET SnoreToast::SnoreToastActions) > + target_link_libraries(KF5Notifications PRIVATE Qt5::Core Qt5::Network > SnoreToast::SnoreToastActions) > +endif () `Qt5::Core` is not needed here; if we really want to be

D21661: add snoretoast backend for KNotifications on Windows

pino added a comment. In D21661#476156 , @pino wrote: > how is snoretoast actually used here? you are requiring the library for building and linking, but then: > > - `snoretoastactions.h`, which is part of the headers of snoretoast, is

D21681: ECMPackageConfigHelpers -> CMakePackageConfigHelpers

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY As suggested by the ecm package itself REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

bruns added a dependent revision: D21680: [UnindexedFileIndexer] Pick up comment, tags and rating changes. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21577 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21680: [UnindexedFileIndexer] Pick up comment, tags and rating changes

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY A folder should be reindexed (i.e. the terms should be

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 4 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59425. brute4s99 marked 2 inline comments as done. brute4s99 added a comment. updated acc to review by Hannah REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59401=59425 BRANCH win32 (branched from

D21586: Add syntax definition for ninja build

This revision was automatically updated to reflect the committed changes. Closed by commit R216:a72b6b5e53ec: Add syntax definition for ninja build (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21586?vs=59240=59421

D21661: add snoretoast backend for KNotifications on Windows

vonreth added inline comments. INLINE COMMENTS > CMakeLists.txt:45 > + set_package_properties(LibSnoreToast PROPERTIES TYPE REQUIRED > + PURPOSE "Enable support for the snorenotify framework" > + DESCRIPTION "a cross-platform notification framework" It's snoretoast not

D21533: Format photo exposure time as rational when applicable

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh,

D21672: [PowerStateMonitor] Be conservative when determining power state

bruns added reviewers: Baloo, ngraham, astippich, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21672 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D21674: [balooctl] Streamline indexer control commands

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Currently, there are 7 commands which start/stop the

D21673: [FileIndexScheduler] Ensure indexer is not run in suspended state

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY After commit b13453360685

D21672: [PowerStateMonitor] Be conservative when determining power state

bruns created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When the state defaults to AC-powered, the indexer may start some energy consuming tasks, only to stop these

D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The 'stop' flag was not set when the scheduler is quit,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. updating acc to review by pino REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59401. brute4s99 marked an inline comment as done. brute4s99 added a comment. updated wrt review by toscanos REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59379=59401 BRANCH win32 (branched from

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 22 inline comments as done and an inline comment as not done. brute4s99 added a comment. update incoming INLINE COMMENTS > pino wrote in CMakeLists.txt:48-49 > why are these two needed? if snoretoast require them, then its cmake config > file must require them, so that the

D21586: Add syntax definition for ninja build

cullmann added a comment. Perhaps we must go away from the implicit listing of the syntax files and really just add them all to the CMakeLists.txt, REPOSITORY R216 Syntax Highlighting BRANCH ninja (branched from master) REVISION DETAIL https://phabricator.kde.org/D21586 To: jpoelen,

D21656: Create a breeze icon for kfourinline

ngraham added a comment. Also please add a one-pixel hard bottom shadow. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 119 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/119/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Jun 2019 09:39:36 + Build duration: 1 hr 38 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 48 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/48/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Jun 2019 09:42:40 + Build duration: 1 hr 30 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/114/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Jun 2019 09:42:30 + Build duration: 1 hr 28 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/28/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Jun 2019 09:41:56 + Build duration: 1 hr 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 58 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/58/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 08 Jun 2019 09:39:18 + Build duration: 1 hr 25 min and counting JUnit Tests

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Jun 2019 09:41:45 + Build duration: 1 hr 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/40/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:42:52 + Build duration: 1 hr 9 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/124/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:42:30 + Build duration: 1 hr 7 min and counting JUnit Tests

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/94/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Jun 2019 09:38:53 + Build duration: 1 hr 8 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Jun 2019 09:38:18 + Build duration: 1 hr 6 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/30/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:41:56 + Build duration: 1 hr 2 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/47/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:41:45 + Build duration: 55 min and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/53/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Jun 2019 09:42:40 + Build duration: 51 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:41:15 + Build duration: 45 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 121 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/121/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Jun 2019 09:42:30 + Build duration: 42 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:40:57 + Build duration: 43 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/43/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Jun 2019 09:41:45 + Build duration: 40 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/32/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:40:35 + Build duration: 41 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/129/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:39:37 + Build duration: 39 min and counting JUnit Tests Name: projectroot

D21656: Create a breeze icon for kfourinline

ndavis added a comment. We don't normally do the gloss wave in Breeze. That's more of a Tango/Oxygen thing. How about adding some holes instead to make it look more like the real thing? https://www.gamesworld.com.au/wp-content/uploads/2015/10/cardinal-four-in-a-row.jpg Just some ideas:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:38:28 + Build duration: 24 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/31/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:38:18 + Build duration: 24 min and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/100/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Jun 2019 09:38:53 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/50/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 08 Jun 2019 09:37:52 + Build duration: 20 min and counting JUnit Tests Name:

D21661: add snoretoast backend for KNotifications on Windows

pino added inline comments. INLINE COMMENTS > notifybysnore.cpp:115 > +{ > +if (m_notifications.find(notification->id()) != m_notifications.end()) { > +qCDebug(LOG_KNOTIFICATIONS) << "Duplicate notification with ID: > " << notification->id() << " ignored."; since this method is

D21661: add snoretoast backend for KNotifications on Windows

pino added a comment. how is snoretoast actually used here? you are requiring the library for building and linking, but then: - `snoretoastactions.h`, which is part of the headers of snoretoast, is copied here - the snoretoast library is never used, as the utilities of it are invoked