KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 56 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/56/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 14 Jun 2019 05:43:33 + Build duration: 2 min 55 sec and counting BUILD ARTIFACTS

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59774. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59766=59774 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/99/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 14 Jun 2019 00:11:02 + Build duration: 2 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/105/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 14 Jun 2019 00:11:02 + Build duration: 2 min 53 sec and counting BUILD ARTIFACTS

D20967: [UserMetaData] Add method to query which attributes are set

This revision was automatically updated to reflect the committed changes. Closed by commit R286:bbb05dfe7f9f: [UserMetaData] Add method to query which attributes are set (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. FreeBSD and WIndows folks had their chance to speak up - Windows will just have to wait for the CI ... FreeBSD has been reviewed, @arrowd - Thanks! REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns,

D21788: Make Plasma::Svg::elementRect a bit leaner

apol updated this revision to Diff 59772. apol added a comment. Prefer a QRegularExpression to QRegExp REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21788?vs=59746=59772 BRANCH master REVISION DETAIL

D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time

bruns edited the summary of this revision. bruns added a dependency: D21790: [PendingFileQueue] Use more accurate calculation of remaining time. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21791 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel,

D21790: [PendingFileQueue] Use more accurate calculation of remaining time

bruns added a dependent revision: D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21790 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21792: [PendingFileQueue] Refactor for easier and faster unit testing

bruns added a dependent revision: D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21792 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test

bruns edited the summary of this revision. bruns added a dependency: D21792: [PendingFileQueue] Refactor for easier and faster unit testing. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21793 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel,

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

bruns added a comment. In D21709#477608 , @ngraham wrote: > LGTM, but maybe an autotest might make sense for this case. I have submitted some preliminary changes to make this more feasible. The current autotest structure is not really

D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Waiting 5 seconds until the pending file queue has been

D21792: [PendingFileQueue] Refactor for easier and faster unit testing

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Supply the current time as an argument to the slots, so

D21790: [PendingFileQueue] Use more accurate calculation of remaining time

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY QTime::secsTo completely ignores any fractional

D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There is no need to wait 2 seconds until the file is

D21788: Make Plasma::Svg::elementRect a bit leaner

bruns added a comment. Please put the dead code removal in a separate review. INLINE COMMENTS > svg.cpp:111 > const QString contentsAsString(QString::fromLatin1(contents)); > -QRegExp idExpr(QLatin1String("id\\s*=\\s*(['\"])(\\d+-\\d+-.*)\\1")); > +static QRegExp >

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59766. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59765=59766 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt

D21656: Create a breeze icon for kfourinline

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ndavis added a comment. I just tried the patch on my own computer and I noticed a few more things that need to be changed: - The canvas size is 128x128 px when it should be 48x48 - Strokes need to be converted to paths ( [Ctrl] + [Alt] + [c] ). Strokes don't always look correct in

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59765. brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59574=59765 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 67 inline comments as done. brute4s99 added a comment. updated code incoming. I think I should make a new diff for further discussions, as this one is quite riddled with suggestions now. Are there any more issues with this patch or should I continue with a new one instead?

D15739: [Places panel] Don't show Root by default

ngraham accepted this revision. ngraham added a comment. Lovely. :) REPOSITORY R241 KIO BRANCH arcpatch-D15739 REVISION DETAIL https://phabricator.kde.org/D15739 To: meven, #dolphin, #vdg, tcanabrava, ngraham Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg,

D15739: [Places panel] Don't show Root by default

meven added a dependent revision: D21789: Fix tests relating to the removal of the Root Place in D15739. REPOSITORY R241 KIO BRANCH arcpatch-D15739 REVISION DETAIL https://phabricator.kde.org/D15739 To: meven, #dolphin, #vdg, tcanabrava, ngraham Cc: meven, elvisangelaccio, Codezela,

D15739: [Places panel] Don't show Root by default

meven updated this revision to Diff 59751. meven added a comment. - Adapt test to remove Root in the Places by default REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15739?vs=59750=59751 BRANCH arcpatch-D15739 REVISION DETAIL

D15739: [Places panel] Don't show Root by default

ngraham added a comment. <3 Nice huge diff! You see why I had trouble with it, maybe. :) I am very impressed that you pulled this off so quickly though! REPOSITORY R241 KIO BRANCH arcpatch-D15739 REVISION DETAIL https://phabricator.kde.org/D15739 To: meven, #dolphin, #vdg,

D15739: [Places panel] Don't show Root by default

meven updated this revision to Diff 59750. meven added a comment. - Adapt test to remove Root in the Places by default REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15739?vs=59749=59750 BRANCH arcpatch-D15739 REVISION DETAIL

D15739: [Places panel] Don't show Root by default

meven commandeered this revision. meven added a reviewer: ngraham. meven added a comment. Taking over this. Dolphin test fix patch is coming too. REPOSITORY R241 KIO BRANCH arcpatch-D15739 REVISION DETAIL https://phabricator.kde.org/D15739 To: meven, #dolphin, #vdg, tcanabrava,

D15739: [Places panel] Don't show Root by default

meven updated this revision to Diff 59749. meven added a comment. This revision is now accepted and ready to land. - Adapt test to remove Root in the Places by default REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15739?vs=42276=59749 BRANCH

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 132 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/132/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 13 Jun 2019 19:02:44 + Build duration: 7 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 122 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/122/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 13 Jun 2019 19:02:43 + Build duration: 7 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 132 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/132/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 13 Jun 2019 19:02:44 + Build duration: 6 min 29 sec and counting BUILD ARTIFACTS

D14464: Cancel privilege operation for read-only target with the current user as owner

chinmoyr closed this revision. chinmoyr added a comment. https://commits.kde.org/kio/14b29cf64611f91f0bc1f5828e4c86392510f0e6 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14464 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin Cc:

D14464: Cancel privilege operation for read-only target with the current user as owner

chinmoyr updated this revision to Diff 59748. chinmoyr added a comment. Updated frameworks version. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14464?vs=38714=59748 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14464 AFFECTED FILES

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr added a comment. In D14467#479223 , @ngraham wrote: > @mgerstner How is this looking now? Yea/nay? He is not available for the next couple of weeks. However he did ask one of his colleagues to have a look at it. REPOSITORY

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham added a comment. Totally awesome :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21788: Make Plasma::Svg::elementRect a bit leaner

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Don't double-access maps Don't construct ids more times than necessary. Make

D14467: Auth Support: Drop privileges if target is not owned by root

ngraham added a comment. @mgerstner How is this looking now? Yea/nay? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14467 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin Cc: mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham,

D14464: Cancel privilege operation for read-only target with the current user as owner

ngraham added a comment. @chinmoyr can you address @dfaure's remaining comments so we can get this in? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D14464 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin Cc: kde-frameworks-devel,

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr added a comment. In D21782#479190 , @GB_2 wrote: > I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/ Thanks! I'll give it a shot. REPOSITORY R236 KWidgetsAddons

D21782: Add a warning dialog with details, continue, and cancel button

ngraham added a comment. In D21782#479190 , @GB_2 wrote: > I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/ +1, this seems like a perfect use of that widget in fact.

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

davidedmundson planned changes to this revision. davidedmundson added a comment. Will make new and improved version REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21618 To: davidedmundson, #plasma, apol Cc: broulik, apol, kde-frameworks-devel,

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added a comment. In D21783#479187 , @ngraham wrote: > Thanks! Is this for T8075 ? Yes it is. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg,

D21782: Add a warning dialog with details, continue, and cancel button

GB_2 added a comment. I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/ REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure Cc: GB_2,

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham added a comment. Thanks! Is this for T8075 ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 59738. chinmoyr added a comment. Fix typo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=59737=59738 BRANCH warn REVISION DETAIL https://phabricator.kde.org/D21783 AFFECTED FILES

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr created this revision. chinmoyr added reviewers: VDG, Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Currently it uses the dialog from D21782

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr created this revision. chinmoyr added reviewers: VDG, Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY F6887442: warningdialog.png

D15739: [Places panel] Don't show Root by default

ngraham added a comment. If you'd like to, I'm more than happy to hand it off. Removing Root is trivial, but adjusting the autotest has been a big pain. It explicitly looks for Root and I've had a tough time changing it appropriately. I've sunk a number of hours into it without success, so

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/116/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 13 Jun 2019 13:38:53 + Build duration: 5 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 123 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/123/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 13 Jun 2019 13:38:53 + Build duration: 4 min 49 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/126/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 13 Jun 2019 13:38:53 + Build duration: 2 min 39 sec and counting JUnit Tests

D21767: Automatically set version of desktopthemes packages to KF5_VERSION

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eff37abdcbda: Automatically set version of desktopthemes packages to KF5_VERSION (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21767?vs=59650=59729#toc REPOSITORY

D21780: Add X-Flatpak-RenamedFrom as recognized key

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM. I do not actually know why we need the type definition to begin with though, it occurs to me sycoca could/should just contain all keys it found in the desktop file since they

D21780: Add X-Flatpak-RenamedFrom as recognized key

broulik created this revision. broulik added reviewers: Frameworks, dfaure, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Flatpak enforces RDN notation (`com.example.foo.bar`) from

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59720. ognarb added a comment. Use more round corner. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59707=59720 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » attica » kf5-qt5 AndroidQt5.12 - Build # 21 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/21/ Project: kf5-qt5 AndroidQt5.12 Date of build: Thu, 13 Jun 2019 10:07:22 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT

D21778: Add some documentation for PlatformDependent

This revision was automatically updated to reflect the committed changes. Closed by commit R235:fbda1d799cc1: Add some documentation for PlatformDependent (authored by bshah). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21778?vs=59711=59712 REVISION DETAIL

D21778: Add some documentation for PlatformDependent

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good :) REPOSITORY R235 Attica BRANCH bshah/docs REVISION DETAIL https://phabricator.kde.org/D21778 To: bshah, leinir Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham,

D21778: Add some documentation for PlatformDependent

bshah created this revision. bshah added a reviewer: leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY Also add note about deprecating askForCredentials and saveCredentials in future.

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#478676 , @ngraham wrote: > Could the new one be API compatible so we wouldn't need to wait for KF6? Also it's always nice to avoid breaking API if you don't have to. Not entirely sure we can do that, the

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59707. ognarb added a comment. Change color of some points REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59706=59707 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59706. ognarb added a comment. Still works in progress (need to add the gradiend) but some improvement REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59372=59706 BRANCH master REVISION DETAIL

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

broulik added inline comments. INLINE COMMENTS > appletinterface.cpp:172 > > -applet()->updateConstraints(Plasma::Types::UiReadyConstraint); > +if (m_loadingRef == 0) { > +applet()->updateConstraints(Plasma::Types::UiReadyConstraint); In my case this code path is hit before