D21907: Show feedback inline when creating new files or folders

squeakypancakes added a comment. Do the warnings need to below the buttons? I feel like they are kinda out of place there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham Cc: squeakypancakes, dhaumann, aacid, meven,

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. The gif depicts a rather extreme case where you're deliberately trying to test all the feedback modes in quick succession. :) At @meven's request, I've already removed the red error message when the text field is empty. REPOSITORY R241 KIO REVISION DETAIL

D21907: Show feedback inline when creating new files or folders

dhaumann added a comment. Have not looked at the patch, just the gif: I am rather sceptical if instant feedback is a good idea here. First, having an empty line edit will happen a lot, usually without the user wanting to press OK. That means the user will already get feedback in the middle

D21907: Show feedback inline when creating new files or folders

aacid added inline comments. INLINE COMMENTS > meven wrote in knewfilemenu.cpp:1071 > What about Windows ? maybe use QDir::separator() ? read the docu for QDir::separator() , you seldom ever want to use it. https://agateau.com/2015/qdir-separator-considered-harmful/ REPOSITORY R241 KIO

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. In D21907#482087 , @meven wrote: > It made me think about D17595 . > Would it make sense to upstream this to KIO and unify behavior with Open/Save Dialog (it currently has a folder

D21907: Show feedback inline when creating new files or folders

meven added a comment. It made me think about D17595 . Would it make sense to upstream this to KIO and unify behavior with Open/Save Dialog (it currently has a folder name check using popups). This is a different matter so it should not stop progress

Re: KInit - Current state and benchmarks

El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va escriure: > > Are we sure it's fair to assume people have SSD? our of the 4 laptops i > > own, only 2 have SSD. > > It's at least safe to assume it's the trend moving forward. > > > Do you think it's worth me trying in one

D21907: Show feedback inline when creating new files or folders

ngraham updated this revision to Diff 60079. ngraham marked an inline comment as done. ngraham added a comment. Don't show an ugly error when the text field is blank REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21907?vs=60072=60079 BRANCH

D21907: Show feedback inline when creating new files or folders

meven added inline comments. INLINE COMMENTS > knewfilemenu.cpp:1047 > +if (text.length() == 0) { > +m_messageWidget->setText(i18n("Name cannot be blank.")); > +m_messageWidget->setMessageType(KMessageWidget::Error); I would rather disable the ok button, as long as the user

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel,

D18599: Use specific error message if file/folder name contains '/'

shubham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: emateli, pino, dhaumann, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. I've submitted a proposed replacement for this as D21907: Show feedback inline when creating new files or folders . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks,

D18384: Allow creating directory named '~' and throw a warning before creating it.

ngraham added a comment. I've submitted a proposed replacement for this as D21907: Show feedback inline when creating new files or folders . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: emateli,

D18599: Use specific error message if file/folder name contains '/'

ngraham added a comment. I've submitted a proposed replacement for this as D21907: Show feedback inline when creating new files or folders . REPOSITORY R241 KIO BRANCH err REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham,

D21907: Show feedback inline when creating new files or folders

ngraham created this revision. ngraham added reviewers: VDG, Frameworks, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, the new file/folder dialog allows you to give it an

D21901: Calendar events: allow plugins to show event details

dvratil added a dependent revision: D21906: Events plugin: implement the new showEvent() API. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

dvratil added a dependent revision: D21905: [Digital Clock] Open KOrganizer with event details on click. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil updated this revision to Diff 60068. dvratil added a comment. - Fix ABI compatibility REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21901?vs=60065=60068 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21901 AFFECTED FILES

D21902: Calendar: add method to show event details

dvratil created this revision. dvratil added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY This extends the API to allow calendar UIs to request opening a detailed view of an

D21902: Calendar: add method to show event details

dvratil added a dependency: D21901: Calendar events: allow plugins to show event details. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil added a dependent revision: D21902: Calendar: add method to show event details. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil added a reviewer: Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY This adds new method to the plugin API that will allow plugins to show event details when user clicks on the event,

Re: KInit - Current state and benchmarks

On Wed, 19 Jun 2019, 16:39 Aleix Pol, wrote: > On Tue, Jun 18, 2019 at 12:05 PM David Edmundson > wrote: > > > > > Are we sure it's fair to assume people have SSD? our of the 4 laptops > i own, only 2 have SSD. > > > > It's at least safe to assume it's the trend moving forward. > > > > > Do you

Re: KInit - Current state and benchmarks

On Tue, Jun 18, 2019 at 12:05 PM David Edmundson wrote: > > > Are we sure it's fair to assume people have SSD? our of the 4 laptops i > > own, only 2 have SSD. > > It's at least safe to assume it's the trend moving forward. > > > Do you think it's worth me trying in one of the two that don't

D18384: Allow creating directory named '~' and throw a warning before creating it.

ngraham added a comment. Yes, I plan to put it up for review today or tomorrow. Sorry for the long wait! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: emateli, pino, dhaumann, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. Yes, I plan to put it up for review today or tomorrow. Sorry for the long wait! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck,

D21788: Make Plasma::Svg::elementRect a bit leaner

apol added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21788 To: apol, #plasma, #frameworks Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21882: RFC: [CopyJob] Batch reporting processed amount

chinmoyr accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21882 To: broulik, #frameworks, dfaure, chinmoyr, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21897: Address some issues reported by Krazy analysis

pajamapants3000 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pajamapants3000 requested review of this revision. REVISION SUMMARY Resolved all issues discovered by the krazy plugins: crashy, explicit. Other issues remain; I left

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60052. leinir marked 2 inline comments as done. leinir added a comment. Address pino's comments about BIC (and some documentation) - Don't mark functions virtual which should not be virtual - Apply the signal/slot virt func workaround for improved

Re: KInit - Current state and benchmarks

> Seems like this would need some refocusing if we want to keep it? Definitely. We've essentially broken all of it right now. My goal for the research and this thread is to try and get a definitive kde-wide answer to "if we want to keep it" so I know where to put work in.

D21607: Don't delay emission of matchesChanged indefinitely

This revision was automatically updated to reflect the committed changes. Closed by commit R308:a07027cd4f22: Dont delay emission of matchesChanged indefinitely (authored by fvogt). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21607?vs=59252=60049 REVISION

D21894: set the focusPolicy of kpasswordlineedit to the policy of its proxy

sitter created this revision. sitter added a reviewer: cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this is entirely the same kind of change as done in

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > pino wrote in engine.h:471 > BIC change, you cannot add virtual functions in a public class That shouldn't be virtual anyway, not sure why i did that... > pino wrote in provider.h:148 > BIC change, you

D21813: RFC: Consider adding more padding to the desktop theme

ngraham added a comment. In D21813#481300 , @filipf wrote: > In D21813#481152 , @martinsotirov wrote: > > > I think Plasma needs a whole lot more padding all over the place, not just in the

D21607: Don't delay emission of matchesChanged indefinitely

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I tried it and it works fine for me. Note that the AppStream runner's behavior has improved as of 0.12.7 since it now correctly returns no results instead of all results when it doesn't

D21882: RFC: [CopyJob] Batch reporting processed amount

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21882 To: broulik, #frameworks, dfaure, chinmoyr, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added inline comments. INLINE COMMENTS > brute4s99 wrote in notifybysnore.cpp:84 > well, I just found out the patch had broken functionality that I fixed just > after putting here an `else return`!  I have fixed the issue now. REPOSITORY R289 KNotifications REVISION DETAIL