D21940: Make automatic spellcheck work after reloading a document

sars added a comment. LGTM REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21940 To: ahmadsamir, #ktexteditor, cullmann Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, dhaumann

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 60167. chinmoyr marked 5 inline comments as done. chinmoyr added a comment. Thanks @maltek. I've fixed all the issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14467?vs=59319=60167 BRANCH arcpatch-D14467

D21931: [kmoretools] Add icons to download and install actions

gregormi accepted this revision. gregormi added a comment. Looks good to me. REPOSITORY R304 KNewStuff BRANCH actions REVISION DETAIL https://phabricator.kde.org/D21931 To: nicolasfella, gregormi, ngraham, #vdg, #knewstuff Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

meven abandoned this revision. meven added a comment. The change was making wrong assumptions. kconfig_compile is due to old version of the tool being installed in debian/ubuntu. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D21923 To: meven, dfaure, #frameworks

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When a document gets reloaded for whatever reason, automatic spellcheck should be refreshed so as to

D21933: Symlink install to edit-download

This revision was automatically updated to reflect the committed changes. Closed by commit R266:8ff69b32634d: Symlink install to edit-download (authored by nicolasfella). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21933?vs=60142=60143 REVISION

D21933: Symlink install to edit-download

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, download is basically the same as install from this perspective. REPOSITORY R266 Breeze Icons BRANCH foo REVISION DETAIL https://phabricator.kde.org/D21933 To: nicolasfella,

D21933: Symlink install to edit-download

nicolasfella created this revision. nicolasfella added reviewers: Breeze, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY edit-download is the icon we want for this purpose REPOSITORY

D21933: Symlink install to edit-download

nicolasfella added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21933 To: nicolasfella, #breeze, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Please add description, otherwise let's try it out. REPOSITORY R273 KGuiAddons BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20193 To: apol, romangg Cc:

D21907: Show feedback inline when creating new files or folders

ngraham updated this revision to Diff 60137. ngraham added a comment. This revision is now accepted and ready to land. - Do the right thing on Windows - Don't show any warnings when creating filenames with slashes in them (KIO currently allows it but substitutes a different character)

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

apol edited the summary of this revision. apol edited the test plan for this revision. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D20193 To: apol Cc: dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20443: Move to runtime the decision to use x11 or not

apol updated this revision to Diff 60135. apol added a comment. rebase REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20443?vs=55915=60135 BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20443 AFFECTED FILES

D21931: [kmoretools] Add icons to download and install actions

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R304 KNewStuff BRANCH actions REVISION DETAIL https://phabricator.kde.org/D21931 To: nicolasfella, gregormi, ngraham, #vdg, #knewstuff Cc: kde-frameworks-devel,

D21931: [kmoretools] Add icons to download and install actions

ngraham edited reviewers, added: KNewStuff; removed: Spectacle. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21931 To: nicolasfella, gregormi, ngraham, #vdg, #knewstuff, #spectacle Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21931: [kmoretools] Add icons to download and install actions

ngraham added reviewers: VDG, Spectacle. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21931 To: nicolasfella, gregormi, ngraham, #vdg, #spectacle Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21931: [kmoretools] Add icons to download and install actions

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Makes it look nicer REPOSITORY R304 KNewStuff BRANCH actions REVISION DETAIL

D21931: [kmoretools] Add icons to download and install actions

nicolasfella added reviewers: gregormi, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21931 To: nicolasfella, gregormi, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > display.h:207 > + > +/** @since 5.57 */ > +KeyStateInterface *createKeyStateInterface(QObject *parent = nullptr); please keep up to date. >

D21907: Show feedback inline when creating new files or folders

ngraham planned changes to this revision. ngraham added a comment. Going to better handle Windows and also fix a bug that slipped in. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf Cc: filipf, squeakypancakes,

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. Any more comments? REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf Cc: filipf, squeakypancakes, dhaumann, aacid, meven,

D21907: Show feedback inline when creating new files or folders

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Looks good from a visual and usability POV. REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To:

D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

meven added a comment. In D21923#482383 , @apol wrote: > That doesn't look alright: > https://phabricator.kde.org/source/kconfig/browse/master/src/kconfig_compiler/kconfig_compiler.cpp$1768 That is a line I am editing in this patch

D21864: [QueryTest] Test if independent phrases are really independent

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH phrasestorage_fixes REVISION DETAIL https://phabricator.kde.org/D21864 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

D21862: [QueryTest] Restructure tests to allow easier extension

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH phrasestorage_fixes REVISION DETAIL https://phabricator.kde.org/D21862 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

D21863: [TermGenerator] Insert an empty position between independent terms

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH phrasestorage_fixes REVISION DETAIL https://phabricator.kde.org/D21863 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

D12992: New elisa icon

ngraham added a comment. @lshoravi ping! Any chance we can finish up work on this icon and get it in? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: abetts, paullesur, januz, mgallien, alex-l, andreask,

D16694: Improve visibility for Konsole icon when using Breeze Dark

ngraham added a comment. Ping! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16694 To: anishgiri, ngraham, #vdg Cc: emateli, ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

apol added a comment. That doesn't look alright: https://phabricator.kde.org/source/kconfig/browse/master/src/kconfig_compiler/kconfig_compiler.cpp$1768 We are still including the _kf5 postfix. Also note the executable still is called kconfig_compiler_kf5 REPOSITORY R237

D21919: Change joystick settings icon to game controller

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7ef3c35c7ed6: Change joystick settings icon to game controller (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21919?vs=60102=60113

D21919: Change joystick settings icon to game controller

ngraham added a comment. Looks like that's done in D21922 REPOSITORY R266 Breeze Icons BRANCH joystick-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D21919 To: ndavis, #vdg, ngraham, filipf Cc: usta, davidedmundson,

D21919: Change joystick settings icon to game controller

filipf accepted this revision. REPOSITORY R266 Breeze Icons BRANCH joystick-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D21919 To: ndavis, #vdg, ngraham, filipf Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

meven created this revision. meven added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Since https://git.reviewboard.kde.org/r/116995/diff/1#index_header

D21919: Change joystick settings icon to game controller

usta added a comment. In D21919#482275 , @ngraham wrote: > Maybe we should also consider renaming the KCM to be "Gaming Controller" since I don't know how many people are actually using standalone joysticks anymore. I remember that those were

D15645: Add scheme selection menu with a "System" entry.

ngraham added a comment. I'm sorry this got lost, @amhndu. Is this reviewable in its current state? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino Cc: pino, ngraham, broulik,

D21919: Change joystick settings icon to game controller

ngraham added a comment. Maybe we should also consider renaming the KCM to be "Gaming Controller" since I don't know how many people are actually using standalone joysticks anymore. I remember that those were all the rage in the 90s, but probably these days people are just using their XBox

D21919: Change joystick settings icon to game controller

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH joystick-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D21919 To: ndavis, #vdg, ngraham Cc: davidedmundson, kde-frameworks-devel, LeGast00n,

D21919: Change joystick settings icon to game controller

davidedmundson added a comment. +1 from me. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21919 To: ndavis, #vdg Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21919 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21919 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG: 406679 FIXED-IN: 5.60 REPOSITORY R266 Breeze Icons BRANCH joystick-settings

D20026: Go up in folder hierachy when in "edit mode"

ngraham added a comment. What's the status of this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

ngraham added a comment. In D21907#482146 , @dhaumann wrote: > The much better fix would be: create the folder "New Folder" inline in the list view and immediately switch to edit mode, this way you do not need a dialog at all but don't loose