D22102: Implement apply-on-double-click for all grid view KCM delegates

mglb added a comment. In D22102#487806 , @ngraham wrote: > use its hidden Alt accelerator. Seems like already working solution for the problem. Whats wrong with alt accelerator? REPOSITORY R296 KDeclarative REVISION DETAIL

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/34/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 01 Jul 2019 02:55:30 + Build duration: 1 min 58 sec and counting JUnit Tests Name:

D21204: Ensure no trailing slash in mountpoint read from fstab file

ngraham retitled this revision from "Ensure no trailing slash in mountpoint read from fstab file." to "Ensure no trailing slash in mountpoint read from fstab file". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks Cc: dhaumann,

D21204: Ensure no trailing slash in mountpoint read from fstab file.

ngraham added a comment. In D21204#488719 , @dhaumann wrote: > Minor/general comment: given this is a KDE Frameworks change, could you improve the summary of the commit message for this and future commits? Here it just says bug, ccbug, fixedin.

D22108: [TabBar] Remove exterior margins

This revision was automatically updated to reflect the committed changes. Closed by commit R242:97272465a8b4: [TabBar] Remove exterior margins (authored by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22108?vs=60704=60896

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/128/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 30 Jun 2019 22:06:48 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 121 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/121/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 30 Jun 2019 22:06:48 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 131 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/131/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 30 Jun 2019 22:06:48 + Build duration: 4 min 2 sec and counting JUnit Tests

D21204: Ensure no trailing slash in mountpoint read from fstab file.

dhaumann added a comment. Minor/general comment: given this is a KDE Frameworks change, could you improve the summary of the commit message for this and future commits? Here it just says bug, ccbug, fixedin. Imho a commit log should be self-explaining and self-contained: what is broken

D21813: RFC: Consider adding more padding to the desktop theme

filipf added a comment. friendly ping @ndavis would you be willing to give it a go at making a proper patch for this (i.e. editing the Breeze svg)? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham,

Tipping the apple cart?

Hello folks, as you know, I'm not a coder. However, I'm interested in our code quality, and there has been some observation that "lots of patches get missed, and submitters get confused due to a lack of auto-populated reviewers" on Phabricator. Nate Graham has been adding groups to the reviewers

D21902: Calendar: add method to show event details

dvratil updated this revision to Diff 60891. dvratil added a comment. Adapt to API changes in D21901 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21902?vs=60066=60891 BRANCH master REVISION

D21901: Calendar events: allow plugins to show event details

dvratil updated this revision to Diff 60890. dvratil added a comment. Make the change truly API and ABI compatible REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21901?vs=60068=60890 BRANCH master REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#486700 , @meven wrote: > I have started D22082 enrolling the plan set in the previous comment. > > Once this task has done enough progress and has landed some of its work, I

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh,

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven added a comment. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales,

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh,

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 60886. meven marked an inline comment as done. meven added a comment. New json metadata file REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=60789=60886 BRANCH master REVISION DETAIL

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

meven added a comment. Nice work ! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22144: - Add kio recentlyused:/ to access KactivitytStats data

elvisangelaccio added inline comments. INLINE COMMENTS > recentlyused.protocol:1-14 > +[Protocol] > +X-DocPath=kioslave5/recentlyused/index.html > +exec=kf5/kio/recentlyused > +protocol=recentlyused > +Icon=document-open-recent > +input=none > +output=filesystem We should use the JSON format

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

cullmann added a comment. I think I misunderstood the feature, sorry. I did now try the patch again (it didn't apply perfectly, but that was just a few lines of code to be moved in the katedocument.cpp patch. I tend to agree that until we have perhaps some proper config for that in

D22102: Implement apply-on-double-click for all grid view KCM delegates

ngraham added a comment. I don't really know what else to say. The current workflow is annoying and slow for me and I want to improve it. Maybe this isn't the best way, but it's rather frustrating to come up against a wall of opposition doubting whether it's a problem at all, or if it is,

D22102: Implement apply-on-double-click for all grid view KCM delegates

ndavis added a comment. In D22102#487806 , @ngraham wrote: > Maybe I should move back and examine the rationale for the proposal. > > Right now, I find it *extremely* annoying, slow, and frustrating to test new themes, colors, icons,

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#488593 , @ngraham wrote: > In D22155#488485 , @anthonyfieroni wrote: > > > Renaming the icon is not quite good, if someone use newer framework and old applications /

D22155: Add new activities and virtual desktops icons

ngraham added a comment. In D22155#488485 , @anthonyfieroni wrote: > Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new

D10362: Change reveal password button logic

ngraham added a comment. In D10362#488571 , @ndavis wrote: > In D10362#488389 , @ngraham wrote: > > > I think the idea is that you're not supposed to be typing with the characters visible as you

D10362: Change reveal password button logic

ndavis added a comment. In D10362#488389 , @ngraham wrote: > I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password. I

D22155: Add new activities and virtual desktops icons

anthonyfieroni added a comment. In D22155#488497 , @GB_2 wrote: > We can backport the changes in Plasma to the LTS branch though. We can backport but you cannot increase depends on 5.60 to the LTS branch. So it should have a fallback

D22147: Better use of Qt APIs in Plasma::Theme

apol updated this revision to Diff 60875. apol added a comment. address logic, no artifacts REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22147?vs=60840=60875 BRANCH arcpatch-D22147 REVISION DETAIL

D22172: [kio-extras] Use new activities icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH use-new-activities-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22172 To: GB_2, #plasma, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, kfm-devel,

D22173: [kactivities] Use new activities icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH use-new-activities-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22173 To: GB_2, #plasma, #vdg, ndavis Cc: #vdg, kde-frameworks-devel, #plasma,

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. Phew, done! REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg,

D22102: Implement apply-on-double-click for all grid view KCM delegates

pino added a comment. In D22102#488447 , @ngraham wrote: > In D22102#488388 , @pino wrote: > > > While I can understand that clicking can be "annoying", OTOH I consider all the KCMs you mentioned as

D22173: [kactivities] Use new activities icon

GB_2 added a dependency: D22155: Add new activities and virtual desktops icons. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D22173 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, michaelh, ngraham, bruns

D22173: [kactivities] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 . F6948432:

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22173: [kactivities] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham,

D22172: [kio-extras] Use new activities icon

GB_2 added a dependency: D22155: Add new activities and virtual desktops icons. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22172 To: GB_2, #plasma, #vdg Cc: kde-frameworks-devel, #vdg, kfm-devel, #plasma, fprice, LeGast00n, fbampaloukas, alexde, feverfew,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22172: [kio-extras] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham,

D22172: [kio-extras] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 .

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#488485 , @anthonyfieroni wrote: > Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:074c91a58318: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName() (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D22155: Add new activities and virtual desktops icons

anthonyfieroni added a comment. Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new features + bugs fix and Plasma offers LTS. REPOSITORY R266 Breeze Icons BRANCH

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22171: [colord-kde] Use more appropriate icon, because the activities icon changed. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22170: [latte-dock] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22167: [plasma-workspace] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22168: [plasma-desktop] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D22155: Add new activities and virtual desktops icons

GB_2 added a dependent revision: D22169: [plasma-active-window-control] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc:

D22102: Implement apply-on-double-click for all grid view KCM delegates

ngraham added a comment. In D22102#488388 , @pino wrote: > While I can understand that clicking can be "annoying", OTOH I consider all the KCMs you mentioned as "mostly once" configuration items: you generally configure the

D22166: [AdvancedQueryParser] Introduce support for phrase queries

poboiko added a comment. Note that it somewhat duplicates work done inside `QueryParser`. Which is //almost// not used anywhere - most of the parsing is done by `AdvancedQueryParser`. I feel somewhat weird having two separate parsers, as well as two different entities which store

D22102: Implement apply-on-double-click for all grid view KCM delegates

anthonyfieroni added a comment. Alternatively you can add message widget that explore double click functionality, when double click is applied it can change its message that save is applied. But rater OK/Apply became a bit pointless. REPOSITORY R296 KDeclarative REVISION DETAIL

D22166: [AdvancedQueryParser] Introduce support for phrase queries

poboiko created this revision. poboiko added reviewers: Baloo, ngraham, bruns. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY AdvancedQueryParser's lexxer can actually handle double quotes: for query `a "b c" d`, it returns three tokens

D10362: Change reveal password button logic

ngraham added a comment. I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password. If you're in an environment where security concerns are sufficiently low as to permit this,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 141 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/141/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 30 Jun 2019 15:21:42 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 141 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/141/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 30 Jun 2019 15:21:42 + Build duration: 8 min 22 sec and counting JUnit Tests Name:

D22102: Implement apply-on-double-click for all grid view KCM delegates

pino added a comment. In D22102#487806 , @ngraham wrote: > Right now, I find it *extremely* annoying, slow, and frustrating to test new themes, colors, icons, wallpapers, etc. The workflow is to click on the delegate, and then click on the

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 131 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/131/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 30 Jun 2019 15:21:42 + Build duration: 6 min 24 sec and counting BUILD ARTIFACTS

D10362: Change reveal password button logic

ndavis added a comment. In D10362#202435 , @starbuck wrote: > Would further be also likely more consistent with other toggles in the future, like imagined on mobile "wifi crossed out=disabled", etc. The difference between the WiFi toggle

D10362: Change reveal password button logic

ndavis added a comment. -1 for the current version How am I supposed to type with 2 hands and see the password at the same time if I have to hold down the left mouse button? -0.75 for the previous version of the patch We normally show the action that will happen when a button

D22155: Add new activities and virtual desktops icons

ngraham added a comment. +1, please mark this patch as a dependency for the other patches and then let's land 'em all together once everything looks good. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL

D21427: Always skip trailing slashes in FilderedDirIterator

poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To: poboiko, #frameworks, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D21427: Always skip trailing slashes in FilderedDirIterator

poboiko added a reviewer: ngraham. poboiko added a comment. Not entirely sure, but bug 409257 might be caused by that (at least in my case, it looked the same). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To:

D22047: Fix translation of actiondisplay

aspotashev added inline comments. INLINE COMMENTS > imgurplugin.json:105 > +"Name[zh_TW]": "Imgur", > +"X-Purpose-ActionDisplay": "Imgur" > }, same for Imgur :( REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22047 To: nicolasfella, apol,

D22047: Fix translation of actiondisplay

aspotashev added inline comments. INLINE COMMENTS > pastebinplugin.json:105 > +"Name[zh_TW]": "Pastebin", > +"X-Purpose-ActionDisplay": "Pastebin" > }, oops, ActionDisplay should have ellipsis, e.g. "Pastebin..." REPOSITORY R495 Purpose Library REVISION DETAIL

D10362: Change reveal password button logic

GB_2 added a comment. Ping REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisangelaccio,

D21204: Ensure no trailing slash in mountpoint read from fstab file.

meven marked 2 inline comments as done. meven added a comment. Thanks @anthonyfieroni REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks Cc: anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh

D21204: Ensure no trailing slash in mountpoint read from fstab file.

meven updated this revision to Diff 60855. meven added a comment. Use a const ref in the loop use append to add a trailing / REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21204?vs=58976=60855 BRANCH arcpatch-D21204 REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 105 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/105/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 30 Jun 2019 06:45:35 + Build duration: 6 min 47 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 111 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/111/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 30 Jun 2019 06:45:35 + Build duration: 3 min 2 sec and counting BUILD ARTIFACTS

D22157: Use debugging category in taglib extractor/writer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ce0b873f1888: Use debugging category in taglib extractor/writer (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22157?vs=60844=60850