D22317: Fix type names casing

vatra added a comment. Just out of curiosity, why don't you use the cmake toolchain from Android NDK ? is located in ndk-bundle/build/cmake/android.toolchain.cmake REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22317 To: apol, #frameworks, #android,

D22155: Add new activities and virtual desktops icons

ngraham added a comment. Cool! Consider this a pre-approval to land this at the appropriate time, then. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/3/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 08 Jul 2019 21:00:08 + Build duration: 8 min 51 sec and counting JUnit Tests Name:

D22276: Add an action to insert a non-indented newline

cullmann added a comment. Thanks for the patch! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22276 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: bruns, mickaelbo, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, demsking,

D22276: Add an action to insert a non-indented newline

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH regular-newline (branched from master) REVISION DETAIL https://phabricator.kde.org/D22276 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: bruns, mickaelbo,

D22276: Add an action to insert a non-indented newline

This revision was automatically updated to reflect the committed changes. Closed by commit R39:01526bfcb7e8: Add an action to insert a non-indented newline (authored by ahmadsamir, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D22276: Add an action to insert a non-indented newline

ahmadsamir added a comment. If this is OK, please commit it too. Thanks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22276 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: bruns, mickaelbo, kde-frameworks-devel, kwrite-devel, LeGast00n, domson,

D22276: Add an action to insert a non-indented newline

ahmadsamir updated this revision to Diff 61373. ahmadsamir added a comment. Fix action name, don't use camel case, use _ Fix comment indentation :) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22276?vs=61363=61373 BRANCH regular-newline (branched

D22276: Add an action to insert a non-indented newline

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Please fix the // second: if "indent" is true, indent the new line, if needed... comment and use some non-camel-case action name like no_indent_newline. Then

D22276: Add an action to insert a non-indented newline

ahmadsamir updated this revision to Diff 61363. ahmadsamir added a comment. Use an Enum instead of bool REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22276?vs=61156=61363 BRANCH regular-newline (branched from master) REVISION DETAIL

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 08 Jul 2019 17:19:52 + Build duration: 11 min and counting JUnit Tests Name:

D7909: Add syntax support for Crystal Programming Language

cullmann commandeered this revision. cullmann edited reviewers, added: faguilar; removed: cullmann. cullmann added a comment. Please re-submit if you have time again, thanks! REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: cullmann, dhaumann, vkrause,

D7909: Add syntax support for Crystal Programming Language

cullmann abandoned this revision. REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: cullmann, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, faguilar Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks, faguilar, LeGast00n,

D22276: Add an action to insert a non-indented newline

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think, once there is no bool but some enum, one can push this as is. If one wants to remove the updateView()... glibberish can be decided later, it is ok that this is a

D22315: Add setting to enable/disable text drag-and-drop (on by default)

cullmann added a comment. Thanks! Keep the patches coming :=) Your recent improvements are highly appreciated! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc: ahmadsamir, dhaumann, cullmann, kwrite-devel,

D22315: Add setting to enable/disable text drag-and-drop (on by default)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c0321472330b: Add setting to enable/disable text drag-and-drop (on by default) (authored by thomassc). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D22315: Add setting to enable/disable text drag-and-drop (on by default)

cullmann added a comment. > I would say, merge this now. If somebody wants to fixup the label, one can do that later. === REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION

D22315: Add setting to enable/disable text drag-and-drop (on by default)

ahmadsamir added a comment. IMHO, "Enable/Disable" is already implied by the checkbox :) REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc: ahmadsamir, dhaumann, cullmann,

D22315: Add setting to enable/disable text drag-and-drop (on by default)

cullmann added a comment. I have no issues with the label, matches the other in that category, not sure if "Enable" does make it better or worse. REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc,

D22315: Add setting to enable/disable text drag-and-drop (on by default)

thomassc added a comment. Thanks for having a look. Here is a screenshot of the config page with the new option on it (third from the bottom): F6991601: kate-config-text-drag-and-drop.png Do you think that the label there is okay as-is? Or

D22315: Add setting to enable/disable text drag-and-drop (on by default)

dhaumann added a comment. Good, I expected nothing less ;) REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n,

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven added a comment. In D22144#490974 , @ngraham wrote: > Nice! > > What's the right way to apply this patch? Using the instructions in the text plan section, I'm not able to get it to work: > > ~/kde/src/kio-extras $

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61341. leinir added a comment. - Put the NewStuff.Author component to use on the details page as well REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=61340=61341 BRANCH knsquick-feature-parity-with-kns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61340. leinir added a comment. - Add the user ID to the author class - Expose the entry author id through the qtquick item model - Rename the entryAuthor property to entryAuthorId, as that's what it is - Add a bit more info to the author - Add a

D15814: show all borders for pop up windows in a dock

kossebau resigned from this revision. kossebau added a comment. This revision is now accepted and ready to land. No time for Plasma in the next months reserved, so withdrawing as reviewer/commenter to clear my todo list REPOSITORY R242 Plasma Framework (Library) BRANCH dockBorders

D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

davidedmundson added a comment. https://bugs.kde.org/show_bug.cgi?id=381835 REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D21606 To: fvogt Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/6/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 08 Jul 2019 11:48:31 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 08 Jul 2019 11:48:30 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/129/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Jul 2019 11:48:31 + Build duration: 6 min 5 sec and counting BUILD ARTIFACTS

D22317: Fix type names casing

This revision was automatically updated to reflect the committed changes. Closed by commit R240:70ae7cff8bc7: Fix type names casing (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22317?vs=61304=61334 REVISION DETAIL

D22258: Improve plugin caching

This revision was automatically updated to reflect the committed changes. Closed by commit R242:21227e0f989a: Improve plugin caching (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22258?vs=61122=61333 REVISION DETAIL

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 61331. leinir added a comment. Thanks kbroulik! - allowedByKiosk should be a CONSTANT property, as it's... constant - Postpone engine initialisation until Button is clicked REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 46 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/46/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Jul 2019 07:54:15 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/3/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 08 Jul 2019 07:54:15 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 08 Jul 2019 07:54:15 + Build duration: 5 min 26 sec and counting JUnit Tests Name:

D22216: Use wayland-protocols

This revision was automatically updated to reflect the committed changes. Closed by commit R127:40b86f7792eb: Use wayland-protocols (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22216?vs=61018=61310#toc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D22315: Add setting to enable/disable text drag-and-drop (on by default)

cullmann added inline comments. INLINE COMMENTS > dhaumann wrote in kateconfig.h:986 > @cullmann Is the order here important? This changes all values of remaining > enums. The enum order doesn't matter, for all storage stuff the string keys are used. There shall only be no gaps. REPOSITORY

D22315: Add setting to enable/disable text drag-and-drop (on by default)

dhaumann added inline comments. INLINE COMMENTS > kateconfig.h:986 > ShowWordCount, > +TextDragAndDrop, > SmartCopyCut, @cullmann Is the order here important? This changes all values of remaining enums. REPOSITORY R39 KTextEditor BRANCH

D22315: Add setting to enable/disable text drag-and-drop (on by default)

dhaumann added a comment. When you do UI changes, please always add a screenshot. In this case of the changed config page :) REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc:

D22317: Fix type names casing

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22317 To: apol, #frameworks, #android, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy,

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. In D22155#491783 , @ngraham wrote: > Frameworks 5.60 has been tagged, so this would end up in 5.61 if it lands now. I kind of think we should wait one more month and land it for 5.62 so it's perfectly aligned with Plasma