Re: New framework: KCalCore

2019-07-14 Thread Alexander Potashev
пт, 12 июл. 2019 г. в 19:25, Volker Krause : > - Alexander P's fundamental objections to the current KCalCore API After studing kcalcore sources again and also its usages with LXR, I realize that i would be painful to remove the FileStorage functionality because it implements format detection,

D22144: Add kio recentlyused:/ to access KactivitytStats data

2019-07-14 Thread Nathaniel Graham
ngraham added a comment. Thanks, got it built. However unfortunately it didn't help. I see that `/home/nate/kde/usr/lib64/plugins/kf5/kio/recentlyused.so` exists, and `/home/nate/kde/usr/lib64/plugins` is in my `$QT_PLUGIN_PATH` variable. And yet... $ KDE_FORK_SLAVE=1

D21901: Calendar events: allow plugins to show event details

2019-07-14 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > calendareventsplugin.h:236 > + * > + * @since 5.60 > + */ should be since 5.61 now REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart, apol Cc: ngraham, broulik,

D21901: Calendar events: allow plugins to show event details

2019-07-14 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart, apol Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D22425: personsmodel: Add phoneNumber

2019-07-14 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R307 KPeople BRANCH personsmodel-phoneNumber (branched from master) REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim,

D22459: Send wl_pointer.frame when emulating pointer events out of touch ones

2019-07-14 Thread Sebastian Krzyszkowiak
dos updated this revision to Diff 61760. dos added a comment. Added context REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22459?vs=61754=61760 REVISION DETAIL https://phabricator.kde.org/D22459 AFFECTED FILES src/server/seat_interface.cpp To: dos,

D22459: Send wl_pointer.frame when emulating pointer events out of touch ones

2019-07-14 Thread Sebastian Krzyszkowiak
dos added a comment. I've been using nested rootston inside KWin and noticed problems with content refresh when using touchscreen. It worked better with mouse. After debugging, it turned out that: - rootston doesn't register to wl_touch, so KWin emulates wl_pointer events - when

D22459: Send wl_pointer.frame when emulating pointer events out of touch ones

2019-07-14 Thread Roman Gilg
romangg added a comment. Please include the context for this diff. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22459 To: dos, #kwin Cc: romangg, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22460: DrKonqi: improved lldb integration

2019-07-14 Thread René J . V . Bertin
rjvbb created this revision. rjvbb added reviewers: kde-frameworks-devel, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rjvbb requested review of this revision. REVISION SUMMARY Since a few versions lldb has had a tendency to remain stuck after the initial

D21782: Add a warning dialog with details, continue, and cancel button

2019-07-14 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > kmessagebox.h:329 > + * > + * @since 5.60 > + */ Needs a bump to 5.61 REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol Cc:

D22459: Send wl_pointer.frame when emulating pointer events out of touch ones

2019-07-14 Thread Sebastian Krzyszkowiak
dos created this revision. dos added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dos requested review of this revision. REVISION SUMMARY When touching a surface that doesn't register to wl_touch events, KWin didn't send frame events

D21427: Always skip trailing slashes in FilderedDirIterator

2019-07-14 Thread Igor Poboiko
poboiko added a comment. In D21427#494174 , @bruns wrote: > In D21427#494010 , @poboiko wrote: > > > Ping! > > > > Apparently, it does fix bug 409257, which is pretty serious one (db

D17302: Add test for adding properties to result

2019-07-14 Thread Alexander Stippich
astippich abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22144: Add kio recentlyused:/ to access KactivitytStats data

2019-07-14 Thread Méven Car
meven added a comment. In D22144#495277 , @ngraham wrote: > I wonder if this is the problem: > > ls /home/nate/kde/usr/bin/kioclient5 > ls: cannot access '/home/nate/kde/usr/bin/kioclient5': No such file or directory > > > What

D22144: Add kio recentlyused:/ to access KactivitytStats data

2019-07-14 Thread Nathaniel Graham
ngraham added a comment. I wonder if this is the problem: ls /home/nate/kde/usr/bin/kioclient5 ls: cannot access '/home/nate/kde/usr/bin/kioclient5': No such file or directory What actually builds that binary? My KIO doesn't seem to do it. REPOSITORY R320 KIO Extras

D22339: Make sure solid backends are reentrant

2019-07-14 Thread David Edmundson
davidedmundson added a comment. I don't endorse things being closed whilst there are still review comments, but replying purely on the tech side: > How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for

D22144: Add kio recentlyused:/ to access KactivitytStats data

2019-07-14 Thread Méven Car
meven retitled this revision from "- Add kio recentlyused:/ to access KactivitytStats data" to "Add kio recentlyused:/ to access KactivitytStats data". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio,

D21902: Calendar: add method to show event details

2019-07-14 Thread Daniel Vrátil
dvratil added a reviewer: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

2019-07-14 Thread Daniel Vrátil
dvratil added a comment. Ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

2019-07-14 Thread Daniel Vrátil
dvratil added a comment. Ping? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22339: Make sure solid backends are reentrant

2019-07-14 Thread Luca Beltrame
lbeltrame added a comment. Why was this committed when changes were requested? Wasn't that the whole point of having reviews? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22339 To: apol, #frameworks, davidedmundson, bruns Cc: lbeltrame, bruns,