davidedmundson added a comment.
That was less than 5 hours from posting to give up on a review!
We're not in a rush.
INLINE COMMENTS
> package.cpp:52
> +{
> +static QSet blacklist = {"metadata", "metadatajson"};
> +return blacklist.contains(name);
that's a whitelist
>
nxiss7 changed the visibility from "Public (No Login Required)" to "All Users".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D22419
To: nxiss7, #frameworks
Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,
bruns
nxiss7 added a comment.
ES File Manager 3.2.5 has this issue.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D22419
To: nxiss7, #frameworks
Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,
bruns
nxiss7 added a comment.
You're right.
But some applications don't work well.
I think this would make KIO more "works out of the box" and help end-user...
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D22419
To: nxiss7, #frameworks
Cc: svuorela,
svuorela added a comment.
According to the RFC, the server should ignore case:
> Upper and lower case alphabetic characters are to be treated
> identically. Thus any of the following may represent the retrieve
> command:
>
> RETR Retr retr ReTr rETr
I'm not sure how many
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/4/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Mon, 15 Jul 2019 19:38:52 +
Build duration:
45 sec and counting
JUnit Tests
Name: projectroot
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:898e5133e796: Use metadata.json when creating the
metadata from KPackage::metadata() (authored by apol).
REPOSITORY
kossebau added a comment.
Default is `false,` so does not change behaviour unless someone toggles the
switch, right?
I would rename the option to `WordCompletionMatchFromWordStartOnly` though,
as from what I can tell completion often only does from start, and matching
also in the word
cullmann added reviewers: KDevelop, kossebau, mwolff, kfunk.
cullmann added a comment.
Given KDevelop uses the completion a lot more extensive than Kate, I would
like to have some input from there, too ;=)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D22477
ahmadsamir created this revision.
ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
This disables the current behaviour where if no match is found,
completions that "contain" the
On Fri, Jul 12, 2019 at 9:03 PM Allen Winter wrote:
>
> On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote:
> > With the 19.08 release approaching (and thus the deadline for incompatible
> > changes if we go ahead with this plan), I'd like to raise this again for
> > getting to a
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
Otherwise we'd end up using the slow path.
TEST PLAN
metadata still gets loaded but
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:811e78ef0ee3: Calendar events: allow plugins to show
event details (authored by dvratil).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D21901?vs=60890=61798#toc
REPOSITORY
R296
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:2631be903f94: new class KBusyIndicatorWidget similar to
QtQuicks BusyIndicator (authored by sitter).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
cfeck accepted this revision.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22375
To: sitter, cfeck, apol
Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n,
sbergeron, michaelh, bruns
sitter updated this revision to Diff 61789.
sitter added a comment.
typos--
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22375?vs=61659=61789
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22375
AFFECTED FILES
davidedmundson added a comment.
> So now name() will often return an empty string?
That's certainly not the intention.
The system is:
Firstly we do the fallback. Reading from /proc/N/state . Though this is
rubbish and truncates things.
Both name and command are set to this.
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/33/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Mon, 15 Jul 2019 13:12:05 +
Build duration:
9 min 9 sec and counting
BUILD ARTIFACTS
apol added a comment.
So now name() will often return an empty string?
INLINE COMMENTS
> kprocesslist_unix.cpp:142
> +int processNameStart = cmd.lastIndexOf('/', zeroIndex);
> +if (processNameStart == -1) {
> +processNameStart = 0;
if it's
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/4/
Project:
kf5-qt5 SUSEQt5.13
Date of build:
Mon, 15 Jul 2019 13:12:05 +
Build duration:
3 min 4 sec and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/3/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Mon, 15 Jul 2019 13:12:05 +
Build duration:
2 min 22 sec and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:3c5f3f8ba4cd: Port KXMessages away from QWidget (authored
by davidedmundson).
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22472?vs=61787=61788
REVISION
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22472
To: davidedmundson, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
It's only needed for an xcb_window
This allows use of
ndavis abandoned this revision.
ndavis added a comment.
Abandoning because it can negatively affect other widget styles.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D22003
To: ndavis, #vdg, #breeze, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/132/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Mon, 15 Jul 2019 11:58:15 +
Build duration:
16 min and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/9/
Project:
kf5-qt5 SUSEQt5.13
Date of build:
Mon, 15 Jul 2019 11:58:15 +
Build duration:
6 min 0 sec and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/5/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Mon, 15 Jul 2019 11:58:15 +
Build duration:
2 min 37 sec and counting
JUnit Tests
davidedmundson updated this revision to Diff 61784.
davidedmundson added a comment.
Swap member order
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22471?vs=61783=61784
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22471
AFFECTED
broulik added a comment.
+1
INLINE COMMENTS
> kprocesslist_p.h:46
> qint64 pid;
> +QString command;
> QString name;
Order name before since that's how the methods are ordered
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D22471
To:
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Currently KProcessList had a method called "name" which confusingly
returns the entire command line.
lshoravi added a comment.
I believe we'll need @abetts .svg file- I can't seem to find it.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D12992
To: lshoravi, #vdg, ngraham, #elisa
Cc: abetts, paullesur, januz, mgallien, alex-l, andreask, kde-frameworks-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:a46504bdfcb3: generate list of data files on the fly
(authored by sitter).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D22421?vs=61658=61781#toc
REPOSITORY
R264 KApiDox
CHANGES SINCE
jbbgameich closed this revision.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D22425
To: jbbgameich, #plasma:_mobile, #kde_pim, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20FreeBSDQt5.13/3/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Mon, 15 Jul 2019 06:30:27 +
Build duration:
1 min 23 sec and counting
JUnit Tests
35 matches
Mail list logo
