D21002: Remove kde4 migration agent completely

2019-07-18 Thread Siddhartha Sahu
siddharthasahu added a comment. Do I have to reset something on my machine after this? I'm am running frameworks and plasma from git master, and with this commit, kwalled does not seem to working for me. Kwallet manager starts with a empty window and applications (ssh agent and

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 19 Jul 2019 02:53:17 + Build duration: 2 hr 2 min and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 11 - Fixed!

2019-07-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/11/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 19 Jul 2019 03:35:30 + Build duration: 8 min 47 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 136 - Still Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/136/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 19 Jul 2019 02:41:00 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 19 Jul 2019 00:48:35 + Build duration: 2 hr 4 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 13 - Still Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/13/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 19 Jul 2019 02:41:00 + Build duration: 10 min and counting BUILD ARTIFACTS

D22541: Update refresh and restart icons to reflect new breeze-icons versions

2019-07-18 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4e35b61a83fb: Update refresh and restart icons to reflect new breeze-icons versions (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D22536: Don't advertise using KPassivePopup

2019-07-18 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH passivepopup REVISION DETAIL https://phabricator.kde.org/D22536 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 135 - Still Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/135/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 19 Jul 2019 00:48:35 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 12 - Still Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/12/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 19 Jul 2019 00:48:34 + Build duration: 15 min and counting BUILD ARTIFACTS

D22546: Add missing components in org.kde.plasma.components 3.0

2019-07-18 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY These were created but never installed. Was looking into porting krunner to 3.0 and they

Re: kdewebkit tarball gone missing?!

2019-07-18 Thread Albert Astals Cid
El dijous, 18 de juliol de 2019, a les 0:15:16 CEST, René J. V. Bertin va escriure: > Albert Astals Cid wrote: > > > https://download.kde.org/stable/frameworks/5.60/portingAids/ > > Ah, thanks, I must have missed the announcement of its promotion. > > So what kind of tier is kdesigner-plugin

D22544: [RFC] Deprecate KPassivePopup

2019-07-18 Thread David Edmundson
davidedmundson added a comment. > Given it's brokeness and relative usefulness I propose to remove it. Seems sensible. It'll break on wayland without some work put into it. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella,

Re: New framework: KCalCore

2019-07-18 Thread Dominik Haumann
To me this sounds as if KCal is the best choice: KCal - a library with iCal support. It's short, closest to iCal, and does not clash with calendar systems. Greetings Dominik Allen Winter schrieb am Do., 18. Juli 2019, 18:40: > On Thursday, July 18, 2019 12:18:36 PM EDT Volker Krause wrote: > >

D13867: [KMessageWidget] Pass widget to standardIcon()

2019-07-18 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. The commit log says "Breeze now knows it's a KMessageWidget". Ok. And now? The commit log lacks what issue this patch fixes... Besides that, looks good to me. REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D22544: [RFC] Deprecate KPassivePopup

2019-07-18 Thread Alexander Potashev
aspotashev added a comment. kdialog also uses KPassivePopup REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks, broulik Cc: aspotashev, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22541: Update refresh and restart icons to reflect new breeze-icons versions

2019-07-18 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R242 Plasma Framework (Library) BRANCH plasma-theme-refresh-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22541 To: ngraham,

D22544: [RFC] Deprecate KPassivePopup

2019-07-18 Thread Alexander Potashev
aspotashev added a comment. > The case where no notification daemon is running is IMHO an edge case that we don't need to support. Disagree here. I believe a lot of people don't use a notification system on Linux. If we remove KPassivePopup, some apps with stop working properly for

D22544: [RFC] Deprecate KPassivePopup

2019-07-18 Thread Nicolas Fella
nicolasfella added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22544: [RFC] Deprecate KPassivePopup

2019-07-18 Thread Nicolas Fella
nicolasfella edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22544: [RFC] Deprecate KPassivePopup

2019-07-18 Thread Nicolas Fella
nicolasfella edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22544: [RFC] Deprecate KPassivePopup

2019-07-18 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY KPassivePopup is hideous and broken in many ways. Currently it

D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

2019-07-18 Thread Aleix Pol Gonzalez
apol added a comment. I need this additionally diff --git a/src/runnermanager.cpp b/src/runnermanager.cpp index f92830d..6ec0c3c 100644 --- a/src/runnermanager.cpp +++ b/src/runnermanager.cpp @@ -345,6 +345,7 @@ public: emit

D17595: Upstream Dolphin's file rename dialog

2019-07-18 Thread Méven Car
meven updated this revision to Diff 62005. meven added a comment. Fix email in copyright declaration REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=59292=62005 BRANCH arcpatch-D17595 REVISION DETAIL https://phabricator.kde.org/D17595 AFFECTED

D22541: Update refresh and restart icons to reflect new breeze-icons versions

2019-07-18 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22541 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-18 Thread Christoph Feck
cfeck added a comment. Oh, if the latter syntax also works, then you are right. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22541: Update refresh and restart icons to reflect new breeze-icons versions

2019-07-18 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Like D22534 , but for the Plasma theme.

D17595: Upstream Dolphin's file rename dialog

2019-07-18 Thread Méven Car
meven marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham Cc: mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D13867: [KMessageWidget] Pass widget to standardIcon()

2019-07-18 Thread Christoph Feck
cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13867 To: broulik, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

2019-07-18 Thread Simon Peter
probono added a comment. Things like AppImageLauncher are really just workarounds because functionality like this has been missing natively from the system so far. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks Cc: broulik, ngraham,

D22510: Added dialog to set execute permission for executable file when trying to run it.

2019-07-18 Thread Simon Peter
probono added a comment. Very much appreciate this. Thank you. This is nothing AppImage specific. It should handle all sorts of ELF files, which AppImages are just a special case of. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski,

D22534: Use clockwise arrows for *refresh* and update-* icons

2019-07-18 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:74c4155ff3d7: Use clockwise arrows for *refresh* and update-* icons (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22534?vs=61996=62001

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 180 - Still unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/180/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 18 Jul 2019 19:05:09 + Build duration: 3 min 46 sec and counting JUnit Tests

D22534: Use clockwise arrows for *refresh* and update-* icons

2019-07-18 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good! Can you also do `process-stop`? It shares the same basic shape and orientation as `view-refresh` and is used for related functions. REPOSITORY R266 Breeze Icons

D22536: Don't advertise using KPassivePopup

2019-07-18 Thread Nicolas Fella
nicolasfella added a reviewer: Frameworks. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D22536 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22536: Don't advertise using KPassivePopup

2019-07-18 Thread Nicolas Fella
nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY KNotification should always be used instead of KPassivePopup REPOSITORY R239 KDELibs4Support BRANCH

D22534: Use clockwise arrows for *refresh* and update-* icons

2019-07-18 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22534 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22534: Use clockwise arrows for *refresh* and update-* icons

2019-07-18 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22534 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22534: Use clockwise arrows for *refresh* and update-* icons

2019-07-18 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now we are inconsistent with the arrow directionality for our circular

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-18 Thread Gleb Popov
arrowd added a comment. In D22525#497332 , @cfeck wrote: > Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. I don't

D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-07-18 Thread Yaroslav Sidlovsky
ZaWertun added a comment. Patch was made against version 5.60.0 (rev 8513ca9 ). Sorry that I didn't mention it earlier. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun,

Re: New framework: KCalCore

2019-07-18 Thread Allen Winter
On Thursday, July 18, 2019 12:18:36 PM EDT Volker Krause wrote: > On Wednesday, 17 July 2019 01:51:42 CEST Aleix Pol wrote: > > On Tue, Jul 16, 2019 at 6:10 PM Volker Krause wrote: > > > On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote: > > > > On Fri, Jul 12, 2019 at 9:03 PM Allen Winter

D22515: Add support for additional QML keywords not part of JavaScript

2019-07-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:7b06481d5506: Add support for additional QML keywords not part of JavaScript (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

Re: New framework: KCalCore

2019-07-18 Thread Volker Krause
On Wednesday, 17 July 2019 01:51:42 CEST Aleix Pol wrote: > On Tue, Jul 16, 2019 at 6:10 PM Volker Krause wrote: > > On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote: > > > On Fri, Jul 12, 2019 at 9:03 PM Allen Winter wrote: > > > > On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause

D13867: [KMessageWidget] Pass widget to standardIcon()

2019-07-18 Thread Kai Uwe Broulik
broulik updated this revision to Diff 61989. broulik added a comment. - Pass `QStyleOption` REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13867?vs=37101=61989 REVISION DETAIL https://phabricator.kde.org/D13867 AFFECTED FILES

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 134 - Still Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/134/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 18 Jul 2019 15:45:49 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 11 - Still Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/11/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 18 Jul 2019 15:45:49 + Build duration: 9 min 7 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 18 Jul 2019 15:45:49 + Build duration: 6 min 21 sec and counting JUnit Tests

D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-07-18 Thread Nathaniel Graham
ngraham added a reviewer: cfeck. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-07-18 Thread Nathaniel Graham
ngraham retitled this revision from "KIO FTP: File copy hangs when copying to existing file - fix" to "KIO FTP: Fix file copy hanging when copying to existing file". ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To:

D22528: KIO FTP: File copy hangs when copying to existing file - fix

2019-07-18 Thread Yaroslav Sidlovsky
ZaWertun retitled this revision from "KIO FTP: File copy hangs when copying to existing file" to "KIO FTP: File copy hangs when copying to existing file - fix". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure Cc: kde-frameworks-devel,

D9033: man ioslave: asserts trying to display pam(8)

2019-07-18 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R320:87215e7ea765: man ioslave: asserts trying to display pam(8) (authored by marten, committed by ltoscano). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D22531: [KColorSchemeManager] Optimize preview generation

2019-07-18 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Create them only on-demand (e.g. when the menu opens or the DecorationRole is

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-18 Thread Christoph Feck
cfeck added a comment. Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-18 Thread Piyush Aggarwal
brute4s99 added inline comments. INLINE COMMENTS > dfaure wrote in kio_sftp.cpp:2037 > Why ReadWrite, if we know it doesn't exist? > > Does setFileTime() even need open() first? I wouldn't have thought so. `setFileTime()` needs the file to be open. Source :

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-18 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 61972. brute4s99 marked 7 inline comments as done. brute4s99 added a comment. updated wrt new comments. @dfaure please take another look!  REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61419=61972

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.11 - Build # 49 - Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.11/49/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 18 Jul 2019 11:41:34 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 179 - Failure!

2019-07-18 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/179/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 18 Jul 2019 11:41:41 + Build duration: 3 min 40 sec and counting CONSOLE OUTPUT

D22528: KIO FTP: File copy hangs when copying to existing file

2019-07-18 Thread Yaroslav Sidlovsky
ZaWertun added a comment. One more small thing: it's better replace `sCopyFile` in call to `error` with something like `dest.path()`, to display server path rather than local source. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure

D22528: KIO FTP: File copy hangs when copying to existing file

2019-07-18 Thread Yaroslav Sidlovsky
ZaWertun added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: File copy hangs when copying to existing file

2019-07-18 Thread Kai Uwe Broulik
broulik added a reviewer: sitter. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: File copy hangs when copying to existing file

2019-07-18 Thread Yaroslav Sidlovsky
ZaWertun created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ZaWertun requested review of this revision. REVISION SUMMARY Subj. TEST PLAN Before patch: 1. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png 2. kioclient5 cp

D7820: man ioslave: spurious numbers included in clang(1) man page

2019-07-18 Thread Martin Koller
mkoller requested changes to this revision. mkoller added a comment. This revision now requires changes to proceed. I think this was solved with bugfix to Bug Nr 335169 with commit 87d8ab4371149c84794f4e93d1f590f7bac5f327

D9033: man ioslave: asserts trying to display pam(8)

2019-07-18 Thread Martin Koller
mkoller accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma, kfm-devel, mkoller Cc: ltoscano, kde-frameworks-devel, apol, plasma-devel, aprcela, fprice, LeGast00n,

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 76 - Fixed!

2019-07-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/76/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 18 Jul 2019 10:53:16 + Build duration: 1 min 37 sec and counting

D21660: remove dbus for windows build and change audio dep logic

2019-07-18 Thread Piyush Aggarwal
This revision was automatically updated to reflect the committed changes. Closed by commit R289:be466180db21: remove dbus for windows build and change audio dep logic (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D21660: remove dbus for windows build and change audio dep logic

2019-07-18 Thread Piyush Aggarwal
brute4s99 added a comment. landing it REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 10 - Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/10/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 18 Jul 2019 09:10:51 + Build duration: 8 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Fixed!

2019-07-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 18 Jul 2019 09:10:51 + Build duration: 2 min 37 sec and counting JUnit Tests Name:

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-18 Thread Gleb Popov
arrowd created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arrowd requested review of this revision. REVISION SUMMARY BUG: 408632 TEST PLAN `kioclient5 exec http://localhost:9000` now works correctly. REPOSITORY R126 KDE CLI Utilities BRANCH

KDE CI: Frameworks » kunitconversion » kf5-qt5 WindowsMSVCQt5.11 - Build # 44 - Unstable!

2019-07-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20WindowsMSVCQt5.11/44/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 18 Jul 2019 08:46:41 + Build duration: 2 min 34 sec and counting JUnit Tests

D22365: KNotification macOS native support by NSNotificationCenter

2019-07-18 Thread René J . V . Bertin
rjvbb added a comment. Kai Uwe Broulik wrote on 20190718::07:13:16 re: "D22365 <https://phabricator.kde.org/D22365>: KNotification macOS native support by NSNotificationCenter" > Thanks a lot! Indeed. I've looked a few times in doing this myself but

D22521: Fix a mistake with "Pb"

2019-07-18 Thread Yuri Chornoivan
This revision was automatically updated to reflect the committed changes. Closed by commit R292:dce763feb436: Fix minor typos (authored by yurchor). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22521?vs=61949=61955 REVISION DETAIL

D22523: Remove visibilityChanged connection in favor of existing eventFilter

2019-07-18 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY KMainWindow compresses saving its configuration by a 500ms timer.

D22521: Fix a mistake with "Pb"

2019-07-18 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R292 KUnitConversion BRANCH Pb_fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D22521 To: ppeter, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron,

D22520: Remove Growl support

2019-07-18 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. (Once the replacement backends are actually in) INLINE COMMENTS > notifybypopupgrowl.cpp:27 > -#define GROWL_LOCATION_MACOSX >

D22365: KNotification macOS native support by NSNotificationCenter

2019-07-18 Thread Kai Uwe Broulik
broulik added a comment. Thanks a lot! INLINE COMMENTS > notifybymacosnotificationcenter.h:6 > + > +class MacOSNotificationCenterPrivate; > + Unused > notifybymacosnotificationcenter.h:14 > +NotifyByMacOSNotificationCenter(QObject* parent); > +~NotifyByMacOSNotificationCenter(); >

D22521: Fix a mistake with "Pb"

2019-07-18 Thread Yi-Jyun Pan
ppeter added a reviewer: Frameworks. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D22521 To: ppeter, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22365: KNotification macOS native support by NSNotificationCenter

2019-07-18 Thread Kai Uwe Broulik
broulik added a reviewer: rjvbb. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22521: Fix a mistake with "Pb"

2019-07-18 Thread Yi-Jyun Pan
ppeter updated this revision to Diff 61949. ppeter added a comment. Remove the useless `{' REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22521?vs=61947=61949 BRANCH Pb_fix (branched from master) REVISION DETAIL

D22521: Fix a mistake with "Pb"

2019-07-18 Thread Yi-Jyun Pan
ppeter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ppeter requested review of this revision. REPOSITORY R292 KUnitConversion BRANCH Pb_fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D22521 AFFECTED