D23034: implicit fallthough if there is fallthoughContext

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I appreciate the removal of the fallthrough=bool attribute. Given it is sematic-free if no fall through context is there I guess this is a "compatible" change. But please

D23036: Fix incorrect initial tabs position for vertical tab bars

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e2cd97d822d3: Fix incorrect initial tabs position for vertical tab bars (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23036: Fix incorrect initial tabs position for vertical tab bars

hein accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23036 To: lisin, #plasma, ngraham, hein Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23036: Fix incorrect initial tabs position for vertical tab bars

ngraham added a task: T10047: Guerilla UX testing: a GNOME switcher. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23036 To: lisin, #plasma, ngraham, hein Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23036: Fix incorrect initial tabs position for vertical tab bars

ngraham added a reviewer: hein. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks like you fixed it! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23036 To: lisin, #plasma, ngraham,

D23036: Fix incorrect initial tabs position for vertical tab bars

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23036 To: lisin, #plasma, ngraham, hein Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23019: Make notification icons look like bells

ndavis added a comment. @broulik With D23033 , the notification-disabled element will be unused. Do you still require changes to this patch? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis,

D23036: Fix incorrect initial tabs position for vertical tab bars

lisin added a comment. I didn't make a third copy of the positioning code, instead I put it all into a separate function. For Kickoff you can test the changes like this: Place Kickoff in a vertical panel. Restart plasmashell. Open Kickoff. Before fix: first tab is placed out of

D23036: Fix incorrect initial tabs position for vertical tab bars

lisin created this revision. lisin added reviewers: Plasma, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lisin requested review of this revision. REVISION SUMMARY This fixes the incorrect initial positioning of the tabs for vertical tab bars

D23034: implicit fallthough if there is fallthoughContext

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY fallthrough="true" is redundant with fallthroughContext="xxx" and there is no reason

D23013: Latex: several fixes (math mode, nested verbatim, ...)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:75e233dc5792: Latex: several fixes (math mode, nested verbatim, ...) (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23013?vs=63378=63379#toc REPOSITORY R216 Syntax

D23013: Latex: several fixes (math mode, nested verbatim, ...)

jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL https://phabricator.kde.org/D23013 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kde-frameworks-devel, kwrite-devel, univerz,

D23013: Latex: several fixes (math mode, nested verbatim, ...)

jpoelen added a comment. The 410477 did not exist when I started my modifications, I add it in the list. REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL https://phabricator.kde.org/D23013 To: jpoelen, #framework_syntax_highlighting, dhaumann,

D23013: Latex: several fixes (math mode, nested verbatim, ...)

jpoelen updated this revision to Diff 63378. jpoelen added a comment. At first, I didn't have much change. But as I broke my teeth on one of the bugs and there were some problems here and there, I armed myself with a bulldozer :D REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

D23014: Lua: fix color of end with several levels of condition and function nesting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:2b06bf42be04: Lua: fix color of end with several levels of condition and function nesting (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23014?vs=63376=63377#toc

D23014: Lua: fix color of end with several levels of condition and function nesting

jpoelen updated this revision to Diff 63376. jpoelen added a comment. increase the version number REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23014?vs=63320=63376 BRANCH lua (branched from master) REVISION DETAIL

D23013: Latex: several fixes (math mode, nested verbatim, ...)

nibags added a comment. There are many improvements to the Latex highlighter! Recently I marked bugs 274440, 322081 and others as duplicates (in fact, this patch fixes them well) REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL

D23019: Make notification icons look like bells

ndavis edited dependencies, added: D23033: [notifications] Change default icon to notification-inactive; removed: D23018: [notifications] Remove unread counter, use icons instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis,

D23019: Make notification icons look like bells

ngraham accepted this revision. ngraham added a comment. Never mind, you did change it to `notification-inactive` in the other patch. So this is good to go IMO. As for landing it, we have two options to make sure that rolling release distro users don't see their notification icon change

D23019: Make notification icons look like bells

ngraham added a comment. In D23019#508605 , @ndavis wrote: > In D23019#508599 , @broulik wrote: > > > You can't repurpose icon ids for different meanings: > > F7178337:

D23019: Make notification icons look like bells

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma, broulik Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

poboiko added a comment. In D23008#508782 , @bruns wrote: > @poboiko - is the problem you describe purely theoretical, or did you actually see it happen? > > Multiple triggers of `slotNewInput` are **not** a problem, the code flow reaches

D23019: Make notification icons look like bells

ngraham added a comment. I think I approve of the end goal, but it seems like this needs a change in the notifications widget rather than just changing the icon itself. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg,

D23030: [Image Thumbnailer] Support RLE images

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b21e81a9fe51: [Image Thumbnailer] Support RLE images (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23030?vs=63356=63361 REVISION DETAIL

D22936: [Text thumbnailer] Don't show text preview for .directory and .flatpakref files

This revision was automatically updated to reflect the committed changes. Closed by commit R320:df85d47c7242: [Text thumbnailer] Dont show text preview for .directory and .flatpakref files (authored by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D23022: [Comic Thumbnailer] Add support for 7zip-compressed comic books

This revision was automatically updated to reflect the committed changes. Closed by commit R320:c4b212d7211e: [Comic Thumbnailer] Add support for 7zip-compressed comic books (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D22936: [Text thumbnailer] Don't show text preview for .directory and .flatpakref files

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I think I would prefer a mime type check over a `endsWith(.flatpakref)` but that would introduce some overhead, so I guess this is fine. REPOSITORY R320 KIO Extras BRANCH

D23022: [Comic Thumbnailer] Add support for 7zip-compressed comic books

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Hehe I was working on a patch for this too and your patch is almost identical. :) Would you mind reviewing D22936 ? REPOSITORY R320 KIO Extras

D22936: [Text thumbnailer] Don't show text preview for .directory and .flatpakref files

ngraham added a reviewer: broulik. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22936 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun,

D23030: [Image Thumbnailer] Support RLE images

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23030 To: broulik, aacid, jtamate, ngraham Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, fbampaloukas,

D23030: [Image Thumbnailer] Support RLE images

broulik created this revision. broulik added reviewers: aacid, jtamate, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY They contain a good old BMP image. TEST PLAN I

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

bruns added a comment. @poboiko - is the problem you describe purely theoretical, or did you actually see it happen? Multiple triggers of `slotNewInput` are **not** a problem, the code flow reaches the `m_tr = new Transaction(...)` only iff a batch has been read. And batches are only

D23029: Fix the attica pkgconfig file.

cgiboudeaux edited the test plan for this revision. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D23029 To: cgiboudeaux Cc: fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23029: Fix the attica pkgconfig file.

cgiboudeaux updated this revision to Diff 63354. cgiboudeaux added a comment. use ${prefix} for the exec line. For the others, it's a bit trickier since you can use either relative or absolute paths when calling CMake. This will be handled when the ECM macro gets updated. REPOSITORY

D23029: Fix the attica pkgconfig file.

cgiboudeaux edited the test plan for this revision. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D23029 To: cgiboudeaux Cc: fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23029: Fix the attica pkgconfig file.

cgiboudeaux updated this revision to Diff 63353. cgiboudeaux added a comment. fix path REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23029?vs=63351=63353 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23029 AFFECTED FILES

D23029: Fix the attica pkgconfig file.

fvogt added inline comments. INLINE COMMENTS > libKF5Attica.pc.cmake:3 > +exec_prefix=${BIN_INSTALL_DIR} > libdir=${LIB_INSTALL_DIR} > +includedir=${KF5_INCLUDE_INSTALL_DIR} In ECM and Qt this is absolute, `${prefix}/lib64`, same for `exec_prefix`. REPOSITORY R235 Attica REVISION DETAIL

D23013: Latex: several fixes (math mode, nested verbatim, ...)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I believe in your tests, as my LaTeX skills are just on "I wrote a bad phd with it" level ;=) Feel free to push after you incremented the version number. Btw. => Thanks a lot for

D23029: Fix the attica pkgconfig file.

cgiboudeaux added a comment. Note: the ecm_generate_pkgconfig_file macro cannot be used since it doesn't support extra CFLAGS (yet) REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D23029 To: cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23029: Fix the attica pkgconfig file.

cgiboudeaux edited the test plan for this revision. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D23029 To: cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23029: Fix the attica pkgconfig file.

cgiboudeaux created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY the file was unusable due to bogus version name, missing dependencies and wrong paths. TEST PLAN - Before

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 08 Aug 2019 11:34:02 + Build duration: 1 min 19 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdbusaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 48 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdbusaddons/job/kf5-qt5%20WindowsMSVCQt5.11/48/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 08 Aug 2019 10:30:27 + Build duration: 3 min 13 sec and counting JUnit Tests

KDE CI: Frameworks » kdbusaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 47 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdbusaddons/job/kf5-qt5%20WindowsMSVCQt5.11/47/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 08 Aug 2019 09:46:46 + Build duration: 1 min 1 sec and counting CONSOLE OUTPUT

D20078: fix race on kcrash auto-restarts

This revision was automatically updated to reflect the committed changes. Closed by commit R271:5bf091ee07ac: fix race on kcrash auto-restarts (authored by sitter). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20078?vs=62840=63344 REVISION DETAIL

D23022: [Comic Thumbnailer] Add support for 7zip-compressed comic books

broulik created this revision. broulik added reviewers: Dolphin, ngraham, fleger. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 410696 TEST PLAN - Got a thumbnail for the

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

poboiko added inline comments. INLINE COMMENTS > anthonyfieroni wrote in app.cpp:76-81 > processNextFile should be called till m_ids ends, why it does not happen, > probably that's why @bruns reject your patch Well, if that happens, something went wrong, and we have to do something. As far as

D23019: Make notification icons look like bells

ndavis added a comment. In D23019#508599 , @broulik wrote: > You can't repurpose icon ids for different meanings: > F7178337: Screenshot_20190808_094519.png > This is what the "no notifications" case

D23019: Make notification icons look like bells

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. You can't repurpose icon ids for different meanings: F7178337: Screenshot_20190808_094519.png This is what the "no notifications" case

D23014: Lua: fix color of end with several levels of condition and function nesting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Fell free to push this, but please increase the version number first ;=) REPOSITORY R216 Syntax Highlighting BRANCH lua (branched from master) REVISION DETAIL

D23019: Make notification icons look like bells

ndavis added a comment. In D23019#508581 , @broulik wrote: > Screenshots, please. > The question is what about the transition when this is released in Frameworks but the Plasma version with the change isn't yet. The screenshots would

D23015: Highlighting indexer: all warnings are fatal

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0572fa2821e9: Highlighting indexer: all warnings are fatal (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23015?vs=63321=63335#toc REPOSITORY

D23015: Highlighting indexer: all warnings are fatal

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. More strict checking is always welcome! REPOSITORY R216 Syntax Highlighting BRANCH warning_as_error (branched from master) REVISION DETAIL https://phabricator.kde.org/D23015

D23019: Make notification icons look like bells

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23019: Make notification icons look like bells

broulik added a comment. Screenshots, please. The question is what about the transition when this is released in Frameworks but the Plasma version with the change isn't yet. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis,

D23019: Make notification icons look like bells

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns