D23077: Modify restoration icon to make it look like something is being restored from the trash

shubham retitled this revision from "Change restoration icon" to "Modify restoration icon to make it look like something is being restored from the trash". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23077 To: shubham, #vdg, ndavis Cc: ngraham,

D23077: Change restoration icon

shubham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23077 To: shubham, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23077: Change restoration icon

ngraham added a reviewer: ndavis. ngraham added a comment. Nice! It would also help if you wrote the title in a way that described the change. Also, if this fixes https://bugs.kde.org/show_bug.cgi?id=401974, please add `BUG: 401974` to the description. In terms of the new icon, I

D23077: Change restoration icon

shubham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23077 To: shubham, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23077: Change restoration icon

shubham added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23077 To: shubham, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23077: Change restoration icon

shubham created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23077 AFFECTED FILES

D23061: Possiblity to change Definition data after loading

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. This looks more correct ;=) Could you now add some test to the auto-tests? Thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D23061: Possiblity to change Definition data after loading

sirgienko updated this revision to Diff 63492. sirgienko added a comment. Bugfix REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23061?vs=63489=63492 BRANCH read-write REVISION DETAIL https://phabricator.kde.org/D23061 AFFECTED FILES

D23061: Possiblity to change Definition data after loading

sirgienko added a comment. In D23061#509851 , @cullmann wrote: > Hmm, I think we want an unit test for this, too. > And I think it won't work like it is, before the call to initLookupForCaseSensitivity one needs to clear both

D23061: Possiblity to change Definition data after loading

cullmann added a reviewer: vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23061 To: sirgienko, dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns,

D23061: Possiblity to change Definition data after loading

cullmann added a comment. Hmm, I think we want an unit test for this, too. And I think it won't work like it is, before the call to initLookupForCaseSensitivity one needs to clear both m_keywordsSortedCaseSensitive and m_keywordsSortedCaseInsensitive vectors. REPOSITORY R216 Syntax

D23061: Possiblity to change Definition data after loading

sirgienko updated this revision to Diff 63489. sirgienko added a comment. Use `setKeywordList` instead previous API REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23061?vs=63448=63489 BRANCH read-write REVISION DETAIL

D23061: Possiblity to change Definition data after loading

sirgienko marked an inline comment as done. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23061 To: sirgienko, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns,

Re: Increasing KF5 cmake requirement to 3.5?

On samedi 10 août 2019 16:34:39 CEST David Faure wrote: > On dimanche 2 décembre 2018 00:05:48 CEST Albert Astals Cid wrote: > > El dissabte, 17 de novembre de 2018, a les 22:36:03 CET, Albert Astals Cid > > va escriure: > > > El dissabte, 17 de novembre de 2018, a les 20:03:37 CET, Wolfgang

Re: Increasing KF5 cmake requirement to 3.5?

On dimanche 2 décembre 2018 00:05:48 CEST Albert Astals Cid wrote: > El dissabte, 17 de novembre de 2018, a les 22:36:03 CET, Albert Astals Cid va escriure: > > El dissabte, 17 de novembre de 2018, a les 20:03:37 CET, Wolfgang Bauer va escriure: > > > > -Original Message- > > > > I'm

Re: Setting bug report address in KPlugin json data?

On lundi 26 novembre 2018 18:11:38 CEST René J.V. Bertin wrote: > Hi, > > I cannot seem to find how to set a bug reporting address in a plugin json > file. Is that possible and if so, how? That's a job for KAboutData, but the question is how to set one for a plugin; AFAICS this notion only

Re: Coding style: white space around asterisks

On mardi 6 août 2019 16:44:08 CEST Roman Gilg wrote: > Hi, > > Frameworks C++ coding style for pointer declarations follows the > asterisk to the right approach like Qt coding style recommends. > > This is most often a sensible choice but is difficult to read in my > opinion when there is no

D23062: Disable KCONFIG_USE_DBUS on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R237:710883fbbb0a: Disable KCONFIG_USE_DBUS on Android (authored by nicolasfella). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23062?vs=63450=63470 REVISION DETAIL

D23062: Disable KCONFIG_USE_DBUS on Android

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH nodbus REVISION DETAIL https://phabricator.kde.org/D23062 To: nicolasfella, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns