D23688: Allow to customize attributes for KSyntaxHighligting themes

nibags retitled this revision from "Allow customizing theme attributes in KSyntaxHighligting themes" to "Allow to customize attributes for KSyntaxHighligting themes". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23688 To: nibags, #ktexteditor, dhaumann, cullmann

D23688: Allow customizing theme attributes in KSyntaxHighligting themes

nibags created this revision. nibags added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY The diff D23516

D21760: Add KListOpenFiles::ListOpenFilesJob

hallas retitled this revision from "Add KListOpenFiles::listProcessesWithOpenFiles" to "Add KListOpenFiles::ListOpenFilesJob". hallas edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik,

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas added inline comments. INLINE COMMENTS > dfaure wrote in klistopenfilestest_unix.cpp:83 > I usually just use "/does/not/exist" as a path ;-) > > This might actually be better because Windows has weird race conditions with > the filesystem stuff. This test is unix only anyway so there

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas updated this revision to Diff 65284. hallas marked 3 inline comments as done. hallas added a comment. Review comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21760?vs=65237=65284 BRANCH add_list_processes_with_open_files (branched from

D23667: Add == and != operators to KIO::UDSEntry

pino added a comment. Oh, and also please add tests for them in UDSEntryTest. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

pino added a comment. Please move the implementations in the cpp file, otherwise it will be impossible to change/fix the implementation later on in a binary compatible way. Also: - both the operators ought to be const, since they do not mutate the object (and otherwise they cannot

D23658: Make notification icons use outline style

ngraham added a comment. If you're going to change the clapper position, don't forget about `preferences-desktop-notification-bell` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23658 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D22069: Localize long number strings

ngraham updated this revision to Diff 65283. ngraham added a comment. Correct test and don't run it if it can't succeed REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22069?vs=60622=65283 BRANCH localized-long-number-strings (branched from master)

D22069: Localize long number strings

ngraham marked 2 inline comments as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh,

D22069: Localize long number strings

ngraham added a comment. Thanks @aacid! REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh,

D23667: Add == and != operators to KIO::UDSEntry

ngraham added a comment. I know it seems silly for such tiny functions, but can you follow the pattern and keep only the function definitions in the header file and move the actual logic into the .cpp file? INLINE COMMENTS > udsentry.h:118 > +/** > + * Returns true if the entry

D23685: Make user-trash icons look like trashcans

ngraham added a comment. Yay real trashcans The appearance is definitely more appropriate compared to before. I really like it. However I'm afraid the visual recognizability of the full state compared to the empty state is worsened compared to the status quo: Empty: F7310762:

D22968: Make it possible to modify contacts

apol abandoned this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

apol added a comment. Committed as https://commits.kde.org/kpeople/7cf00a2cb27dcc11c8cd5b06423ce69c41537c82. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Sep 2019 22:00:00 + Build duration: 3 min 39 sec and counting JUnit Tests Name:

D22510: Added dialog to set execute permission for executable file when trying to run it.

dfaure added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:147 > I wonder why this doesn't use isExecutable(mimetype)... Hmm, because isExecutable(mimetype) also returns true for desktop files. So this would change behaviour for users of this API. (see why we try to limit public

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid added a comment. In D23119#519676 , @asemke wrote: > The original problem in LabPlot was reported by a windows user. The proposed fix won't fix the problem on windows. I think the only way to get the proper strings on Windows is to get

D23464: Add breeze icons for ROOT cern files

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. You're getting there. - 16px: needs 2px margins on the top and bottom - 22px: needs 3px margins on the top and bottom - 32px: needs to be lined up with the pixel grid and

D23685: Make user-trash icons look like trashcans

ndavis updated this revision to Diff 65268. ndavis added a comment. Add breeze dark icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23685?vs=65267=65268 BRANCH trash (branched from master) REVISION DETAIL https://phabricator.kde.org/D23685

D23685: Make user-trash icons look like trashcans

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23685 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23685: Make user-trash icons look like trashcans

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23685 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23685: Make user-trash icons look like trashcans

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG: 399613 REPOSITORY R266 Breeze Icons BRANCH trash (branched from master)

D23619: Introduce cloning and replication of output devices

romangg added a dependent revision: D23684: WIP: Add presenting event to output-device protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: kpiwowarski, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23684: WIP: Add presenting event to output-device protocol

romangg retitled this revision from "Add presenting event to output-device protocol" to "WIP: Add presenting event to output-device protocol". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23684 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23684: WIP: Add presenting event to output-device protocol

romangg added a dependency: D23619: Introduce cloning and replication of output devices. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23684 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23684: Add presenting event to output-device protocol

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The idea for this event is to inform output managing clients about the current state

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks, dfaure, cfeck, pino Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23661: Port away from Qt's foreach all loops over method-local containers

dhaumann added a comment. Also did a review and it looks good to me, thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23661 To: kossebau, #kate, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked 6 inline comments as done. mdlubakowski added a comment. Fixed according to comments, hope I haven't forget anything this time. Sorry for the API change, I thought it may make sense to add it like this since `isExecutableFile` and `isExecutable` are a part of it. I

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 65265. mdlubakowski added a comment. - Incorporated feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=65260=65265 BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 65264. alexde edited the test plan for this revision. alexde added a comment. Remove all circles and only use root symbol. This makes the root symbol less faint and the icons fit better to Breeze overall. REPOSITORY R266 Breeze Icons CHANGES SINCE

D23682: Make use of KPluginMetaData where we can

broulik added inline comments. INLINE COMMENTS > containmentactions.h:70 > * including name, pluginName and icon > - * @since 5.0 > + * @since 5.0 use metadata > */ @deprecated since 5.62 use metadata > dataengine.cpp:70 > : QObject(parent), > - d(new

D23619: Introduce cloning and replication of output devices

romangg updated this revision to Diff 65263. romangg marked 2 inline comments as done. romangg added a comment. - Fix enum ordering, typo. Thx @kpiwowarski. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23619?vs=65118=65263 BRANCH clone REVISION

D22510: Added dialog to set execute permission for executable file when trying to run it.

dfaure added a comment. Pino is right, I hadn't noticed that you added it as API. Yes please make the requested changes, we'll land it when it's perfect :-) REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski,

Re: Proposing Quick Charts as a new framework

Arjen Hiemstra ha scritto: > Hi, > > I have been working on a library the past few months that provides a QtQuick > module for rendering gpu-accelerated charts. It currently lives in a > playground > repository, here: https://invent.kde.org/kde/kf5quickcharts . I would like for > this library to

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski added a comment. Thanks for your guidance! I don't have developer account, so can't land myself. Should I fix those two other comments before landing? REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski,

D22510: Added dialog to set execute permission for executable file when trying to run it.

pino added inline comments. INLINE COMMENTS > krun.cpp:164 > > +bool KRun::hasExecuteBit(const QString ) > +{ please make this function as file static, so there is no need to expose it as API of the KRun class > krun.cpp:310 > +// Helper function that attempts to set execute bit for given

Proposing Quick Charts as a new framework

Hi, I have been working on a library the past few months that provides a QtQuick module for rendering gpu-accelerated charts. It currently lives in a playground repository, here: https://invent.kde.org/kde/kf5quickcharts . I would like for this library to be included as a Tier 1 Framework.

D22510: Added dialog to set execute permission for executable file when trying to run it.

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks for the changes. Looks ok to me now, despite some more nitpicks ;) Do you have a developer account to submit this? INLINE COMMENTS > krun.cpp:147 > QMimeDatabase db; >

D23682: Make use of KPluginMetaData where we can

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead of relying on the older KPluginInfo which is slower (parses de metadata twice) and

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 65260. mdlubakowski added a comment. - Removed leftover kfileitem.h include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=65258=65260 BRANCH arcpatch-D22510 REVISION DETAIL

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked 6 inline comments as done. mdlubakowski added a comment. Reversed my changes to `isExecutableFile` method as per D23660 , since my changes aren't needed anymore. Also added `hasExecuteBit` method. REPOSITORY R241 KIO REVISION DETAIL

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 65258. mdlubakowski added a comment. - Reverse change to KRun::isExeutableFile - Incorporated feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=64930=65258 BRANCH arcpatch-D22510 REVISION DETAIL

D23670: [KPropertiesDialog] Always check mount point being null

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:3b571aacf7e9: [KPropertiesDialog] Always check mount point being null (authored by broulik). REPOSITORY R241 KIO

D23670: [KPropertiesDialog] Always check mount point being null

PureTryOut added a comment. I tested this patch as a fix for https://bugs.kde.org/show_bug.cgi?id=411517 and it did the trick, it doesn't crash anymore. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23670 To: broulik, #frameworks, dfaure, shubham Cc: PureTryOut,

D23660: [KRun] Check mime type for isExecutableFile first

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9b12a872da35: [KRun] Check mime type for isExecutableFile first (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23660?vs=65206=65241 REVISION

D23660: [KRun] Check mime type for isExecutableFile first

broulik added a comment. > will still be used by isPromptNeeded, so this can go in. Speaking of which, that prompt check should be done after the mimetypejob has finished, not casually blocking everything in synchronous mime type determination beforehand :) REPOSITORY R241 KIO

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Nice job. Final comments. INLINE COMMENTS > klistopenfilestest_unix.cpp:51 > +QCOMPARE(processInfoAvailableSpy.at(0).at(0).value(), > path.path()); > +

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas added a comment. I have added a minimal Windows implementation which always emits an error, along with a unit test. Please review it thoroughly and then I think it is ready to land :) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas,

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas updated this revision to Diff 65237. hallas marked 2 inline comments as done. hallas added a comment. Review comments. Added minimal Windows implementation which basically always reports failure with the error code Unsupported. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65236. leinir added a comment. - Make sure to import the right version of newstuff REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=65219=65236 BRANCH knsquick-feature-parity-with-kns (branched from master)

D22144: Add kio recentlyused:/ to access KActivityStats data

dfaure added a comment. In D22144#520773 , @meven wrote: > This "magic" precisely is what I would have wished to find, it seemed to me something other ioslaves might want, to have contextual log or error message at least. > The pid of the

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

apol added inline comments. INLINE COMMENTS > normalvimode.cpp:3848 > } else { > -cAfter.setColumn(textLines.last().length() - 0); > -cAfter.setLine(cAfter.line() + textLines.length() - 1); > +const int lastLineLength = pastedText.size() - >

D23664: Port away from Qt's foreach all loops over method-local containers

kossebau edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23664 To: kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23660: [KRun] Check mime type for isExecutableFile first

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Makes sense. In D22510 I actually suggested splitting this method into two, but the all-in-one method will still be used by isPromptNeeded, so this

D22510: Added dialog to set execute permission for executable file when trying to run it.

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krun.cpp:186 > +protected: > +void showEvent(QShowEvent *e) override > +{ _pre-existing) this code will also be triggered when switching virtual

D23661: Port away from Qt's foreach all loops over method-local containers

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2ee34748cdb8: Port away from Qts foreach all loops over method-local containers (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I admit that I never understood why this was using KConfig. I guess Waldo had a hammer and everything looked like nails ;-) INLINE COMMENTS > slavebase.cpp:191 > +delete

D23661: Port away from Qt's foreach all loops over method-local containers

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok for me, thanks for taking care. REPOSITORY R39 KTextEditor BRANCH plainporttorangeloop REVISION DETAIL https://phabricator.kde.org/D23661 To: kossebau, #kate, cullmann

D23625: Use QString::count(QChar) over QString::split().length() - 1

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in normalvimode.cpp:3844 > Ah, no, textLines.last().length() needs the string section, so just a plain > count would not be enough, only if combining with a QString::section call > later, I now remember. > And some other patch

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH

D23625: Use QString::count(QChar) over QString::split().length() - 1

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in normalvimode.cpp:3844 > Guess the complete change missed to enter the commit, and review did not > catch it, > Well spotted, I shall do a follow-up. Ah, no, textLines.last().length() needs the string section, so just a plain

D23670: [KPropertiesDialog] Always check mount point being null

broulik edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23670 To: broulik, #frameworks, dfaure, shubham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23625: Use QString::count(QChar) over QString::split().length() - 1

kossebau added inline comments. INLINE COMMENTS > apol wrote in normalvimode.cpp:3844 > you didn't port this one to count? Guess the complete change missed to enter the commit, and review did not catch it, Well spotted, I shall do a follow-up. REPOSITORY R39 KTextEditor REVISION DETAIL

D23625: Use QString::count(QChar) over QString::split().length() - 1

apol added inline comments. INLINE COMMENTS > normalvimode.cpp:3844 > KTextEditor::Cursor cAfter = pasteLocation; > -const QStringList textLines = pastedText.split(QStringLiteral("\n")); > +const QStringList textLines = pastedText.split(QLatin1Char('\n')); > if

D23619: Introduce cloning and replication of output devices

kpiwowarski added inline comments. INLINE COMMENTS > outputdevice.xml:318 > + +summary="change due to hotplug of involved devices"/> > + It's not the same ;) None= 0, Explicit= 1 << 0, Hotplug = 1 << 1, Dpms= 1 << 2, Enablement = 1

D23670: [KPropertiesDialog] Always check mount point being null

broulik created this revision. broulik added reviewers: Frameworks, dfaure, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY File type got added after the fact and outside the guard.

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/23/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 02 Sep 2019 10:17:30 + Build duration: 18 min and counting

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Sep 2019 10:15:11 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/22/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 01 Sep 2019 02:57:57 + Build duration: 1 day 7 hr and counting CONSOLE OUTPUT

D13867: [KMessageWidget] Pass widget to standardIcon()

This revision was automatically updated to reflect the committed changes. Closed by commit R236:dbee23dd939b: [KMessageWidget] Pass widget to standardIcon() (authored by broulik). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13867?vs=61989=65220

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65219. leinir added a comment. - Whole lot of @since-ing - Adopt Qt-style KF5-version-aligned import versioning REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64986=65219 BRANCH

D23667: Add == and != operators to KIO::UDSEntry

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY I felt it was missing. TEST PLAN Compiles REPOSITORY R241 KIO BRANCH master

D23619: Introduce cloning and replication of output devices

romangg added a dependent revision: D23665: [platforms/drm] Support output replication. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23664: Port away from Qt's foreach all loops over method-local containers

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The simple porting, as those containers are not shared with anyone, so the

D23619: Introduce cloning and replication of output devices

romangg added a dependent revision: D23662: Wayland: Support output replication. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven added a comment. D23578 is the next step, but it is not in great shape. To do things properly, it will require quite some changes I fear. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

This revision was automatically updated to reflect the committed changes. Closed by commit R282:d9cb570cbef4: Add property lastScanTime and lastRequestTime to WirelessDevice (authored by meven). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven edited the summary of this revision. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich accepted this revision. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23661: Port away from Qt's foreach all loops over method-local containers

kossebau added a comment. There are quite a lot of foreachs in ktexteditor, so IMHO it makes sense to split up the porting in multiple commits, so in case of regressions one can bisect in the overall changes a bit and then has fewer changes to reason about where something might have been

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven updated this revision to Diff 65208. meven added a comment. Add a ref to the returned date REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=65204=65208 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 AFFECTED

D23661: Port away from Qt's foreach all loops over method-local containers

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY The simple porting, as those containers are not shared with

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Sorry, I missed that last one. Once it's fixed it's ready to go. INLINE COMMENTS > wirelessdevice.h:232 > + */ > +void lastScanChanged(const QDateTime timestamp); > const

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/48/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Sep 2019 08:31:39 + Build duration: 7 min 35 sec and counting JUnit Tests Name:

D23660: [KRun] Check mime type for isExecutableFile first

broulik created this revision. broulik added reviewers: dfaure, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The mime type is passed into the function, so it's already known. Checking

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven updated this revision to Diff 65204. meven marked an inline comment as done. meven added a comment. Review, remove incorrect doc REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=65002=65204 BRANCH master REVISION DETAIL

D23650: Add an icon for the trash root and a proper label

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9f8aeb11776: Add an icon for the trash root and a proper label (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23650?vs=65144=65205 REVISION

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > utils.h:86 > + > +QDateTime clockBootTimeToQDateTime(const qlonglong ); > } 1. Missing NETWORKMANAGERQT_EXPORT 2. I would remove 'Q' from the name → clockBootTimeToDateTime 3. just qlonglong clockBoottime, no const and & REPOSITORY R282

D23650: Add an icon for the trash root and a proper label

meven added a comment. In D23650#524092 , @Codezela wrote: > Why trash icon don't look like trash > Like any other os This is not related to this patch. Open a design bug if you'd like. REPOSITORY R241 KIO BRANCH master REVISION

D23650: Add an icon for the trash root and a proper label

Codezela added a comment. Why trash icon don't look like trash Like any other os REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks, broulik Cc: Codezela, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23650: Add an icon for the trash root and a proper label

meven added a reviewer: broulik. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven marked 3 inline comments as done. meven added inline comments. INLINE COMMENTS > broulik wrote in slavebase.cpp:281 > This is initialized automatically like this That's on purpose, the first use of mapConfig is in rebuildConfig and is a clear() call. REPOSITORY R241 KIO REVISION

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 65200. meven marked an inline comment as done. meven added a comment. Review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=65006=65200 BRANCH arcpatch-D23523_1 REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65199. meven added a comment. arc amend REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65198=65199 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65198. meven added a comment. Better variable naming REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65197=65198 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65197. meven added a comment. Add recentlyused:/ entry to Recent group to existing users REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65191=65197 BRANCH arcpatch-D7446 REVISION DETAIL

  1   2   >