apol added inline comments.
INLINE COMMENTS
> configmodule.cpp:174
> +
> if (!package.filePath("mainscript").isEmpty()) {
> d->_qmlObject->setSource(package.fileUrl("mainscript"));
maybe put it after checking the mainscript? the "no QML file provided" error
is more accurate. We
kossebau created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
GIT_SILENT
REPOSITORY
R236 KWidgetsAddons
BRANCH
adapttoecmaddqtpluginchange
REVISION DETAIL
kossebau added a dependent revision: D23726: Designer plugin: adapt to
pre-release API change of ECMAddQtDesignerPlugin.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D23725
To: kossebau, #frameworks, #build_system, vkrause
Cc: kde-frameworks-devel,
kossebau added a dependency: D23725: ECMAddQtDesignerPlugin: pass code sample
indirectly via variable name arg.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D23726
To: kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
kossebau created this revision.
kossebau added reviewers: Frameworks, Build System, vkrause.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
The initial API asked to
thomassc abandoned this revision.
thomassc added a comment.
Okay, thanks for your feedback. Discarding this then. I think I might have
found the problematic access in KDevelop already in the meantime ...
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23721
To:
dhaumann added a comment.
KTextEditor is nowhere designed to be thread-safe. Even if this patch solves
a particular issue you have in multithreaded access, we can be sure there will
be other (corner?) cases where it won't work: Think only of modifying the text
at some other place at the
thomassc added a comment.
Okay, I wasn't aware of the overall situation wrt. threading. Still, couldn't
it be useful to at least allow for concurrent read accesses which is probably
not a large effort (in contrast to concurrent read and write)? I guess that
people might not expect
ngraham added a comment.
+1 in concept. Is there any more verbose information we can get though? Like
specifically how the package is invalid?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D23722
To: broulik, mart, tcanabrava
Cc: ngraham,
cullmann added a comment.
Hmm, the use of atomic + a local var might avoid that the compiler optimizes
away the local var and just uses m_lastUsedBlock again directly, but I am not
sure if we should go that way.
If one has concurrent accesses to the buffer from different threads, all is
broulik created this revision.
broulik added reviewers: mart, tcanabrava.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Previously it would warn about no "mainscript" having been provided but all
thomassc edited the summary of this revision.
thomassc added a reviewer: KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23721
To: thomassc, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns,
thomassc created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
thomassc requested review of this revision.
REVISION SUMMARY
In the "shortcut: try last block first" branch in TextBuffer::blockForLine(),
m_lastUsedBlock is
kossebau added a comment.
Maybe it's because I am thirsty rigt now, but the new user-full-trash on a
quick look also resembles a full fresh beer glass waiting to be emptied :) Not
sure this association improves my life :P
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c3a9be4d311a: Improve user-trash icon
(authored by GB_2).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23711?vs=65376=65377
REVISION DETAIL
GB_2 edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
BRANCH
arcpatch-D23711
REVISION DETAIL
https://phabricator.kde.org/D23711
To: GB_2, #vdg, ngraham, ndavis
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns
GB_2 updated this revision to Diff 65376.
GB_2 added a comment.
Fix more 64px hard shadows
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23711?vs=65373=65376
BRANCH
arcpatch-D23711
REVISION DETAIL
https://phabricator.kde.org/D23711
AFFECTED
ndavis accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
arcpatch-D23711
REVISION DETAIL
https://phabricator.kde.org/D23711
To: GB_2, #vdg, ngraham, ndavis
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns
meven updated this revision to Diff 65374.
meven marked 5 inline comments as done.
meven added a comment.
Review feedback, add @since, review mapConfig signature, reset config and
configGroup to nullptr after deletion
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
GB_2 edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23711
To: GB_2, #vdg, ngraham, ndavis
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns
GB_2 updated this revision to Diff 65373.
GB_2 added a comment.
Fix margins and hard shadows
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23711?vs=65353=65373
BRANCH
arcpatch-D23711
REVISION DETAIL
https://phabricator.kde.org/D23711
AFFECTED
jgrulich added a comment.
I'm not sure the "Cipher Proposals" groupbox should be inside the "Options"
groupbox, imo it should be separated groupbox
INLINE COMMENTS
> strongswanwidget.cpp:100
> d->ui.ipComp->setChecked(dataMap[NM_STRONGSWAN_IPCOMP] == "yes");
> +
jgrulich added inline comments.
INLINE COMMENTS
> meven wrote in wirelessdevice.h:143
> I chose lastRequestScanTime to have RequestScan in the name, that is the
> function, it keeps the last time called from.
>
> The Time suffix does not feel great indeed.
>
> I can make an adjustment to
meven added inline comments.
INLINE COMMENTS
> jgrulich wrote in wirelessdevice.h:143
> Thinking about it now, wouldn't be this wording better?
>
> QDateTime lastScanRequestTime() const;
>
> Maybe even without the "Time" at the end so it's consistent with "lastScan".
I chose
jgrulich added inline comments.
INLINE COMMENTS
> wirelessdevice.h:143
> + */
> +QDateTime lastRequestScanTime() const;
> /**
Thinking about it now, wouldn't be this wording better?
QDateTime lastScanRequestTime() const;
Maybe even without the "Time" at the end so it's consistent
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.
We're supposed to use 6px margins on the top and bottom, making the visible
part of the icon 52px tall. Bottom line shadows are normally supposed to be 1px
tall. Other than that,
26 matches
Mail list logo
