KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 06 Sep 2019 05:13:35 + Build duration: 13 min and counting JUnit Tests Name:

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. In D7446#526494 , @meven wrote: > It would be great to have two different icons for recentlyused:/locations and recentlyused:/files. > Also I am not sure recentlyuserd:/ should use "document-open-recent-symbolic"

D21760: Add KListOpenFilesJob

hallas updated this revision to Diff 65494. hallas added a comment. Review comments, renamed the files to match the class name REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21760?vs=65330=65494 BRANCH add_list_processes_with_open_files (branched

D21760: Add KListOpenFilesJob

hallas marked an inline comment as done. hallas added a comment. In D21760#525842 , @dfaure wrote: > Yes, the filenames should match the classname, obviously :) > > I did a deeper review of the KJob usage and I have two more comments, sorry

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 WindowsMSVCQt5.13 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20WindowsMSVCQt5.13/4/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 06 Sep 2019 04:32:19 + Build duration: 7 min 23 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20WindowsMSVCQt5.13/3/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 06 Sep 2019 03:24:17 + Build duration: 1 hr 6 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 28 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/28/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 06 Sep 2019 04:19:57 + Build duration: 9 min 59 sec and counting

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. It would be great to have two different icons for recentlyused:/locations and recentlyused:/files. Also I am not sure recentlyuserd:/ should use "document-open-recent-symbolic" since it is monochrone, the kio declares currently "document-open-recent". Maybe

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/27/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 05 Sep 2019 13:46:09 + Build duration: 14 hr and counting

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65492. meven added a comment. Use Terms::Type::directories() REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65484=65492 BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. @ngraham you added some dependencies but D23737 and D23741 are not direct dependencies, but rather related fixes. Still, I don't mind leaving them as dependencies. REPOSITORY R241 KIO

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

meven updated this revision to Diff 65491. meven added a comment. Spacing REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65490=65491 BRANCH arcpatch-D23736 REVISION DETAIL https://phabricator.kde.org/D23736 AFFECTED FILES

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

meven updated this revision to Diff 65490. meven added a comment. Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG bis REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65489=65490 BRANCH arcpatch-D23736 REVISION DETAIL

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

meven updated this revision to Diff 65489. meven added a comment. Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65488=65489 BRANCH arcpatch-D23736 REVISION DETAIL

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

meven retitled this revision from "Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then" to "Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them". REPOSITORY R159 KActivities Statistics REVISION

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then

meven retitled this revision from "Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories" to "Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then". REPOSITORY R159 KActivities Statistics REVISION DETAIL

D23736: Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories

meven updated this revision to Diff 65488. meven added a comment. Rename locations to directories REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65485=65488 BRANCH arcpatch-D23736 REVISION DETAIL

Re: Proposing Quick Charts as a new framework

On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra wrote: > > On 02-09-2019 19:26, Luigi Toscano wrote: > > Arjen Hiemstra ha scritto: > >> Hi, > >> > >> I have been working on a library the past few months that provides a > >> QtQuick > >> module for rendering gpu-accelerated charts. It currently

D23708: [CopyJob] Fix crash when copying an already existing dir and pressing "Skip"

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. In D23708#525848 , @dfaure wrote: > Thanks for the fix! > > Do you feel like writing a unittest for it? > JobTest::chmodFileError shows how to use

D23708: [CopyJob] Fix crash when copying an already existing dir and pressing "Skip"

ahmadsamir updated this revision to Diff 65486. ahmadsamir retitled this revision from "[CopyJob] Fix crash when copying all files is skipped for an already existing dir" to "[CopyJob] Fix crash when copying an already existing dir and pressing "Skip"". ahmadsamir edited the summary of this

D23736: Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories

ngraham added inline comments. INLINE COMMENTS > ivan wrote in terms.h:106 > Can we call it `directories` to follow the Qt API? That is the only complaint > I have, otherwise thie is quite a nice addition. +1, directories is fine for the code, and we can just surface the word "locations" in

Re: Proposing Quick Charts as a new framework

On 02-09-2019 19:26, Luigi Toscano wrote: Arjen Hiemstra ha scritto: Hi, I have been working on a library the past few months that provides a QtQuick module for rendering gpu-accelerated charts. It currently lives in a playground repository, here: https://invent.kde.org/kde/kf5quickcharts .

D23736: Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories

ivan added inline comments. INLINE COMMENTS > terms.h:106 > + */ > +static Type locations(); > Can we call it `directories` to follow the Qt API? That is the only complaint I have, otherwise thie is quite a nice addition. REPOSITORY R159 KActivities Statistics REVISION

D23736: Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories

meven retitled this revision from "Add a Term::Type::files() to filter excluding directories" to "Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories". REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23736 To:

D23736: Add a Term::Type::files() to filter excluding directories

meven updated this revision to Diff 65485. meven added a comment. Add Term::Type::locations REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65446=65485 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23736 AFFECTED

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65484. meven added a comment. grammar REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65474=65484 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 AFFECTED FILES

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65474. meven added a comment. typo REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65473=65474 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 AFFECTED FILES

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65473. meven added a comment. Replace /folders by /locations, add some documentation REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65470=65473 BRANCH master REVISION DETAIL

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

zzag added a task: T11480: Make xdg-shell properties double-buffered. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23745 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY So far all double-buffered properties in our implementation of xdg-shell weren't actually

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ngraham added a dependent revision: D7446: [Places panel] Revamp the Recently Saved section. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice,

D7446: [Places panel] Revamp the Recently Saved section

ngraham edited the summary of this revision. ngraham added dependencies: D23742: Add two special cases url recentlyused:/files and recentlyused:/folders, D23737: Extract mimetype from recentlyused.xbel, D23741: Save the Mimetype of opened resources. REPOSITORY R241 KIO REVISION DETAIL

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65470. meven added a comment. Add some const REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65467=65470 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 AFFECTED FILES

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ivan accepted this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D22069: Localize long number strings

ngraham added a comment. In D22069#526291 , @aacid wrote: > But i guess @huftis is right, the test is not setting the language "enough" to be french, just "a bit" (there's too many layers of stuff to set) and it just works for me because i'm

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. In D7446#526304 , @meven wrote: > In D7446#526201 , @ngraham wrote: > > > Fantastic work. That's exactly what I had in mind and it works perfectly! > > > > With those, we

D23739: Fix uninitialized memory read

aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D23739 To: aacid, dfaure, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65467. meven added a comment. Rephrase 'Recent Folders' to 'Recent Locations' REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65449=65467 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#526201 , @ngraham wrote: > Fantastic work. That's exactly what I had in mind and it works perfectly! > > With those, we can have Recent Files and Recent Locations (or maybe Recent Folders) in the Recent

D23739: Fix uninitialized memory read

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D23739 To: aacid, dfaure, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

aacid added a comment. But i guess @huftis is right, the test is not setting the language "enough" to be french, just "a bit" (there's too many layers of stuff to set) and it just works for me because i'm also in a locale tht uses , like the french REPOSITORY R249 KI18n REVISION DETAIL

D22069: Localize long number strings

aacid added a comment. In D22069#526284 , @ngraham wrote: > In D22069#526278 , @aacid wrote: > > > In D22069#526243 , @ngraham wrote: > > > > > That's

D22069: Localize long number strings

ngraham added a comment. In D22069#526278 , @aacid wrote: > In D22069#526243 , @ngraham wrote: > > > That's the same failure I have too, but @aacid said it was because my system was mis-configured.

D22069: Localize long number strings

aacid added a comment. In D22069#526243 , @ngraham wrote: > That's the same failure I have too, but @aacid said it was because my system was mis-configured. I don't really understand the issue, I'm afraid. Are you really saying that when

D22069: Localize long number strings

huftis added a comment. In D22069#526243 , @ngraham wrote: > That's the same failure I have too, but @aacid said it was because my system was mis-configured. I don't really understand the issue, I'm afraid. On my system, the test passes

D22069: Localize long number strings

ngraham added a comment. That's the same failure I have too, but @aacid said it was because my system was mis-configured. I don't really understand the issue, I'm afraid. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks,

D23698: document: Port away from foreach loops over members without calls to owner

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_document REVISION DETAIL https://phabricator.kde.org/D23698 To: kossebau, #kate,

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. Fantastic work. That's exactly what I had in mind and it works perfectly! With those, we can have Recent Files and Recent Locations (or maybe Recent Folders) in the Recent section, and we can get rid of the existing Today entry. That will make this patch

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. After applying the full patchset, this works great. It's //exactly// what I was hoping for!  REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D23736: Add a Term::Type::files() to filter excluding directories

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Add the same for directories for completeness REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23736 To: meven, ivan Cc: kde-frameworks-devel,

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#526039 , @meven wrote: > In D7446#526032 , @ngraham wrote: > > > This works great. > > > > one minor concern I have with the new IOSlave in general is how it shows

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven created this revision. meven added reviewers: ivan, ngraham, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Depends on D23736

D23736: Add a Term::Type::files() to filter excluding directories

meven added a dependent revision: D23742: Add two special cases url recentlyused:/files and recentlyused:/folders. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23736 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

This revision was automatically updated to reflect the committed changes. Closed by commit R266:939cbf897133: Add 22px dialog-scripts, change script actions/places icons to match it (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D23736: Add a Term::Type::files() to filter excluding directories

meven updated this revision to Diff 65446. meven added a comment. Exclude files whose mimetype is not known from the files filter REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65433=65446 BRANCH master REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Sep 2019 15:38:02 + Build duration: 7 min 39 sec and counting JUnit Tests Name:

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH scripts-box-shape (branched from master) REVISION DETAIL https://phabricator.kde.org/D23738 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

ndavis added a dependent revision: D23740: Change terminal panel icon to dialog-scripts. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23738 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23738 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

meven added a comment. I didn't know about `KMount` Gwenview uses it as we are trying here : bool urlIsFastLocalFile(const QUrl ) { if (!url.isLocalFile()) { return false; } KMountPoint::List list = KMountPoint::currentMountPoints();

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23738 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23739: Fix uninitialized memory read

aacid created this revision. aacid added reviewers: dfaure, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Make sure whole of pixel_size in pixel has data either because it was read or

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old ">_" style without the box around it looked odd and the margins were wrong.

D23730: Add new protocol for 7z archives

ngraham added a comment. In D23730#526045 , @nhiga wrote: > @meven > > There is a weird bug if I name the protocol as "7z" or "7zip": > > 1. If I double click on the 7z file, Dolphin gives the "invalid protocol" error. > 2. If I try to

D23736: Add a Term::Type::files() to filter excluding directories

meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23736

D23730: Add new protocol for 7z archives

nhiga added a comment. @meven There is a weird bug if I name the protocol as "7z" or "7zip": 1. If I double click on the 7z file, Dolphin gives the "invalid protocol" error. 2. If I try to manually enter the URL in Dolphin, i.e. `7z:/tmp/bar.7z` or `7zip:/tmp/bar.7z`, it does not

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#526032 , @ngraham wrote: > This works great. > > one minor concern I have with the new IOSlave in general is how it shows both files and folders. For me, the folders are a distraction from the file listing.

D23730: Add new protocol for 7z archives

meven requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe,

D23730: Add new protocol for 7z archives

meven added a comment. In D23730#526024 , @ltoscano wrote: > Does it work when the older KIO is installed? Yes, I have tested it. INLINE COMMENTS > sevenz.protocol:3 > +exec=kf5/kio/archive > +protocol=sevenz >

D7446: [Places panel] Revamp the Recently Saved section

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D7446: [Places panel] Revamp the Recently Saved section

ngraham accepted this revision. ngraham added a comment. This works great. one minor concern I have with the new IOSlave in general is how it shows both files and folders. For me, the folders are a distraction from the file listing. But I was thinking: how about adding modes that allow

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Sep 2019 13:46:09 + Build duration: 9 min 44 sec and counting JUnit Tests Name:

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. ping @ngraham any luck testing this ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > jgrulich wrote in wirelessdevice.h:143 > Please do, you can push it directly, it's just a function rename. https://cgit.kde.org/networkmanager-qt.git/commit/?id=af98fdba63e32c38008592774436ae6c9b61cd90

D23730: Add new protocol for 7z archives

ltoscano added a comment. Does it work when the older KIO is installed? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas,

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

This revision was automatically updated to reflect the committed changes. Closed by commit R241:509640f8e185: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath (authored by nhiga, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23730: Add new protocol for 7z archives

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. In D23730#526010 , @ngraham wrote: > Probably best to submit the KIO patch first. D23490 has been

D23730: Add new protocol for 7z archives

ngraham added a comment. Probably best to submit the KIO patch first. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga Cc: ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D23722: Warn if KPackage is invalid

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's consider it an iteration though. INLINE COMMENTS > broulik wrote in configmodule.cpp:174 > Is "mainscript" mandatory? > > In any case, if your package has the incorrect folder

D23730: Add new protocol for 7z archives

nhiga added a comment. Notes: 1. This patch requires D23490 and the following KIO patch: diff --git a/src/filewidgets/kurlnavigator.cpp b/src/filewidgets/kurlnavigator.cpp index 80aa975..5a6c720 100644 ---

D23730: Add new protocol for 7z archives

nhiga created this revision. nhiga added a project: Frameworks. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. nhiga requested review of this revision. REVISION SUMMARY This patch adds a new protocol, sevenz, for 7z archives by utilizing K7Zip. Previously, users have to

D23708: [CopyJob] Fix crash when copying all files is skipped for an already existing dir

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for the fix! Do you feel like writing a unittest for it? JobTest::chmodFileError shows how to use PredefinedAnswerJobUiDelegate to simulate the user pressing "Skip"

D21760: Add KListOpenFilesJob

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Yes, the filenames should match the classname, obviously :) I did a deeper review of the KJob usage and I have two more comments, sorry for not taking the time to do this

D22069: Localize long number strings

dfaure added a comment. This broke the unittest in CI. https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.12/35/testReport/junit/projectroot/autotests/ki18n_klocalizedstringtest/ I can reproduce the failure locally. FAIL! : KLocalizedStringTest::correctSubs()

D23722: Warn if KPackage is invalid

broulik added inline comments. INLINE COMMENTS > apol wrote in configmodule.cpp:174 > maybe put it after checking the mainscript? the "no QML file provided" error > is more accurate. We can keep ::isValid as a fallback. > Actually, if there's no mainscript it probably shouldn't be valid. Is

KDE CI: Frameworks » kglobalaccel » kf5-qt5 WindowsMSVCQt5.13 - Build # 4 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20WindowsMSVCQt5.13/4/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 05 Sep 2019 06:01:32 + Build duration: 14 min and counting JUnit Tests Name: