D23730: Add new protocol for 7z archives

nhiga edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D23780: Add new protocol for 7z archives

nhiga created this revision. nhiga added reviewers: Frameworks, cfeck, pino, dfaure, meven. nhiga added a project: Frameworks. nhiga requested review of this revision. REVISION SUMMARY D23730 adds the `sevenz` protocol for 7z archives by utilizing K7Zip, so

D23703: (others): Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:90aa6c665ed3: (others): Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23702: utils: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7449bb5a8f2e: utils: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23701: undo: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c365f1e9a2d3: undo: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23700: view: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d35377978a90: view: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23699: mode: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2d582d7f8d46: mode: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23698: document: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:84bb5661927b: document: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23697: buffer: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:b9167245dd3d: buffer: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23597: Bulk port away from foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R236:549fc06ffa21: Bulk port away from foreach (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23597?vs=65089=65614 REVISION DETAIL

D23778: Remove superfluous >22px recent documents icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Keep the 24px icon for now. It's in Adwaita at 24px too, so there might be some app out there that uses 24px icons. When the repo is setup to generate 24px icons at build time,

D23772: Make less use of deprecated enum alias NET::StaysOnTop

This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R278:c747c71d7146: Make less use of deprecated enum alias NET::StaysOnTop (authored by kossebau). CHANGED PRIOR TO COMMIT

D23778: Remove superfluous >22px recent documents icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think we should still have 24px icons for compatibility, but since they're exactly the same as the 22px icons with wider margins, it might be better to generate 24px icons at build time.

D23418: KStartupInfo: drop dead code for removing quotes from data values

This revision was automatically updated to reflect the committed changes. Closed by commit R278:14519d311709: KStartupInfo: drop dead code for removing quotes from data values (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ivan accepted this revision. REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D23777: Fix diff

GB_2 removed R242 Plasma Framework (Library) as the repository for this revision. GB_2 removed a project: Frameworks. GB_2 removed subscribers: apol, kde-frameworks-devel. REVISION DETAIL https://phabricator.kde.org/D23777 To: GB_2 Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham,

D23777: Fix diff

GB_2 abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23777 To: GB_2 Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23777: Fix diff

apol added a comment. Please fix commit message. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23777 To: GB_2 Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 18:35:49 + Build duration: 3 hr 0 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 18:29:07 + Build duration: 3 hr 3 min and counting JUnit Tests Name:

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65608. meven marked 5 inline comments as done. meven added a comment. typo fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65607=65608 BRANCH arcpatch-D23667 REVISION DETAIL

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65607. meven added a comment. Fix test and implementation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65298=65607 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 18:09:26 + Build duration: 3 hr 16 min and counting JUnit Tests Name:

D23707: Fix crash on teardown with Applet's ConfigLoader

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5f746ce1c2c2: Fix crash on teardown with Applets ConfigLoader (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

zzag updated this revision to Diff 65603. zzag added a comment. Handle value of zero in set_max_size callback. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23745?vs=65472=65603 BRANCH surface-role REVISION DETAIL https://phabricator.kde.org/D23745

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 17:33:41 + Build duration: 3 hr 36 min and counting JUnit Tests Name:

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

zzag added a comment. In D23745#527309 , @davidedmundson wrote: > Only question is whether it'd more useful to have an api which helps track that we only have one role, or have an api where /all/ the objects attached to a surface (blur, plasma

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65602. meven added a comment. Use new folder-open-recent for /locations bookmark REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65519=65602 BRANCH arcpatch-D7446 REVISION DETAIL

D23761: Make small recent documents icons look like documents and improve clock emblems

meven added a comment. Is that the expected result ? F7328222: Screenshot_20190907_230008.png If so, it needs some polishing IMO. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23761 To: ngraham, #vdg, ndavis

D23766: FakeInput: add support for keyboard key press and release

jgrulich updated this revision to Diff 65600. jgrulich added a comment. Bump framework version Apparently KDE Frameworks 5.62 are already out. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23766?vs=65557=65600 BRANCH master REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 16:46:57 + Build duration: 3 hr 53 min and counting JUnit Tests Name:

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ngraham accepted this revision. REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 16:32:07 + Build duration: 3 hr 53 min and counting JUnit Tests Name:

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65597. meven added a comment. Use new folder-open-recent for /locations REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65492=65597 BRANCH arcpatch-D23742 REVISION DETAIL

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 16:30:18 + Build duration: 3 hr 52 min and counting JUnit Tests Name:

D23778: Remove superfluous >22px recent documents icons

ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The >22px versions of these icons are unnecessary (we don't generally do >22px

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/61/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 15:35:17 + Build duration: 4 hr 33 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 14:48:59 + Build duration: 5 hr 12 min and counting JUnit Tests

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

davidedmundson added a comment. > pray to the God hoping that the client committed associated surface. Practically its nowhere near as bad as this sounds. We might send a configure event early, but it'll only ever have an application after a new commit. The most that will be broken is

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/14/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 07 Sep 2019 17:36:23 + Build duration: 1 hr 2 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:09:15 + Build duration: 5 hr 26 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:09:01 + Build duration: 5 hr 19 min and counting JUnit Tests Name:

D10362: Change reveal password button logic

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel, LeGast00n,

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65592. GB_2 added a comment. Don't hide button if revealing password, like in the PolKit dialog and simplify code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65585=65592 BRANCH

D23777: Fix diff

GB_2 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D23777 AFFECTED FILES

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:09:10 + Build duration: 5 hr 0 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 13 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/13/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 07 Sep 2019 13:09:12 + Build duration: 4 hr 27 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kunitconversion » kf5-qt5 WindowsMSVCQt5.13 - Build # 4 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20WindowsMSVCQt5.13/4/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 07 Sep 2019 15:15:22 + Build duration: 2 hr 18 min and counting JUnit Tests

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:09:12 + Build duration: 4 hr 24 min and counting JUnit Tests Name:

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.13 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.13/12/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 07 Sep 2019 13:08:51 + Build duration: 4 hr 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/50/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 07 Sep 2019 13:08:50 + Build duration: 4 hr 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/12/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 07 Sep 2019 15:09:10 + Build duration: 2 hr 11 min and counting JUnit Tests

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:09:00 + Build duration: 3 hr 37 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:09:09 + Build duration: 3 hr 22 min and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:09:10 + Build duration: 3 hr 20 min and counting JUnit Tests Name:

D22069: Localize long number strings

huftis added a comment. In D22069#526284 , @ngraham wrote: > I actually don't know how to properly install other language stuff. When I add French in the languages KCM, I suffer from https://bugs.kde.org/show_bug.cgi?id=327757. > > What is

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65585. GB_2 added a comment. Fix normal text fields REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65551=65585 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/60/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:09:03 + Build duration: 2 hr 25 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/11/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 07 Sep 2019 13:09:00 + Build duration: 1 hr 59 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 159 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/159/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 07 Sep 2019 13:08:50 + Build duration: 1 hr 56 min and counting JUnit Tests Name: (root)

D23411: Fix crash in writer collection and cleanup

bruns added inline comments. INLINE COMMENTS > apol wrote in writercollection.cpp:133 > maybe it would make sense to use shared pointers there? No. `m_plugin` is either a QPluginLoader::instance(), i.e. shared, or a collection-owned ExternalWriter. REPOSITORY R286 KFileMetaData REVISION

KDE CI: Frameworks » kglobalaccel » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 07 Sep 2019 13:09:02 + Build duration: 1 hr 40 min and counting JUnit Tests

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:09:00 + Build duration: 1 hr 39 min and counting JUnit Tests

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.12 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 07 Sep 2019 13:08:51 + Build duration: 1 hr 19 min and counting BUILD ARTIFACTS

Re: Proposing Quick Charts as a new framework

On 06-09-2019 02:49, Aleix Pol wrote: On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra wrote: On 02-09-2019 19:26, Luigi Toscano wrote: > Arjen Hiemstra ha scritto: >> Hi, >> >> I have been working on a library the past few months that provides a >> QtQuick >> module for rendering

D23772: Make less use of deprecated enum alias NET::StaysOnTop

kossebau added a comment. @zzag: Thanks for review. Will land once KF 5.62 is branched this WE. INLINE COMMENTS > zzag wrote in netwininfotestwm.cpp:449 > We can remove this row now. Indeed, does the same test as the row above, good catch, Will remove then. REPOSITORY R278 KWindowSystem

D23758: [CopyJob] Use resolved URL in copyingDone so undo can rename back using local file

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23758 To: dfaure, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23411: Fix crash in writer collection and cleanup

apol added inline comments. INLINE COMMENTS > writer.h:63 > > +WriterPrivate *d; > friend class WriterCollection; Why's this change? > writercollection.cpp:133 > +Writer writer; > +writer.d->m_plugin = plugin; > +

D23772: Make less use of deprecated enum alias NET::StaysOnTop

zzag added inline comments. INLINE COMMENTS > netwininfotestwm.cpp:449 > QTest::newRow("keepAbove")<< NET::States(NET::KeepAbove) > << (QVector() << keepAbove << staysOnTop); > -QTest::newRow("staysOnTop") << NET::States(NET::StaysOnTop) > << (QVector() <<

D23772: Make less use of deprecated enum alias NET::StaysOnTop

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH lessuseofstaysOnTop REVISION DETAIL https://phabricator.kde.org/D23772 To: kossebau, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/46/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Sep 2019 13:08:50 + Build duration: 22 min and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/26/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 07 Sep 2019 13:08:50 + Build duration: 7 min 41 sec and counting JUnit Tests

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65579. leinir added a comment. - Add a getter for the first provider (usually the default) - Get the default provider, if one is not yet set - Handle the multi-provider scenario REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D23418: KStartupInfo: drop dead code for removing quotes from data values

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH dropdeadcodeforremovingquotesfromstartupdatavalue REVISION DETAIL https://phabricator.kde.org/D23418 To: kossebau, #plasma, hein, broulik, #kwin, zzag Cc:

D23418: KStartupInfo: drop dead code for removing quotes from data values

kossebau added a reviewer: KWin. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23418 To: kossebau, #plasma, hein, broulik, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D14948: Port scriptabletags to QJSEngine

carewolf abandoned this revision. REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

D23772: Make less use of deprecated enum alias NET::StaysOnTop

zzag edited reviewers, added: KWin; removed: Frameworks. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23772 To: kossebau, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23772: Make less use of deprecated enum alias NET::StaysOnTop

kossebau added a comment. Found while experimenting with code for T11490 . This patch would later allow to do a simple #if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 0) /** @deprecated This is an obsolete name for

D23772: Make less use of deprecated enum alias NET::StaysOnTop

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY - use NET::KeepAbove instead of NET::StaysOnTop in code - deduplicate code

D23411: Fix crash in writer collection and cleanup

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D23411 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D19088: Use propertymap to store properties in Baloo::Result

astippich accepted this revision. astippich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > file.cpp:121 > const QJsonDocument jdoc = QJsonDocument::fromJson(arr); > -const QVariantMap varMap = jdoc.object().toVariantMap(); > -d->propertyMap

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Since released versions of dolphin, baloo-widgets and elisa now actually cope with this case, I am no longer opposed merging this REPOSITORY R293 Baloo BRANCH submit REVISION

D23771: Improve API documentation for Definition::setKeywordList()

This revision was automatically updated to reflect the committed changes. Closed by commit R216:5db5ac6dad3d: Improve API documentation for Definition::setKeywordList() (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23771: Improve API documentation for Definition::setKeywordList()

dhaumann added a comment. Thanks for the quick review! REPOSITORY R216 Syntax Highlighting BRANCH improve-docs REVISION DETAIL https://phabricator.kde.org/D23771 To: dhaumann, sirgienko Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D23771: Improve API documentation for Definition::setKeywordList()

sirgienko accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH improve-docs REVISION DETAIL https://phabricator.kde.org/D23771 To: dhaumann, sirgienko Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,

D23771: Improve API documentation for Definition::setKeywordList()

dhaumann added inline comments. INLINE COMMENTS > sirgienko wrote in definition.h:344 > > In general, ... in general > > Is it correct? Or just accidental typo? Of course not! Thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23771 To: dhaumann,

D23771: Improve API documentation for Definition::setKeywordList()

dhaumann updated this revision to Diff 65571. dhaumann added a comment. - Fix duplication of "in general" REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23771?vs=65570=65571 BRANCH improve-docs REVISION DETAIL

D23771: Improve API documentation for Definition::setKeywordList()

sirgienko added inline comments. INLINE COMMENTS > definition.h:344 > * > - * This function can be usefull for dynamic higlighting, when the > document rehiglights more, that one time. > - * For example, you have a program for editing and running Octave > scripts files and > -

D23771: Improve API documentation for Definition::setKeywordList()

dhaumann created this revision. dhaumann added a reviewer: sirgienko. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Followup to D23061 .

D23755: Fix no device available text

This revision was automatically updated to reflect the committed changes. Closed by commit R495:f30debdd498e: Fix no device available text (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23755?vs=65517=65568 REVISION DETAIL

D23722: Warn if KPackage is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit R296:19bf8ad69bde: Warn if KPackage is invalid (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23722?vs=65380=65567 REVISION DETAIL

D23753: Fix test failing

aacid closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D23753 To: aacid, ngraham, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

jgrulich added a dependent revision: D23769: Add support for keyboard key press and release from fake input protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2,

D23766: FakeInput: add support for keyboard key press and release

jgrulich added inline comments. INLINE COMMENTS > jgrulich wrote in fakeinput.h:222 > I will need a little bit of help to understand what type of key event should > be used and I don't remember where I got the information it expects codes > defined from linux/input-event-codes.h (I copied it

D23764: Make it possible to delete contacts from backends

This revision was automatically updated to reflect the committed changes. Closed by commit R307:0514c4d0cc17: Make it possible to delete contacts from backends (authored by jbbgameich). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23764?vs=6=65563

D23766: FakeInput: add support for keyboard key press and release

jgrulich added inline comments. INLINE COMMENTS > fakeinput.h:222 > + * Request a keyboard button release. > + * @param linuxButton The button code as defined in > linux/input-event-codes.h > + * I will need a little bit of help to understand what type of key event should be used

D23764: Make it possible to delete contacts from backends

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH master REVISION DETAIL https://phabricator.kde.org/D23764 To: jbbgameich, apol, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

jgrulich added reviewers: davidedmundson, apol, Plasma, romangg. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REVISION SUMMARY Adds support for keyboard button press and release as defined in linux/input-event-codes.h REPOSITORY R127

D22155: Add new activities and virtual desktops icons

dfaure added a comment. Thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: dfaure, anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

  1   2   >