D23579: WIP: port ftp slave to new error reporting system

pino added inline comments. INLINE COMMENTS > anthonyfieroni wrote in ftp.h:49 > That's BIC we cannot remove, reorder nor insert parent(s) > That's BIC we cannot remove, reorder nor insert parent(s) This is a kioslave, built as plugin. There is no such thing as BC for this kind of stuff.

D23579: WIP: port ftp slave to new error reporting system

anthonyfieroni added inline comments. INLINE COMMENTS > ftp.h:49 > > //=== > -class Ftp : public QObject, public KIO::SlaveBase > { That's BIC we cannot remove, reorder nor insert parent(s) > ftp.h:167 > + > +class

D23667: Add == and != operators to KIO::UDSEntry

dfaure added a comment. Note that there is `KFileItem::cmp` for a more thorough comparison of two fileitems. But it only looks at some UDS fields -- those that matter at the KDirLister level. Or maybe it shows that UDSEntry::operator== was missing so KFileItem::cmp uses a poor man's

D23579: WIP: port ftp slave to new error reporting system

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Nice work! INLINE COMMENTS > ftptest.cpp:33 > +public: > +QUrl url(const QString ) > +{ this method should be const > ftptest.cpp:50 > +// works around the fact

D24113: xcf: Properly read image resolution

cfeck added a comment. That's bug 362484, please close. Merci! REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24113 To: aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D12992: New elisa icon

ndavis added a comment. icons/apps/22/elisa.svg does not apply cleanly. Not sure why. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: trickyricky26, ndavis, KonqiDragon, abetts, paullesur, januz, mgallien, alex-l,

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Sep 2019 21:18:48 + Build duration: 1 min 24 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Sep 2019 20:41:19 + Build duration: 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Sep 2019 20:42:07 + Build duration: 41 sec and counting JUnit Tests Name:

D24113: xcf: Properly read image resolution

aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24113 To: aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24114: xcf: Fix regression when reading files with "unsupported" properties

aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24114 To: aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven added a comment. In D23667#535222 , @dfaure wrote: > Looks ok, but I'm just curious about the use case. "I felt it was missing" doesn't sound as strong an argument as "I need this"... > > Slaves are supposed to mostly create those, not

D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid

fvogt added a reviewer: Frameworks. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D23692 To: maltek, adridg, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24091: Move "Full Screen Mode" item from Settings menu to View menu

This revision was automatically updated to reflect the committed changes. Closed by commit R263:93455f78d78d: Move Full Screen Mode item from Settings menu to View menu (authored by ngraham). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24091?vs=66541=66554

D24113: xcf: Properly read image resolution

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D24113 To: aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24114: xcf: Fix regression when reading files with "unsupported" properties

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D24114 To: aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24076: add a simple smoke test for slaves by using kioclient5

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smoketests REVISION DETAIL https://phabricator.kde.org/D24076 To: sitter, dfaure Cc: feverfew, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/96/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Sep 2019 16:01:40 + Build duration: 8 min 13 sec and counting JUnit Tests Name:

D24113: xcf: Properly read image resolution

aacid created this revision. aacid added reviewers: cfeck, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY QDataStream reads 64 bits when reading into a float unless you tell it to use

D24003: kwaylandScanner produce version enum per class

romangg added a comment. By the way I guess the reason why only the `PrimarySelectionOfferV1InterfaceVersion` is there without the patch is that the other interfaces are created through the manager on request of the client while the offer is created server-side and then sent through an

D21897: Address some issues reported by Krazy analysis

pajamapants3000 added inline comments. INLINE COMMENTS > elvisangelaccio wrote in krichtextwidget.cpp:638 > Ah of course. I didn't notice it was `exec()` that was being called. Coming back after two months, even I thought this looked wrong at first. I will endeavor to make my intent clearer,

D24114: xcf: Fix regression when reading files with "unsupported" properties

aacid created this revision. aacid added reviewers: cfeck, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY The fact that we don't know the property is most of the times not fatal, so what we

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D24091 To: ngraham, #vdg, #frameworks, cfeck, ndavis Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham updated this revision to Diff 66541. ngraham added a comment. Add safe extra separator REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24091?vs=66484=66541 BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL

D24003: kwaylandScanner produce version enum per class

romangg added a comment. Header output with the patch: #ifndef KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H #define KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H #include "global.h" #include "resource.h" #include namespace KWayland {

D24059: Replace KSslError::errorString with QSslError::errorString

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b56de79a281f: Replace KSslError::errorString with QSslError::errorString (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24059?vs=66400=66546

D12992: New elisa icon

ngraham added a subscriber: trickyricky26. ngraham added a comment. @abetts has been inactive recently; probably needs @lshoravi or @ndavis or @trickyricky26 to take over. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham,

D24091: Move "Full Screen Mode" item from Settings menu to View menu

ngraham added a comment. Oh perfect, then this can land as-is. Thanks! REPOSITORY R263 KXmlGui BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D24091 To: ngraham, #vdg, #frameworks, cfeck, ndavis Cc: dfaure, kde-frameworks-devel,

D24003: kwaylandScanner produce version enum per class

gladhorn marked an inline comment as done. gladhorn added inline comments. INLINE COMMENTS > zzag wrote in generator.cpp:431 > Is it correct thogugh? Can you provide some test input so it's easier to see > the problem? run kwaylandScanner on

D24004: Teach kwaylandscanner about PrimarySelection

gladhorn added subscribers: zzag, romangg, davidedmundson. gladhorn added a comment. @romangg and @davidedmundson any comments? I think @zzag prefers the class names without the V1. I'd like to progress on this step by step and the generator at least gives a good starting point.

D23667: Add == and != operators to KIO::UDSEntry

dfaure accepted this revision. dfaure added a comment. Looks ok, but I'm just curious about the use case. "I felt it was missing" doesn't sound as strong an argument as "I need this"... Slaves are supposed to mostly create those, not compare them, and apps are supposed to use KFileItem

D24091: Move "Full Screen Mode" item from Settings menu to View menu

dfaure added a comment. You can never end up with double separators, QMenu takes care of that. REPOSITORY R263 KXmlGui BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D24091 To: ngraham, #vdg, #frameworks, cfeck, ndavis Cc:

D21897: Address some issues reported by Krazy analysis

broulik added inline comments. INLINE COMMENTS > ktextedit.cpp:373 > + > +delete dialog; > } You can do `dialog->setAttribute(Qt::WA_DeleteOnClose);` when creating the dialog instead of an explicit delete call REPOSITORY R310 KTextWidgets BRANCH krazy-50b2564 (branched from master)

D21897: Address some issues reported by Krazy analysis

pajamapants3000 added a comment. Thank you for the feedback and approval! I don't have the access needed to land a change, what should I do next? I would certainly appreciate someone else landing it for me. Let me know, thanks! REPOSITORY R310 KTextWidgets BRANCH krazy-50b2564

D24072: properly install whole plasmacomponent3

This revision was automatically updated to reflect the committed changes. Closed by commit R242:455b41bc625e: properly install whole plasmacomponent3 (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24072?vs=66441=66537

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ahiemstra added inline comments. INLINE COMMENTS > leinir wrote in Button.qml:112 > Humhum, yes... so it needs to be possible to change enabled from outside, but > it also needs to be locked to disabled if allowedByKiosk is false... i'm > thinking this probably won't be the prettiest thing,

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir requested review of this revision. leinir added a comment. Ping for some of the frameworks peeps... would be great to get this in sooner rather than later :) INLINE COMMENTS > ahiemstra wrote in author.cpp:37 > Suggestion: It might make sense to do this caching at the provider level

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 66529. leinir added a comment. - Fix some whitespace issues REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=66368=66529 BRANCH knsquick-feature-parity-with-kns (branched from master) REVISION DETAIL