KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 53 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/53/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 01 Oct 2019 03:13:20 + Build duration: 2 min 24 sec and counting BUILD ARTIFACTS

D23682: Make use of KPluginMetaData where we can

apol added inline comments. INLINE COMMENTS > broulik wrote in dataengine.cpp:70 > Where is this constructor used? Unsure, but we can't remove symbols anyway... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma Cc: broulik,

D24326: Add syntax highlighting for RenPy (.rpy)

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 381547 REPOSITORY R216 Syntax Highlighting BRANCH renpy (branched from

D24245: Add support for passing Unix file descriptors

aacid added a comment. In D24245#539508 , @volkov wrote: > Without UnixFileDescriptor you could try to write > > int fd = ... > Action action(...); > action.addArgument(QStringLiteral("fd"), fd); > > > but then KAuth won't be

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added a comment. In D22727#513842 , @dfaure wrote: > The truth is stronger than "I would not recommend". > put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

dfaure added a comment. I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/ $ grep -r LIBSHARED_DEPRECATED\ . | grep -w define ./UNIX_DeprecatedOnly/libshared_export.h:# define LIBSHARED_DEPRECATED __attribute__ ((__deprecated__))

D24318: Make 32px document-save icon colorful

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. - I think this doesn't look enough like the monochrome versions and it looks too much like the KFloppy icon. - Make the label area more similar to the monochrome icons. -

D24312: Small performance enhacements

This revision was automatically updated to reflect the committed changes. Closed by commit R237:33bcefa50dcf: Small performance enhacements (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24312?vs=67066=67084#toc REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D24318: Make 32px document-save icon colorful

ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24318: Make 32px document-save icon colorful

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY We're trying to move away from using the monochrome style for >22px action icons. This

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. In D23789#539940 , @dfaure wrote: > I see the theoretical problem, but how could this ever be a problem in practice? > On Unix all compilers support the same syntax (`__attribute__ ((__deprecated__))`), so you'd

D24314: Improve KFloppy icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:26dbd301f16b: Improve KFloppy icon (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24314?vs=67075=67082 REVISION DETAIL

D24314: Improve KFloppy icon

wbauer accepted this revision. wbauer added a comment. Thanks! REPOSITORY R266 Breeze Icons BRANCH better-kfloppy-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24314 To: ngraham, #vdg, ndavis, wbauer Cc: wbauer, ndavis, kde-frameworks-devel, LeGast00n,

D24315: REPORT also supports the Depth header

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This is exactly why we release KF5 every month these days, so people fix issues here instead of working around them in app code like in 2010 :-) REPOSITORY R241 KIO BRANCH next

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah I see, `the hacks in KDAV::DavManager` is the context :) REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc:

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. Test Plan: ? Did you see this in a specific application? Just to have some context about why/when this occurs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

dfaure added a comment. > Which might be an issue for people who would like to use different compiler on the same system, both building against the same generated export header file. I see the theoretical problem, but how could this ever be a problem in practice? On Unix all compilers

D24314: Improve KFloppy icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH better-kfloppy-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24314 To: ngraham, #vdg, ndavis Cc: ndavis,

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY So far WebDAV only really works when using webdav[s]: URLs, which is an unexpected

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/111/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 30 Sep 2019 16:56:13 + Build duration: 6 min 58 sec and counting JUnit Tests Name:

D24315: REPORT also supports the Depth header

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY See RFC 3253 Section 3.6. Setting the depth for REPORT currently requires dirty

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/110/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 30 Sep 2019 16:47:40 + Build duration: 8 min 20 sec and counting JUnit Tests Name:

D24293: Make QSslError::SslError <-> KSslError::Error conversion reusable

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fab04a62f2ca: Make QSslError::SslError - KSslError::Error conversion reusable (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23920: Deprecate the KSslError::Error ctor of KSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d75d5ac36582: Deprecate the KSslError::Error ctor of KSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23920?vs=65954=67076 REVISION

D24314: Improve KFloppy icon

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The KFloppy icon has really weird proportions, making the floppy appear fat. This

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Quick Update (week 40): Locally have added experimental code to even set the proper attribute for GCC compiler, so we get e.g.: /home/koder/Kode/kdegit/kf5/frameworks/kparts/tests/notepad.cpp: In constructor ‘NotepadPart::NotepadPart(QWidget*, QObject*,

D24312: Small performance enhacements

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D24312 To: aacid, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24263: edit mode action

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in corona.cpp:406 > This isn't just editing editing widgets; maybe "Enter Edit Mode" ? That would > make the name better correspond with the text of the opposite state too. > > Alternatives: > > - Edit Layout and Widgets/Freeze

D24262: Modernize code: use range-based loops & algorithms in more places

This revision was automatically updated to reflect the committed changes. Closed by commit R306:65c55de00bae: Modernize code: use range-based loops algorithms in more places (authored by kossebau). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE

D24311: Remove useless variable

aacid closed this revision. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D24311 To: aacid, cullmann Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24312: Small performance enhacements

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY suggested by clang-tidy REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D24312

D24311: Remove useless variable

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yeah, looks useless. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D24311 To: aacid, cullmann Cc: cullmann, kde-frameworks-devel, LeGast00n,

D24311: Remove useless variable

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D24311 AFFECTED FILES src/kemailaddress.cpp To:

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in browseropenorsavequestion.cpp:270 > I give C++11/14/17 trainings, if it helps :-) :) Though, I doubt you give them in single person understanding-pace-driven tiredness-cut bed settings (besides own family how to tell a nerd

D24308: [DataProtocol] compile without implicit coversion from ascii

ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH ahmad/compile-without-ascii-cast (branched from master) REVISION DETAIL

D24306: Highlight GeoJSON files as if they were plain JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R216:25b08fe3f4c6: Highlight GeoJSON files as if they were plain JSON (authored by gszymaszek). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D24306: Highlight GeoJSON files as if they were plain JSON

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Good idea. REPOSITORY R216 Syntax Highlighting BRANCH basic-geojson-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D24306 To: gszymaszek, cullmann

D24306: Highlight GeoJSON files as if they were plain JSON

gszymaszek created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gszymaszek requested review of this revision. REVISION SUMMARY Currently, GeoJSON files syntax isn’t highlighted in any way. GeoJSON is a subset of JSON

D22258: Improve plugin caching

wbauer added a comment. In D22258#539682 , @davidedmundson wrote: > I don't know the situation well enough to know whether it's valid that it's invalid or not. Let's follow that up in your bug report. The problem apparently is that the

D24263: edit mode action

mart updated this revision to Diff 67051. mart added a comment. - always keep the edit action consistent REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24263?vs=66953=67051 BRANCH phab/editModeActionwq! REVISION DETAIL

D22258: Improve plugin caching

davidedmundson added a comment. I don't know the situation well enough to know whether it's valid that it's invalid or not. Let's follow that up in your bug report. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22258 To: apol, #plasma,

D22258: Improve plugin caching

wbauer added inline comments. INLINE COMMENTS > davidedmundson wrote in pluginloader.cpp:860 > Changed. > Though that won't stop the warning from appearing. True. Maybe it would be better to downgrade it to qCDebug()? (until the existing invalid metadata is fixed at least) REPOSITORY R242

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 187 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/187/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 30 Sep 2019 08:30:11 + Build duration: 12 min and counting BUILD ARTIFACTS

D22258: Improve plugin caching

davidedmundson added inline comments. INLINE COMMENTS > wbauer wrote in pluginloader.cpp:860 > Shouldn't this use categorized logging as well? > > It causes *lots* of warnings from plasmashell, see > https://bugs.kde.org/show_bug.cgi?id=412464 Changed. Though that won't stop the warning from

D22258: Improve plugin caching

wbauer added inline comments. INLINE COMMENTS > pluginloader.cpp:860 > +if (!metadata.isValid()) { > +qWarning() << "invalid metadata" << pluginPath; > +return; Shouldn't this use categorized logging as well? It causes *lots* of warnings from

D24262: Modernize code: use range-based loops & algorithms in more places

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kossebau wrote in browseropenorsavequestion.cpp:270 > Sigh... I learned C++ originally from the Stroustrup book, mostly reading in > bed in leisure time. C++11 I