D24355: TypeScript: update grammar and fixes

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY TypeScript: - Add

D24354: Mustache/Handlebars: fix delimiters in HTML tags

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Using `WordDetect` rules

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.13 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.13/6/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 01 Oct 2019 18:59:08 + Build duration: 39 min and counting JUnit Tests Name:

D24350: [src/kpac/*] replace deprecated foreach with range for

ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Add convience function that returns const QList&, since that list is iterated over in several places in the code. TEST

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/6/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 01 Oct 2019 18:59:08 + Build duration: 3 min 34 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 01 Oct 2019 18:59:08 + Build duration: 3 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 01 Oct 2019 18:59:08 + Build duration: 1 min 5 sec and counting JUnit Tests Name:

D24348: Use range for loop instead of ugly sizeof arithmetic

aacid closed this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D24348 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24348: Use range for loop instead of ugly sizeof arithmetic

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D24348 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24349: More (and last) fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, kossebau. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH ahmad/ascii-cast2 (branched from master) REVISION DETAIL

D22365: KNotification macOS native support by NSNotificationCenter

Inoki added a comment. Updating with new incoming code. Will try landing it this week REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb, nicolasfella Cc: lnj, nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

hallas added a comment. In D21235#536576 , @hallas wrote: > In D21235#535951 , @bruns wrote: > > > In D21235#535861 , @hallas wrote: > > > > > I have

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 01 Oct 2019 17:38:27 + Build duration: 4 min 34 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 01 Oct 2019 17:38:27 + Build duration: 4 min 43 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/5/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 01 Oct 2019 17:38:27 + Build duration: 4 min 39 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 01 Oct 2019 17:38:27 + Build duration: 1 min 27 sec and counting CONSOLE OUTPUT

D24347: Use range for loop instead of sizeof(x) / sizeof(x[0])

aacid closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24347 To: aacid, vkrause Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales,

D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0])

aacid closed this revision. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D24346 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0])

aacid closed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D24344 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24348: Use range for loop instead of ugly sizeof arithmetic

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R310 KTextWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D24348 AFFECTED FILES

D24347: Use range for loop instead of sizeof(x) / sizeof(x[0])

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D24347 To: aacid, vkrause Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde,

D24347: Use range for loop instead of sizeof(x) / sizeof(x[0])

aacid created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D24347 AFFECTED FILES

D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0])

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D24346 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0])

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24344 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:e0ef6b7ed41a: Make 22px squiggle more like 16px squiggle (authored by ndavis). REPOSITORY R266 Breeze Icons

D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0])

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D24346 AFFECTED FILES src/lib/aztecbarcode.cpp

D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0])

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24344 AFFECTED FILES src/kdatepicker.cpp

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/113/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 01 Oct 2019 16:55:37 + Build duration: 8 min 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/112/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 01 Oct 2019 16:44:26 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9713ea02e49e: Consider the usage of WebDAV methods sufficient for assuming WebDAV (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24315: REPORT also supports the Depth header

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ac0462180c0d: REPORT also supports the Depth header (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24315?vs=67078=67141 REVISION DETAIL

D24308: [DataProtocol] compile without implicit coversion from ascii

ahmadsamir updated this revision to Diff 67125. ahmadsamir added a comment. Make it faster by comparing char's directly REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24308?vs=67062=67125 BRANCH ahmad/compile-without-ascii-cast (branched from master)

D24263: edit mode action

ngraham added a comment. "Customize Layout" is fine IMO. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

davidedmundson added a comment. How does kio-fuse know when to unmount? INLINE COMMENTS > krun.cpp:529 > +// Lets try a KIOFuse mount instead. > +QDBusInterface > kiofused(QStringLiteral("org.kde.kded5"), > +

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH 2019_09_okbutton_configurable REVISION DETAIL https://phabricator.kde.org/D24252 To: dfaure, cfeck, vkrause, apol Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D24159: new module ECMSourceVersionControl

This revision was automatically updated to reflect the committed changes. Closed by commit R240:f3f4893b5bd2: new module ECMSourceVersionControl (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24159?vs=4=67114 REVISION

D23512: Avoid overloading KCModule::changed

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D23512 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added a comment. we need this because the symbols being currently used are Unix-only. Porting to Qt supplied ones allows this plugin to work on other OSes (my concern: Windows) as well.  REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22727 To:

D24159: new module ECMSourceVersionControl

apol added a comment. +1 REPOSITORY R240 Extra CMake Modules BRANCH vcs REVISION DETAIL https://phabricator.kde.org/D24159 To: sitter, kde-buildsystem, dfaure Cc: apol, kossebau, kde-frameworks-devel, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24308: [DataProtocol] compile without implicit coversion from ascii

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > dataprotocol.cpp:120 > { > -int size = buf.length(); > -while (pos < size && buf[pos].isSpace()) { > +const QString = QString::fromLatin1(buf);

D24263: edit mode action

mart updated this revision to Diff 67113. mart added a comment. - Customize Layout REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24263?vs=67051=67113 BRANCH phab/editModeActionwq! REVISION DETAIL https://phabricator.kde.org/D24263

D24263: edit mode action

mart added a comment. i think in the end Customize Layout/Finish Customizing Layout i prefer not to name the term "mode" at all if i can, both because is kinda a nerdy term and because modes are an ux cardinal sin, so at least not being too proud of it ;) REPOSITORY R242 Plasma

D24263: edit mode action

mart added a comment. the last, "the least the name "edit mode" is user facing, the better it is REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

dfaure added a comment. I'm not sure what the QFileDevice enum gives us compared to the octal permissions as int? Is this just because it looks nicer, to save a conversion, or because you actually need the differenciation between ReadUser and ReadOwner, on Windows? REPOSITORY R320 KIO

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

This revision was automatically updated to reflect the committed changes. Closed by commit R320:52175ce07389: Add two special cases url recentlyused:/files and recentlyused:/folders (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D24245: Add support for passing Unix file descriptors

volkov added a comment. It will require adding the following methods: Action::setFileDescriptors() Action::addFileDescriptor() Action::fileDescriptors() ActionReply::setFileDescriptors() ActionReply::addFileDescriptor() ActionReply::fileDescriptors() and

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven added a comment. The /folders path is /locations in fact REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe,

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 67102. meven added a comment. Correct ?type use with /files : ?type overrules /files, since they are aggregated with ORs REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65959=67102 BRANCH arcpatch-D23742