D24568: Provide clang-format target with a common KDE style file

cullmann added a comment. In D24568#545736 , @apol wrote: > I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code.

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir added a task: T11577: Port Konversation away from KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24588 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This is needed as part of porting Koversation to use QSslSocket instead of KTcpSocket. TEST PLAN The code

D24584: Add a few const

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24584 To: aacid, meven Cc: meven, kde-frameworks-devel, #baloo, hurikhan77,

D24400: Make hours qint64

aacid abandoned this revision. aacid added a comment. Meh, just realized this patch is useless since we end up passing the quint variable to formatSingleDuration that passes it to QObject::tr and that one only supports int, so at some point there's a potential loss of range anyway

D24400: Make hours qint64

aacid added inline comments. INLINE COMMENTS > aacid wrote in kformatprivate.cpp:339 > because its unnecessary, qint64 / number don't need a quint64 to store it. sorry i just realized ms is quint64, so yes sshould b quint64 REPOSITORY R244 KCoreAddons REVISION DETAIL

D24584: Add a few const

aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY These things aren't super expensive to copy, but const & is less expensive REPOSITORY R293 Baloo BRANCH

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67772. meven added a comment. Clean up a QVariant() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67771=67772 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582 AFFECTED FILES

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67771. meven added a comment. Fixes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67768=67771 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582 AFFECTED FILES src/ioslaves/file/file.cpp

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67768. meven added a comment. Replace more config() calls, fixes, code cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67767=67768 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67767. meven added a comment. Replace more config() calls, fixes, code cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67765=67767 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24582 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven added a dependent revision: D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig(). REPOSITORY R241 KIO BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel,

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Depends on D23523 Now that

D24568: Provide clang-format target with a common KDE style file

dhaumann added a comment. I'm all for it. This would unify how we can reformat any KDE module, which is very much desirable. Being able to just reformat a patch sounds interesting, too, but can be added later still. Don't let the perfect be the enemy of the good... The example

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 67763. meven added a comment. Fix slavebase.cpp following QVariant changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=67762=67763 BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 67762. meven added a comment. Update since, use QVariant as mapConfig value REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=65991=67762 BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe marked an inline comment as done. guoyunhe added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:1101 > should this be in ifdef Q_OS_WIN? > > On windows, *.exe is executed, not opened (with e.g. wine) Yes, I updated this part. REPOSITORY R241 KIO REVISION DETAIL

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe updated this revision to Diff 67761. guoyunhe added a comment. *.exe should be normal executable in Windows REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24463?vs=67458=67761 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463

D24578: Meson: Add a comment section for comment/uncomment with Kate

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please increase the version number and commit. REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL https://phabricator.kde.org/D24578 To:

D23802: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24466: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24467: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24467 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24468: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24468 To: kossebau, #frameworks, cfeck, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2,

<    1   2