KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 142 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/142/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 18 Oct 2019 05:10:52 + Build duration: 18 min and counting JUnit Tests Name: projectroot

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 68210. kossebau added a comment. update to latest master and new deprecated API REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24684?vs=68021=68210 BRANCH useECMGenerateExportHeader REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 155 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/155/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 18 Oct 2019 05:10:52 + Build duration: 12 min and counting BUILD ARTIFACTS

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto updated this revision to Diff 68206. tienisto added a comment. use root folder icon REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24746?vs=68205=68206 BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto updated this revision to Diff 68205. tienisto added a comment. cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24746?vs=68199=68205 BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL

D24610: Use ECMGenerateExportHeader to manage deprecated API better

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R276:95d6613e23b4: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R276

D24497: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R265:bf157dfa4d76: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24497?vs=68010=68203#toc REPOSITORY R265

Developing an GLFW app that links makes use of KWindowEffects?

Hi guys, I hope I landed into the right channel (it's many many years ago I did stuff with KDE), so I've to apologize in advance, eventually. :-) I am developing an OpenGL / GLFW application (for highest platform independence and easiest porting efforts). It's basically a terminal emulator, and

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto added inline comments. INLINE COMMENTS > ahmadsamir wrote in kpropertiesdialog.cpp:1172 > Probably not so obvious for new Linux users; especially those coming from > windows where things are represented as C:\, D:\ ... etc. I think new linux users don't even know what mounting means

D24746: [kpropertiesdialog] adjust ui for root directory

ahmadsamir added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1172 > > -l = new QLabel(i18n("Mounted on:"), d->m_frame); > -grid->addWidget(l, curRow, 0, Qt::AlignRight); > +// only show for non-root folders because '/' is obviously

D24746: [kpropertiesdialog] adjust ui for root directory

GB_2 added a comment. Can we also set the root folder icon? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto edited the summary of this revision. tienisto added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto created this revision. tienisto added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tienisto requested review of this revision. REVISION SUMMARY special ui changes if root directory is selected REPOSITORY R241 KIO BRANCH

D24598: Update elisa icon

trickyricky26 accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH elisa_updated (branched from master) REVISION DETAIL https://phabricator.kde.org/D24598 To: astippich, #vdg, ngraham, mgallien, trickyricky26 Cc: trickyricky26,

D24598: Update elisa icon

ngraham accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24598 To: astippich, #vdg, ngraham, mgallien, trickyricky26 Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, carneirogustavo, jguidon,

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

This revision was automatically updated to reflect the committed changes. Closed by commit R159:2cb2d4a20f26: Add a utility accessor to get a QUrl from a ResultSet::Result (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

meven updated this revision to Diff 68194. meven added a comment. Add a KF6 TODO REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24741?vs=68172=68194 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24741 AFFECTED FILES

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

meven marked 3 inline comments as done. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D24741 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24598: Update elisa icon

astippich updated this revision to Diff 68192. astippich added a comment. - update and save as optimized svg REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24598?vs=67836=68192 BRANCH elisa_updated (branched from master) REVISION DETAIL

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Just add TODO and you are free to push INLINE COMMENTS > meven wrote in resultset.h:78 > `url` makes more sense to me, no need to decorate it, this is idiomatic > KDE/Qt. `toUrl` might make

D24568: Provide clang-format target with a KDE Frameworks style file

zzag added inline comments. INLINE COMMENTS > dfaure wrote in clang-format.cmake:75 > typo: ternary I've been always wondering how one should break long ternary operators when writing KF code. There are several ways to do it (a) w/o breaking (BreakBeforeTernaryOperators: false) const

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

meven added inline comments. INLINE COMMENTS > ivan wrote in resultset.h:78 > `url` or `resourceUrl`? > > I hoped we are not going to have these problems after the death of Nepomuk. > Thought file paths for files and urls for everything else would be a sane > default. :) > > Also, can you

D24617: Use ECMGenerateExportHeader to manage deprecated API better

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R293:7c58c615206e: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R293

D24620: Windows MSVC compile fix

cullmann added a comment. Ok to push that? Would avoid the last patch in craft to build frameworks. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D24620 To: cullmann, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a comment. Without the initializer change, the file works for me reasonable well, tried it again on KTextEditor. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks, dfaure Cc: sitter, mwolff, ochurlaud,

D24707: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R269:02721f6c30fa: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24707?vs=68073=68188#toc REPOSITORY R269

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann updated this revision to Diff 68186. cullmann marked an inline comment as done. cullmann added a comment. - avoid collapsing of constructor initializer lines REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24568?vs=68091=68186 BRANCH

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann marked an inline comment as done. cullmann added a comment. With BreakConstructorInitializers: BeforeColon you get collapsed stuff like; Range::Range(const KTextEditor::Cursor , const KTextEditor::Cursor c2, MotionType mt) : Range(c1.line(), c1.column(), c2.line(),

D24742: Make non-ignorable SSL errors explicit

apol added a comment. LGTM otherwise INLINE COMMENTS > ksslcertificatemanager.cpp:537 > +}); > return {}; > } `return ret; ` ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 154 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/154/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 17 Oct 2019 16:41:19 + Build duration: 25 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 141 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/141/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 17 Oct 2019 16:41:19 + Build duration: 13 min and counting JUnit Tests Name: projectroot

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

meven updated this revision to Diff 68172. meven added a comment. Add @since REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24741?vs=68163=68172 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24741 AFFECTED FILES

D24611: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7e971bfd6d2a: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b5f5fb475da7: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24600: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R275:c03781b0a6b7: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D24742: Make non-ignorable SSL errors explicit

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY So far this is done implicitly in KSSLD by not being able to persist these error codes in its config file. This

D24608: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R302:f046410b316f: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24608?vs=67843=68167#toc REPOSITORY R302

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/41/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 17 Oct 2019 16:19:54 + Build duration: 4 min 14 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/46/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 17 Oct 2019 16:13:09 + Build duration: 3 min 43 sec and counting JUnit Tests Name:

D24667: [KStatusNotifierItem] Allow left click when menu is null

This revision was automatically updated to reflect the committed changes. Closed by commit R289:aa6bb9b06cfb: [KStatusNotifierItem] Allow left click when menu is null (authored by kmaterka). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

meven added a comment. Relates to D16087 as well REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D24741 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

meven updated this revision to Diff 68163. meven added a comment. Improve comment REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24741?vs=68162=68163 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24741 AFFECTED FILES

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

meven updated this revision to Diff 68162. meven added a comment. Fix indentation REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24741?vs=68161=68162 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24741 AFFECTED FILES

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Improve API UI to prevent user handling QString to QUrl. Would prevent error such as D22005

D24667: [KStatusNotifierItem] Allow left click when menu is null

kmaterka marked 2 inline comments as done. kmaterka added a comment. In D24667#548245 , @broulik wrote: > > bool takeOwnership = true); > > If only Qt/we used modern C++ features to communicate object ownership :) Hehe, yes.

D24466: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R263:808bd05b37e4: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24466?vs=67733=68160#toc REPOSITORY R263

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in kactioncollection.h:308 > Fixed to `KXMLGUI_ENABLE_DEPRECATED_SINCE`, as `slotActionHighlighted` is a > virtual method, which the compiler needs to always know about. Eh, fixed to KXMLGUI_BUILD_DEPRECATED_SINCE actually :)

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > kactioncollection.h:308 > > +#if KXMLGUI_ENABLE_DEPRECATED_SINCE(5, 0) > /** Fixed to `KXMLGUI_ENABLE_DEPRECATED_SINCE`, as `slotActionHighlighted` is a virtual method, which the compiler needs to always know about. REPOSITORY R263

D24689: Add support for SAE authentication used by WPA3

This revision was automatically updated to reflect the committed changes. Closed by commit R282:4a6a5e708077: Add support for SAE authentication used by WPA3 (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24689?vs=68156=68157

D24689: Add support for SAE authentication used by WPA3

jgrulich marked an inline comment as done. REPOSITORY R282 NetworkManagerQt BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24689 To: jgrulich, #frameworks, meven Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

jgrulich updated this revision to Diff 68156. jgrulich added a comment. - Coding style REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24689?vs=68029=68156 BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24689 AFFECTED FILES

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 17 Oct 2019 14:38:39 + Build duration: 2 min 39 sec and counting JUnit Tests Name:

D21146: KProcessInfoList -- add proclist backend for FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit R244:b1d27cabc2a9: KProcessInfoList -- add proclist backend for FreeBSD (authored by tcberner). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21146?vs=68138=68151

D24495: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R284:adb16c18d98c: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE

D21146: KProcessInfoList -- add proclist backend for FreeBSD

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. Let's get this in, and then quibble about how much commentary needs to be written for the `_p.h` file (since, looking back, it's a bit heavy on the C++ fancyness -- my Opinions have

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure accepted this revision. dfaure added a comment. Yep all good from my point of view. REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24710: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R301:2f0fffb70604: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE

D24736: Grab the keyboard when KeySequenceItem is recording

davidre updated this revision to Diff 68144. davidre added a comment. Whitespace REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24736?vs=68143=68144 BRANCH grabkeyboard (branched from master) REVISION DETAIL https://phabricator.kde.org/D24736

D24736: Grab the keyboard when KeySequenceItem is recording

davidre updated this revision to Diff 68143. davidre added a comment. - Make helper a qquickitem instead REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24736?vs=68142=68143 BRANCH grabkeyboard (branched from master) REVISION DETAIL

D24736: Grab the keyboard when KeySequenceItem is recording

broulik added a comment. Alternatively you could make the `KeySequenceHelper` itself a `QQuickItem` so it gets assigned a window. INLINE COMMENTS > keysequencehelper.cpp:118 > QString shortcutDisplay; > - > +QQuickItem* keySequenceItem; > //! Check the key sequence against

D24736: Grab the keyboard when KeySequenceItem is recording

davidre added a reviewer: Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise assigning a key combination which is currently bound to a global shortcut action will trigger the global

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner added a comment. @adridg I've addressed your comments [finally]. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21146 To: tcberner, #freebsd, adridg, davidedmundson Cc: pino, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner updated this revision to Diff 68138. tcberner added a comment. - procstat: add FindProcstat.cmake - procstat: add procstat backend - procstat: add procstat option - procstat: add linkage for procstat backend REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. @dfaure Any remaining issues from your side, or is your +1 available as well now? :) REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel,

D24537: Icons for windy weather

kossebau added a subscriber: spstarr. kossebau added a comment. Good work with the icons. Seems there is also need for snow + wind, @vkrause & @spstarr can and hopefully tell you more. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack,

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.12 - Build # 64 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/64/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 17 Oct 2019 12:04:38 + Build duration: 6 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/29/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 17 Oct 2019 12:04:38 + Build duration: 5 min 8 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/28/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 17 Oct 2019 12:00:13 + Build duration: 3 min 14 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.12 - Build # 63 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/63/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 17 Oct 2019 12:00:14 + Build duration: 2 min 36 sec and counting CONSOLE OUTPUT [...truncated

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

broulik accepted this revision. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D24716 To: davidedmundson, #plasma, ervin, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

This revision was automatically updated to reflect the committed changes. Closed by commit R295:aea58fcca359: Fix memory leak of KQuickAddons::ConfigModule objects (authored by davidedmundson). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 48 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/48/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 17 Oct 2019 11:08:26 + Build duration: 4 min 6 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/44/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 17 Oct 2019 11:08:22 + Build duration: 3 min 41 sec and counting JUnit Tests Name:

D24725: Fix grammar

This revision was automatically updated to reflect the committed changes. Closed by commit R244:b539685e9495: Fix grammar (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24725?vs=68118=68123 REVISION DETAIL

D24726: Fix null pointer reference when extraction fails

pvuorela created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pvuorela requested review of this revision. REPOSITORY R243 KArchive BRANCH null_check REVISION DETAIL https://phabricator.kde.org/D24726 AFFECTED FILES src/karchive.cpp

D24725: Fix grammar

apol retitled this revision from "GIT_SILENT Fix grammar" to "Fix grammar". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24725 To: ahmadsamir, #frameworks, mpyne Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24725: Fix grammar

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH text-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D24725 To: ahmadsamir, #frameworks, mpyne, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24689: Add support for SAE authentication used by WPA3

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me, but I might not be the best person to approve this. INLINE COMMENTS > utils.cpp:355 > +} > + if

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Looks good to me, I'll accept it but better wait a bit in case others want to chip in. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D24716 To:

D24725: GIT_SILENT Fix grammar

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH text-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D24725

D24568: Provide clang-format target with a KDE Frameworks style file

sitter added inline comments. INLINE COMMENTS > KDEClangFormat.cmake:53 > +# try to find clang-format in path > +find_program(KDE_CLANG_FORMAT_EXECUTABLE clang-format) > + I'm pretty sure you need to check the version the exectuable. When I use 6.0 I get ctors smushed into one line.

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

davidedmundson marked 2 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D24716 To: davidedmundson, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

davidedmundson updated this revision to Diff 68113. davidedmundson edited the summary of this revision. davidedmundson removed a reviewer: ervin. davidedmundson removed a subscriber: ervin. davidedmundson added a comment. Use unique_ptr REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D24487: fix password error condition handling of smb mount

This revision was automatically updated to reflect the committed changes. Closed by commit R320:45b1327a6dac: fix password error condition handling of smb mount (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24487?vs=67483=68112

D24722: Add an ability to set local name for BLE Advertisement

arturdrobinskiy created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arturdrobinskiy requested review of this revision. TEST PLAN 1. Start ./bin/leserver 2. Scan for existing BLE devices (e.g. using nRF Connect for Android/iOS) 3. Check

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmoduleloader.cpp:101 > } else { > KQuickAddons::ConfigModule *cm = > factory->create(nullptr, args2); > if

D24650: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me REPOSITORY R235 Attica BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24650 To: kossebau, #frameworks, gladhorn, leinir,

D24600: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24600 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24611: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24611 To: kossebau, #frameworks, bruns, mlaurent Cc: kde-frameworks-devel, #baloo, hurikhan77,

D24495: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24495 To: kossebau, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,