D24993: Add integrated inline spelling menu to KTextEdit

pajamapants3000 edited the test plan for this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D24993 To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 27 Oct 2019 22:24:07 + Build duration: 2 min 32 sec and counting JUnit Tests Name: proje

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

kossebau added a comment. Alternatively kded could be build with additionally `-DKSERVICE_DISABLE_DEPRECATED_BEFORE_AND_AT=0x05`. So it will would be still hidden to anyone else who uses -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x050x00 REPOSITORY R309 KService REVISION DETAIL https:/

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24974 To: dfaure, kossebau, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D24974 To: dfaure, kossebau, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

dfaure added a comment. Any reason why you didn't implement my suggestion of DeleteJobIOWorker *ioworker() { if (!m_ioworker) { ... } return m_ioworker; } [...] QMetaObject::invokeMethod(ioworker(), "rmfile", [...]); ? A cal

D24993: Add integrated inline spelling menu to KTextEdit

ngraham added a comment. Very nice! Could you attach a screenshot or a screen recording in the Test Plan section that shows what this is and how it works? it's nice to do this when you add #vdg as a reviewer since not all VDG people can test out patches

D24993: Add integrated inline spelling menu to KTextEdit

ngraham added reviewers: Frameworks, cullmann, cfeck. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D24993 To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24993: Add integrated inline spelling menu to KTextEdit

pajamapants3000 created this revision. pajamapants3000 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pajamapants3000 requested review of this revision. REVISION SUMMARY Adds a new option to the KTextEdit control in KTextWidgets to sho

D24932: [WIP]: Add Button to open the folder in filelight for more details

ngraham added a comment. Copy some other code that's already doing it this way I guess. For example, in plasma: https://cgit.kde.org/plasma-workspace.git/tree/libtaskmanager/tasktools.cpp#n767 If you don't already know about it, let me introduce you to the magic of LXR: https://lxr.kde.

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 68854. meven marked 7 inline comments as done. meven added a comment. Create worker thread only once needed, fix a removeLast missing, formatting REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68826&id=68854 BRANCH

D24975: Change some 32px action icons to color style

ngraham added a comment. In D24975#554805 , @ndavis wrote: > I don't have time to do all 32px icons at once, but thankfully, they're usually only used in the desktop shell (I can put 32px monochrome icons in the desktop theme), or in preferences

D24318: Make 32px document-save icon colorful

ngraham abandoned this revision. ngraham added a comment. Abandoned in favor of D24975 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg, ndavis Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n

D24975: Change some 32px action icons to color style

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. These look great to me. REPOSITORY R266 Breeze Icons BRANCH color32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg, ngraham Cc: ngraham

D24966: KXmlGui: port away from KF5 deprecated API

kossebau added a comment. Actually I have a WIP undeprecation patch somewhere, which reduced the deprecation to notes with setApplicationData/appliactionData, Guess I should pick this from the attic, clean up and share, REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.or

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau created this revision. kossebau added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH enableal

D24966: KXmlGui: port away from KF5 deprecated API

dfaure added a subscriber: jriddell. dfaure added a comment. Yep, actually I found code in kcmutils (KPluginSelector::Private::PluginDelegate::slotAboutClicked) which sets the program icon name from a plugin (so NOT qApp->windowIcon()) on the aboutData passed to this dialog. So the functio

D24966: KXmlGui: port away from KF5 deprecated API

dfaure added a reviewer: jriddell. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24966 To: dfaure, kossebau, elvisangelaccio, vkrause, jriddell Cc: jriddell, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24989: support multiple rcc files with icons themes

vonreth requested changes to this revision. vonreth added a subscriber: dfaure. vonreth added a comment. This revision now requires changes to proceed. Rest looks good to me. @dfaure you created the initial version what do you think? INLINE COMMENTS > kicontheme.cpp:79 > +for (const aut

D24989: support multiple rcc files with icons themes

cullmann added reviewers: Frameworks, vonreth. cullmann added a comment. To make this usable, we will need to change the way we create the binary resources in breeze-icons and adapt the craft packaging. Then we can use e.g. breeze + breeze dark for app store applications like normally. We

D24989: support multiple rcc files with icons themes

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY Instead of one hard-coded theme, support multiple ones This assumes that the rccs themself contain a /icons/ prefix

Re: KSyntaxHighlighting: My changes to data files don’t seem to affect test outputs

What does `ldd build/bin/syntax/testhighlighter_test` tell you? What, if you first source build/prefix.sh? Likely the wrong lib is used. Greetings Dominik Adrian Chaves schrieb am So., 27. Okt. 2019, 17:49: > I emptied data/syntax/rest.xml (made it a valid syntax file that would > mark all te

D24979: KRunner: port away from deprecated KF5 API

kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. One of the Interesting challenges with all the cross-library deprecation visibility control setup. Let me try to collect requirements: - Plasma::Package is part of AB

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 131 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/131/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 27 Oct 2019 17:45:50 + Build duration: 6 min 21 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 159 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/159/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 27 Oct 2019 17:41:51 + Build duration: 8 min 17 sec and counting JUnit Tests Name: projectro

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Almost there ;) INLINE COMMENTS > deletejob.cpp:73 > +/** > + * Deletes the file @p points to > + * The file must be a LocalFile Missing "url" after @p (which introdu

D24970: Port away from I18N_NOOP2 and KLocalizedString::insertQtDomain

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24970 To: dfaure, aacid, ilic Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/22/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 27 Oct 2019 16:34:15 + Build duration: 56 min and counting JUnit Tests Name: proje

D24975: Change some 32px action icons to color style

ndavis added a comment. I don't have time to do all 32px icons at once, but thankfully, they're usually only used in the desktop shell (I can put 32px monochrome icons in the desktop theme), or in preferences or navigation sidebars. I suppose it also affects people who raise the toolbar icon

D24975: Change some 32px action icons to color style

ndavis added a subscriber: ngraham. ndavis added a comment. In D24975#554721 , @mglb wrote: > Why do you replace action icons instead of adding separate colorful icons for use in preference dialogs? Right now all action icons are "monochrome", m

D24961: Port to the QSslError variant of KSslInfoDialog

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24961 To: vkrause, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KSyntaxHighlighting: My changes to data files don’t seem to affect test outputs

I emptied data/syntax/rest.xml (made it a valid syntax file that would mark all text as normal). Then I run: rm -rf build && mkdir build && cd build cmake .. && make -j8 && make test But the contents of build/autotests/html.output/highlight.rst.html are still those that would be gener

D24970: Port away from I18N_NOOP2 and KLocalizedString::insertQtDomain

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24970 To: dfaure, aacid, ilic Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24983: KateModeMenuList: improve word wrap

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. It's hard to review all the pixel changes with no screenshots. It's even unclear to me what problem exactly is fixed at hand. Given it's all your code, I trust you know what you are doi

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.12 - Build # 58 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.12/58/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 27 Oct 2019 16:34:15 + Build duration: 6 min 48 sec and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 35 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/35/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 27 Oct 2019 16:34:15 + Build duration: 4 min 18 sec and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kpeople » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 27 Oct 2019 16:34:15 + Build duration: 1 min 48 sec and counting JUnit Tests Name: project

KDE CI: Frameworks » kpeople » kf5-qt5 AndroidQt5.13 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20AndroidQt5.13/7/ Project: kf5-qt5 AndroidQt5.13 Date of build: Sun, 27 Oct 2019 16:34:15 + Build duration: 1 min 5 sec and counting

D24982: Small improvements in some XML files

dhaumann added a comment. I wonder if the `?:` optimizations make sense. QRegularExpression has the option `QRegularExpression::DontCaptureOption` to not capture anything. Looking into our code we have: 561 bool RegExpr::doLoad(QXmlStreamReader& reader) 562 { 563 m_regexp.

D24939: Meson: more built-in functions and add built-in member functions

This revision was automatically updated to reflect the committed changes. Closed by commit R216:9181ad6fedae: Meson: more built-in functions and add built-in member functions (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24939?vs=68727&id=68838#toc REPOSITORY R2

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. In D24928#554731 , @vkrause wrote: > In D24928#554720 , @ahmadsamir wrote: > > > So, we ditch digestMethod but keep the rest? ecryptionMethod/authenticationMethod/keyExch

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir updated this revision to Diff 68836. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24928?vs=68834&id=68836 BRANCH ahmad/tcpslavebase (branched from master) REVI

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir updated this revision to Diff 68834. ahmadsamir added a comment. cipher.name() is deemed sufficient when setting the ssl MetaData REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24928?vs=68701&id=68834 BRANCH ahmad/tcpslavebase (branched from maste

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

vkrause added a comment. In D24928#554720 , @ahmadsamir wrote: > So, we ditch digestMethod but keep the rest? ecryptionMethod/authenticationMethod/keyExchangeMethod can be deduced from the name() sometimes, but some others, not so obvious:

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven updated this revision to Diff 68829. meven added a comment. Add KIO::UDSEntry::UDS_RECURSIVE_SIZE to store recursive size of folders REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24773?vs=68402&id=68829 BRANCH arcpatch-D24773 REVISION DETAIL https:

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven added a comment. In D24773#554409 , @dfaure wrote: > You can do whatever you want in the GUI -- I'll happily step out of that part of the discussion --, as long as you don't abuse UDS_SIZE for what it was not meant for, thus creating an am

D24981: Modelines: fix end of comment

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-end-modelines REVISION DETAIL https://phabricator.kde.org/D24981 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks

D24932: [WIP]: Add Button to open the folder in filelight for more details

shubham added a comment. @ngraham How should I create a KService for runApplication? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

mglb added a comment. Why do you replace action icons instead of adding separate colorful icons for use in preference dialogs? Right now all action icons are "monochrome", making few of them colorful will introduce inconsistency. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phab

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. So, we ditch digestMethod but keep the rest? ecryptionMethod/authenticationMethod/keyExchangeMethod can be deduced from the name() sometimes, but some others, not so obvious: Name: "TLS_AES_256_GCM_SHA384" Encryption method: "AESGCM(256)" Auth meth

D24983: KateModeMenuList: improve word wrap

nibags updated this revision to Diff 68828. nibags added a comment. - Fixes REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24983?vs=68827&id=68828 BRANCH improve-word-wrap REVISION DETAIL https://phabricator.kde.org/D24983 AFFECTED FILES src/mod

D24983: KateModeMenuList: improve word wrap

nibags created this revision. nibags added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY - Use `QFontMetrics::horizontalAdvance(text)` i

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 68826. meven marked 4 inline comments as done. meven added a comment. Remove some const bool in function signature, use m_currentURL for consistency REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68825&id=68826 BRAN

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

dfaure added inline comments. INLINE COMMENTS > deletejob.cpp:67 > +Q_SIGNALS: > +void rmfileResult(bool succeeded, const QUrl& url, const bool isLink); > +void rmddirResult(bool succeeded, const QUrl& url); "const bool" doesn't do anything in a signal, I suggest removing the const. > d

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

On dimanche 27 octobre 2019 03:07:01 CET Friedrich W. H. Kossebau wrote: > Am Freitag, 25. Oktober 2019, 00:35:46 CET schrieb David Faure: > > On jeudi 24 octobre 2019 22:24:55 CEST Friedrich W. H. Kossebau wrote: > > > BTW, we want to also set > > > > > > -DQT_DEPRECATED_WARNINGS_SINCE=0x0600

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 68825. meven added a comment. Fix rmdir, we must use removeLast since we remove in reverse order REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68822&id=68825 BRANCH master REVISION DETAIL https://phabricator.k

D24982: Small improvements in some XML files

nibags updated this revision to Diff 68824. nibags added a comment. - Increase version of javascript.xml REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24982?vs=68823&id=68824 BRANCH improve-some-xml REVISION DETAIL https://phabricator.kde

D24982: Small improvements in some XML files

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY **Changes:** - Replace

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 68822. meven added a comment. Fix argument passing to invokeMethod REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68821&id=68822 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24962 AFFECTED FILES

D24975: Change some 32px action icons to color style

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 68821. meven added a comment. amend commit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68819&id=68821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24962 AFFECTED FILES src/core/deletejob.cpp

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven retitled this revision from "WIP [DeleteJob] Use a separate worker thread to run actual IO operation" to "[DeleteJob] Use a separate worker thread to run actual IO operation". meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2

D24981: Modelines: fix end of comment

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Use `fallthroughContext` to

D24959: Add new preferences search icons

ndavis added a comment. In D24959#554523 , @trickyricky26 wrote: > On the technical side, we usually convert everything to paths, and even though I can't imagine Qt SVG Renderer would have a problem with `circle`, it might be better to convert

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

meven added a comment. In D24962#554586 , @dfaure wrote: > I like the approach. Thanks for the suggestion in the last diff. I feared the callback hell, but this was not too difficult in fact. > Just a few minor things. > > (and

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 68819. meven added a comment. Review feedback, cleanup, simplify parts, use removeFist instead of erase, formatting, comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68816&id=68819 BRANCH master REVISION

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

Am Freitag, 25. Oktober 2019, 00:35:46 CET schrieb David Faure: > On jeudi 24 octobre 2019 22:24:55 CEST Friedrich W. H. Kossebau wrote: > > BTW, we want to also set > > > > -DQT_DEPRECATED_WARNINGS_SINCE=0x06 > > > > otherwise the deprecations done with QT_DEPRECATED_VERSION in Qt's API

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 71 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/71/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 27 Oct 2019 03:20:46 + Build duration: 6 min 18 sec and counting BUILD ARTIFACTS acc/KF5Purpose

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

ndavis added a task: T10165: Large category icons should all be colorful. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The TCPSlaveBase side of this can be fully ported to QSslError once D24928 is in

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 68816. meven marked 9 inline comments as done. meven added a comment. Review feedback, cleanup, simplify parts, formatting, comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68785&id=68816 BRANCH master REV

D24975: Change some 32px action icons to color style

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY - document-open-recent, document-save-all, document-save-as, document-save, folder-open-rec

D21235: Add handling of fuseiso filesystem type

hallas marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21235 To: hallas, bruns, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24979: KRunner: port away from deprecated KF5 API

dfaure created this revision. dfaure added reviewers: kossebau, mart, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Plasma::Package has been deprecated since 5.28, but it's used in the publi

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 72 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/72/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 27 Oct 2019 08:44:35 + Build duration: 8 min 48 sec and counting BUILD ARTIFACTS acc/KF5Purpose-

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/21/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 27 Oct 2019 08:47:43 + Build duration: 4 min 52 sec and counting CONSOLE OUTPUT [.

KDE CI: Frameworks » kpeople » kf5-qt5 AndroidQt5.13 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20AndroidQt5.13/6/ Project: kf5-qt5 AndroidQt5.13 Date of build: Sun, 27 Oct 2019 08:47:35 + Build duration: 2 min 29 sec and counting CONSOLE OUTPUT [...truncat

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 34 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/34/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 27 Oct 2019 08:47:43 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT [...truncated 339

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.12 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.12/57/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 27 Oct 2019 08:47:41 + Build duration: 50 sec and counting CONSOLE OUTPUT [...truncated 340 line

KDE CI: Frameworks » kpeople » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 27 Oct 2019 08:47:44 + Build duration: 32 sec and counting CONSOLE OUTPUT [...truncated 29

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I like the approach. Just a few minor things. (and remember to remove the WIP from the commit log and the phab request) The passing of iterators to another thread *looks

D24978: Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut

meven created this revision. meven added reviewers: davidre, fvogt, apol, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Currently KglobalAccel uses NoDisplay to disable its component. But N

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.13/12/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 27 Oct 2019 08:39:50 + Build duration: 6 min 24 sec and counting JUnit Tests

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

vkrause added a comment. In D24928#554514 , @ahmadsamir wrote: > In D24928#553952 , @vkrause wrote: > > > The cipher naming stuff looks very fishy though, that's not due to your changes though but

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.13 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.13/20/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 27 Oct 2019 08:39:50 + Build duration: 2 min 43 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 27 Oct 2019 08:39:50 + Build duration: 1 min 8 sec and counting JUnit Tests Name: p