D23801: Port kpac from QtScript

kossebau added inline comments. INLINE COMMENTS > carewolf wrote in script.cpp:316 > Not really. I prefer to do it that way for invokable as the value will be > copied, but const ref works too. So why would it be preferable to have the value be copied there? In general, one prefers to avoid

D23801: Port kpac from QtScript

carewolf added inline comments. INLINE COMMENTS > kossebau wrote in script.cpp:316 > Hi @carewolf . Curious: Why all the non-const-ref QString argument types here? > > Is there a need to do that with Q_INVOKABLE methods somehow? > Asking because clazy falgs these, compare D25039 >

D25039: Fix Clazy performance issues, const &, noexcept

kossebau added a comment. As excuse for bad drive-by comment, here now hopefully making up a bit by giving some in-detail review, please see in-line comments. No idea about exceptions. I would the noexcept also make a different commit, for more separation of concerns. When looking

D25084: Allow a Multiple instances to become Unique

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This fixes an issue with konsole when launched as Multiple Applications but once you typed --new-tab (that

D23801: Port kpac from QtScript

kossebau added inline comments. INLINE COMMENTS > script.cpp:316 > // @returns true if @p str matches the shell @p pattern > -QScriptValue ShExpMatch(QScriptContext *context, QScriptEngine *engine) > +Q_INVOKABLE QJSValue ShExpMatch(QString str, QString patternStr) > { Hi @carewolf . Curious:

T11627: Improve KIO asynchronicity

broulik added a comment. I'm pretty sure there's a tonne of blocking DBus calls being done all over the place during file copy (checking for slaves on hold, updating kuiserver job tracking info, etc) which can cause apps to hang or slow down if whatever they're trying to call into is busy.

D25039: Fix Clazy performance issues, const &, noexcept

meven marked 2 inline comments as done. meven added a comment. If somebody could accept this before KF 5.64 tagging, it would to modify `SlaveBase::configValue` signature that were added for the same value. I don't think any of this is subject to much concern. I may commit it without

T11627: Improve KIO asynchronicity

meven added a comment. @dfaure I think that ioslave suffer from the same kind of issue DeleteJob has : it freezes because of I/O. I believe it is the origin lag in such cases as https://bugs.kde.org/show_bug.cgi?id=342056 especially on slow I/O operation like move/copy. I don't get

D25039: Fix Clazy performance issues, const &, noexcept

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in slavebase.h:351 > Would be a proper change, but sadly also changes the signature of a API under > ABI promise, so here and in all other public API places not possibe. > Can be only done when breaking the ABI with KF6. > >

D25039: Fix Clazy performance issues, const &, noexcept

kossebau added a comment. (Quick drive-by comment only as I had this in a search result...) INLINE COMMENTS > slavebase.h:351 > */ > -bool configValue(QString key, bool defaultValue) const; > +bool configValue(const QString , bool defaultValue) const; > Would be a proper

D24938: Fix memory leak in KXzFilter::init

aacid added a comment. I'll commit this on saturday unless someone disagrees REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24938 To: aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24898: Add KLocalizedString::untranslatedText

aacid added a comment. I'll commit this on saturday unless someone disagrees REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

aacid closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25061 To: aacid, ervin, apol Cc: kde-frameworks-devel, ervin, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > file_unix.cpp:58 > +// Defaults to 5MB so the user can follow copy progress > +#define SENDFILE_CHUNK_SIZE (5 * 1024 * 1024) > #endif I have reduced the value to 5 MB so that users can still follow progress,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 162 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/162/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 30 Oct 2019 18:07:45 + Build duration: 9 min 21 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 161 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/161/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 30 Oct 2019 17:58:24 + Build duration: 9 min 16 sec and counting JUnit Tests Name:

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven updated this revision to Diff 69075. meven added a comment. Limit sendfile chunk size to 5MB so that users can still follow progress while enjoying faster copy REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25079?vs=69065=69075 BRANCH master

D24961: Port to the QSslError variant of KSslInfoDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4c2cd442a001: Port to the QSslError variant of KSslInfoDialog (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24961?vs=68781=69074 REVISION

D24931: Port KSSLD internals from KSslError to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:62af525910d4: Port KSSLD internals from KSslError to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24931?vs=68709=69073 REVISION

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 160 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/160/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 30 Oct 2019 17:42:39 + Build duration: 7 min 31 sec and counting JUnit Tests Name:

D24742: Make non-ignorable SSL errors explicit

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8dc567852b26: Make non-ignorable SSL errors explicit (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68289=69071 REVISION DETAIL

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R310:47f24c83759d: Remove call to no longer needed KIconTheme::assignIconsToContextMenu (authored by vkrause). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE

Re: KF6 Sprint

Hi, we have a date and venue by now: November 22 - 24 at the MBition office in Berlin (Dovestraße 1, 10587 Berlin), that's right after the Qt Contributor Summit to reduce travel overhead a bit. Thanks to Eike and Agustin for making this possible! Please subscribe to

D25067: Fix the header layouts for EntryDetails and Page components

leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in EntryDetails.qml:95 > It does not. I am also unsure whether `anchors.fill` will work, since the > titleDelegate is instantiated by a loader and its sizing behaviour is > somewhat fuzzy. The only option that is guaranteed to

D25067: Fix the header layouts for EntryDetails and Page components

leinir updated this revision to Diff 69067. leinir added a comment. Based on @ahiemstra's comments on the sizing logic, this seems to work... - Switch to an implicitWidth based approach REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven added a comment. In D25079#556824 , @ahmadsamir wrote: > Hopefully may fix https://bugs.kde.org/show_bug.cgi?id=402276 The bug scope is rather large. But this will help and I suspect https://phabricator.kde.org/D23523 will too.

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

ahmadsamir added a comment. Hopefully may fix https://bugs.kde.org/show_bug.cgi?id=402276 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

sitter added a comment. TBH, I would move away from the hardcoding in general try to sendfile size_of_file and `if n < size` use n as new count for the next cycle. The second cycle will use the maximum regardless of what the specific kernel version has as maximum. The maximum is an

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven updated this revision to Diff 69065. meven added a comment. Update quote from man sendfile REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25079?vs=69064=69065 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25079 AFFECTED FILES

D25070: Make KCModuleQml conform to the defaulted() signal

ngraham edited the summary of this revision. ngraham added a dependency: D25069: Adjust KCModule to also channel information about defaults. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25070 To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure Cc:

D25069: Adjust KCModule to also channel information about defaults

ngraham added a dependent revision: D25070: Make KCModuleQml conform to the defaulted() signal. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25069 To: ervin, #frameworks, #plasma, mart, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25067: Fix the header layouts for EntryDetails and Page components

ahiemstra added inline comments. INLINE COMMENTS > ngraham wrote in EntryDetails.qml:95 > I don't think this works, since it's not inside another layout. Instead maybe > `anchors.fill: parent` would work better? It does not. I am also unsure whether `anchors.fill` will work, since the

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

apol added a comment. This is really interesting, I can expect this to make the whole thing much faster. INLINE COMMENTS > file_unix.cpp:55 > +// On Linux, write() (and similar system calls) will transfer at most > +// 0x7000 (2,147,479,552) bytes, returning the number of bytes > +//

D25067: Fix the header layouts for EntryDetails and Page components

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Close, but not quite: F7695250: Screenshot_20191030_095130.png F7695252: Screenshot_20191030_095200.png

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven updated this revision to Diff 69064. meven added a comment. amend commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25079?vs=69063=69064 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25079 AFFECTED FILES

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven created this revision. meven added reviewers: dfaure, Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY We had a bad value of 32,768 bytes to copy at once. But Linux

D24959: Add new preferences search icons

astippich added a comment. This is a scaled copy of the kfind magnifier glass. However, it was way too small to be directly usable imho REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26,

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

apol accepted this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D25061 To: aacid, ervin, apol Cc: kde-frameworks-devel, ervin, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D25059: KPluginSelector: use new KAboutPluginDialog

kossebau added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kpluginselector.cpp:799-803 > Can you guard for nullptr? The pluginEntry? That would be inconsistent with the rest of the code here, which does no such checks. We should be relatively safe here, as the slot should be

D25070: Make KCModuleQml conform to the defaulted() signal

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25070 To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25067: Fix the header layouts for EntryDetails and Page components

leinir added reviewers: Frameworks, Plasma. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25067 To: leinir, ngraham, #knewstuff, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25070: Make KCModuleQml conform to the defaulted() signal

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmoduleqml.cpp:80-82 > needsSave emits the current state and then connects for changes > representsDefaults only connects for changes > > I would expect them to match as they're doing equivalent things. > > It looks to me

D25072: Disable the restore defaults button if the KCModule says so

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25072 To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/46/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 30 Oct 2019 12:38:25 + Build duration: 20 min and counting JUnit Tests Name:

D25070: Make KCModuleQml conform to the defaulted() signal

davidedmundson added inline comments. INLINE COMMENTS > kcmoduleqml.cpp:80-82 > if (d->configModule->needsSave()) { > emit changed(true); > } needsSave emits the current state and then connects for changes representsDefaults only connects for changes I would expect them to

D25071: Have KCModuleProxy take care of the defaulted state

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25071 To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 30 Oct 2019 12:37:53 + Build duration: 16 min and counting JUnit Tests Name:

D25071: Have KCModuleProxy take care of the defaulted state

ervin added a comment. In D25071#556681 , @davidedmundson wrote: > Edit: ah, I see why. > > KCMMultiDialog and system settings re-evaluate the buttons on receipt of the changed signal > Still seems maybe a bit odd, but it makes sense in

D25077: Use compile time checked connect

This revision was automatically updated to reflect the committed changes. Closed by commit R296:92f6e85438f8: Use compile time checked connect (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25077?vs=69051=69052 REVISION DETAIL

D25077: Use compile time checked connect

bport accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25077 To: ervin, #plasma, #frameworks, mart, davidedmundson, bport Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25077: Use compile time checked connect

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25077 To: ervin, #plasma, #frameworks, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25077: Use compile time checked connect

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Benjamin made me realized we went through introspection

D25071: Have KCModuleProxy take care of the defaulted state

davidedmundson added a comment. Edit: ah, I see why. KCMMultiDialog and system settings re-evaluate the buttons on receipt of the changed signal Still seems maybe a bit odd, but it makes sense in context. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25071

D25071: Have KCModuleProxy take care of the defaulted state

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmoduleproxy.cpp:196-197 > Why emit changed? > > Given KCModuleProxy mirrors KCModule API I would have expected a defaulted > signal to match? Because all the consumers I found surprisingly don't care about the

D25069: Adjust KCModule to also channel information about defaults

ervin marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25069 To: ervin, #frameworks, #plasma, mart, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25071: Have KCModuleProxy take care of the defaulted state

davidedmundson added inline comments. INLINE COMMENTS > kcmoduleproxy.cpp:196-197 > +defaulted = d; > +emit q->changed(changed); > +emit q->changed(q); > +} Why emit changed? Given KCModuleProxy mirrors KCModule API I would have expected a defaulted signal to match? REPOSITORY

D25069: Adjust KCModule to also channel information about defaults

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. One minor change INLINE COMMENTS > kcmodule.cpp:201 > } > emit changed(false); > +widgetChanged(); this line becomes redundant as widgetChanged() will always

D25073: Get KQuickAddons::ConfigModule to expose if we're in the defaults state

This revision was automatically updated to reflect the committed changes. Closed by commit R296:b2788c1a0894: Get KQuickAddons::ConfigModule to expose if were in the defaults state (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D25075: Make the settingChanged() slot protected.

This revision was automatically updated to reflect the committed changes. Closed by commit R296:372dbb493df6: Make the settingChanged() slot protected. (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25075?vs=69045=69048 REVISION

D25073: Get KQuickAddons::ConfigModule to expose if we're in the defaults state

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25073 To: ervin, #plasma, #frameworks, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25075: Make the settingChanged() slot protected.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25075 To: ervin, #plasma, #frameworks, bport, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25075: Make the settingChanged() slot protected.

ervin created this revision. ervin added reviewers: Plasma, Frameworks, bport, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This might be necessary for some subclasses which

D25073: Get KQuickAddons::ConfigModule to expose if we're in the defaults state

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY ManagedConfigModule is adjusted as well to manage that new

D25070: Make KCModuleQml conform to the defaulted() signal

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This new signal got introduced in KCModule, so we

D25072: Disable the restore defaults button if the KCModule says so

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL

D25071: Have KCModuleProxy take care of the defaulted state

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Now that KCModule exposes a defaulted() signal,

D25069: Adjust KCModule to also channel information about defaults

ervin created this revision. ervin added reviewers: Frameworks, Plasma, mart, davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY We'd probably do things differently nowadays

D25067: Fix the header layouts for EntryDetails and Page components

leinir edited the test plan for this revision. leinir added reviewers: ngraham, KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25067 To: leinir, ngraham, #knewstuff Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25067: Fix the header layouts for EntryDetails and Page components

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This ensures that the header is the correct width, and further that the text does not disappear when there is no space

D25041: Ensure that the changedEntries property is correctly propagated

This revision was automatically updated to reflect the committed changes. Closed by commit R304:344e9b7c07ad: Ensure that the changedEntries property is correctly propagated (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. LGTM, maybe give some times to others to chip in. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D25061 To: aacid, ervin Cc: kde-frameworks-devel,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 69023. meven added a comment. Use StatDetail to reduce statx mask, support old details metadata in file ioslave, adding metadata statDetails for the new values REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE