D21235: Add handling of fuseiso filesystem type

hallas added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:301 > The API is totally awkward. > > You end up with something significantly cleaner when you create a new class > for it: > > QStringMultiHash m_mtabCache; > QHash m_mtabFstypeCache; > bool

D25340: Added background colors to active and inactive icon view

ndavis added a comment. I wonder if the Light gray line on the inactive mode should be a little brighter (up to 35% opacity) or if the background for inactive and minimized should be a little darker (down to 15% opacity) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis added a comment. Here's a cleaned up version of the file with the changes Nate and I requested: F7767647: tasks.svg F7767649: Screenshot_20191117_005703.png REPOSITORY R242 Plasma Framework (Library)

D25340: Added background colors to active and inactive icon view

ndavis added a comment. Unfortunately, InactiveText doesn't work and neither does DisabledText. I might need to change whatever library handles stylesheets for plasmashell. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D21660: remove dbus for windows build and change audio dep logic

bcooksley added a comment. Considering that D-Bus doesn't really belong on Windows, and has been known to cause security software (such as anti-malware packages) to generate false positives in the past, we really should avoid D-Bus completely if at all possible on Windows. For standalone

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#563425 , @bcooksley wrote: > If tests launch D-Bus Daemon, then they will cause the CI system to jam as CTest will wait indefinitely for dbus-daemon to exit. There is a fix for this issue, see

D25340: Added background colors to active and inactive icon view

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Also, according to the title, the line thickness changes are unrelated, so they shouldn't even be included here at all. Let's make this patch only about adding/changing

D25328: Always rehiglhight() after definition was changed

meven added a comment. In D25328#563406 , @dhaumann wrote: > Can't you call `rehighlight()` yourself after calling `setDefinition()`? > > Btw, tanks for looking into this! I have done so in D25323 .

D25340: Added background colors to active and inactive icon view

ngraham added a comment. I like the background changes here and I think it makes logical sense to have a progression of changing background colors to indicate the status. However I'm not a huge fan of reducing the active indicator to just 2px. It's now so small that it becomes kind of

D25244: Implement ISpellChecker backend for Windows >= 8

vonreth added inline comments. INLINE COMMENTS > ispellcheckerclient.cpp:33 > +// init com if needed > +m_wasCOMInitialized = SUCCEEDED(CoInitializeEx(nullptr, > COINIT_MULTITHREADED)); > + is that needed? It should be handled by the qt main loop? > ispellcheckerclient.cpp:59 > +

D24957: Add new baloo icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:61331d6ce20a: Add new baloo icons (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24957?vs=69857=69859 REVISION DETAIL

D24957: Add new baloo icons

astippich updated this revision to Diff 69857. astippich added a comment. - tweak icon and shadows - remove baloo symlink REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24957?vs=69501=69857 BRANCH newBalooIcon REVISION DETAIL

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#563388 , @niccolove wrote: > > @ndavis said: > > Here's what I think: > > > > - The line should indicate that the app is opened, the window is not minimized and the window is focused (opaque blue) or

D21660: remove dbus for windows build and change audio dep logic

bcooksley added a comment. If tests launch D-Bus Daemon, then they will cause the CI system to jam as CTest will wait indefinitely for dbus-daemon to exit. D-Bus should not be used under any circumstances on Windows. REPOSITORY R289 KNotifications REVISION DETAIL

D21660: remove dbus for windows build and change audio dep logic

habacker added a comment. In D21660#481421 , @bcooksley wrote: > With regards to Windows, please note that any unit test which depends on calls that involve D-Bus on the CI system will likely lead to that test hanging because dbus-daemon is

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 69851. niccolove added a comment. Added background colors to active and inactive icon view REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69849=69851 BRANCH backrgound-color-iconviewer

D25328: Always rehiglhight() after definition was changed

dhaumann added a comment. Can't you call `rehighlight()` yourself after calling `setDefinition()`? Btw, tanks for looking into this! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25328 To: meven, kossebau, cullmann, vkrause Cc: dhaumann,

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#563400 , @ndavis wrote: > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work? No. My bad. Let me

D25340: Added background colors to active and inactive icon view

ndavis added a comment. This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D25340: Added background colors to active and inactive icon view

niccolove added a subscriber: ndavis. niccolove added a comment. > @ndavis said: > Here's what I think: > > - The line should indicate that the app is opened, the window is not minimized and the window is focused (opaque blue) or inactive (opaque gray) > - The background should

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#563295 , @niccolove wrote: > In D25334#563285 , @ngraham wrote: > > > Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files.

D25340: Added background colors to active and inactive icon view

niccolove edited the test plan for this revision. niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Added: - Light blue color for active window - Light gray color for inactive but not minimized window

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#563346 , @ngraham wrote: > Found the bug report tracking that requested change: https://bugs.kde.org/show_bug.cgi?id=370465 > > Based on the comments there, it's likely that this proposal would receive

Re: Disabling of 'kdav-davitemfetchjob' test in KDav

On Sat, Nov 16, 2019 at 11:49 PM Volker Krause wrote: > > On Saturday, 16 November 2019 11:26:39 CET Volker Krause wrote: > > On Saturday, 16 November 2019 07:04:57 CET Ben Cooksley wrote: > > > Hi everyone, > > > > > > Currently we have an issue where the test 'kdav-davitemfetchjob' within > > >

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added reviewers: cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullmann, dhaumann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. F7766842: Screenshot_20191116_092819.png Add screenshot to demonstrate the problem. And what I'd like to point is, for CJK users, it is uncommon for them to select a single font to cover all the characters, because

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 69848. xuetianweng added a comment. Add comment about the actual characters. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=69847=69848 BRANCH master REVISION DETAIL

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng created this revision. xuetianweng added a reviewer: KTextEditor. xuetianweng added projects: Kate, Frameworks. xuetianweng requested review of this revision. REVISION SUMMARY When a font has fallback, the fontHeight is broken can may cut the string in the middle in the line. Try

D25334: Added transparent blue background to tabbars

ngraham added a comment. In D25334#563345 , @niccolove wrote: > In D25334#563334 , @ngraham wrote: > > > If you wanna do that, let's split it out into a different patch though. > > > Sure.

D25334: Added transparent blue background to tabbars

ngraham added a comment. Found the bug report tracking that requested change: https://bugs.kde.org/show_bug.cgi?id=370465 Based on the comments there, it's likely that this proposal would receive pushback, and we should endeavor to understand why it was changed to the current state in

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563334 , @ngraham wrote: > If you wanna do that, let's split it out into a different patch though. Sure. Should this patch land first, or should I try to make two at the same time? REPOSITORY R242

D25334: Added transparent blue background to tabbars

ngraham added a comment. If you wanna do that, let's split it out into a different patch though. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham Cc: ngraham, ndavis, KonqiDragon, #vdg,

D25334: Added transparent blue background to tabbars

ngraham added a comment. In D25334#563308 , @niccolove wrote: > F7766720: Screenshot_20191116_172052.png > I think that this last one looks much prettier and usable, but that's just an idea I only

D25328: Always rehiglhight() after definition was changed

cullmann added a comment. Hmm, I am not sure this doesn't regress cases that rely on setDefinition being "cheap" for the nop case. Is there no other way to trigger re-highlight for the wanted case? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25328

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563301 , @ngraham wrote: > If anything, I think the tab bar line should increase to be 3px to match the open app task manager highlight. If we do the reverse, the highlight for open app swill be too subtle

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added a comment. Then we can merge this, or? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

ngraham added a comment. Ping. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25219: Only create a session config when actually restoring a session

ngraham added a comment. Ping. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25219 To: ngraham, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

ngraham added a comment. If anything, I think the tab bar line should increase to be 3px to match the open app task manager highlight. If we do the reverse, the highlight for open app swill be too subtle IMO. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D25015: Update breeze theme shadows

niccolove added a comment. This is a comparison: F7766697: Screenshot_20191116_165659.png The problem is not that you don't see, it's that it doesn't show. I'll try to understand what's going on and get back to you. REPOSITORY R242 Plasma Framework

D25015: Update breeze theme shadows

ngraham added a comment. Okay, after you taught me how to delete the cache files `rm ~/.cache/plasma*`, I can see other changes to the plasma theme SVG files but I must admit I still don't see a difference between the old and new shadows in this patch. :/ REPOSITORY R242 Plasma Framework

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563285 , @ngraham wrote: > Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files. Deleting those fixed a bunch of other issues I was having with applying plasma theme SVG

D25296: [RFC] Fix Display Configuration icon margins

ngraham added a comment. Never mind, I wasn't deleting the cache files properly after rebuilding. When I do that, the monochrome icons don't get used at all and it reverts to the colorful one: F778: Screenshot_20191116_084222.png REPOSITORY

D25334: Added transparent blue background to tabbars

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files. Deleting those fixed a bunch of other issues I was having with applying plasma theme SVG

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/65/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 16 Nov 2019 15:24:58 + Build duration: 8 min 27 sec and counting BUILD ARTIFACTS

D24957: Add new baloo icons

ngraham added a comment. Yes, that's correct. REPOSITORY R266 Breeze Icons BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/42/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 16 Nov 2019 15:28:56 + Build duration: 2 min 27 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/41/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 16 Nov 2019 15:24:07 + Build duration: 4 min 46 sec and counting BUILD ARTIFACTS

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563265 , @ngraham wrote: > Did you change the SVGs for vertical tab bars as well? Uh, yes I did. Try deleting the plasma theme + svg cache in .cache > I also noticed one visual papercut in the

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/39/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 16 Nov 2019 15:24:58 + Build duration: 2 min 1 sec and counting JUnit Tests Name:

D25334: Added transparent blue background to tabbars

niccolove updated this revision to Diff 69841. niccolove added a comment. Fixed broken north bottom-left tabbar line REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25334?vs=69840=69841 BRANCH master REVISION DETAIL

Re: Bulk replacement of projects.kde.org on Frameworks modules

Luigi Toscano ha scritto: > Hi, > basically all Frameworks components reference the ECM website > using the old projects.kde.org URL, which is long gone and > it is just a (partial) redirect. > > See for example: > > set_package_properties(ECM PROPERTIES TYPE REQUIRED > DESCRIPTION "Extra

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/40/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 16 Nov 2019 15:17:23 + Build duration: 6 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/64/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 16 Nov 2019 15:20:53 + Build duration: 2 min 26 sec and counting BUILD ARTIFACTS

D25296: [RFC] Fix Display Configuration icon margins

ngraham added a comment. Hmm, if I change that, the icon disappears entirely when displayed at the 22px size: F7766627: Screenshot_20191116_082035.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25296

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 16 Nov 2019 15:20:53 + Build duration: 1 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/63/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 16 Nov 2019 15:17:23 + Build duration: 2 min 30 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 16 Nov 2019 15:17:23 + Build duration: 1 min 28 sec and counting JUnit Tests Name:

D25334: Added transparent blue background to tabbars

ngraham added subscribers: ndavis, ngraham. ngraham added a comment. This is great, I've wanted Plasma tabs to look like this for ages. It gels very well with the in-progress highlight changes that @ndavis is working on. However for me it only seems to take effect for horizontal tab bars.

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563254 , @KonqiDragon wrote: > Something like this looks better and clearer. > F6924045: grafik.png That's because no element was selected. If you select an

D25334: Added transparent blue background to tabbars

KonqiDragon added a comment. Is it possible to make the selection of system tray visually more cleary? On this screenshot i see that opened the "Status and Notifications" tray popup, but it looks like that selected all in the system tray F7766344: Screenshot_20191116_121454.png

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 185 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/185/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 16 Nov 2019 14:29:28 + Build duration: 8 min 45 sec and counting JUnit Tests Name:

D25334: Added transparent blue background to tabbars

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

niccolove updated this revision to Diff 69840. niccolove edited the summary of this revision. niccolove added a comment. Resized blue line of tabbars REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25334?vs=69833=69840 BRANCH master

D25237: Deprecated KTcpSocket and KSsl* classes

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ba8e9c7df86c: Deprecated KTcpSocket and KSsl* classes (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25237?vs=69530=69839 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 184 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/184/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 16 Nov 2019 12:20:34 + Build duration: 9 min 53 sec and counting JUnit Tests Name:

D24433: Move URL parsing methods from kioslave to query object

iasensio added inline comments. INLINE COMMENTS > bruns wrote in kio_search.cpp:88 > @broulik - why `endsWith()`? should I just change the comparisons to `path == ...`, just like the `/documents` one? REPOSITORY R293 Baloo BRANCH extend_query_url REVISION DETAIL

D24433: Move URL parsing methods from kioslave to query object

iasensio updated this revision to Diff 69836. iasensio added a comment. Remove extra spaces REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24433?vs=69613=69836 BRANCH extend_query_url REVISION DETAIL https://phabricator.kde.org/D24433 AFFECTED FILES

D25236: Remove the last traces of KSslError from TCPSlaveBase

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e0eb9ebaa569: Remove the last traces of KSslError from TCPSlaveBase (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25236?vs=69527=69835

D25244: Implement ISpellChecker backend for Windows >= 8

mludwig added a comment. I've tried it out and works just fine! :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: kconfig-elektra

Dear David, Am 16.11.19 um 03:20 schrieb David Faure: > On mardi 12 novembre 2019 16:58:19 CET k...@markus-raab.org wrote: >> Dear KDE developers, >> >> As discussed in Akademy 2018 [1] Felix Resch and Dardan Haxhimustafa are >> working on a patch for KConfig so that KConfig uses Elektra [2]

D25334: Added transparent blue background to tabbars

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. niccolove added a reviewer: VDG. niccolove added a subscriber: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg Cc: #vdg,

D25334: Added transparent blue background to tabbars

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Used the T11124 highlight effect for breeze tabbars by editing the file

Re: Disabling of 'kdav-davitemfetchjob' test in KDav

On Saturday, 16 November 2019 11:26:39 CET Volker Krause wrote: > On Saturday, 16 November 2019 07:04:57 CET Ben Cooksley wrote: > > Hi everyone, > > > > Currently we have an issue where the test 'kdav-davitemfetchjob' within > > kdav causes kdeinit5 to be relaunched, as can be seen in the CI > >

Re: Disabling of 'kdav-davitemfetchjob' test in KDav

On Saturday, 16 November 2019 07:04:57 CET Ben Cooksley wrote: > Hi everyone, > > Currently we have an issue where the test 'kdav-davitemfetchjob' within > kdav causes kdeinit5 to be relaunched, as can be seen in the CI > run log below. > >

D24957: Add new baloo icons

astippich added a comment. the scalable test fails with this one. Is the right solution to just delete the 32px symlink under .../preferences? REPOSITORY R266 Breeze Icons BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc:

D24959: Add new preferences search icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:40acd718572a: Add new preferences search icons (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24959?vs=69500=69830 REVISION DETAIL

D24568: Provide clang-format target with a KDE Frameworks style file

dhaumann added a comment. You can force the current clang format to keep the multi-line if as follows: if (roles.isEmpty() // comment || roles.contains(Notifications::UpdatedRole) || roles.contains(Notifications::ExpiredRole) The comment prevents clang to