KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 65 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/65/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 22 Nov 2019 06:20:49 + Build duration: 3 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/60/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 06:20:49 + Build duration: 2 min 12 sec and counting JUnit Tests Name:

D25446: [kcoredirlister] Port away from QLinkedList

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoredirlister.cpp:1547 > +QVector itemsToChange; > +itemsToChange.reserve(itemsInUse.size()); > QSet listers; There can be a lot more items in

D25451: [KCMultiDialog] Remove most special margins handling; it's done in KPageDialog now

ngraham edited the summary of this revision. ngraham added a dependency: D25444: Unify KPageDialog margin handling into KPageDialog itself. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25451 To: ngraham, #frameworks, mart, cfeck Cc: kde-frameworks-devel, LeGast00n,

D25444: Unify KPageDialog margin handling into KPageDialog itself

ngraham added a dependent revision: D25451: [KCMultiDialog] Remove most special margins handling; it's done in KPageDialog now. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25444 To: ngraham, #frameworks, cfeck, mart Cc: kossebau, kde-frameworks-devel,

D25444: Unify KPageDialog margin handling into KPageDialog itself

ngraham retitled this revision from "Fix assistant dialog margins" to "Unify KPageDialog margin handling into KPageDialog itself". ngraham edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25444 To: ngraham, #frameworks,

D25444: Fix assistant dialog margins

ngraham edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25444 To: ngraham, #frameworks, cfeck, mart Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25451: [KCMultiDialog] Remove most special margins handling; it's done in KPageDialog now

ngraham created this revision. ngraham added reviewers: Frameworks, mart, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY See D25444 TEST PLAN See

D25443: [chmodjob] Port away from QLinkedList

dfaure added inline comments. INLINE COMMENTS > chmodjob.cpp:131 ><< "\n new permissions = " << > QString::number(info.permissions,8);*/ > -m_infos.prepend(info); > +m_infos.push_front(info); > //qDebug() << "processList : Adding

D25445: [copyjob] Port away from QLinkedList

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH cjob REVISION DETAIL https://phabricator.kde.org/D25445 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25444: Fix assistant dialog margins

ngraham updated this revision to Diff 70128. ngraham added a comment. Do it universally REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25444?vs=70118=70128 BRANCH fix-assistant-dialog-margins (branched from master) REVISION DETAIL

D25117: file ioslave: stop copying as soon as the ioslave is killed

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Nice, I didn't realize the slave had 5 seconds to cleanup after being killed, I thought it died immediately (genericsig_handler in slavebase.cpp). Hmm, the Windows code is

D25334: Added transparent blue background to tabbars

ndavis added a comment. Here's the fixed file: F680: tabbar.svg Unfortunately, it still doesn't look right. F681: Screenshot_20191121_160905.png REPOSITORY R242 Plasma Framework (Library) REVISION

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 324 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/324/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Nov 2019 20:51:57 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 208 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/208/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 21 Nov 2019 20:51:57 + Build duration: 7 min 5 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 193 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/193/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 21 Nov 2019 20:51:56 + Build duration: 6 min 4 sec and counting JUnit Tests Name:

D25334: Added transparent blue background to tabbars

ndavis added inline comments. INLINE COMMENTS > ndavis wrote in tabbar.svg:47 > Oh wait, this must be where the color problem is. It's hardcoded to a light > color. It should be ButtonFocus with semi-transparency instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25334: Added transparent blue background to tabbars

ndavis added inline comments. INLINE COMMENTS > tabbar.svg:47 > + > + height="12" fill="#93cee9" opacity=".34"/> > + height="12" fill="#93cee9" opacity=".34"/> Oh wait, this must be where the color problem is. It's hardcoded to a light color. REPOSITORY R242 Plasma

D25401: Fix deprecation syntax in ktcpsocket.h

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25401 To: dfaure, vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#565851 , @ngraham wrote: > Are you talking about the effect itself in terms of its background color, or how it fits in the space available when displayed by widgets? The latter will require many complicated

D25334: Added transparent blue background to tabbars

ngraham added a comment. Are you talking about the effect itself in terms of its background color, or how it fits in the space available when displayed by widgets? The latter will require many complicated changes in various places to fix, but can't the former be fixed in this patch?

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#565798 , @ngraham wrote: > Honestly I think this is fine to land now. We can incrementally improve things with patches to individual widgets, but for the most part I think this is a big improvement already.

D25448: EBN cleanup of autests transfer protocal

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY change newlinetest.cpp protocol from http to https REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from

D25443: [chmodjob] Port away from QLinkedList

bruns added a comment. Or just change the direction? INLINE COMMENTS > chmodjob.cpp:115 > { > Q_Q(ChmodJob); > while (!m_lstItems.isEmpty()) { For efficiency, probably do a `m_infos.reserve(m_infos.capacity() + m_lstItems.size());` here. > chmodjob.cpp:155 >

D25444: Fix assistant dialog margins

ngraham planned changes to this revision. ngraham added a comment. Sure, I can look into that. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25444 To: ngraham, #frameworks, cfeck, mart Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25444: Fix assistant dialog margins

cfeck added a comment. Since KAssistantDialog is a KPageDialog, what happens to other users of that class? I had hoped the fix is in KPageDialog, and it would only omit the margins when the caller requested it (e.g. KCMs etc.). INLINE COMMENTS > kassistantdialog.cpp:103 > +

D25443: [chmodjob] Port away from QLinkedList

fabiank added a comment. While the change should be fine as is, that sounds like a job for std::deque, as we don't need insertions/removals at random positions. Or even for a std::queue, because we only operate on the front. REPOSITORY R241 KIO REVISION DETAIL

D25334: Added transparent blue background to tabbars

ngraham added a comment. Honestly I think this is fine to land now. We can incrementally improve things with patches to individual widgets, but for the most part I think this is a big improvement already. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25444: Fix assistant dialog margins

ngraham updated this revision to Diff 70118. ngraham marked an inline comment as done. ngraham added a comment. Cache the style REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25444?vs=70115=70118 BRANCH fix-assistant-dialog-margins (branched from

D25446: [kcoredirlister] Port away from QLinkedList

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Use QVector instead. Not sure that's the best thing

D25446: [kcoredirlister] Port away from QLinkedList

nicolasfella added a task: T12087: Port away from QLinkedList. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25446 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25445: [copyjob] Port away from QLinkedList

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY QLinkedList will likely go away in Qt 6 TEST PLAN Copied files

D25445: [copyjob] Port away from QLinkedList

nicolasfella added a task: T12087: Port away from QLinkedList. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25445 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25444: Fix assistant dialog margins

kossebau added inline comments. INLINE COMMENTS > kassistantdialog.cpp:102 > +q->pageWidget()->layout()->setContentsMargins( > +q->pageWidget()->style()->pixelMetric(QStyle::PM_LayoutLeftMargin), > +q->pageWidget()->style()->pixelMetric(QStyle::PM_LayoutTopMargin), Ideally

D25444: Fix assistant dialog margins

ngraham created this revision. ngraham added reviewers: Frameworks, cfeck, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Same fix as in

D24993: Add integrated inline spelling menu to KTextEdit

cfeck added a comment. Oh, I didn't read the code, only replied to the comment. If this is new code, then changing the visibility is no ABI problem. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D24993 To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck

D24993: Add integrated inline spelling menu to KTextEdit

pajamapants3000 added a comment. @cfeck - I was referring to `SpellingMenu::addWordToDictionary` and `SpellingMenu::ignoreWord` being inconsistent with the documentation of that (brand new) class. I don't think there should be any ABI considerations there, since it is a new class, but

D25401: Fix deprecation syntax in ktcpsocket.h

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25401 To: dfaure, vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25443: [chmodjob] Port away from QLinkedList

nicolasfella added a task: T12087: Port away from QLinkedList. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25443: [chmodjob] Port away from QLinkedList

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY QLinkedList is likely to go away in Qt 6. A comment suggests that

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 207 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/207/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 21 Nov 2019 16:06:47 + Build duration: 15 min and counting BUILD ARTIFACTS

D25442: Set application name and version on the knshandler tool

leinir added reviewers: Frameworks, Plasma, starbuck. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D25442 To: leinir, #frameworks, #plasma, starbuck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25442: Set application name and version on the knshandler tool

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In preparation for D25441 and D25440 being

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 192 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/192/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 21 Nov 2019 16:06:48 + Build duration: 8 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 323 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/323/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Nov 2019 16:06:47 + Build duration: 7 min 1 sec and counting BUILD ARTIFACTS

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:4d8aa4be386e: [KPropertiesDialog] provide a way of showing the target of a symlink (authored by ngraham). REPOSITORY

D25441: Send along the config name with requests

leinir added reviewers: KNewStuff, Frameworks, Plasma, starbuck, ronaldv. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25441 To: leinir, #knewstuff, #frameworks, #plasma, starbuck, ronaldv Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25440: Set a proper agent string for Attica requests

leinir added a reviewer: ronaldv. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D25440 To: leinir, #frameworks, #knewstuff, #plasma, starbuck, ronaldv Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24993: Add integrated inline spelling menu to KTextEdit

cfeck added a comment. I am not sure if changing the visibility of members is ABI compatible. This might need to wait for KF6. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D24993 To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck Cc: ngraham,

D25440: Set a proper agent string for Attica requests

leinir added reviewers: Frameworks, KNewStuff, Plasma, starbuck. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D25440 To: leinir, #frameworks, #knewstuff, #plasma, starbuck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25440: Set a proper agent string for Attica requests

leinir added a dependent revision: D25441: Send along the config name with requests. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D25440 To: leinir Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25441: Send along the config name with requests

leinir added a dependency: D25440: Set a proper agent string for Attica requests. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25441 To: leinir Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25441: Send along the config name with requests

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This allows the server to perform some minimal analysis on the origin of requests, without sending out anything that is

D25440: Set a proper agent string for Attica requests

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Rather than simply accepting the default value for the agent string, which suggests that this library is Mozilla, we

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

apol added a comment. +1 LGTM REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25226 To: ngraham, #vdg, #frameworks Cc: apol, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 322 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/322/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Nov 2019 14:34:12 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 206 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/206/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 21 Nov 2019 14:34:12 + Build duration: 7 min 15 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 191 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/191/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 21 Nov 2019 14:34:12 + Build duration: 7 min 59 sec and counting JUnit Tests Name:

D25435: [Network Ioslave] Add Display name to network:/

This revision was automatically updated to reflect the committed changes. Closed by commit R320:2f6f67aba31b: [Network Ioslave] Add Display name to network:/ (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25435?vs=70096=70107 REVISION

D25438: Ftp ioslave: Fix ProxyUrls parameter passing

trufanov accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25438 To: meven, trufanov, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25436: [Remote ioslave] Add Display Name to remote:/

This revision was automatically updated to reflect the committed changes. Closed by commit R241:20c25a1941ad: [Remote ioslave] Add Display Name to remote:/ (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25436?vs=70093=70105 REVISION DETAIL

D25438: Ftp ioslave: Fix ProxyUrls parameter passing

meven created this revision. meven added reviewers: trufanov, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY QVariant stored in mapConfig always contain QByteArray values. So QVariant

D25432: Fix HTTP proxy settings

meven added a comment. In D25432#565595 , @trufanov wrote: > Hmm, I've just `git grep` the repo and found another place that is most probably affected by the same problem in FTP slave; >

D25436: [Remote ioslave] Add Display Name to remote:/

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25436 To: meven, broulik, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25435: [Network Ioslave] Add Display name to network:/

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, perfect. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D25435 To: meven, ngraham, #frameworks Cc: broulik, kde-frameworks-devel,

D25435: [Network Ioslave] Add Display name to network:/

meven added a comment. In D25435#565600 , @ngraham wrote: > Ah, I see why: because the bug report is about `remote:/`, not `network:/`. I guess `network needs this patch too, but it's not fully complete unless `remote:/` gets the same fix.

D25435: [Network Ioslave] Add Display name to network:/

ngraham added a comment. Ah, I see why: because the bug report is about `remote:/`, not `network:/`. I guess `network needs this patch too, but it's not fully complete unless `remote:/` gets the same fix. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25435

D25435: [Network Ioslave] Add Display name to network:/

ngraham added a comment. Hmm, somehow this does not work for me. The "Network" place in the places panel still shows "." as the text. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25435 To: meven, ngraham, #frameworks Cc: broulik, kde-frameworks-devel,

D25432: Fix HTTP proxy settings

trufanov added a comment. Hmm, I've just `git grep` the repo and found another place that is most probably affected by the same problem in FTP slave; https://github.com/KDE/kio/blob/d03551cd0367ac7760224c56bda943c937ba5dac/src/ioslaves/ftp/ftp.cpp#L320 Could you check out if it's a

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 70102. meven added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=70101=70102 BRANCH arcpatch-D25117 REVISION DETAIL https://phabricator.kde.org/D25117 AFFECTED FILES

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 70101. meven added a comment. Keep FileCopyJob::doKill REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=69208=70101 BRANCH arcpatch-D25117 REVISION DETAIL https://phabricator.kde.org/D25117 AFFECTED FILES

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. > I'm open to counter-arguments and counter-examples. Actually, do we know of any other app than konsole which supports both Multiple and Unique modes? I would prefer to have only one mode. Tab & Split drag 'n drop only work in Single Instances, so if

T11542: Remove KHTML

cordlandwehr added a subtask: T12086: Port Kile away from KHTML. TASK DETAIL https://phabricator.kde.org/T11542 To: cordlandwehr Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, manuelal, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner,

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 166 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/166/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 21 Nov 2019 11:38:07 + Build duration: 19 min and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 205 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/205/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 21 Nov 2019 11:38:06 + Build duration: 9 min 36 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 190 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/190/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 21 Nov 2019 11:38:06 + Build duration: 7 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 321 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/321/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Nov 2019 11:38:04 + Build duration: 7 min 26 sec and counting BUILD ARTIFACTS

D25432: Fix HTTP proxy settings

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c0ae03d14b0e: Fix HTTP proxy settings (authored by trufanov). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25432?vs=70084=70098 REVISION DETAIL

D25435: [Network Ioslave] Add Display name to network:/

meven added a comment. In D25435#565544 , @broulik wrote: > I think this needs a `add_definitions(-DTRANSLATION_DOMAIN` and `Messages.sh` file? Thanks done REPOSITORY R320 KIO Extras REVISION DETAIL

D25435: [Network Ioslave] Add Display name to network:/

meven updated this revision to Diff 70096. meven added a comment. Clean REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25435?vs=70095=70096 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25435 AFFECTED FILES network/CMakeLists.txt

D25435: [Network Ioslave] Add Display name to network:/

meven updated this revision to Diff 70095. meven added a comment. fix REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25435?vs=70094=70095 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25435 AFFECTED FILES network/CMakeLists.txt

D25435: [Network Ioslave] Add Display name to network:/

meven updated this revision to Diff 70094. meven added a comment. Add translation and Messages.sh to network:/ REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25435?vs=70092=70094 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25435

D25435: [Network Ioslave] Add Display name to network:/

broulik added a comment. I think this needs a `add_definitions(-DTRANSLATION_DOMAIN` and `Messages.sh` file? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25435 To: meven, ngraham, #frameworks Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio,

D25436: [Remote ioslave] Add Display Name to remote:/

meven updated this revision to Diff 70093. meven added a comment. Update commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25436?vs=70091=70093 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25436 AFFECTED FILES

D25436: [Remote ioslave] Add Display Name to remote:/

meven retitled this revision from "[Remote ioslave] Add Display Name to remote://" to "[Remote ioslave] Add Display Name to remote:/". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25436 To: meven, broulik, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25435: [Network Ioslave] Add Display name to network:/

meven updated this revision to Diff 70092. meven added a comment. Formatting REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25435?vs=70090=70092 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25435 AFFECTED FILES

D25436: [Remote ioslave] Add Display Name to remote://

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25436 To: meven, broulik, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25436: [Remote ioslave] Add Display Name to remote://

meven created this revision. meven added reviewers: broulik, ngraham, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 414345 FIXED-IN: 5.65 REPOSITORY R241 KIO BRANCH master

D25435: [Network Ioslave] Add Display name to network:/

meven created this revision. meven added reviewers: ngraham, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY CCBUG: 414345 REPOSITORY R320 KIO Extras BRANCH master

D25432: Fix HTTP proxy settings

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Thank you for digging it ! KConfig did quite some work `KConfigGroupPrivate::deserializeList` https://cgit.kde.org/kconfig.git/tree/src/core/kconfiggroup.cpp#n155 But a simple

D25432: Fix HTTP proxy settings

meven edited the summary of this revision. meven added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25432 To: trufanov, meven, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. In D25010#565421 , @dfaure wrote: > Hmm, I meant Name is always useful when *listing*. But when *stating*, we don't always need to get the name back. The NoDetails comment is about a stat that really can just

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70088. meven added a comment. Add NoDetails to StatDetail, add StatJob::setDetails\(KIO::StatDetail detail\), small comment update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70051=70088 BRANCH