KDE CI: Frameworks » kinit » kf5-qt5 SUSEQt5.13 - Build # 28 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20SUSEQt5.13/28/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 07:34:29 + Build duration: 2 min 30 sec and counting BUILD ARTIFACTS

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25632: Fix module imports with Python3

2019-12-01 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R264:f8ff31dc9af0: Fix module imports with Python3 (authored by cordlandwehr). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25632?vs=70625=70721 REVISION DETAIL

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

2019-12-01 Thread Noah Davis
ndavis added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis added a dependent revision: D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

2019-12-01 Thread Noah Davis
ndavis added a dependency: D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

2019-12-01 Thread Noah Davis
ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks.

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis updated this revision to Diff 70718. ndavis added a comment. - Split up Effects enum REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25676?vs=70717=70718 BRANCH enum-item-counts (branched from master) REVISION DETAIL

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis retitled this revision from "Add items to ColorSet and Role enums for the total number of items" to "[KColorScheme] Add items to ColorSet and Role enums for the total number of items". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis,

D25676: Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis updated this revision to Diff 70717. ndavis added a comment. - Also do Effects enum REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25676?vs=70716=70717 BRANCH enum-item-counts (branched from master) REVISION DETAIL

D25676: Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

2019-12-01 Thread Noah Davis
ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY I noticed that QPalette had these, but KColorScheme didn't. Since there is no function to get the number of items in an

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 02:52:55 + Build duration: 30 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 115 - Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/115/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 02:52:42 + Build duration: 28 min and counting BUILD ARTIFACTS

D25673: Deprecate KServiceTypeProfile

2019-12-01 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kservicetypeprofile.h:50 > * @param disabledServices List of services which are normally associated > with this serviceType, > * but which should be disabled, i.e. trader queries will not return them. > */ @deprecated 5.65 REPOSITORY R309

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 79 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/79/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 02:52:26 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/73/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 02:52:16 + Build duration: 8 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 84 - Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 02:52:07 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 02:04:53 + Build duration: 3 min 54 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/27/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 01 Dec 2019 23:53:41 + Build duration: 1 hr 39 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:51:10 + Build duration: 1 hr 7 min and counting JUnit Tests Name:

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.13/21/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 01 Dec 2019 23:53:38 + Build duration: 1 hr 2 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/64/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:51:03 + Build duration: 1 hr 3 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 33 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/33/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 00:08:18 + Build duration: 44 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:51:03 + Build duration: 1 hr 1 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:51:02 + Build duration: 58 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » threadweaver » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:51:02 + Build duration: 55 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:51:01 + Build duration: 53 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/46/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:51:01 + Build duration: 52 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:50:59 + Build duration: 48 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 44 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/44/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 00:07:58 + Build duration: 30 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 152 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/152/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:50:57 + Build duration: 45 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 45 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/45/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 00:07:55 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kinit » kf5-qt5 SUSEQt5.13 - Build # 27 - Failure!

2019-12-01 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20SUSEQt5.13/27/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 00:07:54 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 42 - Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/42/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 00:07:50 + Build duration: 7 min 6 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:50:56 + Build duration: 21 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/40/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:50:56 + Build duration: 22 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:50:54 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 208 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/208/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:50:54 + Build duration: 13 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:50:53 + Build duration: 5 min 40 sec and counting JUnit Tests Name:

D25673: Deprecate KServiceTypeProfile

2019-12-01 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's unused. See T12287

D25671: Fix git builds against Qt 5.14

2019-12-01 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's not really acceptable to just error on everything since some of the solutions (like in this

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 77 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/77/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 01 Dec 2019 23:05:03 + Build duration: 6 min 2 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 43 - Still Unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/43/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 01 Dec 2019 23:05:02 + Build duration: 4 min 30 sec and counting JUnit Tests Name:

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

2019-12-01 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25589#570375 , @dfaure wrote: > My head hurts a bit but I think I understand this now ;) Indeed, this gets more & more complex, I hope in time for ECM6 there are enough samples collected from real-world

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

2019-12-01 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R240:23d868a07712: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D25630: Port to json metadata

2019-12-01 Thread Nicolas Fella
nicolasfella updated this revision to Diff 70698. nicolasfella added a comment. - Use kcoreaddons_desktop_to_json REPOSITORY R150 KDE Telepathy KDE Daemon Module CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25630?vs=70623=70698 BRANCH json REVISION DETAIL

D25599: Fix plugin-metadata translations on windows

2019-12-01 Thread Albert Astals Cid
aacid added a comment. In D25599#570372 , @sars wrote: > ki18n does not seem to use QLocale to get the language for translation It already does that on non unix appendLanguagesFromQLocale(localeLanguages, QLocale::system()); the

D25660: Decouple KBookmarksMenu from KActionCollection

2019-12-01 Thread Nicolas Fella
nicolasfella updated this revision to Diff 70694. nicolasfella added a comment. Rebase REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25660?vs=70693=70694 BRANCH addd REVISION DETAIL https://phabricator.kde.org/D25660 AFFECTED FILES

D25660: Decouple KBookmarksMenu from KActionCollection

2019-12-01 Thread Nicolas Fella
nicolasfella retitled this revision from "Add member for editbookmarks action" to "Decouple KBookmarksMenu from KActionCollection". nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. REPOSITORY R294 KBookmarks REVISION DETAIL

D25660: Add member for editbookmarks action

2019-12-01 Thread Nicolas Fella
nicolasfella updated this revision to Diff 70693. nicolasfella added a comment. - Decouple from KActionCollection REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25660?vs=70680=70693 BRANCH addd REVISION DETAIL https://phabricator.kde.org/D25660

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 01 Dec 2019 20:39:27 + Build duration: 2 min 14 sec and counting JUnit Tests

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 4 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 01 Dec 2019 20:27:47 + Build duration: 1 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Still unstable!

2019-12-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/3/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 01 Dec 2019 20:17:12 + Build duration: 2 min 9 sec and counting JUnit Tests

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 3 - Failure!

2019-12-01 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 01 Dec 2019 20:17:12 + Build duration: 56 sec and counting CONSOLE OUTPUT [...truncated 358

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.13 - Build # 2 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.13/2/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 01 Dec 2019 20:03:37 + Build duration: 1 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Failure!

2019-12-01 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/2/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 01 Dec 2019 20:03:37 + Build duration: 2 min 6 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 20:03:37 + Build duration: 1 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 2 - Fixed!

2019-12-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 01 Dec 2019 20:03:37 + Build duration: 1 min 39 sec and counting BUILD ARTIFACTS

D25599: Fix plugin-metadata translations on windows

2019-12-01 Thread Hannah von Reth
vonreth added a comment. Well it sounds to me like we might need both. But the issue this pr tries to tackle would probably be gone with setDefault REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel,

D24489: KAutosaveFile not respecting maximum filename length

2019-12-01 Thread David Faure
dfaure added a comment. A unittest would be very welcome. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

2019-12-01 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. My head hurts a bit but I think I understand this now ;) I'm not sure what's the use case for disabling this though? (I'm wondering the same about the existing

D25599: Fix plugin-metadata translations on windows

2019-12-01 Thread Kåre Särs
sars added a comment. ki18n does not seem to use QLocale to get the language for translation, but uses LANGUAGE env. Also gettext uses the env variable. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel,

D25599: Fix plugin-metadata translations on windows

2019-12-01 Thread Albert Astals Cid
aacid added a comment. To be honest i don't remember why we don't use setDefault. It's a solution we could investigate REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets,

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-12-01 Thread Alexander Saoutkin
feverfew added a comment. In D23384#570347 , @ngraham wrote: > In D23384#570119 , @feverfew wrote: > > > In D23384#570016 , @ngraham wrote: > > > > >

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-12-01 Thread Alexander Saoutkin
feverfew added a comment. In D23384#570349 , @ngraham wrote: > In D23384#570125 , @dfaure wrote: > > > @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the

D24489: KAutosaveFile not respecting maximum filename length

2019-12-01 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-12-01 Thread Nathaniel Graham
ngraham added a comment. In D23384#570125 , @dfaure wrote: > @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the application being started, and the application, if it supports gvfs, re-translates that into

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-12-01 Thread Nathaniel Graham
ngraham added a comment. In D23384#570119 , @feverfew wrote: > In D23384#570016 , @ngraham wrote: > > > In D23384#569929 , @feverfew wrote: > > > > >

D25572: [KFileWidget] Allow double quotes in filenames

2019-12-01 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I think this needs more work, we lost some tolerance here, AFAICS. INLINE COMMENTS > kfilewidget.cpp:1751 > > -const int count = line.count(QLatin1Char('"')); > -if

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-12-01 Thread Nathaniel Graham
ngraham added a comment. In D23384#570118 , @fvogt wrote: > Please try both of the following: Done. Here are the log files: F7793378: kio-fuse.log F7793379: strace output.log

D25599: Fix plugin-metadata translations on windows

2019-12-01 Thread Hannah von Reth
vonreth added a comment. Why can't we use setDefault? Your linked patch does not look like it would change the behaviour on Windows? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25661: Simplify null check

2019-12-01 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R294:4b8609a04c31: Simplify null check (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25661?vs=70687=70688 REVISION DETAIL

D25661: Simplify null check

2019-12-01 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH nulll REVISION DETAIL https://phabricator.kde.org/D25661 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Add member for editbookmarks action

2019-12-01 Thread Nicolas Fella
nicolasfella planned changes to this revision. nicolasfella added a comment. I can do it with the rest of the patch REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25572: [KFileWidget] Allow double quotes in filenames

2019-12-01 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks Méven. I can confirm that it works in Gwenview with no other changes. I have to re-compile Kolourpaint, but then it works from there too. Odd. REPOSITORY R241 KIO BRANCH

D25661: Simplify null check

2019-12-01 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds, Dolphin's bookmark menu stil opens REPOSITORY R294 KBookmarks

D25660: Add member for editbookmarks action

2019-12-01 Thread Aleix Pol Gonzalez
apol added a comment. Maybe this is too of an intermediate step? this patch doesn't really do anything. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25657: Clean up includes

2019-12-01 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R294:a195de5012b1: Clean up includes (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25657?vs=70677=70684 REVISION DETAIL

D25656: Remove unneeded moc include

2019-12-01 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R294:1ee83cf07143: Remove unneeded moc include (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25656?vs=70676=70683 REVISION DETAIL

D25650: Port foreach

2019-12-01 Thread Nicolas Fella
nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:72 > This comment looks wrong Fixed REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25650 To: nicolasfella, #frameworks, apol Cc: apol,

D25659: Add TODO KF6 note

2019-12-01 Thread Aleix Pol Gonzalez
apol added a comment. I'm unsure such comments are useful. :/ Maybe it would work better as a phabricator task or so? REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25659 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25650: Port foreach

2019-12-01 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R263:6ba0d9371f74: Port foreach (authored by nicolasfella). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25650?vs=70664=70682 REVISION DETAIL

D25657: Clean up includes

2019-12-01 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH incl REVISION DETAIL https://phabricator.kde.org/D25657 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25656: Remove unneeded moc include

2019-12-01 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH moc REVISION DETAIL https://phabricator.kde.org/D25656 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

2019-12-01 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:72 > add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00) > # Subdirectories > add_definitions(-DTRANSLATION_DOMAIN=\"kxmlgui5\") This comment

D25660: Add member for editbookmarks action

2019-12-01 Thread Nicolas Fella
nicolasfella added a task: T12056: KBookmarks. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25658: Remove superflous private

2019-12-01 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R294:29139b7b8f66: Remove superflous private (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25658?vs=70678=70681 REVISION DETAIL

D25660: Add member for editbookmarks action

2019-12-01 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY First step towards getting rid of KActionCollection dependency.

D25658: Remove superflous private

2019-12-01 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH pri REVISION DETAIL https://phabricator.kde.org/D25658 To: nicolasfella, #frameworks, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

2019-12-01 Thread Ahmad Samir
ahmadsamir added a comment. IIUC, FILENAME_MAX corresponds to PATH_MAX, 4096 (bytes; or chars in an array). NAME_MAX is the max. filename (the filename part only, without the canonical path) length, this is 255 on Linux. So using FILENAME_MAX is correct in the code. See:

D23457: Port regex search to QRegularExpression

2019-12-01 Thread Ahmad Samir
ahmadsamir added a comment. In D23457#568067 , @dhaumann wrote: > Any news here? For starters, this needs to be rebased; I'll try and get to it soon. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To:

D25599: Fix plugin-metadata translations on windows

2019-12-01 Thread Albert Astals Cid
aacid added a comment. Right, but we set it in initializeLanguages. https://github.com/KDE/kxmlgui/blob/master/src/kswitchlanguagedialog_p.cpp#L81 I think the bug is that initializeLanguages should set the proper stuff in QLocale for windows too. I had this that fixes part of a

D25632: Fix module imports with Python3

2019-12-01 Thread Olivier Churlaud
ochurlaud accepted this revision. ochurlaud added a comment. This revision is now accepted and ready to land. If it still works it's OK to push. REPOSITORY R264 KApiDox BRANCH bugfix/graphvizImportPython3 REVISION DETAIL https://phabricator.kde.org/D25632 To: cordlandwehr, ochurlaud

D25659: Add TODO KF6 note

2019-12-01 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R294 KBookmarks BRANCH toto REVISION DETAIL

  1   2   >