D25939: TypeScript: add "bigint" primitive type

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems fine, thanks! REPOSITORY R216 Syntax Highlighting BRANCH typescript-bigint-type REVISION DETAIL https://phabricator.kde.org/D25939 To: nibags,

D25939: TypeScript: add "bigint" primitive type

nibags created this revision. nibags added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Add the "bigint" type:

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25869 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D24433: Move URL parsing methods from kioslave to query object

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. just nitpicks ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham, astippich, bruns Cc: broulik, bruns,

D24433: Move URL parsing methods from kioslave to query object

bruns added inline comments. INLINE COMMENTS > query.cpp:342 > +QString jsonString = urlQuery.queryItemValue(QStringLiteral("json"), > QUrl::FullyDecoded); > +q = Query::fromJSON(jsonString.toUtf8()); > +} else if (urlQuery.hasQueryItem(QStringLiteral("query"))) { just

D25622: partial solution to accept accentuated characters on windows

This revision was automatically updated to reflect the committed changes. Closed by commit R286:9220e5045687: partial solution to accept accentuated characters on windows (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 219 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/219/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Dec 2019 22:34:38 + Build duration: 10 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 234 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/234/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Dec 2019 22:34:38 + Build duration: 7 min 18 sec and counting BUILD ARTIFACTS

D25937: pic: Fix Invalid-enum-value undefined behaviour

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Instead of directly casting the quint8 to PicChannelEncoding we just store the quint8 and compare it to the possible

D25622: partial solution to accept accentuated characters on windows

vonreth added a comment. In D25622#576498 , @bruns wrote: > Again, #windows does not care ... The team is very small... REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

ngraham edited the summary of this revision. REPOSITORY R245 Solid BRANCH arcpatch-D21204 REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks, ngraham Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, GB_2,

D24433: Move URL parsing methods from kioslave to query object

ngraham accepted this revision. ngraham added a comment. Let's do this unless @bruns objects soon. :) REPOSITORY R293 Baloo BRANCH extend_query_url REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham, astippich Cc: broulik, bruns,

D25414: xattr: fix crash on dangling symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4bb4195a6fc6: xattr: fix crash on dangling symlinks (authored by iasensio). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25414?vs=70035=71397 REVISION

D25622: partial solution to accept accentuated characters on windows

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Again, #windows does not care ... REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D25622 To:

D25934: [xattr] Fix passing negative size to QByteArray

anthonyfieroni abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25934 To: anthonyfieroni, bruns, astippich Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

bruns added a comment. please remove the 2 comments. REPOSITORY R245 Solid BRANCH arcpatch-D21204 REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks, ngraham Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n,

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > fstabhandling.cpp:246 > +if (deviceName.endsWith(QLatin1Char('/'))) { > +// remove trailing slash > +deviceName.chop(1); This comment is

D25934: [xattr] Fix passing negative size to QByteArray

bruns added a comment. Duplicate of D25414 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25934 To: anthonyfieroni, bruns, astippich Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,

D25414: xattr: fix crash on dangling symlinks

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fix_symlink REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,

D25516: Remove unrequired private declarations for taglibextractor

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH cleanupTagLib REVISION DETAIL https://phabricator.kde.org/D25516 To: astippich, #baloo, bruns, ngraham, mgallien Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

D25934: [xattr] Fix passing negative size to QByteArray

anthonyfieroni created this revision. anthonyfieroni added reviewers: bruns, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY CCBUG: 414227 TEST PLAN Not tested

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:323 > Could we have a kill switch for KIOFuse if it fails to work properly in some > release? > > E.g. some `export KIO_FUSE=0` or `export KIO_FUSE_DISABLE=1`. > Or a KConfig entry (use

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#572363 , @dfaure wrote: > Why does KRun duplicate all of the (new) code from DesktopExecParser, when DesktopExecParser is actually a helper class for KRun? > I would expect it to have solved all this

D25902: Fix decrement index and not iterator as discussed with David

This revision was automatically updated to reflect the committed changes. Closed by commit R320:6f1b8a6c61d8: Fix decrement index and not iterator as discussed with David (authored by mlaurent). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

fvogt added a comment. This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25902: Fix decrement index and not iterator as discussed with David

dfaure accepted this revision. dfaure added a comment. We can thank Qt for deprecating QHash::iterator::operator-- which allowed Laurent to catch this :-) REPOSITORY R320 KIO Extras BRANCH fix_kioslave_notifier (branched from master) REVISION DETAIL https://phabricator.kde.org/D25902

D25902: Fix decrement index and not iterator as discussed with David

anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH fix_kioslave_notifier (branched from master) REVISION DETAIL https://phabricator.kde.org/D25902 To: mlaurent, dfaure, anthonyfieroni Cc: anthonyfieroni,

D25902: Fix decrement index and not iterator as discussed with David

mlaurent added a comment. Ping ?:) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25902 To: mlaurent, dfaure Cc: anthonyfieroni, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in ksortfilterproxymodel.h:44 > Did you try that `QRegularExpression` vs `QRegExp` thing? We did some research - Old Qt which we support doesn't convert JS to QRegularExpresssion - We don't want to write new code with

D25296: [RFC] Fix Display Configuration icon margins

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5172b920f9e1: [RFC] Fix Display Configuration icon margins (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25924: fix static linking on e.g. macOS

cullmann abandoned this revision. cullmann added a comment. Let's just close that. If I have enough time somewhen, will report a Qt bug (or try .1) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25924 To: cullmann, vkrause Cc: kwrite-devel,

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

broulik added inline comments. INLINE COMMENTS > ksortfilterproxymodel.h:2 > +/* > + * Copyright 2010 by Marco MArtin > + *Martin > ksortfilterproxymodel.h:44 > + */ > +Q_PROPERTY(QString filterRegExp READ filterRegExp WRITE setFilterRegExp > NOTIFY filterRegExpChanged) > + Did

D25296: [RFC] Fix Display Configuration icon margins

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-xrandr-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D25296 To: ngraham, #vdg, ndavis Cc: trickyricky26, kde-frameworks-devel,

D25877: [KColorschemeManager] Add option to reenable following global theme

ngraham added a comment. Yeah, I guess my idea precludes the user forcing a specific color scheme that happens to be equal to the current system default color scheme. If that's something we think we should support, then feel free to ignore me. REPOSITORY R265 KConfigWidgets REVISION

D25924: fix static linking on e.g. macOS

cullmann added a comment. If you think that is just a Qt issue, we can close this again =) In-house we will just patch this :-0 Debugging the static linking in Qt is too much work. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25924 To: cullmann,

D25927: [PC3] Complete plasma progress bar animation

davidedmundson added a reviewer: filipf. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25927 To: davidedmundson, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25926: [PC3] Only show progress bar indicator when the ends won't overlap

davidedmundson added a reviewer: filipf. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25926 To: davidedmundson, #plasma, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25927: [PC3] Complete plasma progress bar animation

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwside if we toggle indeterminate the bar resizes to 50% of the view and X stops on the current

D25926: [PC3] Only show progress bar indicator when the ends won't overlap

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY If the width is smaller than LeftMargin + Right Margin the two

D25924: fix static linking on e.g. macOS

cullmann added a comment. Therefore I made this review request ;) For me, for Qt 5.14 static linked, it doesn't seem to propagate. I am not sure why that worked before thought. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25924 To: cullmann,

D25924: fix static linking on e.g. macOS

vkrause added a comment. This looks wrong though, QtNetwork is not used in the public interface, is it? And the cmake config files are supposed to propagate private link libraries in case of static linking too I think, otherwise LINK_PRIVATE could basically never work, no? REPOSITORY

D25924: fix static linking on e.g. macOS

cullmann created this revision. cullmann added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY Before, linking fails for me here (static Qt) TEST PLAN make

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added a comment. Also if then the color scheme is changed while the application is running it would display "Breeze (system default)" checked, breeze dark is unchecked but the app is dark because breeze dark is the global color scheme. I think it should be possible to use

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added a comment. But isn't that going away from the problem that this is trying to solve? To have an option to go back from a fixed colorscheme to the system one. Also I'm sure it can be done I just need to figure out how stuff works :D REPOSITORY R265 KConfigWidgets REVISION

D25877: [KColorschemeManager] Add option to reenable following global theme

ngraham added a comment. Then maybe we could even do it like so: Instead of having a separate "use system default" option, we could make the color scheme that has the same name as the default into the "use system default option, and present it thusly in the menu: ( ) Arc ( )

D25922: Don't use a verified nullptr as a data source

leinir added reviewers: Frameworks, KNewStuff, Plasma, ronaldv. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D25922 To: leinir, #frameworks, #knewstuff, #plasma, ronaldv Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25922: Don't use a verified nullptr as a data source

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Actually use some variables with usable information in version.h Don't de-reference what will at this point

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added a comment. In D25877#576205 , @ngraham wrote: > Is there actually a way for this to see the name of the system color scheme? I think so. We can certainly see the name of the system color scheme at startup. The tricky thing

D25918: Consistently define the tooltip delay

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH coco REVISION DETAIL https://phabricator.kde.org/D25918 To: apol, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

ngraham added a comment. Is there actually a way for this to see the name of the system color scheme? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added a task: T12147: KConfigWidgets. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 71355. davidre added a comment. Really fix typo REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=71354=71355 BRANCH systemthem (branched from master) REVISION DETAIL

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 71354. davidre added a comment. Typo REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=71353=71354 BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 71353. davidre added a comment. Fix things, new api + documentation REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=71347=71353 BRANCH systemthem (branched from master) REVISION DETAIL

D25918: Consistently define the tooltip delay

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Set the right value on the Kirigami.Units and use it from tooltip. REPOSITORY R242 Plasma

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 71347. davidre added a comment. Update REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=71261=71347 BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877

D25296: [RFC] Fix Display Configuration icon margins

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25296 To: ngraham, #vdg, ndavis Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25296: [RFC] Fix Display Configuration icon margins

ngraham updated this revision to Diff 71346. ngraham added a comment. Finally fix this thing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25296?vs=69815=71346 BRANCH fix-xrandr-icon (branched from master) REVISION DETAIL

D25914: Remove ColorSchemeFilter from KStyle

This revision was automatically updated to reflect the committed changes. Closed by commit R252:9fc5bade9c26: Remove ColorSchemeFilter from KStyle (authored by davidre). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25914?vs=71342=71344

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

davidre abandoned this revision. davidre added a comment. Abandoned in favor of D25915 REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25875 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25914: Remove ColorSchemeFilter from KStyle

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH remove (branched from master) REVISION DETAIL https://phabricator.kde.org/D25914 To: davidre, #plasma, #frameworks, davidedmundson Cc:

D25914: Remove ColorSchemeFilter from KStyle

davidre created this revision. davidre added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY The code is duplciated in plasma-integration. According to the summary of

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre planned changes to this revision. davidre added a comment. Make it a standalone diff REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

davidre edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25875 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

davidre added a comment. Maybe a better place to do this would be plasma-integration? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25875 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

ngraham added a comment. The straight lines in the system tray items from my screenshot are definitely 1px strokes. But all the curved lines look thicker by virtue of not being able to align to the pixel grid. And most monochrome widgets have thicker lines when added to a tall panel:

D25149: Add a new template for KCMs

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > %{APPNAMELC}settings.kcfg:8 > + > + > + The Exam Now that I think about it, what about using both key and name here? To have a nice property name