D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

crossi added inline comments. INLINE COMMENTS > davidedmundson wrote in managedconfigmodule.cpp:43 > Any reason for doing this approach rather than connecting to QObject:: > destroyed and cleaning the list as we go? Sort of a guard if one registers manually a KCoreConfigSkeleton and then

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 71703. meven added a comment. Fix Two references to KF 5.65 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=71702=71703 BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 71702. meven added a comment. Fix Two references to KF 5,65 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=71701=71702 BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 71701. meven added a comment. Rebase for kio 5.66 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70669=71701 BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED FILES

D26062: Port to QRandomGenerator

mlaurent added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26062 To: mlaurent, dfaure Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D26062: Port to QRandomGenerator

mlaurent created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY qrand is deprecated in qt5.15 REPOSITORY R293 Baloo BRANCH remove_qrand (branched from master)

D26061: QHash::insertMulti is deprecated

mlaurent added a reviewer: dfaure. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26061 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26061: QHash::insertMulti is deprecated

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QHash::insertMulti is deprecated in qt5.15 TEST PLAN autotest ok REPOSITORY R304 KNewStuff BRANCH

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without qrandr TEST PLAN autotest ok REPOSITORY R243 KArchive BRANCH port_qrandomgenerator (branched

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

mlaurent added a reviewer: dfaure. mlaurent removed R243 KArchive as the repository for this revision. REVISION DETAIL https://phabricator.kde.org/D26060 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25716: [KPropertiesDialog] Show extra fields

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25716 To: broulik, #frameworks, #vdg, dfaure, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25716: [KPropertiesDialog] Show extra fields

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25716 To: broulik, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26055: Enable wheel events on Slider {}

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D26055 To: apol, #plasma, broulik, davidedmundson Cc: davidedmundson, kde-frameworks-devel,

D26055: Enable wheel events on Slider {}

davidedmundson added a comment. > Used it with a test. What test? I just noticed it's missing from p-f/tests/components REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26055 To: apol, #plasma, broulik Cc: davidedmundson,

D26057: Deprecate the top-level IconSize() function

vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D26057 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This removes the last of the non-namespaced top-level functions here as well. REPOSITORY R302 KIconThemes BRANCH

D25530: Sonnet: Add locales that are missing in QLocale

waqar abandoned this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25530 To: waqar Cc: cullmann, aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added a comment. ping REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

meven resigned from this revision. meven added a comment. This revision now requires review to proceed. Leave the first reviewer position to someone else. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26046 To: crossi, #plasma, #frameworks, ervin, bport,

D26047: Expose KConfig settings to allow registration in KCM Notification

meven resigned from this revision. meven added a comment. This revision now requires review to proceed. Someone else should valide this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26047 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson,

D26055: Enable wheel events on Slider {}

apol created this revision. apol added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY So far PC3 version of the slider doesn't react to events, this change enables it.

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

davidedmundson added a comment. Generally +1 INLINE COMMENTS > managedconfigmodule.cpp:43 > ManagedConfigModule *_q; > -QList _skeletons; > +QList> _skeletons; > }; Any reason for doing this approach rather than connecting to QObject:: destroyed and cleaning the list as we

D26054: partial fix for accentuated characters in file name on Windows

mgallien updated this revision to Diff 71684. mgallien added a comment. sorry for the mess in the previous patch REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26054?vs=71683=71684 BRANCH fixWriterAccentuatedFileName REVISION DETAIL

D26044: Set breeze as default theme when reading from configuration file

apol added a comment. LGTM otherwise INLINE COMMENTS > kiconloader.cpp:564 > const QString newThemeName = sharedConfig->group("Icons") > - .readEntry("Theme", > QString()); > +

D26054: partial fix for accentuated characters in file name on Windows

mgallien created this revision. mgallien added reviewers: bruns, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY partial fix to try to get accentuated file names to work with

D26047: Expose KConfig settings to allow registration in KCM Notification

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26047 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart, meven Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Code looks sane to me. One nitpick INLINE COMMENTS > managedconfigmodule.h:205 > + * After manual registration on the fly, > + * it may be needed to call settingsChanged() > +

D25865: kfilemetadata EBN transport protocol cleanup

jhayes added a comment. You're right, can we just close this? John REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25865 To: jhayes Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi created this revision. crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY For KCM Notification, allow to register the generated

D26043: Add edit mode menu item to desktop widget context menu

GB_2 updated this revision to Diff 71675. GB_2 added a comment. Remove space REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26043?vs=71674=71675 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26043 AFFECTED FILES

D26043: Add edit mode menu item to desktop widget context menu

GB_2 updated this revision to Diff 71674. GB_2 added a comment. Decrease line count REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26043?vs=71670=71674 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26043 AFFECTED

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

crossi created this revision. crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. crossi requested review of this revision. REVISION SUMMARY Helpful for derived class that do not

D26043: Add edit mode menu item to desktop widget context menu

GB_2 added a reviewer: mart. GB_2 added a subscriber: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg, mart Cc: mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

bport added a dependent revision: D24846: Port kcm icons to kconfigxt. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D26044 To: bport, #plasma, ervin, crossi Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

bport created this revision. bport added reviewers: Plasma, ervin, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Icons KCM is moved to KConfigXT, default value is "breeze" and in that case

D26043: Add edit mode menu item to desktop widget context menu

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY - much improves discoverability of the ability to move added widgets without clicking and

D26043: Add edit mode menu item to desktop widget context menu

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 71666. feverfew added a comment. fix indentation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=71543=71666 BRANCH arcpatch-D23384_1 REVISION DETAIL https://phabricator.kde.org/D23384 AFFECTED FILES

D26013: [KeySequenceHelper] Grab actual window when embedded

davidre accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26013 To: broulik, #plasma, davidre Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Dec 2019 12:53:26 + Build duration: 1 min 4 sec and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/46/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Dec 2019 12:51:13 + Build duration: 1 min 34 sec and counting JUnit Tests Name:

D23551: CMake config files: use as dep version the Qt one built against (private API)

kossebau abandoned this revision. kossebau added a comment. Discarding with same reason as given here: D23550#578745 One day someone else will do this in a similar way, I am sure ;) REPOSITORY R263 KXmlGui REVISION DETAIL

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau abandoned this revision. kossebau added a comment. Oh well, seems no-one else sees the light yet ;) Given this IMHO wrong data in the current CMake config files does not do actual harm in 99.9 % cases I will discard this for now, and just do it correctly (for what I see) only in my

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/48/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 16 Dec 2019 09:04:30 + Build duration: 3 min 18 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/83/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Dec 2019 09:04:30 + Build duration: 3 min 20 sec and counting JUnit Tests Name: