D26112: Clean up unnecessary code

This revision was automatically updated to reflect the committed changes. Closed by commit R245:38c99f154ad3: Clean up unnecessary code (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26112?vs=71859=71925 REVISION DETAIL

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/49/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 07:38:59 + Build duration: 2 min 14 sec and counting JUnit Tests Name:

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

dfaure added a comment. Part-loading discussion continues in https://phabricator.kde.org/T12173. Meanwhile this review request is about application lookup :) REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25698 To: dfaure, broulik, mart, vkrause, nicolasfella

D26137: Add KPluginMetaData::supportsMimeType

dfaure created this revision. dfaure added reviewers: arichardson, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This will be useful to look up KParts using KPluginLoader::findPlugins.

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH port_qrandomgenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26060 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26062: Port to QRandomGenerator

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH remove_qrand (branched from master) REVISION DETAIL https://phabricator.kde.org/D26062 To: mlaurent, dfaure Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,

D26123: Port QRegExp to QRegularExpression

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kemailaddresstest.cpp:345 > QFETCH(bool, expResult); > - > QCOMPARE(isValidSimpleAddress(input), expResult); unrelated and the empty line made

D26136: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: Frameworks. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R265 KConfigWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26133: Enable Auto Save

tcanabrava updated this revision to Diff 71920. tcanabrava added a comment. - Use a timer of 1s to trigger the save REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26133?vs=71916=71920 BRANCH enableAutoSave REVISION DETAIL

D26133: Enable Auto Save

ngraham edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26133 To: tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26133: Enable Auto Save

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Some applications don't want the `wait for apply / ok / cancel` and prefer to automatically save the settings

D26130: Simplify return logic

patrickelectric accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH simplifyVarPath REVISION DETAIL https://phabricator.kde.org/D26130 To: tcanabrava, patrickelectric Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26131: Braces around for, break early.

patrickelectric added inline comments. INLINE COMMENTS > kconfig_compiler.cpp:619 > bool isAscii = true; > -for (int i = s.length(); i--;) > +for (int i = s.length(); i--;) { > if (s[i].unicode() > 127) { std::any_of ? REPOSITORY R237 KConfig REVISION DETAIL

D26122: Add utility text function KShell::tildeCollapse

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26131: Braces around for, break early.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Recompiled, Run Unittests REPOSITORY R237 KConfig BRANCH nitpicksLiteralString REVISION DETAIL

D26130: Simplify return logic

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Don't create a temporary to edit and return, return something directly, this way we can benefit from RTO

D26129: Remove Iterator based loops for range based loops

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Compiled and run the unittests REPOSITORY R237 KConfig BRANCH rangeBasedFor REVISION DETAIL

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Recompiled and run the unittests REPOSITORY R237 KConfig BRANCH simplifyDefaultValue REVISION DETAIL

D26127: Simplify cppType method: Return Early, Use a Map and Assert.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Recompiled and runned the unittests REPOSITORY R237 KConfig BRANCH simplifyCppType REVISION DETAIL

D26126: Simplify param method: Return Early, Use a Map and Assert.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Recompiled and runned the unittests REPOSITORY R237 KConfig BRANCH simplifyParam REVISION DETAIL

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71907. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. One more QRegExp REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71900=71907 BRANCH l-qregexp (branched from master)

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/54/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Dec 2019 18:11:40 + Build duration: 2 min 6 sec and counting JUnit Tests Name:

D25789: Correctly report if baloo_file is unavailable

This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R293:76b81a614f10: Correctly report if baloo_file is unavailable (authored by davidedmundson). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 130 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/130/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Dec 2019 17:58:20 + Build duration: 4 min 24 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/78/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Dec 2019 17:58:20 + Build duration: 3 min 25 sec and counting JUnit Tests Name:

D25878: Use clearer relative dates

This revision was automatically updated to reflect the committed changes. Closed by commit R244:9ab008f6b583: Use clearer relative dates (authored by ngraham). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25878?vs=71276=71903 REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

ngraham added a comment. Awesome. Does this need a rebase? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc: lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino,

D26123: Port QRegExp to QRegularExpression

ahmadsamir planned changes to this revision. ahmadsamir added a comment. I missed one QRegExp. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26123 To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26123: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, mlaurent, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY I had to modify the regex pattern slightly to make kemailaddresstest pass TEST PLAN make &&

D26122: Add utility text function KShell::tildeCollapse

meven created this revision. meven added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN ctest REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

meven added a comment. In D17595#569924 , @lydia wrote: > For posterity's sake: > > I confirm that we have confirmation to the board list from (hope I didn't overlook anyone): > > - Emmanuel Pescosta > - Roman Inflianskas > -

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71888. ahmadsamir removed a subscriber: mlaurent. ahmadsamir added a comment. Revert min required Qt version REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71869=71888 BRANCH l-qregexp (branched from

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Dec 2019 12:44:19 + Build duration: 12 min and counting JUnit Tests Name:

D26099: Port QRegExp to QRegularExpression

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:3 > cmake_minimum_required(VERSION 3.5) > -set(REQUIRED_QT_VERSION 5.11.0) > +set(REQUIRED_QT_VERSION 5.12.0) > set(KF5_VERSION "5.66.0")

D26101: Port away from Qt 5.14 deprecated QList methods

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e1ad18533db3: Port away from Qt 5.14 deprecated QList methods (authored by ahmadsamir). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26101?vs=71837=71885 REVISION

D26118: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71884. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Don't touch Qt required version directly for frameworks. Use \A and \z anchors instead of the convenience function QRegularExpression::anchoredPattern() REPOSITORY

D26118: Port QRegExp to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:14 > kauth is a framework package. You can't increase qt version directly. I didn't know that, sorry. Luckily fixing it is easy in this particular case, I'll anchor

D26116: Reduce timeout when trying to connect to an app dbus interface

meven added a comment. In D26116#580539 , @davidedmundson wrote: > > Encountered this issue while testing krunner. > > Can you expand on this, so I can see what problem we're actually trying to solve. I had a "org.kde.krunner"

D26116: Reduce timeout when trying to connect to an app dbus interface

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > I would say any application that does not respond in 5 seconds is buggy, or at least in a bad state. That's not necessarily true. We're asking an app to

D26116: Reduce timeout when trying to connect to an app dbus interface

meven added a comment. In D26116#580480 , @broulik wrote: > I'd say 5 seconds is optimistic. Granted. 10 seconds maybe. > Does Kate's session selection dialog still block startup? I am not aware of this. REPOSITORY R271

D26112: Clean up unnecessary code

meven edited the summary of this revision. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D26112 To: meven, #frameworks, bruns, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26112: Clean up unnecessary code

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Don't make this `GIT_SILENT`, please REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D26112 To: meven, #frameworks, bruns, broulik Cc: broulik,

D26113: Places: For mounted volume display mount points instead of description

broulik added a comment. Not a fan of this special handling in Places. Also I think it should stay with the remote path as the fact that it's mounted locally somewhere is only an implementation detail. > Short name (mount point) should be used or this should at least be configurable.

D26116: Reduce timeout when trying to connect to an app dbus interface

broulik added a comment. I'd say 5 seconds is optimistic. Does Kate's session selection dialog still block startup? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D26116 To: meven, #frameworks, davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2,

D17205: Build kio_nfs against standalone libtirpc

meven added a comment. ping @asturmlechner REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D17205 To: asturmlechner, #dolphin, dfaure, rdieter Cc: meven, sitter, kde-frameworks-devel, cgiboudeaux, arojas, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:14 > > -set(REQUIRED_QT_VERSION 5.11.0) > +set(REQUIRED_QT_VERSION 5.12.0) > find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED

D25506: Remove Attica from KAboutDialog

leinir added a comment. Right, with the influx of blog entries, a chat with Kai Uwe and a bit of mental distance to it, it is a bit clearer precisely why this stuff is being attempted. So, i'm entirely in favour of narrowing the hard dependencies in Frameworks in general, and in that

D26101: Port away from Qt 5.14 deprecated QList methods

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH l-qt14-deprecated (branched from master) REVISION DETAIL https://phabricator.kde.org/D26101 To: ahmadsamir, #baloo, meven, bruns, astippich, dfaure Cc: alexeymin,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

broulik added a reviewer: ahartmetz. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26017 To: broulik, #frameworks, davidedmundson, ahartmetz Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Require Qt 5.12 for QRegularExpression::anchoredPattern() TEST PLAN make && ctest REPOSITORY R283 KAuth

D26117: [solid] Clarify referencing of DeviceInterface

anthonyfieroni edited the summary of this revision. anthonyfieroni edited the test plan for this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26117 To: anthonyfieroni, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26117: [solid] Clarify referencing of DeviceInterface

broulik added a reviewer: bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26117 To: anthonyfieroni, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26117: [solid] Clarify referencing of DeviceInterface

anthonyfieroni created this revision. anthonyfieroni added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY DeviceInterface should be treated as weak object, also let he

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71869. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Use QRegularExpression::anchoredPattern() to port QRegExp::exactMatch() REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 231 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/231/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Dec 2019 07:59:17 + Build duration: 8 min 1 sec and counting JUnit Tests Name: