Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-21 Thread Friedrich W. H. Kossebau
Am Samstag, 21. Dezember 2019, 23:32:10 CET schrieb Stephen Kelly: > On 21/12/2019 19:12, Friedrich W. H. Kossebau wrote: > > Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly: > >> Great, Grantlee is now available at g...@git.kde.org:grantlee.git. > >> > >> I've pushed a few

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-21 Thread Stephen Kelly
On 21/12/2019 19:12, Friedrich W. H. Kossebau wrote: Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly: Great, Grantlee is now available at g...@git.kde.org:grantlee.git. I've pushed a few commits to make it depend on ECM etc. Once the review period is finished it can be

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-21 Thread Stephen Kelly
On 21/12/2019 21:33, Volker Krause wrote: * Attracting external components and having them opt to move under the Frameworks umbrella is a sign that we are doing things right IMHO. So let's make this easy for people and avoid scaring off their users by forcing a larger migration on them when

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-21 Thread David Redondo
davidre updated this revision to Diff 71976. davidre added a comment. remove qdebug REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=71975=71976 BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-21 Thread David Redondo
davidre updated this revision to Diff 71975. davidre added a comment. Remove stuff that was just for testing and included in the diff by mistake REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=71974=71975 BRANCH systemthem (branched from

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-21 Thread Volker Krause
On Saturday, 21 December 2019 20:12:48 CET Friedrich W. H. Kossebau wrote: > Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly: > > Great, Grantlee is now available at g...@git.kde.org:grantlee.git. > > > > I've pushed a few commits to make it depend on ECM etc. > > > > Once the

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-21 Thread David Redondo
davidre updated this revision to Diff 71974. davidre added a comment. This revision is now accepted and ready to land. remove comment REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=71355=71974 BRANCH systemthem (branched from master)

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-21 Thread David Redondo
davidre added a comment. Nevermind confused myself, I was not changing the `UserRole` data but the data of the actions of the menu. For that there are no guarantees documented. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks,

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-21 Thread David Redondo
davidre planned changes to this revision. davidre added a comment. Changing the `UserRole` is not the best REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D21783: Show more details in warning dialog shown before starting a privileged operation

2019-12-21 Thread Nathaniel Graham
ngraham retitled this revision from "[WIP]Show more details in warning dialog shown before starting a privileged operation" to "Show more details in warning dialog shown before starting a privileged operation". REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

2019-12-21 Thread David Faure
dfaure added a comment. (remember to remove the [WIP] from the commit log, if you still have it locally) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel,

D24568: Provide clang-format target with a KDE Frameworks style file

2019-12-21 Thread Christoph Cullmann
cullmann added a comment. In D24568#580338 , @kossebau wrote: > This has been missing the link from an rst file in docs/, so the documentation generation picks up the file. Fixed with c4890d5c03ed79f0c87da861b6608bbd46c2162c

D26113: Places: For mounted volume display mount points instead of description

2019-12-21 Thread Nathaniel Graham
ngraham added a comment. In D26113#581227 , @bruns wrote: > The mount path is the only useful identifier. There is no filesystem label or similar. > > As Vaults are not backed by an fstab entry, it would be the responsibility of Vaults to

D26113: Places: For mounted volume display mount points instead of description

2019-12-21 Thread Stefan Brüns
bruns added a comment. The mount path is the only useful identifier. There is no filesystem label or similar. As Vaults are not backed by an fstab entry, it would be the responsibility of Vaults to set a useful name (via x-gvfs-name). REPOSITORY R241 KIO REVISION DETAIL

CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-21 Thread Friedrich W. H. Kossebau
Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly: > Great, Grantlee is now available at g...@git.kde.org:grantlee.git. > > I've pushed a few commits to make it depend on ECM etc. > > Once the review period is finished it can be part of KF5 releases. There are quite some things

D26146: Delete icon

2019-12-21 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R293:77058387f41c: Delete icon (authored by ngraham). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26146?vs=71960=71971 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 234 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/234/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 18:56:27 + Build duration: 12 min and counting JUnit Tests Name: projectroot

D25683: KDirOperator: Use a fixed line height for scroll speed

2019-12-21 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:59b944470470: KDirOperator: Use a fixed line height for scroll speed (authored by ahiemstra, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26148: Add truncation support to FileJob

2019-12-21 Thread Alexander Saoutkin
feverfew created this revision. feverfew added reviewers: fvogt, dfaure, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY This patch adds support for truncation for FileJob. It also

D26146: Delete icon

2019-12-21 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH delete-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D26146 To: ngraham, #baloo, #vdg, IlyaBizyaev, ndavis Cc: kde-frameworks-devel, hurikhan77,

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2019-12-21 Thread Nathaniel Graham
ngraham added a comment. I'm using your Dolphin branch but I don't see it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26067 To: broulik, #frameworks, #vdg, #dolphin Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26146: Delete icon

2019-12-21 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Baloo, VDG, IlyaBizyaev. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY There's a Breeze icon now, so we don't need to ship an old,

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2019-12-21 Thread Kai Uwe Broulik
broulik added a comment. I added icon size context menu in dolphin REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26067 To: broulik, #frameworks, #vdg, #dolphin Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2019-12-21 Thread Nathaniel Graham
ngraham added a comment. One thing I notice has been lost is the ability to choose the size of the icons. Dolphin currently exposes this in the context menu for places panel headers. The File dialog does something different and automatically resizes the icons according to how much vertical

D26145: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: mlaurent, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY With QRegularExpression \x escape sequences that use more than two hex digists have be in the form \x{}.

D26113: Places: For mounted volume display mount points instead of description

2019-12-21 Thread Nathaniel Graham
ngraham added a comment. We can make the name override more discoverable for sure. But IMO we should also improve the default presentation, because this is just yucky: F7828189: Screenshot_20191221_092825.png None of my other mounted devices insist

D26044: Set breeze as default theme when reading from configuration file

2019-12-21 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D26044 To: bport, #plasma, ervin, crossi, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

2019-12-21 Thread Benjamin Port
bport marked 2 inline comments as done. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D26044 To: bport, #plasma, ervin, crossi Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

2019-12-21 Thread Benjamin Port
bport updated this revision to Diff 71955. bport added a comment. QString to QStringLiteral REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26044?vs=71671=71955 REVISION DETAIL https://phabricator.kde.org/D26044 AFFECTED FILES src/kiconloader.cpp

D26099: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir marked an inline comment as done. ahmadsamir added a comment. I guess I was confused because I saw KItemModels has the min. Qt version 5.12.0 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent

D26099: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71954. ahmadsamir added a comment. Don't assign inside if condition REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71943=71954 BRANCH l-qregexp (branched from master) REVISION DETAIL

D26113: Places: For mounted volume display mount points instead of description

2019-12-21 Thread Méven Car
meven added a comment. In D26113#581021 , @bruns wrote: > I would consider an item changing its name based on the state a bug. > > As said, the name *is*configurable. I am leaning towards abandoning this and D26114

D26099: Port QRegExp to QRegularExpression

2019-12-21 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > timelinetools.cpp:119 > +QRegularExpressionMatch match; > +if ((match = s_dateRegexp.match(sections.last())).hasMatch()) { > dateString = sections.last(); Pleae avoid assigning in an `if (...)` expression, just move it

D26118: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71948. ahmadsamir added a comment. KF5 now requires Qt 5.12 REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26118?vs=71884=71948 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26117: [solid] Clarify referencing of DeviceInterface

2019-12-21 Thread Stefan Brüns
bruns added a comment. I think the Summary is very poor. You only give a phenomenological reason (it no longer crashes), but thats insufficient. State what happens without the change (i.e. who owns what), and why doing it differently is **always** correct. Giving a good summary

D26117: [solid] Clarify referencing of DeviceInterface

2019-12-21 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26117 To: anthonyfieroni, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

2019-12-21 Thread Stefan Brüns
bruns added a comment. I would consider an item changing its name based on the state a bug. As said, the name *is*configurable. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham Cc: bruns, broulik, kde-frameworks-devel,

Re: Submitting Grantlee as a KF5 Framework

2019-12-21 Thread laurent Montel
Le samedi 21 décembre 2019, 13:03:17 CET Stephen Kelly a écrit : > On 08/12/2019 10:12, laurent Montel wrote: > > Le dimanche 8 décembre 2019, 10:52:19 CET Volker Krause a écrit : > >> Hi, > >> > >> very happy to see Grantlee "coming home" :) > >> > >> Technically I think it's largely in line

D26099: Port QRegExp to QRegularExpression

2019-12-21 Thread Méven Car
meven accepted this revision. meven added a comment. Seems fine to me REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,

D26099: Port QRegExp to QRegularExpression

2019-12-21 Thread Méven Car
meven added a comment. In D26099#581001 , @ahmadsamir wrote: > Frameworks now require Qt 5.12 Indeed since 65da5bf151fa934bbdcac82543e3cd9f5cc4ab43 in baloo

Re: Submitting Grantlee as a KF5 Framework

2019-12-21 Thread Friedrich W. H. Kossebau
Hi Stephen, Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly: > Great, Grantlee is now available at g...@git.kde.org:grantlee.git. > > I've pushed a few commits to make it depend on ECM etc. You pushed only to github though it seems :) Forwarded your commits now to the master

D26106: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #frameworks, #framework_syntax_highlighting Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26099: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71943. ahmadsamir added a comment. Frameworks now require Qt 5.12 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71936=71943 BRANCH l-qregexp (branched from master) REVISION DETAIL

D26123: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71941. ahmadsamir added a comment. Frameworks min. required Qt has just been raised to 5.12 REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71934=71941 BRANCH l-qregexp (branched from master) REVISION

D26123: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir added a comment. Sorry, I did reply to your inline comments but didn't "submit" the replies only "save draft"ed. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26123 To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel,

D26123: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kemailaddress.cpp:631 > Message from Giuseppe D'Angelo (author of QRegularExpression) : if you can > depend from Qt 5.12, there's QRegularExpression::anchoredPattern instead of > manual wrapping in \A and \z > > We can't

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 48 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/48/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Dec 2019 11:38:08 + Build duration: 1 hr 3 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 233 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/233/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 12:02:42 + Build duration: 37 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/50/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:39:25 + Build duration: 48 min and counting JUnit Tests Name: projectroot

D26123: Port QRegExp to QRegularExpression

2019-12-21 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > dfaure wrote in kemailaddress.cpp:639 > `{,3}` would be `{0,3}`, not `{1,3}` > > Would this allow to minimize the amount of changes made here? I'm worried >

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:38:07 + Build duration: 39 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.13 - Build # 36 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.13/36/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Dec 2019 11:32:41 + Build duration: 44 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 90 - Fixed!

2019-12-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/90/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Dec 2019 11:38:07 + Build duration: 29 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:37:06 + Build duration: 28 min and counting JUnit Tests Name: projectroot

Re: Submitting Grantlee as a KF5 Framework

2019-12-21 Thread Stephen Kelly
On 08/12/2019 10:12, laurent Montel wrote: Le dimanche 8 décembre 2019, 10:52:19 CET Volker Krause a écrit : Hi, very happy to see Grantlee "coming home" :) Technically I think it's largely in line with Frameworks requirements already, and it has been reliably powering e.g. KMail's message

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 232 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/232/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:35:30 + Build duration: 27 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/46/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:36:41 + Build duration: 26 min and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:35:16 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:33:43 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:33:54 + Build duration: 13 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 131 - Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/131/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Dec 2019 11:33:12 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/79/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:33:12 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.12 - Build # 64 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.12/64/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Dec 2019 11:32:41 + Build duration: 11 min and counting BUILD ARTIFACTS

Frameworks minimum Qt version raised to 5.12

2019-12-21 Thread Albert Astals Cid
I just executed the policy that says last three Qt versions, i.e. 5.12, 5.13 and 5.14 Cheers, Albert P.S: Since we have the new Qt LTS exception to the policy we won't be raising the minimum requirement until Qt 5.16 is released (assuming Qt 5.15 is LTS and there is a Qt 5.16) and then we

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:32:28 + Build duration: 9 min 52 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcodecs » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:32:40 + Build duration: 8 min 51 sec and counting JUnit Tests Name:

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Fixed!

2019-12-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/56/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 11:31:24 + Build duration: 4 min 52 sec and counting JUnit Tests Name:

D26099: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71936. ahmadsamir added a comment. Add TODO for when we can depend on Qt 5.12 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71888=71936 BRANCH l-qregexp (branched from master) REVISION DETAIL

D26106: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir added a reviewer: Framework: Syntax Highlighting. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #framework_syntax_highlighting Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

2019-12-21 Thread Ahmad Samir
ahmadsamir added a reviewer: mlaurent. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26102 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D26123: Port QRegExp to QRegularExpression

2019-12-21 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71934. ahmadsamir marked 4 inline comments as done. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address review comments REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE

D26138: qrand is deprecated. Port to QRandomGenerator

2019-12-21 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R235:fb25d833103b: qrand is deprecated. Port to QRandomGenerator (authored by mlaurent). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26138?vs=71929=71930 REVISION

D26138: qrand is deprecated. Port to QRandomGenerator

2019-12-21 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH port_to_QRandomGenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26138 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Unstable!

2019-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/55/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Dec 2019 08:22:51 + Build duration: 13 min and counting JUnit Tests Name:

D26138: qrand is deprecated. Port to QRandomGenerator

2019-12-21 Thread Laurent Montel
mlaurent edited the test plan for this revision. mlaurent added a reviewer: dfaure. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D26138 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26138: qrand is deprecated. Port to QRandomGenerator

2019-12-21 Thread Laurent Montel
mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QRandomGenerator REPOSITORY R235 Attica BRANCH port_to_QRandomGenerator (branched from master)

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-21 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R243:82fdd07d387d: Port to QRandomGenerator (qrand was deprecated in qt5.15) (authored by mlaurent). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE

D26062: Port to QRandomGenerator

2019-12-21 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R293:b5c7c6b7012a: Port to QRandomGenerator (authored by mlaurent). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26062?vs=71829=71927 REVISION DETAIL