D26137: Add KPluginMetaData::supportsMimeType

2019-12-22 Thread David Faure
dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26137 To: dfaure, arichardson, aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26145: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R174:66ed335757c5: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26145?vs=71996=72038 REVISION DETAIL

D26156: [KDocTools] Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir marked 2 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in docbookl10nhelper.cpp:184 > Just do `QRegularExpressionMatch match = rxEntity.match(line);` I did it that way to indicate match is going to be re-assigned-to later on, but it does

D26156: [KDocTools] Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 72037. ahmadsamir added a comment. Make QRegularExpression objects const. Declare and assign on one line. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26156?vs=72004=72037 BRANCH l-qregularexpression

D26158: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R286:6d6327868c8c: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26158?vs=72006=72036 REVISION

D26136: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir added a comment. In D26136#581721 , @apol wrote: > I'm a bit confused as to why the regex needs to be different. Explain in the commit message? Fair point. Done. REPOSITORY R265 KConfigWidgets REVISION DETAIL

D26136: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 72035. ahmadsamir added a comment. Explain why the regex was changed REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=71923=72035 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 252 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/252/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 23 Dec 2019 04:33:10 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 370 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/370/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 23 Dec 2019 04:33:10 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 237 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/237/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 23 Dec 2019 04:33:10 + Build duration: 12 min and counting JUnit Tests Name: projectroot

D26170: i18n: Add more semantic context strings

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH i18n-more-msgctxt REVISION DETAIL https://phabricator.kde.org/D26170 To: aspotashev, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26159: Drop KWindowSystem dependency

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D26159 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26158: Port QRegExp to QRegularExpression

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26158 To: ahmadsamir, #baloo, bruns, apol Cc: kde-frameworks-devel, #baloo,

D26156: [KDocTools] Port QRegExp to QRegularExpression

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment. LGTM otherwise INLINE COMMENTS > docbookl10nhelper.cpp:158 > **/ > -QRegExp rxEntity, rxEntity2, rxDocType, rxDocType2; > - > rxDocType.setPattern(QStringLiteral("^\\s* - > rxDocType2.setPattern(QStringLiteral("^\\s*$")); > - >

D26145: Port QRegExp to QRegularExpression

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R174 KContacts BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26145 To: ahmadsamir, mlaurent, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26137: Add KPluginMetaData::supportsMimeType

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26137 To: dfaure, arichardson, aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26136: Port QRegExp to QRegularExpression

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment. I'm a bit confused as to why the regex needs to be different. Explain in the commit message? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26133: Enable Auto Save

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment. It could make sense to add a test. Also for an application (system settings or kconfig dialogs) it's already possible to just trigger save when the kcm has changed (we already have signals for this). Why do you think it's needed? REPOSITORY R237 KConfig

D26122: Add utility text function KShell::tildeCollapse

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment. I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik,

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

2019-12-22 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kconfig_compiler.cpp:1122 > +// Types that `{}` are ok as return type for default value. > +if (QVector({ > +QLatin1String("stringlist"), If instead of creating a QVector you used an initializer list directly, you could use

D26126: Simplify param method: Return Early, Use a Map and Assert.

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment. I'd make the types static const, or at least const. Also are you sure that here std::map is better than QHash? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26171: Implement wp_viewporter

2019-12-22 Thread Roman Gilg
romangg added a task: T4456: Implement viewporter protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26171 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26171: Implement wp_viewporter

2019-12-22 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > surface_interface.h:130 > + **/ > +BufferInterface *constBuffer() const; > QPoint offset() const; Needed for a call in a const function in KWin. Do we want to do it like that? Other suggestions? REPOSITORY R127 KWayland REVISION

D26151: LaTeX: fix brackets in some commands

2019-12-22 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6ddf50d243dd: LaTeX: fix brackets in some commands (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26151?vs=71983=72031 REVISION

D26171: Implement wp_viewporter

2019-12-22 Thread Roman Gilg
romangg added a dependent revision: D26172: Add wp_viewporter support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26171 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26171: Implement wp_viewporter

2019-12-22 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY This patch adds interfaces for specifying viewports via the wp_viewporter protocol

D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev added a comment. In D26168#581665 , @kossebau wrote: > Seems you went fully "at it", good work :) > > "after string freeze" meant "after relase tagging for string freeze reasons" , right? ;) Yes, of course. REPOSITORY

D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. Seems you went fully "at it", good work :) "after string freeze" meant "after relase tagging for string freeze reasons" , right? ;) REPOSITORY R263 KXmlGui BRANCH i18n-split REVISION DETAIL https://phabricator.kde.org/D26168 To: aspotashev, kossebau

D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev added a comment. will try to push around January 5, 2020 after string freeze REPOSITORY R263 KXmlGui BRANCH i18n-split REVISION DETAIL https://phabricator.kde.org/D26168 To: aspotashev, kossebau Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26170: i18n: Add more semantic context strings

2019-12-22 Thread Alexander Potashev
aspotashev added a comment. will try to push around January 5, 2020 after string freeze REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26170 To: aspotashev Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev added a comment. In D26168#581637 , @kossebau wrote: > Looks good to me for what I know as programmer, but none-translator :) > While at it, for consistency the other tab titles could also get a "@title:tab" UI marker context?

D26170: i18n: Add more semantic context strings

2019-12-22 Thread Alexander Potashev
aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN it compiles REPOSITORY R263 KXmlGui BRANCH i18n-more-msgctxt REVISION DETAIL https://phabricator.kde.org/D26170

D26167: Update holidays and add flagdays and namedays for Sweden

2019-12-22 Thread Luigi Toscano
ltoscano added a comment. Try to use [easter] + 50 days Example (from Italian holidays): "Ascensione (Chiesa Cattolica)" religious on ((year >= 1977) ? ([easter] + 42 days): noop) https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?#n47 REPOSITORY R175

D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Looks good to me for what I know as programmer, but none-translator :) While at it, for consistency the other tab titles could also get a "@title:tab" UI marker context? In

D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev added a subscriber: kossebau. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26168 To: aspotashev Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN it compiles REPOSITORY R263 KXmlGui BRANCH i18n-split REVISION DETAIL https://phabricator.kde.org/D26168

D26167: Update holidays and add flagdays and namedays for Sweden

2019-12-22 Thread Felix Riiga
riiga created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. riiga requested review of this revision. REVISION SUMMARY Holidays for Sweden have been corrected and updated. Flag days have been added along with a few other significant cultural

D26155: Add RPM support to Krarc

2019-12-22 Thread Nathaniel Graham
ngraham added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26155 To: gengisdave, #frameworks, dfaure Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D26054: partial fix for accentuated characters in file name on Windows

2019-12-22 Thread Matthieu Gallien
This revision was automatically updated to reflect the committed changes. Closed by commit R286:8c066c834c64: partial fix for accentuated characters in file name on Windows (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D26006: Deprecate KPixmapProvider

2019-12-22 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. KIO's KUrlPixmapProvider needs to be deprecated too, preferably before this commit lands. REPOSITORY R284 KCompletion BRANCH pmp REVISION DETAIL https://phabricator.kde.org/D26006

D26006: Deprecate KPixmapProvider

2019-12-22 Thread Nicolas Fella
nicolasfella added a reviewer: dfaure. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D26006 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

2019-12-22 Thread Nicolas Fella
nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26034 To: nicolasfella, #frameworks, dfaure Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26117: [solid] Clarify referencing of DeviceInterface

2019-12-22 Thread Stefan Brüns
bruns added a comment. No reason for being rude. You should know how a reasonable commit message looks like. It should be self contained and easy to understand, without requiring everyone to setup a test bed first, also in retrospective. REPOSITORY R245 Solid REVISION DETAIL

D26154: Port qrand deprecated method to QRandomGenerator

2019-12-22 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R1048:4e0aed086c30: Port qrand deprecated method to QRandomGenerator (authored by mlaurent). REPOSITORY R1048 Grantlee CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26154?vs=71991=72015

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2019-12-22 Thread Nathaniel Graham
ngraham accepted this revision as: VDG. ngraham added a comment. Yep, my branches weren't up to date. Works fine now! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26067 To: broulik, #frameworks, #vdg, #dolphin Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D26154: Port qrand deprecated method to QRandomGenerator

2019-12-22 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R1048 Grantlee BRANCH port_QRandomGenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26154 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26159: Drop KWindowSystem dependency

2019-12-22 Thread David Edmundson
davidedmundson added a task: T12413: RFC: Split KWindowSystem into KX11 and KHighLevelWindowStuff. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D26159 To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26159: Drop KWindowSystem dependency

2019-12-22 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY KWindowSystem activateWindow does the same thing as the QPA does when calling QWindow::requestActivate.

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 22 Dec 2019 18:43:33 + Build duration: 1 min 10 sec and counting JUnit Tests Name:

D26157: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R299:8376e5f664a9: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26157?vs=72005=72007 REVISION DETAIL

D26157: Port QRegExp to QRegularExpression

2019-12-22 Thread Fabian Vogt
fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R299 KDESu BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26157 To: ahmadsamir, sitter, fvogt, jriddell Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-22 Thread Nathaniel Graham
ngraham added a comment. I agree. If and when this lands, you could commandeer and close D15645 REPOSITORY R265 KConfigWidgets BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks,

D26158: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R286 KFileMetaData BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26157: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: sitter, fvogt, jriddell. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R299 KDESu BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26156: [KDocTools] Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Documentation, ltoscano. Herald added projects: Frameworks, Documentation. ahmadsamir requested review of this revision. REVISION SUMMARY xslt.cpp didn't really use QRegExp as the line using it has been commented out since 2013,

D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-12-22 Thread Nathaniel Graham
ngraham added a comment. @chinmoyr now that D21783 has landed, this is all that's left before we can turn on the feature, right? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: chinmoyr, apol, bruns, davidedmundson,

D26117: [solid] Clarify referencing of DeviceInterface

2019-12-22 Thread Anthony Fieroni
anthonyfieroni added a comment. You can't run kinfocenter or what? Application: Info Center (kinfocenter), signal: Segmentation fault Using host libthread_db library "/lib/libthread_db.so.1". [Current thread is 1 (Thread 0x7f4c245a2840 (LWP 318849))] Thread 4 (Thread

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 251 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/251/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 22 Dec 2019 16:41:27 + Build duration: 24 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 250 - Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/250/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 22 Dec 2019 08:16:29 + Build duration: 8 hr 24 min and counting BUILD ARTIFACTS

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-22 Thread Friedrich W. H. Kossebau
Am Sonntag, 22. Dezember 2019, 17:08:15 CET schrieb Stephen Kelly: > On 21/12/2019 23:55, Friedrich W. H. Kossebau wrote: > > Perhaps joining the "Release Service" (formerly known as "KDE > > Applications") is a better place then, it also contains a set of > > libraries already. That would serve

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-22 Thread Stephen Kelly
On 21/12/2019 23:55, Friedrich W. H. Kossebau wrote: Perhaps joining the "Release Service" (formerly known as "KDE Applications") is a better place then, it also contains a set of libraries already. That would serve the purpose of having releases happening regularly. The goals of making

D26155: Add RPM support to Krarc

2019-12-22 Thread Davide Gianforte
gengisdave created this revision. gengisdave added a reviewer: Frameworks. gengisdave added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gengisdave requested review of this revision. REVISION SUMMARY This fix the conflict between file: and krarc: protocols when and

D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

2019-12-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R293:de269bf48e58: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14 (authored by ahmadsamir). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

2019-12-22 Thread Laurent Montel
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH l-qt14-deprecated-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26102 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel,

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2019-12-22 Thread Kai Uwe Broulik
broulik added a comment. F7831018: Screenshot_20191222_162523.png Works fine here. Are both branches up to date and are you clicking an empty area? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26067 To: broulik, #frameworks,

D26123: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71999. ahmadsamir added a comment. Verbatim REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71941=71999 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D26123

D26145: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71996. ahmadsamir added a task: T12279: Port frameworks away from QRegExp. ahmadsamir added a comment. Verbatim REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26145?vs=71995=71996 BRANCH l-qregularexpression

D26106: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71997. ahmadsamir added a comment. Verbatim REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26106?vs=71994=71997 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26145: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71995. ahmadsamir added a comment. Link to KF6 task REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26145?vs=71959=71995 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26106: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71994. ahmadsamir added a comment. Link to KF6 task REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26106?vs=71843=71994 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26099: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71992. ahmadsamir added a comment. Link to KF6 task REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71954=71992 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D26099

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 236 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/236/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 22 Dec 2019 11:42:05 + Build duration: 2 hr 39 min and counting JUnit Tests Name:

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-22 Thread David Redondo
davidre added a comment. In D25877#581355 , @kossebau wrote: > D15645 tried something similar from what I understood without looking at details, you might want to compare at least :) Sorry, no time myself to

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. D15645 tried something similar from what I understood without looking at details, you might want to compare at least :) Sorry, no time myself to look at things currently beyond this comment. REPOSITORY R265 KConfigWidgets

D26154: Port qrand deprecated method to QRandomGenerator

2019-12-22 Thread Laurent Montel
mlaurent added a reviewer: dfaure. REPOSITORY R1048 Grantlee REVISION DETAIL https://phabricator.kde.org/D26154 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26154: Port qrand deprecated method to QRandomGenerator

2019-12-22 Thread Laurent Montel
mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QRandomGenerator REPOSITORY R1048 Grantlee BRANCH port_QRandomGenerator (branched from master)

D26148: Add truncation support to FileJob

2019-12-22 Thread Alexander Saoutkin
feverfew updated this revision to Diff 71990. feverfew added a comment. Add unit test for truncation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26148?vs=71963=71990 BRANCH TruncateSupport REVISION DETAIL https://phabricator.kde.org/D26148 AFFECTED

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 369 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/369/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 22 Dec 2019 10:50:28 + Build duration: 1 hr 55 min and counting BUILD ARTIFACTS

D26054: partial fix for accentuated characters in file name on Windows

2019-12-22 Thread Alexander Stippich
astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fixWriterAccentuatedFileName REVISION DETAIL https://phabricator.kde.org/D26054 To: mgallien, bruns, astippich Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 235 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/235/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 22 Dec 2019 08:16:29 + Build duration: 3 hr 25 min and counting JUnit Tests Name:

D26151: LaTeX: fix brackets in some commands

2019-12-22 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R216 Syntax Highlighting BRANCH latex-brackets REVISION DETAIL https://phabricator.kde.org/D26151 To: nibags, #framework_syntax_highlighting, cullmann Cc:

D26153: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface

2019-12-22 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:d25bc3ce2138: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26153: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface

2019-12-22 Thread Roman Gilg
romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D26153 To: davidedmundson, #kwin, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26153: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface

2019-12-22 Thread David Edmundson
davidedmundson edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26153 To: davidedmundson, #kwin, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26153: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface

2019-12-22 Thread David Edmundson
davidedmundson created this revision. davidedmundson added reviewers: KWin, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Currently the widget explorer relied on some QML code

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 368 - Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/368/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 22 Dec 2019 08:16:29 + Build duration: 2 hr 33 min and counting BUILD ARTIFACTS

D26151: LaTeX: fix brackets in some commands

2019-12-22 Thread Nibaldo González
nibags created this revision. nibags added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 415384 In the parameter of some

D21783: Show more details in warning dialog shown before starting a privileged operation

2019-12-22 Thread David Faure
dfaure added a comment. Fixed. https://commits.kde.org/kio/e2a38d7726e33f637576f254575c2c0743d205b8 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: bcooksley, mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-22 Thread Dominik Haumann
Hi all, in any case, maybe the discussed points should go to the KF6 workboard? https://phabricator.kde.org/project/view/310/ I indeed believe that consistency in the KF5 world is an important feature, so Friedrich does have a point here. Other framework additions had to adapt as well (what

D26113: Places: For mounted volume display mount points instead of description

2019-12-22 Thread Méven Car
meven added a comment. In D26113#581077 , @ngraham wrote: > We can make the name override more discoverable for sure. But IMO we should also improve the default presentation, because this is just yucky: F7828189: Screenshot_20191221_092825.png

D21783: Show more details in warning dialog shown before starting a privileged operation

2019-12-22 Thread Ben Cooksley
bcooksley added a comment. This changes FTBFS - see https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20SUSEQt5.12/47/ There are currently a large number of Dependency Builds underway to correct changes in the tree as a consequence of Grantlee

D21783: Show more details in warning dialog shown before starting a privileged operation

2019-12-22 Thread Chinmoy Ranjan Pradhan
This revision was automatically updated to reflect the committed changes. Closed by commit R241:82aae02e2114: Show more details in warning dialog shown before starting a privileged operation (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE