D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72349. tcanabrava added a comment. - Fix some obvious bugs. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=72338=72349 BRANCH megaRefactor REVISION DETAIL https://phabricator.kde.org/D26202 AFFECTED

D26202: WIP: Refactor KConfigXT

tcanabrava edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 242 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/242/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 29 Dec 2019 18:24:56 + Build duration: 9 min 6 sec and counting JUnit Tests Name:

D26277: KFilePlaceEditDialog: move logic into isIconEditable()

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY Instead of relying on whether `m_iconButton` has been

D26276: KFilePlaceEditDialog: fix crash when editing the Trash place

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9ea007cf87c: KFilePlaceEditDialog: fix crash when editing the Trash place (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26202: WIP: Refactor KConfigXT

ngraham added reviewers: Frameworks, ervin, bport. ngraham added a comment. That explanation really belongs in the Description section of this patch, not in a comment. :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin,

D26276: KFilePlaceEditDialog: fix crash when editing the Trash place

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oops! Nice fix. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26276 To: elvisangelaccio, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel,

D26276: KFilePlaceEditDialog: fix crash when editing the Trash place

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY `m_iconButton` is initialized only when the url scheme of

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72338. tcanabrava added a comment. - Move XmlParser to another file. - Move Code around again - Fix some issues - still broken - Move Parser to own file - Move a lot of code to the Parser Class - Fix a few of the many many warnings.

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 72337. davidre marked 5 inline comments as done. davidre added a comment. - note the version in which behavior was changed in the documentation - constexpr variable for default scheme row - more comments REPOSITORY R265 KConfigWidgets CHANGES SINCE

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:227 > +// The property needs to be set before the palette change because is is > checked upon the > +// ApplicationPaletteChange event. > qApp->setProperty("KDE_COLOR_SCHEME_PATH", index.data(Qt::UserRole));

D25877: [KColorschemeManager] Add option to reenable following global theme

kossebau added a comment. Some comments while flying over the code due to being triggered by phab message, but no in-detail review and analysis of approach done, lack of concentration currently, sorry. I also propose to change all magic number `0`s to use some `defaultThemeRow` from a

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 72334. davidre added a comment. Fix test REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=72332=72334 BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. @heikobecker are you still interested in this patch? I can take over otherwise. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc: ngraham,

D26273: cmake: don't use taglib-config if we are cross compiling

elvisangelaccio added a comment. In D26273#584234 , @vkrause wrote: > Longer term we probably either want to convince upstream to install cmake config files, or at least have this in ECM, a quick local grep find a handful of copies of this.

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 72332. davidre added a comment. typo REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=72331=72332 BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre marked 4 inline comments as done. REPOSITORY R265 KConfigWidgets BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks, ngraham Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 72331. davidre marked 4 inline comments as done. davidre added a comment. - Remove function - Select system scheme on invalid model index - fix and expand comment REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D25877: [KColorschemeManager] Add option to reenable following global theme

kossebau added inline comments. INLINE COMMENTS > davidre wrote in kcolorschememanager.h:111 > Would I need to add @since for a new overload? "Would I need"... put yourself in the shoes of a user of this class: you would want to know at which version this new overload is available when using

D25877: [KColorschemeManager] Add option to reenable following global theme

ahmadsamir added inline comments. INLINE COMMENTS > ahmadsamir wrote in kcolorschememanager.h:111 > I would say yes (your question made me search for an answer since I wanted > too:)), from > https://community.kde.org/Guidelines_and_HOWTOs/API_Documentation: > > > The @since tag tells users

D25877: [KColorschemeManager] Add option to reenable following global theme

ahmadsamir added inline comments. INLINE COMMENTS > davidre wrote in kcolorschememanager.h:111 > Would I need to add @since for a new overload? I would say yes (your question made me search for an answer since I wanted too:)), from

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

On 28/12/2019 23:30, Friedrich W. H. Kossebau wrote: Why are you proposing to do a step back instead to the old state, which everyone including you considered not that satisfying? Because it's a temporary situation. We still have a way forward in KF6 (which will open in a few months).

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added inline comments. INLINE COMMENTS > kcolorschememanager.h:111 > KActionMenu *createSchemeSelectionMenu(const QString > , QObject *parent); > +KActionMenu *createSchemeSelectionMenu(QObject *parent); > Would I need to add @since for a new overload? REPOSITORY R265

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added inline comments. INLINE COMMENTS > kcolorschememanager.h:130 > +void followSystemScheme(); > + > private: I like that idea with an empty ModelIndex. REPOSITORY R265 KConfigWidgets BRANCH systemthem (branched from master) REVISION DETAIL

D26273: cmake: don't use taglib-config if we are cross compiling

pino added a comment. Or maybe switch this module to use pkg-config as primary way to detect taglib, falling back to taglib-config only when the pkg-config file is not available. REPOSITORY R286 KFileMetaData BRANCH bshah/cross REVISION DETAIL https://phabricator.kde.org/D26273 To:

D26273: cmake: don't use taglib-config if we are cross compiling

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Longer term we probably either want to convince upstream to install cmake config files, or at least have this in ECM, a quick local grep find a handful of copies of this. REPOSITORY

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72326. tcanabrava added a comment. - Add new Class, KConfigSourceGenerator, fix usage of addHeader - Move CreateSingletonImplementation - Create Cpp Preamble - Move Constructor implementation - move Getter / Setter / Destructor - Remove unused

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. @hoffmannrobert: by the way, looking at your phabricator activity, you should get a KDE contributor account, if you don't have one already. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor,

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. @hoffmannrobert: Are you maybe also interested in looking into https://bugs.kde.org/show_bug.cgi?id=415570 ? It's again about printing, this time about the very last line that seems to be wrong... REPOSITORY R39 KTextEditor REVISION DETAIL

D26273: cmake: don't use taglib-config if we are cross compiling

bshah created this revision. bshah added a reviewer: vkrause. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY If we are cross compiling two things are possible, - cmake finds host