KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 264 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/264/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 04 Jan 2020 06:56:33 + Build duration: 7 min 6 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 263 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/263/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 01 Jan 2020 19:06:15 + Build duration: 2 days 11 hr and counting BUILD ARTIFACTS

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

anthonyfieroni added inline comments. INLINE COMMENTS > kfileitem.cpp:782 > if (!path.isEmpty()) { > -const KFileSystemType::Type fsType = > KFileSystemType::fileSystemType(path); > -m_slow = (fsType == KFileSystemType::Nfs || fsType == > KFileSystemType::Smb)

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

ngraham added reviewers: broulik, dfaure. ngraham added inline comments. INLINE COMMENTS > kfileitem.cpp:47 > +/** > + * A coche of currently mounted filesystems > + */ cache > kfileitem.cpp:1245 > > -if (d->m_bSkipMimeTypeFromContent) { > +// avoid potential bloqing stat on network

D26331: Removed reading description from desktop files

ngraham added a comment. Having been a sysadmin setting up computers for new users, let me tell you that there is a 0% chance that I would use this feature. I would (and did, and have) *by far* prefer to document anything slightly confusing using an internal company-wide knowledge-base or

D26410: Port KLanguageButton from KConfig to QSettings

nicolasfella added a task: T12197: Move KLanguageButton from KConfig -> QSettings. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26410 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26410: Port KLanguageButton from KConfig to QSettings

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Implement T12197 TEST PLAN

KDE CI: Frameworks » kparts » kf5-qt5 WindowsMSVCQt5.13 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20WindowsMSVCQt5.13/41/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 03 Jan 2020 23:13:46 + Build duration: 2 hr 42 min and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/51/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 04 Jan 2020 00:14:16 + Build duration: 1 hr 7 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:16:05 + Build duration: 1 hr 41 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 91 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/91/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 03 Jan 2020 23:10:52 + Build duration: 1 hr 35 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:14:56 + Build duration: 1 hr 28 min and counting JUnit Tests Name:

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

dfaure added a comment. See D26408 for a unittest. But maybe the code can just be killed... REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26366 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel,

D26408: ki18n: add unittest for KUitSetup::setFormatForMarker

dfaure created this revision. dfaure added a reviewer: ilic. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This is to test the port to QRegularExpression in D26366

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/86/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 Jan 2020 00:14:16 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:14:02 + Build duration: 1 hr 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 256 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/256/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:12:41 + Build duration: 1 hr 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/49/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:13:40 + Build duration: 1 hr 16 min and counting JUnit Tests Name:

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Alternative to D23198 BUG: 401579

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:12:29 + Build duration: 1 hr 8 min and counting JUnit Tests Name:

D26402: [android] Fix apk install target

This revision was automatically updated to reflect the committed changes. Closed by commit R240:c427b4e94ebb: [android] Fix apk install target (authored by nicolasfella). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26402?vs=72703=72718

D26402: [android] Fix apk install target

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH androidinstall REVISION DETAIL https://phabricator.kde.org/D26402 To: nicolasfella, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:11:27 + Build duration: 59 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/54/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:11:17 + Build duration: 57 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/86/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:10:48 + Build duration: 47 min and counting JUnit Tests Name:

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.13 - Build # 32 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.13/32/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 03 Jan 2020 23:09:44 + Build duration: 39 min and counting JUnit Tests

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/46/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 23:10:12 + Build duration: 37 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 138 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/138/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 Jan 2020 23:10:52 + Build duration: 29 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 89 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/89/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 03 Jan 2020 22:03:51 + Build duration: 7 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/50/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 03 Jan 2020 22:04:00 + Build duration: 6 min 42 sec and counting BUILD ARTIFACTS

D11156: add autotest for zips within zips

dfaure added a comment. The command you're looking for is `arc patch D11156` (tested, works) REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D11156 To: sandsmark, dfaure, #frameworks Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

dfaure added a comment. I don't understand this line of argumentation. Are you saying that all documentation in the world is useless? You're setting up a computer for a new employee, with a whole lot of folders. Having some room to document "inline" the purpose of some folders sounds

D26405: Add mime type for backtraces saved from DrKonqi

broulik edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26405 To: broulik, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26405: Add mime type for backtraces saved from DrKonqi

broulik created this revision. broulik added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN There's also text/x-apport - My saved crash reports now have a nice icon

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72715. tcanabrava edited the test plan for this revision. tcanabrava added a comment. - Add Hack for Enums - Fix Whitespace diff - Move some raw scopes to start/end scope() REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D25117: file ioslave: stop copying as soon as the ioslave is killed

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > dfaure wrote in jobtest.cpp:2171 > Always use QVERIFY() around spy.wait(). > Well, I'm assuming we actually expect the signal to be emitted :-) > I would also

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > broulik wrote in ktoolbar.cpp:908 > I just realized this is false-y deprecated. The feature adds the > configuration options for toolbar buttons. > What needs to be done here for proper deprecation is port that over to >

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yep. Bug in D9983 . REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26364 To: kfunk, chinmoyr, davidedmundson,

D24466: Use ECMGenerateExportHeader to manage deprecated API better

broulik added inline comments. INLINE COMMENTS > ktoolbar.cpp:908 > { > -#ifndef KXMLGUI_NO_DEPRECATED > +#if KXMLGUI_BUILD_DEPRECATED_SINCE(5, 0) > if (mainWindow() && d->enableContext) { I just realized this is false-y deprecated. The feature adds the configuration options for toolbar

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Rather than a banknote or money symbol. Git log suggests this was added for GNU cash,

D26202: WIP: Refactor KConfigXT

tcanabrava edited the summary of this revision. tcanabrava edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72711. tcanabrava added a comment. - Add missing .h - Fixes placement of code - Change how tests save tests - Change how the Indentation is done - Fix filename in the preamble - Separate logic to make function readable - Fix more newlines

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. About the unit test, I couldn't think of a way to test it, unless I use a snippet to check the regex (like you did in D26332 ), which doesn't seem to fit in a unit test for KLocalizedString... REPOSITORY R249 KI18n REVISION

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir updated this revision to Diff 72709. ahmadsamir added a comment. Use a meaningful name for the QRegularExpression object Explain the (my) logic behind the changes in parseUiMarker() in the commit message REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir updated this revision to Diff 72710. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Verbatim REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26366?vs=72709=72710 BRANCH l-parseUiM (branched from master) REVISION

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 388 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/388/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 Jan 2020 18:59:47 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 255 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/255/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 18:59:47 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D25991: [KFilePlacesModel] Fix supported scheme check for devices

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R241:3a6e3f927111: [KFilePlacesModel] Fix supported scheme check for devices (authored by broulik). Herald added a

D25991: [KFilePlacesModel] Fix supported scheme check for devices

ngraham added a comment. No response, I think you can land this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25991 To: broulik, #frameworks, dfaure, ngraham, bruns Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26397: Change XHTML icon to be a purple HTML icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:fdaded68913f: Change XHTML icon to be a purple HTML icon (authored by broulik). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26397?vs=72693=72707 REVISION

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25991 To: broulik, #frameworks, dfaure, ngraham, bruns Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

lbeltrame added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 To: bport, ervin, crossi, meven, #plasma, bruns Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D26402: [android] Fix apk install target

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The APK output path changed at some point

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport added a dependent revision: D26401: KCM Baloo: Migrate to KConfigXT and add immutability. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 To: bport, ervin, crossi, meven, #plasma Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77,

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport added reviewers: ervin, crossi, meven, Plasma. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 To: bport, ervin, crossi, meven, #plasma Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bport requested review of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 AFFECTED FILES src/file/CMakeLists.txt

D26397: Change XHTML icon to be a purple HTML icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice idea! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26397 To: broulik, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26123: Port QRegExp to QRegularExpression

ahmadsamir added a comment. FTR; in one of my inline comments I said: > And I found that: > > - {,3} in QRegExp is equivalent to {0,3} > - {,3} in QRegularExpression is equivalent to {1,3} The second part is actually wrong (as I was told by dfaure who was told by upstream

D25495: Fix Sonnet autodetect failing on Indian langs

waqar marked an inline comment as done. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

waqar marked an inline comment as done. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added inline comments. INLINE COMMENTS > mludwig wrote in guesslanguage.cpp:589 > Couldn't this if-statement can be dropped? I guess one can argue that > sometimes there may be a language without trigrams that would even be a > better language guess? Yeah, I think so too REPOSITORY

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

This revision was automatically updated to reflect the committed changes. Closed by commit R309:128ed7ce3a1e: Remove endl in qDebug as its already add \n + port to Qt::endl in qt5.15 (authored by mlaurent). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D26397: Change XHTML icon to be a purple HTML icon

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Currently, XHTML is just using the XML icon, but XHTML is more of a "website" than an

D11156: add autotest for zips within zips

sandsmark added a comment. In D11156#501817 , @dfaure wrote: > @sandsmark can you add an expected list of files like other tests do? Yeah, I just need to find out which machine I wrote this on because it is hard to download patches with

D26331: Removed reading description from desktop files

ngraham added a comment. In D26331#586842 , @broulik wrote: > I doubt naming a folder "Technobabble" and then adding a helpful comment "This is where your cat pictures go" is very useful to the inexperienced user 100% agree REPOSITORY

D26394: ECMGeneratePriFile: Fix static configurations

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26394 To: kfunk, dfaure, winterz, vkrause, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2,

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26303 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26394: ECMGeneratePriFile: Fix static configurations

kfunk added reviewers: winterz, vkrause. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26394 To: kfunk, dfaure, winterz, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26394: ECMGeneratePriFile: Fix static configurations

kfunk created this revision. kfunk added a reviewer: dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY Populate module_config with staticlib. This is needed for Qt

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kuitmarkup.cpp:90 > Interesting idea, this simplifies the code. > > However the name "wsRx" no longer matches what this regexp does. > > Also, the old trimming is missing here, isn't it? > I guess \s*:?\s* is needed, and

D25495: Fix Sonnet autodetect failing on Indian langs

waqar updated this revision to Diff 72684. waqar added a comment. Apply requested changes REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25495?vs=72545=72684 BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25495

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent added a comment. So what I need to change in this patch ? (if I need to change a code :) ) REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320 To: mlaurent, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

mludwig added a comment. Thanks for the updated patch! In D25495#585855 , @waqar wrote: > > There is also a bug in GuessLanguagePrivate::guessFromTrigrams(const QString , const QStringList ): if m_minConfidence is left to its default value

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 103 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/103/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 11:09:47 + Build duration: 2 min 18 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 109 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/109/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 03 Jan 2020 11:09:47 + Build duration: 2 min 45 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 217 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/217/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 Jan 2020 11:09:47 + Build duration: 2 min 31 sec and counting JUnit Tests Name: (root)

D26331: Removed reading description from desktop files

broulik added a comment. In D26331#586783 , @count wrote: > I thought, the !d->isSlow() would skip that part for (fsType == KFileSystemType::Nfs || fsType == KFileSystemType::Smb) as seen in kfileitem.cpp:763. So I would leave that here.

D17595: Upstream Dolphin's file rename dialog

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dfaure wrote in renamefiledialog.h:47 > @since 5.62 I hope this comment (between docu and class) doesn't break apidox generation. REPOSITORY R241 KIO BRANCH

D26373: Port endl to \n

dfaure added a comment. I would just use std::cout and std::cerr. Yes, at the price of a call to qPrintable(), but that's less ugly and more standard IMHO. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D26373 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel,

D26331: Removed reading description from desktop files

dfaure added a comment. Also, I see a lot more use cases for showing the comment from .directory files. I could imagine setting up a computer for an inexperienced user, and adding .directory files to document what some directories are about. REPOSITORY R241 KIO REVISION DETAIL

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

dfaure added a comment. Doesn't flushing happen automatically when internal buffers are full enough? i.e. I don't think the app should have to think about that, except when it *wants* partial results to be visible (which isn't the case in a code generator). About replace('\n', '\r\n')

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kuitmarkup.cpp:90 > > -// Role. > -roleName = context; > +static const QRegularExpression >