D26484: Add a new parameter for delaying showing menu

trmdi marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73030. trmdi added a comment. - Add a new function instead of changing the old exported one REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=72975=73030 BRANCH master REVISION DETAIL

D26484: Add a new parameter for delaying showing menu

anthonyfieroni added inline comments. INLINE COMMENTS > dropjob.h:129 > */ > -KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl > , JobFlags flags = DefaultFlags); > +KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl > , JobFlags flags =

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent added a comment. No change needed ? I will commit in two days if no complains. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320 To: mlaurent, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi added a dependent revision: D26514: Delay popup for containments. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26513: Port KNotification from KWindowSystem

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26513 To: davidedmundson, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26513: Port KNotification from KWindowSystem

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY KWindowSystem::activateWindow does the same system call as QWindow::requestActivate for X11 and Windows

D26512: Drop unused headers

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY KWindowSystem as a framework is still used or KKeyServer, so it can't be completely removed. TEST PLAN

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/66/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 07 Jan 2020 22:14:23 + Build duration: 3 min 11 sec and counting JUnit Tests Name:

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

broulik edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26492 To: broulik, #frameworks, ngraham Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26502: [ConfigModule] Say which package is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit R296:00405aacf3f6: [ConfigModule] Say which package is invalid (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26502?vs=73009=73019 REVISION

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella added inline comments. INLINE COMMENTS > dfaure wrote in krecentfilesmenu.cpp:85 > Why not std::vector? > > std::list is a linked list, so this smells like pointers to nodes containing > pointers, lots of indirection. New entries are pushed to the front, which works in constant

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

zzag retitled this revision from "[WIP] [Dialog Shadows] Port to KWindowSystem shadows API" to "[Dialog Shadows] Port to KWindowSystem shadows API". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26503 To: zzag, #plasma Cc: kde-frameworks-devel,

D26491: [Plasma Quick] Add WaylandIntegration class

zzag added a dependent revision: D26503: [WIP] [Dialog Shadows] Port to KWindowSystem shadows API. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26491 To: zzag, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [WIP] [Dialog Shadows] Port to KWindowSystem shadows API

zzag added a dependency: D26491: [Plasma Quick] Add WaylandIntegration class. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26503 To: zzag, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26502: [ConfigModule] Say which package is invalid

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26502 To: broulik, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [WIP] [Dialog Shadows] Port to KWindowSystem shadows API

zzag added a task: T12496: Shadows API in KWindowSystem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26503 To: zzag, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [WIP] [Dialog Shadows] Port to KWindowSystem shadows API

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. TEST PLAN Run `qmlscene tests/dialog.qml` REPOSITORY R242 Plasma Framework (Library) BRANCH

D26502: [ConfigModule] Say which package is invalid

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Makes it easier to spot mismatches between install path and about data. TEST

D26488: smb ioslave: fix build regression

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b2ad75170084: smb ioslave: fix build regression (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26488?vs=72960=73005 REVISION DETAIL

D26488: smb ioslave: fix build regression

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D26488 To: meven, #frameworks, mlaurent, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again

kossebau added a comment. KMainWindowPrivate::CompressCalls being used here still exposes a small issue, as this opens a small time window where the state is not catched before a xmlgui client change happens, so some finalizeGUI might (in theory) still use old state data, as

D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again

kossebau created this revision. kossebau added reviewers: Frameworks, KDevelop, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY If QDockWidgets are "shown" in QWidget sense a second time,

D24629: RFC: Introduce KClockSkewNotifier class

zzag added a comment. The KWin patch has landed. Can we proceed now? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24629 To: zzag, #frameworks Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

ahmadsamir added a comment. Hello. Bug 415951 doesn't look related to this diff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26492 To: broulik, #frameworks, ngraham Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26495: Fix API doc, usrSave is called from save not deprecated writeConfig

This revision was automatically updated to reflect the committed changes. Closed by commit R237:e88f9309e5db: Fix API doc, usrSave is called from save not deprecated writeConfig (authored by bport). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D24629: RFC: Introduce KClockSkewNotifier class

zzag updated this revision to Diff 72993. zzag added a comment. Rename signal. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24629?vs=67889=72993 BRANCH kclockskewnotifier REVISION DETAIL https://phabricator.kde.org/D24629 AFFECTED FILES

D26484: Add a new parameter for delaying showing menu

trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26496: Log categories: fix format adding DEFAULT_SEVERITY

meven abandoned this revision. meven added a comment. Thanks @mlaurent I just have old files installed on my system and got confused, I thought DEFAULT_SEVERITY was mandatory. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26496 To: meven, #frameworks, mlaurent Cc:

D26496: Log categories: fix format adding DEFAULT_SEVERITY

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. But you're wrong "log_kdebugsettings: In this file: "/home/meven/kde/usr/etc/xdg/kio.categories" this line "kf5.kio.cookiejar kcookiejar (KIO)" still use old format. We

D26496: Log categories: fix format adding DEFAULT_SEVERITY

meven created this revision. meven added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prevents warning when launching kdebugsettings such as:

D26484: Add a new parameter for delaying showing menu

trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26495: Fix API doc, usrSave is called from save not deprecated writeConfig

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26495 To: bport, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26488: smb ioslave: fix build regression

meven added a reviewer: mlaurent. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26488 To: meven, #frameworks, mlaurent Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D26495: Fix API doc, usrSave is called from save not deprecated writeConfig

bport created this revision. bport added a reviewer: ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26495 AFFECTED FILES

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26492 To: broulik, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. Bump. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D26484: Add a new parameter for delaying showing menu

trmdi retitled this revision from "Delay 100ms before showing the menu" to "Add a new parameter for delaying showing menu". trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson,

D26484: Delay 100ms before showing the menu

trmdi updated this revision to Diff 72975. trmdi added a comment. - Use signal instead of timer REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=72945=72975 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

broulik updated this revision to Diff 72972. broulik added a comment. - Turns out no close on exit doesnt imply the other, old code was correcter L:) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26492?vs=72971=72972 REVISION DETAIL

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

broulik updated this revision to Diff 72971. broulik added a comment. - Simplify REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26492?vs=72970=72971 REVISION DETAIL https://phabricator.kde.org/D26492 AFFECTED FILES src/widgets/kopenwithdialog.cpp To:

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 415951 TEST PLAN - Normal case still has box - Ran with

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 260 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/260/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 07 Jan 2020 12:37:09 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D26491: [Plasma Quick] Add WaylandIntegration class

zzag updated this revision to Diff 72969. zzag added a comment. Rename a function. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26491?vs=72968=72969 BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26491

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 268 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/268/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 07 Jan 2020 12:37:09 + Build duration: 8 min 11 sec and counting BUILD ARTIFACTS

D26491: [Plasma Quick] Add WaylandIntegration class

zzag updated this revision to Diff 72968. zzag added a comment. Update logs. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26491?vs=72967=72968 BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26491

D26491: [Plasma Quick] Add WaylandIntegration class

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26491 To: zzag, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY It allows us to get rid of DialogShadows::plasmaShellInterface(). REPOSITORY R242 Plasma

D26491: [Plasma Quick] Add WaylandIntegration class

zzag added a task: T12496: Shadows API in KWindowSystem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26491 To: zzag, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26191: Add support for FileJob->truncate() in smb/sftp slaves

sitter accepted this revision. sitter added a comment. I do wonder if maybe more granular return value handling of the smb truncate would be in order, but then I suppose the most relevant error is EACCES and that'd be handled at opening ¯\_(ツ)_/¯ LGTM INLINE COMMENTS > dfaure wrote in

D26490: [KMessageWidget] Use devicePixelRatioF for animation pixmap

This revision was automatically updated to reflect the committed changes. Closed by commit R236:fcc7978c7cf1: [KMessageWidget] Use devicePixelRatioF for animation pixmap (authored by broulik). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D26490: [KMessageWidget] Use devicePixelRatioF for animation pixmap

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice catch! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26490 To: broulik, #frameworks, cullmann Cc: cullmann, kde-frameworks-devel, LeGast00n,

D26490: [KMessageWidget] Use devicePixelRatioF for animation pixmap

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Ensures contents stay crisp during the animation by setting the correct

D26159: Drop KWindowSystem dependency

nicolasfella added a comment. Please also remove from kde-build-metadata REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D26159 To: davidedmundson, apol Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26159: Drop KWindowSystem dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R310:3fec3efc99ac: Drop KWindowSystem dependency (authored by davidedmundson). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26159?vs=72008=72961 REVISION DETAIL

D24932: Add button to open the folder in filelight to view more details

broulik requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks, broulik Cc: broulik, ltoscano, pino, kde-frameworks-devel, #frameworks, LeGast00n, GB_2,

D26488: smb ioslave: fix build regression

meven created this revision. meven added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Regression was introduced in D26420

D24932: Add button to open the folder in filelight to view more details

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. Can you please look for filelight using `KService::serviceByDesktopName("org.kde.filelight")`, then you don't have hardcode the executable path, name, icon, etc. REPOSITORY R241 KIO

D25984: Load translations

mart added a comment. ping, what's the current status of this? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D26416: Kicker/Documents optimization: Lazily build KFileItem

broulik added a comment. Would be lovely in the future to cache those items and make it a proper model with backing data rather than requesting everything on demand every time `data` is called. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26416 To:

D26440: Add KSharedConfig::openStateConfig for storing state information

broulik added a comment. Nice one. Once that `XDG_STATE_HOME` discussion comes to a conclusion [1] we could then easily swap the location over, I suppose. [1] https://lists.freedesktop.org/archives/xdg/2016-December/013803.html REPOSITORY R237 KConfig REVISION DETAIL

D26448: Add KRecentFilesMenu to replace KRecentFileAction

broulik added inline comments. INLINE COMMENTS > krecentfilesmenu.cpp:150 > +// Don't restore if file doesn't exist anymore > +if (url.isLocalFile() && !QFile::exists(url.toLocalFile())) { > +continue; If we're rewriting this thing anyway, can we please make sure it

D26487: [Kuit] Revert changes in parseUiMarker()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This commit partially reverts a9f4cbdda790c3962

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

This revision was automatically updated to reflect the committed changes. Closed by commit R295:6d6e2427f8e2: Update KPluginSelector to allow KCM to show good state for reset, apply and… (authored by bport). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Delay 100ms before showing the menu

trmdi planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26453: [Purpose] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R495:8dc165f088f3: [Purpose] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26453?vs=72856=72949

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 160 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/160/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 08:43:01 + Build duration: 5 min 46 sec and counting BUILD ARTIFACTS

D26194: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R308:7b356e9dd1ad: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72946=72947 REVISION DETAIL

D26194: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72946. ahmadsamir added a comment. Rebase REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72116=72946 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26484: Delay 100ms before showing the menu

dfaure added a comment. Ah, menu items. Code that is connected to aboutToShow will always execute after popup() is called, so delaying the call to popup() can't possibly help, unless I'm missing something. Sounds like we just need a hook, like a signal emitted by this class, with a

D26484: Delay 100ms before showing the menu

trmdi added a comment. In D26484#589327 , @dfaure wrote: > I don't understand the reasoning, what is this waiting for? It is waiting for additional items to be added when the size is changed. REPOSITORY R241 KIO REVISION DETAIL

D25117: file ioslave: stop copying as soon as the ioslave is killed

dfaure added a comment. I don't see a problem with that. It's common to have activate a "test mode". In Qt (single process) there are tons of internal variables exported and used with "extern" in unittests. In multi-process scenarios we need cmdline args or env vars. REPOSITORY R241 KIO

D26484: Delay 100ms before showing the menu

dfaure added a comment. I don't understand the reasoning, what is this waiting for? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

dfaure added a comment. > faster if one msec is even perceivable at all. It's not, but if an application has 200 strings to translate, then there's a 0.2s difference. That starts to be perceivable. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26366 To: