D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R269:d08e77529bd1: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not… (authored by mlaurent).

D26484: Popup menu again to reposition it

trmdi retitled this revision from "Add a new parameter for delaying showing menu" to "Popup menu again to reposition it". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik,

D26484: Add a new parameter for delaying showing menu

trmdi removed a dependent revision: D26514: Delay popup for containments. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,

D26484: Add a new parameter for delaying showing menu

trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73175. trmdi added a comment. - Simplify the approach REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73114=73175 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES

D25490: Remove legacy plugin loading code

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH service REVISION DETAIL https://phabricator.kde.org/D25490 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella marked an inline comment as not done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 73172. nicolasfella marked 6 inline comments as done. nicolasfella added a comment. - More comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=73170=73172 BRANCH recentfilemenu REVISION

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 73170. nicolasfella marked 4 inline comments as done. nicolasfella added a comment. - Address comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=72928=73170 BRANCH recentfilemenu REVISION

Re: Fwd: KDE CI: Administration » Dependency Build Frameworks kf5-qt5 SUSEQt5.12 - Build # 66 - Still Failing!

On Fri, Jan 10, 2020 at 9:39 AM Friedrich W. H. Kossebau wrote: > > Am Donnerstag, 9. Januar 2020, 21:10:23 CET schrieb Ben Cooksley: > > Hi all, > > > > Please see the below Dependency Build failure, which happens on both our Qt > > 5.12 and Qt 5.13 images. > > It appears that for reasons

[sysadmin/ci-tooling] build-specs/Frameworks: Don't build QCH files for KDeclarative due to breakage in Doxygen.

Git commit a193f9562032cfdb4f338c996ab2c7519a516ecf by Ben Cooksley. Committed on 10/01/2020 at 00:09. Pushed by bcooksley into branch 'master'. Don't build QCH files for KDeclarative due to breakage in Doxygen. CCMAIL: kde-frameworks-devel@kde.org A +2-0

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. In D26555#591132 , @davidre wrote: > In D26555#591131 , @The-Feren-OS-Dev wrote: > > > In D26555#591126 , @davidre

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

davidre added a comment. In D26555#591131 , @The-Feren-OS-Dev wrote: > In D26555#591126 , @davidre wrote: > > > I still think the proper fix was to investigate why the widget explorer didn't show

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. In D26555#591126 , @davidre wrote: > I still think the proper fix was to investigate why the widget explorer didn't show an icon instead of randomly changing the icon it uses which can have potential impact on

D25653: [bookmarksmenu] Improve variable name

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R294:78cbabc2d675: [bookmarksmenu] Improve variable name (authored by nicolasfella). CHANGED PRIOR TO COMMIT

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

davidre added a comment. I still think the proper fix was to investigate why the widget explorer didn't show an icon instead of randomly changing the icon it uses which can have potential impact on other themes REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25490: Remove legacy plugin loading code

nicolasfella added a comment. Ping? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25490 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev retitled this revision from "Rename nepomuk Plasma Theme icons to 'search'" to "Rename 'nepomuk' Plasma Theme icons to 'search'". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev Cc: kde-frameworks-devel,

D26555: Rename nepomuk Plasma Theme icons to 'search'

The-Feren-OS-Dev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. The-Feren-OS-Dev requested review of this revision. REVISION SUMMARY BUG: 416072 Since the Milou/Search applet changed its icon from 'nepomuk' to 'search', the

D25655: Remove outdated comments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R294:b8c2e78e371c: Remove outdated comments (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST

D24629: RFC: Introduce KClockSkewNotifier class

zzag updated this revision to Diff 73158. zzag added a comment. Build with older versions of glibc. See D26553 REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24629?vs=72993=73158 BRANCH kclockskewnotifier

Re: Fwd: KDE CI: Administration » Dependency Build Frameworks kf5-qt5 SUSEQt5.12 - Build # 66 - Still Failing!

Am Donnerstag, 9. Januar 2020, 21:10:23 CET schrieb Ben Cooksley: > Hi all, > > Please see the below Dependency Build failure, which happens on both our Qt > 5.12 and Qt 5.13 images. > It appears that for reasons unknown, the QCH generation for KDeclarative > fails in our newly rebuilt images (it

Fwd: KDE CI: Administration » Dependency Build Frameworks kf5-qt5 SUSEQt5.12 - Build # 66 - Still Failing!

Hi all, Please see the below Dependency Build failure, which happens on both our Qt 5.12 and Qt 5.13 images. It appears that for reasons unknown, the QCH generation for KDeclarative fails in our newly rebuilt images (it also seems that CMake doesn't pick this up, as it fails at install rather

D25814: [KColorScheme] Add SeparatorColor

ndavis added a subscriber: broulik. ndavis added a comment. In D25814#591053 , @ngraham wrote: > I wonder if a path forward is to move this option into Breeze itself and keep it out of the color scheme. We would add an option for "dark

D25814: [KColorScheme] Add SeparatorColor

ngraham added a comment. I wonder if a path forward is to move this option into Breeze itself and keep it out of the color scheme. We would add an option for "dark separators when using a dark color scheme" in the super hidden Breeze settings window. REPOSITORY R265 KConfigWidgets

D26484: Add a new parameter for delaying showing menu

trmdi planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

ahmadsamir added inline comments. INLINE COMMENTS > davidedmundson wrote in ksortfilterproxymodel.cpp:101 > I'm not sure your comments are still valid, we switched to using the > superclass QSortFilterProxyModel's methods, and don't shadow that part here. Right, I was looking at an old

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson added inline comments. INLINE COMMENTS > ahmadsamir wrote in ksortfilterproxymodel.cpp:101 > In setFilterRegExp(), > QSortFilterProxyModel::setFilterRegularExpression(QRegularExpression &) is > used, so IIUC here it should be : >

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

ahmadsamir added inline comments. INLINE COMMENTS > ksortfilterproxymodel.cpp:101 > +{ > +return QSortFilterProxyModel::filterRegExp().pattern(); > +} In setFilterRegExp(), QSortFilterProxyModel::setFilterRegularExpression(QRegularExpression &) is used, so IIUC here it should be :

D26540: Consistency: colored selected buttons

mart added a comment. In D26540#590924 , @davidedmundson wrote: > Can you update tests/components/button.qml tests/components/button3.qml > > just a button with "focus: true" and some label that says "this should be highlighted on load"

D26540: Consistency: colored selected buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1d6870b15624: Consistency: colored selected buttons (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26540?vs=73122=73138

D26540: Consistency: colored selected buttons

davidedmundson added a comment. Can you update tests/components/button.qml tests/components/button3.qml just a button with "focus: true" and some label that says "this should be highlighted on load" REPOSITORY R242 Plasma Framework (Library) BRANCH phab/bluebutton REVISION

D26540: Consistency: colored selected buttons

mart added a comment. In D26540#590892 , @ngraham wrote: > +1 for consistency, definitely. One thing to note maybe for a future patch is that the focus behaviors is still a bit inconsistent with the desktop style: Clicking on a button doesn't

D26540: Consistency: colored selected buttons

ngraham added a reviewer: Goal: Consistency. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 for consistency, definitely. One thing to note maybe for a future patch is that the focus behaviors is still a bit inconsistent with the

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

mart added a comment. that depends how heavy the load() implementation is... both ways are not optimal.. this behavior comes from KCModule, where the module nevel loads itself and a load() must be called from outside. here may be worth doing that even if it's two loads as would

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

davidedmundson added a comment. I kinda see what you're saying, I don't understand why we currently do anything on showEvent() But now we're going to call load() twice, which doesn't sound very optimal. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26524

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 269 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/269/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 09 Jan 2020 14:18:26 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 261 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/261/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 09 Jan 2020 14:18:27 + Build duration: 8 min 58 sec and counting JUnit Tests Name:

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:27271405f408: SlaveBase::dispatchLoop: Fix timeout calculation (authored by Julien Goodwin jgood...@studio442.com.au, committed by kfunk). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added a dependent revision: D26544: [WIP] Switch the Plasma Desktop KCMs to using KNewStuffQuick. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26543 To: leinir, #frameworks, #plasma, ngraham, broulik, mart Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added reviewers: Frameworks, Plasma, ngraham, broulik, mart. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26543 To: leinir, #frameworks, #plasma, ngraham, broulik, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This patch changes the previous naive approach to a more elaborate, QQmlListProperty based one. It further introduces a

D26308: Set output device's logical size

romangg added a task: T11222: Reimagine output cloning. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26308 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26540: Consistency: colored selected buttons

mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26540 To: mart, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26540: Consistency: colored selected buttons

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY color selected buttons to the highlight color when it has keyboard focus. This makes

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

On Mon, Dec 30, 2019 at 3:03 AM Stephen Kelly wrote: > > > On 28/12/2019 23:30, Friedrich W. H. Kossebau wrote: > > Why are you proposing to do a step back instead to the old state, which > > everyone including you considered not that satisfying? > > Because it's a temporary situation. We still

[sysadmin/repo-metadata] projects/kdereview/grantlee: Strip Grantlee of it's KDE Git repository and therefore terminate it's status as a KDE project.

Git commit 510628f46bf2ecc6cba15e6940ca1bf3e941224c by Ben Cooksley. Committed on 09/01/2020 at 09:39. Pushed by bcooksley into branch 'master'. Strip Grantlee of it's KDE Git repository and therefore terminate it's status as a KDE project. Ref T12387 CCMAIL: kde-core-de...@kde.org CCMAIL: