D25632: Fix module imports with Python3

kossebau added a comment. No python developer myself, but from patterns seen I guess the imports should have some if sys.version_info.major < 3: // python2 import style else: // python3 import style ? REPOSITORY R264 KApiDox REVISION DETAIL

D25632: Fix module imports with Python3

kossebau added a comment. Hi. Sadly api.kde.org failed to pick this change up until yesterday, as I had forgotten a change in the local checkout on my last work on the server, which then blocked the update via scripted git pull. That I fixed partially yesterday, making sure latest KApiDox

D24932: Add button to open the folder in filelight to view more details

shubham abandoned this revision. shubham added a comment. Abandoned infavour of D26650 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks, broulik Cc: broulik, ltoscano, pino,

D26650: Use KService to look for Filelight

shubham created this revision. shubham added reviewers: broulik, ngraham. shubham added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. shubham requested review of this revision. REVISION SUMMARY Related to D24932

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH no-more-keyboard-selectability (branched from master) REVISION DETAIL https://phabricator.kde.org/D26649 To: ngraham, dfaure, #frameworks, #vdg, ndavis Cc:

D26648: Improved quality of JPEG thumbnails

chroniceel updated this revision to Diff 73480. chroniceel added a comment. Less is more, removing the line appears to be a solution as well. Assuming QImageReader uses sane defaults. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26648?vs=73477=73480 REVISION DETAIL

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. Okay, removing the line appears to have a similar effect to what I already did. I checked over on the imagecreator.cpp file, which appears to handle the thumbnailing of most other image types, and despite also using a QImageReader object, it does not call

D26648: Improved quality of JPEG thumbnails

chroniceel edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas,

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. I'm going to delete that line and see what happens. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. It appears to me that the setQuality() function is meant to, in this use case, to simply decide what downscaler to use. Higher values mean better quality downscaling. Sorry about the images, I did not realize I should have labelled them better. They are

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. Excerpt from the QImageReader class documentation, for the function setQuality(): "In case of scaled image reading, the quality setting may also influence the tradeoff level between visual quality and execution speed of the scaling algorithm." A

D26648: Improved quality of JPEG thumbnails

bruns added a comment. Unfortunately, the QImage**Reader** documentation is not very clear about the effect of `setQuality(..)`. There is a reference to `https://doc.qt.io/qt-5/qimagereader.html#setScaledSize`, and that in turn has a reference to `QImage::scale()` (which no longer exists in

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. This does not affect the size of the created thumbnail, as all thumbnails are stored as png images regardless of source image type. This simply allows the thumbnailer to downscale the image without the artifacting displayed in the screenshots. I have checked and

D26648: Improved quality of JPEG thumbnails

ngraham added reviewers: broulik, Frameworks, VDG. ngraham added a comment. Presumably this was for space saving reasons; there's a big size difference between a 0 quality JPEG and 100 quality. Maybe set it to 80 as a compromise? These are only thumbnails, after all. We don't want to take up

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ngraham created this revision. ngraham added reviewers: dfaure, Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, when you select text in the dialog box, an insertion point

D26648: Improved quality of JPEG thumbnails

chroniceel created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. chroniceel requested review of this revision. REVISION SUMMARY BUG: 411262 Simple tweak to increase quality of JPEG thumbnails. For some reason the

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham added a comment. No worries! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg, #plasma, broulik Cc: gvgeo, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26634: Correctly compute bottom margin for grid delegates with subtitles

gvgeo added a comment. In D26634#593595 , @ngraham wrote: > That's what you see with this patch? My apologies, I've made an error. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham,

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Err, yeah... This definitely makes more sense. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26617 To: meven, ervin, #frameworks, dfaure Cc:

D24629: RFC: Introduce KClockSkewNotifier class

zzag updated this revision to Diff 73471. zzag added a comment. Fix a typo. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24629?vs=73158=73471 BRANCH kclockskewnotifier REVISION DETAIL https://phabricator.kde.org/D24629 AFFECTED FILES

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > meven wrote in desktopexecparser.cpp:213 > > Can you call mimeTypes() instead of serviceTypes() here? I'm trying to > > slowly split the two notions, after it all got

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 97 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/97/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 13 Jan 2020 22:29:11 + Build duration: 2 min 33 sec and counting BUILD ARTIFACTS

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham added a comment. In D26634#593553 , @gvgeo wrote: > Then, is it an option to create GridDelegateSubtitles.qml instead? > As is now, without subtitles, I see everywhere squash shapes and bigger than necessary empty space. > > now

D26634: Correctly compute bottom margin for grid delegates with subtitles

gvgeo added a comment. Then, is it an option to create GridDelegateSubtitles.qml instead? As is now, without subtitles, I see everywhere squash shapes and bigger than necessary empty space. now vs before F7881612: slim empty.png In this

D26560: Fix selection printing

dhaumann added a comment. That looks already better: If a line is wrapped and on the same page, then only the selected text is printed. It seems there are still corner cases. 1. Create a document with just one long line that wraps over two printed pages. I this case, I am not able to

D24932: Add button to open the folder in filelight to view more details

ngraham added a comment. It would make more sense to submit a new patch. This one wasn't reverted, so it's not clear what would happen if we tried to land it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks, broulik Cc: broulik,

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

This revision was automatically updated to reflect the committed changes. Closed by commit R237:215986603c0f: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES (authored by davidre). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

davidre updated this revision to Diff 73455. davidre marked an inline comment as done. davidre added a comment. target_or_source_var REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26626?vs=73410=73455 BRANCH target (branched from master) REVISION

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven updated this revision to Diff 73449. meven marked 7 inline comments as done. meven added a comment. Address review REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26557?vs=73182=73449 BRANCH arcpatch-D26557 REVISION DETAIL

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham updated this revision to Diff 73446. ngraham marked 2 inline comments as done. ngraham added a comment. Fix comment whitespace REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26634?vs=73445=73446 BRANCH compute-bottom-margin-correctly

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > gvgeo wrote in GridDelegate.qml:81 > Maybe need to add caption.visible check, instead of always removing 3 > gridUnits? > Was changed from 2 in the previous commit. If I do that, then grids where some

D26635: GSCreator: Fix hang due to calling exit() after fork()

abizjak retitled this revision from "Fix hang due to calling exit() after fork()" to "GSCreator: Fix hang due to calling exit() after fork()". REPOSITORY R373 Image Thumbnailers REVISION DETAIL https://phabricator.kde.org/D26635 To: abizjak, #frameworks

D26635: Fix hang due to calling exit() after fork()

abizjak created this revision. abizjak added a reviewer: Frameworks. abizjak requested review of this revision. REVISION SUMMARY After fork(), exit() invokes atexit handlers, which can result in a lockup if an atexit handler uses thread synchronization facilities, since all but the current

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg, #plasma, broulik Cc: gvgeo, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham updated this revision to Diff 73445. ngraham added a comment. Work around https://bugreports.qt.io/browse/QTBUG-49646 REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26634?vs=73439=73445 BRANCH compute-bottom-margin-correctly (branched from

D26634: Correctly compute bottom margin for grid delegates with subtitles

gvgeo added inline comments. INLINE COMMENTS > GridDelegate.qml:81 > height: Kirigami.Settings.isMobile ? Math.round((delegate.width - > Kirigami.Units.gridUnit) / 1.6) > : > Math.min(delegate.GridView.view.implicitCellHeight -

D26616: Adjust metainfo.yaml to new tier

This revision was automatically updated to reflect the committed changes. Closed by commit R307:0422b0f449c1: Adjust metainfo.yaml to new tier (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26616?vs=73374=73442 REVISION DETAIL

D26633: Deprecate KWindowEffects::markAsDashboard()

zzag marked an inline comment as done. REPOSITORY R278 KWindowSystem BRANCH deprecate-dashboard REVISION DETAIL https://phabricator.kde.org/D26633 To: zzag, #kwin, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26633: Deprecate KWindowEffects::markAsDashboard()

zzag updated this revision to Diff 73440. zzag added a comment. Add `@deprecated since` REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26633?vs=73436=73440 BRANCH deprecate-dashboard REVISION DETAIL https://phabricator.kde.org/D26633 AFFECTED

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham added a comment. Oh wow, I just noticed that putting these labels in a ColumnLayout triggered the infamous QML text kerning bug! https://bugreports.qt.io/browse/QTBUG-49646 Could that be a clue to solving it maybe? Seeing this now, I can revert the change to use a

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY When I added the subtitle feature, I didn't notice that the bottom

D26633: Deprecate KWindowEffects::markAsDashboard()

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kwindoweffects.h:164 > * > * @param window The window for which to enable the blur effect > */ @deprecated since 5.67, support for dashboard windows was removed

D26633: Deprecate KWindowEffects::markAsDashboard()

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY "Support" for dashboard windows in KWin was removed long time ago. REPOSITORY R278

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, thanks David! Please address kossebau's comments before landing. REPOSITORY R237 KConfig BRANCH target (branched from master) REVISION DETAIL

D26616: Adjust metainfo.yaml to new tier

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH tier REVISION DETAIL https://phabricator.kde.org/D26616 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24401: Use exposed DBus methods to switch activities in CLI

ngraham added a comment. Yep. This is an odd case of a framework depending on Plasma, not the more typical reverse! REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24401: Use exposed DBus methods to switch activities in CLI

muesli added a comment. Actually I'm mistaken, we can't merge this just yet. We'll still need to wait for the Plasma 5.18 release. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

davidre added a subscriber: kossebau. davidre added a comment. Sorry for removing you, I had accidentally opened the change subscribers lineedit REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26626 To: davidre, #frameworks, #build_system Cc: kossebau,

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

davidre removed a subscriber: kossebau. davidre added a comment. For context as I'm not very proficient in CMake this is mostly a copy of https://phabricator.kde.org/D22698 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26626 To: davidre, #frameworks,

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

kossebau added a comment. While touching this file, you might want to fix this file and make it self-contained by also having a `include(CMakeParseArguments)` at the begin, could be done as direct commit, no review needed IMHO :) No comment on the actual new method API, I yet have to

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

davidre added reviewers: Frameworks, Build System. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26626 To: davidre, #frameworks, #build_system Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

crossi updated this revision to Diff 73411. crossi added a comment. API documentation. Schedule settingsChanged(). Clean up the list. Code style. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26046?vs=71673=73411 REVISION DETAIL

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Brings us one step to closer to not needing to create lists of source files REPOSITORY R237 KConfig BRANCH target

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir updated this revision to Diff 73408. leinir added a comment. - As 5.66 was released, update @since to 5.67 - CMakeLists version requirement fun (for easier testing) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26543?vs=73187=73408 BRANCH

D25682: add initial wsdiscovery support

sitter added inline comments. INLINE COMMENTS > dfaure wrote in discovery.cpp:31 > Lines 30-31 duplicate lines 23-28, surely this can't link without errors? They are not. Discover**y** vs. Discover**er**. I am not super fond of the naming though, for exactly that reason :S > dfaure wrote in

D25682: add initial wsdiscovery support

sitter retitled this revision from "[WIP] add initial wsdiscovery support" to "add initial wsdiscovery support". sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter, dfaure, #frameworks, #dolphin Cc: meven,

D25682: [WIP] add initial wsdiscovery support

sitter updated this revision to Diff 73405. sitter marked 19 inline comments as done. sitter added a comment. since there's not been much design input let's move to actual review primary change here is that wsdiscoverer no longer uses qtconcurrent but instead signal slots on the same

D26623: KEMailSettings: group names in kconfig files should not be localized

meven retitled this revision from "KEMailSettings: key names in kconfig files do not need to be localized" to "KEMailSettings: group names in kconfig files should not be localized". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26623 To: meven, #frameworks, ervin

D26623: KEMailSettings: key names in kconfig files do not need to be localized

meven created this revision. meven added reviewers: Frameworks, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This breaks compatiblity with xdg-email for some locals (i.e french) since it is

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 268 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/268/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 13 Jan 2020 12:35:25 + Build duration: 7 min 50 sec and counting JUnit Tests Name:

D26484: Add KIO::DropJobFlag to allow manually showing the menu

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fbb2be9aad19: Add KIO::DropJobFlag to allow manually showing the menu (authored by trmdi). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73399=73400

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi updated this revision to Diff 73399. trmdi added a comment. - Comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73364=73399 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/widgets/dropjob.cpp

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 275 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/275/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 13 Jan 2020 12:06:33 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 267 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/267/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 13 Jan 2020 12:06:33 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D26560: Fix selection printing

hoffmannrobert added a reviewer: dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26560 To: hoffmannrobert, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1e7a62c98f8a: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26492?vs=72972=73394#toc

Re: KApplicationTrader API

> > Note that the least-porting-effort solution is self() and trader language, > since the code currently uses KServiceTypeTrader for this. > > But I'm tempted to say lambdas are nicer (you can debug the filtering more > easily), and would allow to kill the whole > trader-language-parser from

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. In D26122#581717 , @apol wrote: > I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. To reiterate. The use case is to avoid

D26122: Add utility text function KShell::tildeCollapse

meven updated this revision to Diff 73386. meven added a comment. Update KF5 version in @since REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26122?vs=71898=73386 BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 AFFECTED

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26617 To: meven, ervin, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

meven added a comment. 1771412c7cf8a8d07af4fe2687e2a698e409d73b introduced the instanciation of a KService for a created service, only when it was not associated to a mimetype. REPOSITORY R241 KIO REVISION

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

meven created this revision. meven added reviewers: ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26617

D26595: Add network-wireless-hotspot icon

meven added a dependent revision: D26392: Add option to easily configure and start a hotspot. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26595 To: cblack, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26614: Remove extra flush when we close file it will flush

This revision was automatically updated to reflect the committed changes. Closed by commit R269:aed4416be700: Remove extra flush when we close file it will flush (authored by mlaurent). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26614?vs=73365=73378

D26202: WIP: Refactor KConfigXT

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > tcanabrava wrote in kconfigcompiler_test.cpp:129 > the text was really not friendly, it was a big blob of diff content pasted on > screen. Considering that

D24932: Add button to open the folder in filelight to view more details

shubham added a comment. @broulik I believe this is what you wanted? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks, broulik Cc: broulik, ltoscano, pino, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham,

D26099: Port QRegExp to QRegularExpression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R293:eec35486c419: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R293 Baloo CHANGES SINCE

D24932: Add button to open the folder in filelight to view more details

shubham updated this revision to Diff 73376. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24932?vs=72263=73376 REVISION DETAIL https://phabricator.kde.org/D24932 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, ngraham, #frameworks, broulik

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 274 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/274/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 13 Jan 2020 08:30:33 + Build duration: 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 87 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/87/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 13 Jan 2020 08:45:34 + Build duration: 5 min 34 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/56/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 13 Jan 2020 08:45:38 + Build duration: 3 min 49 sec and counting JUnit Tests

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 266 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/266/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 13 Jan 2020 08:30:32 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D26484: Add KIO::DropJobFlag to allow manually showing the menu

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. You can land after making these last minute adjustments, no need for another round of review :) INLINE COMMENTS > dropjob.h:83 > + * @since 5.67 > + **/ > +void showMenu(const

D26616: Adjust metainfo.yaml to new tier

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY With the KService dependency gone it is Tier 2 now REPOSITORY

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 42 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/42/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 13 Jan 2020 08:29:27 + Build duration: 3 min 14 sec and counting JUnit Tests

D26099: Port QRegExp to QRegularExpression

dfaure accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent, apol, dfaure Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D25490: Remove legacy plugin loading code

This revision was automatically updated to reflect the committed changes. Closed by commit R307:fac77e1796e3: Remove legacy plugin loading code (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25490?vs=70219=73373 REVISION DETAIL

D26614: Remove extra flush when we close file it will flush

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH remove_extra_flush (branched from master) REVISION DETAIL https://phabricator.kde.org/D26614 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella added a comment. In D26604#592808 , @broulik wrote: > What again was the reason for not just sending a notification where DBus activation will do its thing? Saving us a futile DBus calls, but I don't know if that matters in

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 86 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/86/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 13 Jan 2020 07:59:22 + Build duration: 2 min 19 sec and counting CONSOLE OUTPUT