KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 96 - Still Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/96/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 20 Jan 2020 01:56:52 + Build duration: 1 min 45 sec and counting JUnit Tests Name:

D26740: Add KService::isSubseq as a public API for filtering queries.

2020-01-19 Thread Aleix Pol Gonzalez
apol added a comment. > I like isSubsequence(). But I also just realized, it's a bit odd to have this in KService. I think I should make it part of the KApplicationTrader namespace instead, since it's a utility method for querying. > This means merging with D25698

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

2020-01-19 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. Looks good to me, bonus points if you provide a better commit message explaining what it does and how you tested it. REPOSITORY R240 Extra CMake Modules BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751 To:

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-19 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > Android.cmake:173 > +set(ANDROID_STL ${CMAKE_ANDROID_STL_TYPE}) > +include(${CMAKE_ANDROID_NDK}/build/cmake/android.toolchain.cmake REQUIRED) > + Why's this better? Or how is it different? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D26735: [Components 3]Make slider tickmarks optional

2020-01-19 Thread Aleix Pol Gonzalez
apol added a comment. But this means that for your keyboard it's either on or off, right? This is what it looks for me. The screen has hundreds of steps so it shows nothing, for the keyboard it has a middle step so it's shown below. I don't think it should be removed. F7893059:

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread patrick j pereira
patrickelectric added a comment. Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ? In #kirogi we provide a valid icon (svg) with a valid prefix (sc), as you probably know *sc* stands

D25015: Update breeze theme shadows

2020-01-19 Thread Niccolò Venerandi
niccolove added a comment. I posted the previous comment in a eccessive state of tiredness and nervousness :-) I will look into doing a better mask *before* asking to land the patch, so I can be sure it's the right patch forward. REPOSITORY R242 Plasma Framework (Library) BRANCH

D25798: Deprecated allowAsDefault

2020-01-19 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH allo REVISION DETAIL https://phabricator.kde.org/D25798 To: nicolasfella, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2020-01-19 Thread Elvis Angelaccio
elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Haven't tried the dolphin branch yet, just a comment on the API for now. From a quick look the patch looks good though. INLINE COMMENTS > kfileplacesview.h:68

D26635: GSCreator: Fix hang due to calling exit() after fork()

2020-01-19 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R373:3e2ea6e924d0: GSCreator: Fix hang due to calling exit() after fork() (authored by abizjak, committed by elvisangelaccio). REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE

D25798: Deprecated allowAsDefault

2020-01-19 Thread Nicolas Fella
nicolasfella added a reviewer: dfaure. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25798 To: nicolasfella, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26635: GSCreator: Fix hang due to calling exit() after fork()

2020-01-19 Thread Ambroz Bizjak
abizjak added a comment. Ambroz Bizjak REPOSITORY R373 Image Thumbnailers REVISION DETAIL https://phabricator.kde.org/D26635 To: abizjak, #frameworks, elvisangelaccio Cc: elvisangelaccio

D25015: Update breeze theme shadows

2020-01-19 Thread Niccolò Venerandi
niccolove added a comment. Regarding the mask: I'd keep it as is right now and look more into it in the (very near) future. Currently the difference is not noticeable even on different scalings and I cannot find another working solution, so I think it should not be a blocking issue. But

D26306: Define more documentation search paths (also custom)

2020-01-19 Thread Andreas Sturmlechner
asturmlechner added a comment. In D26306#585587 , @asturmlechner wrote: > Thanks for that, works for me! Correction, the tests seem to fail even though runtime is fine. See also https://bugs.gentoo.org/705340 REPOSITORY R238

D26202: Refactor KConfigXT

2020-01-19 Thread Tomaz Canabrava
tcanabrava added a comment. In D26202#597044 , @davidre wrote: > I checked https://cgit.kde.org/kconfig.git/tree/src/kconfig_compiler/kcfg.xsd and it says > > > > >

D26635: GSCreator: Fix hang due to calling exit() after fork()

2020-01-19 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Looks safe enough to me. Can you provide an email address for the git authorship? Thanks! REPOSITORY R373 Image Thumbnailers REVISION DETAIL

D26202: Refactor KConfigXT

2020-01-19 Thread David Redondo
davidre added a comment. I checked https://cgit.kde.org/kconfig.git/tree/src/kconfig_compiler/kcfg.xsd and it says According to google default of `minOccurs` is 1 so empty files are indeed not

D26771: Add new signal for default action activation

2020-01-19 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH default REVISION DETAIL https://phabricator.kde.org/D26771 To: nicolasfella, #frameworks, broulik, davidedmundson Cc: davidedmundson, kde-frameworks-devel,

D26771: Add new signal for default action activation

2020-01-19 Thread Nicolas Fella
nicolasfella updated this revision to Diff 73893. nicolasfella added a comment. - Actually emit it REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26771?vs=73891=73893 BRANCH default REVISION DETAIL https://phabricator.kde.org/D26771 AFFECTED

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Ben Cooksley
bcooksley requested changes to this revision. bcooksley added a comment. Christophe is correct here, it is worth warning developers about these issues regardless of the platform, so they can get the code ready for those platforms and test everything in their local environment as much as

D26202: Refactor KConfigXT

2020-01-19 Thread Ben Cooksley
bcooksley added a comment. I can confirm that force pushes are blocked within KDE Git repositories, although we will be opening up `work/` branches at some point which will permit it (and be un-notified in terms of hook processing) REPOSITORY R237 KConfig BRANCH rework_kconfig_compiler

D26771: Add new signal for default action activation

2020-01-19 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Concept ++ I think you've missed some change in knotification.cpp to actually emit this. REPOSITORY R289 KNotifications REVISION DETAIL

D26771: Add new signal for default action activation

2020-01-19 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY activated is an overloaded signal. Add a new signal to

D26202: Refactor KConfigXT

2020-01-19 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Don't force push. It's not what I meant, and I don't think it's even permitted in kde repos. The WIP commit was reverted anyway (so it was indeed work in progress, haha). The comment

D25698: New query mechanism for applications: KApplicationTrader

2020-01-19 Thread David Faure
dfaure updated this revision to Diff 73890. dfaure marked an inline comment as done. dfaure added a comment. Simplify docu for query() REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25698?vs=73858=73890 BRANCH kapplicationtrader REVISION DETAIL

D25698: New query mechanism for applications: KApplicationTrader

2020-01-19 Thread David Faure
dfaure marked 3 inline comments as done. dfaure added inline comments. INLINE COMMENTS > aacid wrote in kapplicationtrader.h:56 > why is it slow? Looking at the code we have to go trhough all apps anyway > since what we do is erase if returning false, so wouldn't returning true > actually be

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D26752#596949 , @tcanabrava wrote: > > I don't see the gain on having a warning - in a windows system, about > missing mac icons if I'm not *deploying*. Then fix your code. ie only call

D26769: Always strip html if server does not support it

2020-01-19 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The spec does not say that text containing markup has to

Re: D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Tomaz Canabrava
I think we are misunderstanding eachother here. If I'm developing the software and running cmake all the time, having a warning that I can't fix (because it depends in another platform) is noise, but still being a developer I don't want to run with -Wno-dev. I do work in applications that targets

D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup

2020-01-19 Thread Hannah von Reth
This revision was automatically updated to reflect the committed changes. Closed by commit R289:4f2b04a171c3: Strip richtext on Windows (authored by vonreth). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26756?vs=73885=73887#toc REPOSITORY R289 KNotifications CHANGES SINCE LAST

D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup

2020-01-19 Thread Nicolas Fella
nicolasfella accepted this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26756 To: vonreth, broulik, brute4s99, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup

2020-01-19 Thread Hannah von Reth
vonreth updated this revision to Diff 73885. vonreth added a comment. whitespace REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26756?vs=73884=73885 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26756 AFFECTED FILES

D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup

2020-01-19 Thread Hannah von Reth
vonreth updated this revision to Diff 73884. vonreth retitled this revision from "Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup " to "Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup". vonreth added a comment. Whitespace

D25015: Update breeze theme shadows

2020-01-19 Thread Noah Davis
ndavis added a comment. Just in case you misunderstood me, when I said create the corners from rounded rectangles, I meant create the rounded rectangle and cut off the parts you don't need so that you're left with corners that you can place however you need. If you're not aware of it, check

D26202: Refactor KConfigXT

2020-01-19 Thread Tomaz Canabrava
tcanabrava added a comment. @dfaure I tried to remove the `WIP` from the history but I'm worried that will force git push --force as I merged this with the wip before. any hints? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks,

D26202: Refactor KConfigXT

2020-01-19 Thread Tomaz Canabrava
tcanabrava retitled this revision from "WIP: Refactor KConfigXT" to "Refactor KConfigXT ". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: cgiboudeaux, kossebau, bport, ngraham, kde-frameworks-devel,

D26768: Revert "Revert "WIP: Refactor KConfigXT""

2020-01-19 Thread Tomaz Canabrava
tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This reverts commit 5f8c2ce63499d05dfb4753eb1acc21dccf21d434

D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup

2020-01-19 Thread Nicolas Fella
nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. you can push the two commits directly INLINE COMMENTS > knotificationplugin.h:104 > + > + > Q_SIGNALS: remove one empty line > notifybysnore.cpp:62 > > + >

Re: Updating our coding conventions and coding style for C++11

2020-01-19 Thread Elvis Angelaccio
Hi, On 16/01/20 18:46, Kai Uwe Broulik wrote: > Hi, > > for "auto" I think we should always annotate it with const, *, and/or & > where appropriate: > > auto *something = new MyCustomType; > auto *keyEvent = static_cast(event); IMHO the * here is redundant and only adds noise. It's clear that

D26755: [WIP] KMessageWidget: Set widget height on resize event

2020-01-19 Thread Juraj Oravec
SGOrava added a comment. it would, but I am not such great guru. I tried few ways to change the behaviour but it was even worse, and since this is used in many programs I do not want to break them. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26755 To:

D25015: Update breeze theme shadows

2020-01-19 Thread Noah Davis
ndavis added a comment. I'll trust your judgement on the masks and corners. If there's a problem, it can be patched. I know this stuff can be super janky at times. REPOSITORY R242 Plasma Framework (Library) BRANCH bettershadows (branched from master) REVISION DETAIL

D26755: [WIP] KMessageWidget: Set widget height on resize event

2020-01-19 Thread Dominik Haumann
dhaumann added a comment. Well, it definitely would be very nice if you find a patch that fixes this. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks Cc: anthonyfieroni, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26767: [KMessageWidget] Subtract the correct margin

2020-01-19 Thread David Redondo
davidre updated this revision to Diff 73881. davidre added a comment. Update comment REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26767?vs=73880=73881 BRANCH margins (branched from master) REVISION DETAIL https://phabricator.kde.org/D26767

D26767: [KMessageWidget] Subtract the correct margin

2020-01-19 Thread David Redondo
davidre edited reviewers, added: SGOrava; removed: svuorela. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26767 To: davidre, #frameworks, SGOrava, svuorela Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26767: [KMessageWidget] Subtract the correct margin

2020-01-19 Thread David Redondo
davidre edited the test plan for this revision. davidre added reviewers: Frameworks, svuorela. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26767 To: davidre, #frameworks, svuorela Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26767: [KMessageWidget] Subtract the correct margin

2020-01-19 Thread David Redondo
davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY The comment describes a 1px border but the border actually has a size of 2px. REPOSITORY R236 KWidgetsAddons BRANCH

D26766: Revert "Revert "WIP: Refactor KConfigXT""

2020-01-19 Thread Tomaz Canabrava
tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Simplify If-Else chain inside of defaultValue function Use a type collection to verify which value we should

D26766: Revert "Revert "WIP: Refactor KConfigXT""

2020-01-19 Thread Tomaz Canabrava
tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26766 To: tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup

2020-01-19 Thread Hannah von Reth
vonreth retitled this revision from "Strip richtext on Windows, as Windows does not support it" to "Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup ". vonreth edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL

D26756: Strip richtext on Windows, as Windows does not support it

2020-01-19 Thread Hannah von Reth
vonreth added a comment. And here in clean with proper commits https://github.com/TheOneRing/knotifications/tree/rhichtext REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26756 To: vonreth, broulik, brute4s99 Cc: nicolasfella, kde-frameworks-devel,

D26756: Strip richtext on Windows, as Windows does not support it

2020-01-19 Thread Hannah von Reth
vonreth updated this revision to Diff 73875. vonreth added a comment. - Drop dependency to KF5Codecs by using the new stripRichText function REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26756?vs=73850=73875 BRANCH master REVISION DETAIL

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D26752#596809 , @tcanabrava wrote: > That’s not a developer issue, it’s a packaging issue. AUTHOR_WARNING *is* for developers. If you want to hide these warnings, use -Wno-dev [1] [1]

D26755: [WIP] KMessageWidget: Set widget height on resize event

2020-01-19 Thread Juraj Oravec
SGOrava added a comment. This is the test I used to check the validity of my change, it kind of always fails. I only hope someone can fix this widget at least for KF6. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks Cc:

D26755: [WIP] KMessageWidget: Set widget height on resize event

2020-01-19 Thread Juraj Oravec
SGOrava updated this revision to Diff 73872. SGOrava added a comment. - KMessageWidget: Add resize autotest REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26755?vs=73845=73872 BRANCH more-proper-height (branched from master) REVISION DETAIL

D26755: [WIP] KMessageWidget: Set widget height on resize event

2020-01-19 Thread Juraj Oravec
SGOrava added a comment. It looks good. But I wrote a test as you suggested which still fails. The test creates parent widget and puts the kmesagewidget and qlistwidget in it in vertical order (as in my test app) and than it resizes the parent widget and compares the height (the

D26755: [WIP] KMessageWidget: Set widget height on resize event

2020-01-19 Thread Dominik Haumann
dhaumann resigned from this revision. dhaumann added a comment. This revision now requires review to proceed. In that case I withdraw my review for now. I can only speak for Kate that I could not find a regression with my tests. But if you find other regressions, then this is likely not

D26755: [WIP] KMessageWidget: Set widget height on resize event

2020-01-19 Thread Anthony Fieroni
anthonyfieroni added a comment. That's same issue when file is open then externally modified then updated by kmessagewidget button cause a frame to not resize correct? REPOSITORY R236 KWidgetsAddons BRANCH more-proper-height (branched from master) REVISION DETAIL

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Tomaz Canabrava
tcanabrava added a comment. That’s not a developer issue, it’s a packaging issue. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava, cgiboudeaux Cc: apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem,

Re: D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Tomaz Canabrava
That’s not a developer issue, it’s a packaging issue. On Sun, 19 Jan 2020 at 12:02 Christophe Giboudeaux < nore...@phabricator.kde.org> wrote: > cgiboudeaux added a comment. View Revision > > > You may use Linux to develop software that's intended to be used

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Christophe Giboudeaux
cgiboudeaux added a comment. You may use Linux to develop software that's intended to be used also on Mac and Windows. You can't expect developers to have build environment for every platform REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To:

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Tomaz Canabrava
tcanabrava added a subscriber: apol. tcanabrava added a comment. But why would I get the warning if I build on Linux? The warning should target the platform, not the entire build system. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To:

Re: D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Tomaz Canabrava
But why would I get the warning if I build on Linux? The warning should target the platform, not the entire build system. On Sun, 19 Jan 2020 at 10:00 Christophe Giboudeaux < nore...@phabricator.kde.org> wrote: > cgiboudeaux requested changes to this revision. > cgiboudeaux added a comment. >

D25698: New query mechanism for applications: KApplicationTrader

2020-01-19 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > kapplicationtrader.h:56 > + * true for all services, this would return the complete list of all > + * installed applications (slow). > + * why is it slow? Looking at the code we have to go trhough all apps anyway since what we do is

D26755: [WIP] KMessageWidget: Set widget height on resize event

2020-01-19 Thread Juraj Oravec
SGOrava retitled this revision from "KMessageWidget: Set widget height on resize event" to "[WIP] KMessageWidget: Set widget height on resize event". REPOSITORY R236 KWidgetsAddons BRANCH more-proper-height (branched from master) REVISION DETAIL https://phabricator.kde.org/D26755 To:

D26755: KMessageWidget: Set widget height on resize event

2020-01-19 Thread Juraj Oravec
SGOrava added a comment. No, my tests say no. This does not update sizeHint which can cause some issue later. It sure looks nice in my test app but it is wrong in the core. This is not the right solution. REPOSITORY R236 KWidgetsAddons BRANCH more-proper-height (branched from

D26755: KMessageWidget: Set widget height on resize event

2020-01-19 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I just tested with KTextEditor's messagetest and KTextEditor's usage of KMessageWidget in the top and bottom bar, and all this looks still good. +1 from my side. Another review

D26757: Reduce dependencies on Windows

2020-01-19 Thread Hannah von Reth
vonreth added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:42 > This results in KStatusNotifierItem not being built on Windows. Is KSNI any > useful on Windows at all? Nope :D REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL

D26757: Reduce dependencies on Windows

2020-01-19 Thread Hannah von Reth
This revision was automatically updated to reflect the committed changes. Closed by commit R289:424fc980d9e3: Reduce dependencies on Windows (authored by vonreth). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26757?vs=73851=73866 REVISION DETAIL

KDE CI: Frameworks » khtml » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:11 + Build duration: 6 hr 59 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:11 + Build duration: 6 hr 55 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:10 + Build duration: 6 hr 45 min and counting JUnit Tests

KDE CI: Frameworks » kded » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:10 + Build duration: 6 hr 44 min and counting

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:11 + Build duration: 6 hr 42 min and counting

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 40 min and counting JUnit Tests

D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler

2020-01-19 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R237:3e287d5fa29b: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler (authored by kossebau). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kdbusaddons » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdbusaddons/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 38 min and counting JUnit Tests

D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler

2020-01-19 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH dependonkconfigcompiler REVISION DETAIL https://phabricator.kde.org/D26723 To: kossebau, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » karchive » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 38 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 34 min and counting JUnit Tests

KDE CI: Frameworks » kpackage » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 34 min and counting JUnit Tests

KDE CI: Frameworks » kdelibs4support » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:04 + Build duration: 6 hr 34 min and counting JUnit Tests

KDE CI: Frameworks » kidletime » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kidletime/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 31 min and counting

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 30 min and counting JUnit Tests

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 25 min and counting JUnit Tests

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 22 min and counting JUnit Tests

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 18 min and counting JUnit Tests

KDE CI: Frameworks » kjobwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 13 min and counting

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:09 + Build duration: 6 hr 13 min and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:04 + Build duration: 6 hr 11 min and counting JUnit Tests

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-19 Thread Christophe Giboudeaux
cgiboudeaux requested changes to this revision. cgiboudeaux added a comment. This revision now requires changes to proceed. I object. This warning is for developers. It tells them the icons are missing for some platforms. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:51:05 + Build duration: 6 hr 9 min and counting JUnit Tests

KDE CI: Frameworks » kcompletion » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcompletion/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:50:58 + Build duration: 6 hr 4 min and counting JUnit Tests

KDE CI: Frameworks » knotifyconfig » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifyconfig/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:50:55 + Build duration: 6 hr 4 min and counting

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:50:53 + Build duration: 6 hr 3 min and counting JUnit Tests Name:

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:50:56 + Build duration: 6 hr 1 min and counting

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:50:53 + Build duration: 6 hr 0 min and counting

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:50:52 + Build duration: 5 hr 58 min and counting JUnit Tests

KDE CI: Frameworks » kplotting » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:50:53 + Build duration: 5 hr 56 min and counting JUnit Tests

KDE CI: Frameworks » kdesignerplugin » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Successful!

2020-01-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdesignerplugin/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:50:52 + Build duration: 5 hr 56 min and counting JUnit Tests

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Unstable!

2020-01-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 03:50:52 + Build duration: 5 hr 53 min and counting JUnit Tests

  1   2   >