D26801: Really fix the Windows backend for KNotifications

brute4s99 added inline comments. INLINE COMMENTS > broulik wrote in notifybysnore.cpp:200 > Does the notification still end up with an `id` eventually? yes. I've used the id in the new patch REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26801 To: brute4s99,

D26801: Really fix the Windows backend for KNotifications

brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26801 To: brute4s99, vonreth, broulik, #kde_connect Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode, Orage, ritwizsinha, LeGast00n,

D26888: work around to fully support the windows backend

brute4s99 reclaimed this revision. brute4s99 added a comment. sorry. abandoned wrong diff REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent updated this revision to Diff 74406. mlaurent added a comment. Use QStringRef::compare REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26890?vs=74349=74406 BRANCH port_QXmlStreamReader (branched from master) REVISION DETAIL

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent marked 4 inline comments as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26890 To: mlaurent, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Introducing SPDX License Headers

Hi, On 1/26/20 7:59 PM, Andreas Cord-Landwehr wrote: Does this approach sound reasonable? If anybody wants to review my conversion tool and the license-header-to-SPDX-translations, I am happy for feedback! +1 It appears like the SPDX markers are not used in the source code of your

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/104/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 27 Jan 2020 00:21:13 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/78/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 27 Jan 2020 00:21:01 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/75/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 27 Jan 2020 00:21:09 + Build duration: 8 min 57 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 77 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/77/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 26 Jan 2020 23:58:17 + Build duration: 3 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 103 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/103/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 26 Jan 2020 23:58:17 + Build duration: 2 min 59 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/74/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 26 Jan 2020 23:58:17 + Build duration: 2 min 8 sec and counting JUnit Tests Name:

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21381 To: mgallien, aacid, yurchor, apol Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

cgiboudeaux added a comment. LGTM REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

meven added inline comments. INLINE COMMENTS > sitter wrote in kpropertiesdialog.cpp:1114 > I'm pretty sure that isn't true. > > KFilePropsPlugin are the tabs inside the properties dialog. They get > instantiated for each dialog and destroyed when the dialog is destroyed. They > are not

D26931: Introduce SPDX license headers

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Introducing SPDX License Headers

Hi, as discussed during last Akademy's KF6 BoF and the KF6 sprint, as well as on the KDE community list, SPDX license information can help us a lot in maintaining a (automatically checkable) good license quality throughout our libraries. Since today, SPDX markers are also known in the KDE

D26931: Introduce SPDX license headers

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D26931 AFFECTED FILES

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/73/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 26 Jan 2020 17:22:06 + Build duration: 59 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 102 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/102/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 26 Jan 2020 17:22:06 + Build duration: 54 sec and counting CONSOLE OUTPUT [...truncated 290

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 76 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/76/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 26 Jan 2020 17:22:06 + Build duration: 53 sec and counting CONSOLE OUTPUT [...truncated 286

D26900: Support multiple values in XDG_CURRENT_DESKTOP

dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26900 To: dfaure, apol, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26900: Support multiple values in XDG_CURRENT_DESKTOP

dfaure added inline comments. INLINE COMMENTS > apol wrote in kservice.cpp:658 > This adds a "KDE" allocation on every which isn't ideal either. I don't know, > maybe it doesn't matter either way... Well, it's a QStringLiteral, AFAIK the QString just points to pre-allocated UTF-16 data. Not

D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams

waqar added inline comments. INLINE COMMENTS > guesslanguage.cpp:745 > > -while (it.hasNext() && counter < m_maxItems && confidence < > m_minConfidence) { > +while (it.hasNext() && counter < m_maxItems && (m_minConfidence == 0.0 > || confidence < m_minConfidence)) { >

D15645: Add scheme selection menu with a "System" entry.

amhndu abandoned this revision. amhndu added a comment. Superseded by D25877 REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino Cc: pino, ngraham,

D26920: Change VLC icon to be more like official VLC icons

ngraham added a comment. Retroactive +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26920 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26855: Add icon for KTrip

nicolasfella abandoned this revision. nicolasfella added a subscriber: jriddell. nicolasfella added a comment. @jriddell added the icon already REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26855 To: nicolasfella, #breeze, ndavis Cc: jriddell,

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol added inline comments. INLINE COMMENTS > kconfigloader.cpp:77 > +case QXmlStreamReader::Characters: > +if (!reader.isWhitespace() && > !reader.text().toString().trimmed().isEmpty()) { > +if (!characters(reader.text())) No need to construct a QString if

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 174 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/174/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 26 Jan 2020 13:05:05 + Build duration: 8 min 38 sec and counting JUnit Tests Name:

D26900: Support multiple values in XDG_CURRENT_DESKTOP

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. The patch looks good to me. INLINE COMMENTS > apol wrote in kservice.cpp:658 > You can use QVector here, it would save us constructing a bunch > of strings for no reason. Maybe not in the

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/55/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 26 Jan 2020 12:54:34 + Build duration: 4 min 6 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/89/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 26 Jan 2020 12:54:35 + Build duration: 4 min 10 sec and counting JUnit Tests Name:

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

This revision was automatically updated to reflect the committed changes. Closed by commit R240:e8abb9601c7d: ECMAddAppIcon: Add sc in regex to extract extension from valid names (authored by patrickelectric). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D23457: Port the search interface from QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 74387. ahmadsamir added a comment. - Rebase - Match the old code and check if the pattern is empty, this lets the vimode_emulatedcommandbar unit test pass REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/75/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 26 Jan 2020 10:26:41 + Build duration: 6 min 32 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/101/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 26 Jan 2020 10:26:41 + Build duration: 6 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/72/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 26 Jan 2020 10:26:41 + Build duration: 2 min 47 sec and counting JUnit Tests Name: