D27263: RFC: Accent colour for KColorScheme

cblack edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack added a task: T11052: Accent Colors, Color Ramps and other improvements to theming.. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh,

D27263: RFC: Accent colour for KColorScheme

cblack planned changes to this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY This is a roughly thrown-together patch demonstrating how an accent colour can be

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 292 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/292/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 04:42:07 + Build duration: 8 min 20 sec and counting JUnit Tests Name:

D27220: add pix icon

mbruchert added a comment. F8092609: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27220 To: mbruchert, camiloh Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. @mlaurent Wasn't there also something which tells kdebugsettings about renamed categories? Is that documented anywhere? Could that be supported by some additional macro or adaption of the existing/new ones? REPOSITORY R240 Extra CMake Modules BRANCH

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/58/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 08 Feb 2020 22:19:51 + Build duration: 5 min 0 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/92/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Feb 2020 22:19:51 + Build duration: 5 min 2 sec and counting JUnit Tests Name:

D26394: ECMGeneratePriFile: Fix static configurations

kossebau added a comment. Pushed a8c3ab79912fcb25d7e59a04c08752a9252a5f08 as hotfix for now. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26394 To: kfunk, dfaure, winterz, vkrause, apol Cc: kossebau, lbeltrame, cgiboudeaux, kde-frameworks-devel,

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Make sure to run the icons through an SVG optimizer, per https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization After that, you'll need to

D26394: ECMGeneratePriFile: Fix static configurations

kossebau added inline comments. INLINE COMMENTS > ECMGeneratePriFile.cmake:183 > + set(PRI_TARGET_MODULE_CONFIG "") > + get_target_property(target_type ${EGPF_LIB_NAME} TYPE) > + if (target_type STREQUAL "STATIC_LIBRARY") Hmpf, this adds the firm assumption that EGPF_LIB_NAME actually is a

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham accepted this revision. ngraham added a comment. Me too! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin,

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

ngraham added a dependent revision: D27260: [applets/systemtray] Set pin button's size correctly. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-pc3-toolbutton-sizing (branched from master) REVISION DETAIL https://phabricator.kde.org/D27221 To: ngraham, #vdg, #plasma, broulik,

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

mthw edited the summary of this revision. mthw edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

cblack accepted this revision. cblack added a comment. Style-wise, the tinting effect definitely an improvement over what we currently have. Everything here LGTM. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75277. niccolove added a comment. Changed saturation to 6.0 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75145=75277 BRANCH contrast_effect_background_color (branched from master)

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#608074 , @ngraham wrote: > But ultimately, don't let this become design-by-committee. This is your patch, and your proposal. It's good to take into account feedback, but not to the extent that it compromises

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/49/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 08 Feb 2020 18:29:05 + Build duration: 1 min 44 sec and counting JUnit Tests Name:

D27255: nota

mbruchert added a reviewer: camiloh. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27255 To: mbruchert, camiloh Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27255: nota

mbruchert added a comment. F8092229: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27255 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27255: nota

mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH nota (branched from master) REVISION DETAIL https://phabricator.kde.org/D27255 AFFECTED

D27220: add pix icon

mbruchert updated this revision to Diff 75270. mbruchert added a comment. - change shadow color REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27220?vs=75186=75270 BRANCH pix (branched from master) REVISION DETAIL

D27246: add buho icon

mbruchert updated this revision to Diff 75269. mbruchert added a comment. - change shadow color REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27246?vs=75247=75269 BRANCH buho (branched from master) REVISION DETAIL

D27218: Add icon for org.kde.Ikona

cblack updated this revision to Diff 75266. cblack added a comment. Drop 64px icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27218?vs=75183=75266 BRANCH ikona-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27218

D27239: [android] Emit defaultActivated when tapping the notification

This revision was automatically updated to reflect the committed changes. Closed by commit R289:0a0efe39f898: [android] Emit defaultActivated when tapping the notification (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D27239: [android] Emit defaultActivated when tapping the notification

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH defa REVISION DETAIL https://phabricator.kde.org/D27239 To: nicolasfella, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D26441: New icon for KTimeTracker

This revision was automatically updated to reflect the committed changes. Closed by commit R266:dca95f680776: New icon for KTimeTracker (authored by cblack). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26441?vs=74293=75263 REVISION DETAIL

D27239: [android] Emit defaultActivated when tapping the notification

nicolasfella updated this revision to Diff 75264. nicolasfella added a comment. - set correct flags REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27239?vs=75242=75264 BRANCH defa REVISION DETAIL https://phabricator.kde.org/D27239 AFFECTED

D27252: add maui index icon in pm style

mbruchert added a reviewer: camiloh. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27252 To: mbruchert, camiloh Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27252: add maui index icon in pm style

mbruchert added a comment. F8092163: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27252 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27252: add maui index icon in pm style

mbruchert updated this revision to Diff 75261. mbruchert added a comment. - fix shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27252?vs=75260=75261 BRANCH index (branched from master) REVISION DETAIL https://phabricator.kde.org/D27252

D27252: add maui index icon in pm style

mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH index (branched from master) REVISION DETAIL https://phabricator.kde.org/D27252 AFFECTED

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. But ultimately, don't let this become design-by-committee. This is your patch, and your proposal. It's good to take into account feedback, but not to the extent that it compromises what you're trying to accomplish in the interests of pleasing people who

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. My result was 0.644. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

License Clarification for kguiaddons/tests/openurltest.cpp

Hi Aleix, I found the file kguiaddons/tests/openurltest.cpp with an ambiguous license statement about both LGPL and GPL. According to the license header, you are the only copyright holder and a review of the file authors resulted in only minor contributions by others. Can you clarify the file

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

gvgeo added a comment. On second thought, maybe it was fine. `Layout.preferredWidth` should not have any effect when icon is not visible anyway. And negative value could be set if needed. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-pc3-toolbutton-sizing (branched from master)

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I personally choose 0.4 for opacity, but I was now thinking whether higher or lower values could be better. I took 50 screenshots in different conditions, but since those are a bit difficult to upload to Phab, I also made a website which helps you pick a value:

D27224: add Kongress icon

mbruchert added a reviewer: dkardarakos. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27224 To: mbruchert, dkardarakos Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

mbruchert added a reviewer: mart. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

mbruchert removed a reviewer: marcorichetta. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, marcorichetta Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

mbruchert added a reviewer: marcorichetta. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, marcorichetta Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27220: add pix icon

mbruchert added a reviewer: camiloh. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27220 To: mbruchert, camiloh Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

mthw edited the summary of this revision. mthw edited the test plan for this revision. mthw added reviewers: VDG, Plasma. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27197: Add symbolic screenshot icons

mbruchert added a reviewer: lnj. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27197 To: mbruchert, lnj Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

mthw updated this revision to Diff 75251. mthw added a comment. Also change Dark icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75250=75251 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

mthw created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mthw requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES

D27246: buho

mbruchert added a reviewer: camiloh. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert, camiloh Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: add buho icon

mbruchert retitled this revision from "buho" to "add buho icon". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert, camiloh Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: buho

mbruchert added a comment. F8091923: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: buho

mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH buho (branched from master) REVISION DETAIL https://phabricator.kde.org/D27246 AFFECTED

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX and add license text files in LICENSES folder as required by the REUSE

D27239: [android] Emit defaultActivated when tapping the notification

nicolasfella updated this revision to Diff 75242. nicolasfella added a comment. - broadcast correctly REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27239?vs=75234=75242 BRANCH defa REVISION DETAIL https://phabricator.kde.org/D27239 AFFECTED

D27234: KPlotting: Convert license statements to SPDX

This revision was automatically updated to reflect the committed changes. Closed by commit R277:5397f0651e8e: KPlotting: Convert license statements to SPDX (authored by cordlandwehr). REPOSITORY R277 KPlotting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27234?vs=75235=75241

D27234: KPlotting: Convert license statements to SPDX

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R277 KPlotting BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27234 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27234: KPlotting: Convert license statements to SPDX

cordlandwehr marked 3 inline comments as done. cordlandwehr added a comment. Unified all license header statements without "*" markers. REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D27234 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack,

D27235: add calindori icon in the new pm style

mbruchert updated this revision to Diff 75236. mbruchert added a comment. - fix radius REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27235?vs=75229=75236 BRANCH calindori (branched from master) REVISION DETAIL https://phabricator.kde.org/D27235

D27234: KPlotting: Convert license statements to SPDX

cordlandwehr updated this revision to Diff 75235. cordlandwehr added a comment. Unify comment style for license headers REPOSITORY R277 KPlotting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27234?vs=75226=75235 BRANCH spdx REVISION DETAIL

D27239: [android] Emit defaultActivated when tapping the notification

nicolasfella edited the test plan for this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27239 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27239: [android] Emit defaultActivated when tapping the notification

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When the user taps a notification the corresponding activity is

D27234: KPlotting: Convert license statements to SPDX

cgiboudeaux added inline comments. INLINE COMMENTS > cordlandwehr wrote in testplot_main.cpp:2-5 > do you mean the "*" character in each comment line? yes. they're added only for a couple files REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D27234 To: cordlandwehr

D27092: Prison: Convert license statements to SPDX identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit R280:3a0aa5897182: Prison: Convert license statements to SPDX identifiers (authored by cordlandwehr). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27092?vs=74842=75233

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#607167 , @ngraham wrote: > Please add a comment in the Description section of this patch explaining why the previously disabled Intensity value is now enabled. ✓ REPOSITORY R242 Plasma Framework

D27238: Add an option to dynamic-break inside words

eudoxos created this revision. eudoxos added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. eudoxos requested review of this revision. REVISION SUMMARY Add option to break lines longer than view width (or static

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27234: KPlotting: Convert license statements to SPDX

cordlandwehr added inline comments. INLINE COMMENTS > cgiboudeaux wrote in testplot_main.cpp:2-5 > extra '*' ? do you mean the "*" character in each comment line? REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D27234 To: cordlandwehr Cc: cgiboudeaux,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27235: add calindori icon in the new pm style

mbruchert added a reviewer: dkardarakos. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27235 To: mbruchert, dkardarakos Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27235: add calindori icon in the new pm style

mbruchert added reviewers: ndavis, ngraham. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27235 To: mbruchert, dkardarakos, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27235: add calindori icon in the new pm style

mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH calindori (branched from master) REVISION DETAIL https://phabricator.kde.org/D27235

D27223: add kirigami-gallery icon

mbruchert retitled this revision from "add kirigami-galery icon" to "add kirigami-gallery icon". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-galery icon

mbruchert updated this revision to Diff 75228. mbruchert added a comment. - fix typo REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27223?vs=75194=75228 BRANCH kirigami_galery (branched from master) REVISION DETAIL

D27234: KPlotting: Convert license statements to SPDX

cgiboudeaux added inline comments. INLINE COMMENTS > testplot_main.cpp:2-5 > + * > + * SPDX-FileCopyrightText: 2006 Jason Harris > + * > + * SPDX-License-Identifier: GPL-2.0-or-later extra '*' ? REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D27234 To:

D27092: Prison: Convert license statements to SPDX identifiers

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27092 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D26931: KIdleTime: Convert license statements to SPDX

cordlandwehr retitled this revision from "Introduce SPDX license headers" to "KIdleTime: Convert license statements to SPDX". REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr, cgiboudeaux Cc: kossebau, cgiboudeaux, kde-frameworks-devel,

D27091: Sonnet: Convert license statements to SPDX

cordlandwehr retitled this revision from "Convert license statements to SPDX" to "Sonnet: Convert license statements to SPDX". REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27091 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack,

D27092: Prison: Convert license statements to SPDX identifiers

cordlandwehr retitled this revision from "Update license statements to SPDX identifiers" to "Prison: Convert license statements to SPDX identifiers". REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27092 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n,

D27103: KItemModels: Convert license headers to SPDX markers

cordlandwehr retitled this revision from "Convert license headers to SPDX markers" to "KItemModels: Convert license headers to SPDX markers". REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D27103 To: cordlandwehr, dfaure Cc: cgiboudeaux, kde-frameworks-devel,

D27231: BluezQt: Convert license statements to SPDX

cordlandwehr closed this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D27231 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27231: BluezQt: Convert license statements to SPDX

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R269 BluezQt BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27231 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27104: KArchive: Convert license statements to SPDX headers

cordlandwehr retitled this revision from "Convert license statements to SPDX headers" to "KArchive: Convert license statements to SPDX headers". REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D27104 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel,

D27158: Fix some compiler warnings

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH l-compiler-warnings (branched from master) REVISION DETAIL https://phabricator.kde.org/D27158 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n,

D27234: KPlotting: Convert license statements to SPDX

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D27234 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27234: KPlotting: Convert license statements to SPDX

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX and add license text files in LICENSES folder as required by the REUSE

D27231: BluezQt: Convert license statements to SPDX

cordlandwehr retitled this revision from "Convert license statements to SPDX" to "BluezQt: Convert license statements to SPDX". REPOSITORY R269 BluezQt BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27231 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel,

D27106: Attica: Convert license statements to SPDX markers

cordlandwehr retitled this revision from "Convert license statements to SPDX markers" to "Attica: Convert license statements to SPDX markers". REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D27106 To: cordlandwehr Cc: dfaure, cgiboudeaux, kde-frameworks-devel,

D27231: Convert license statements to SPDX

cordlandwehr marked an inline comment as done. REPOSITORY R269 BluezQt BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27231 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27231: Convert license statements to SPDX

cordlandwehr updated this revision to Diff 75223. cordlandwehr added a comment. Add missing newline REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27231?vs=75217=75223 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27231 AFFECTED FILES

D27231: Convert license statements to SPDX

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM once the license file is fixed INLINE COMMENTS > LicenseRef-KDE-Accepted-LGPL.txt:13 > +GNU General Public License for more details. > \ No newline at end of file missing

D27106: Convert license statements to SPDX markers

dfaure added a comment. Can you add the repository name in the title of the review request? Otherwise they all look the same in emails. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D27106 To: cordlandwehr Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. The approach makes sense to me. INLINE COMMENTS > kmountpoint.cpp:420 > +#else > +const QString realname = path; > #endif You should rename this variable, it's no longer

D27231: Convert license statements to SPDX

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX and add license text files in LICENSES folder as required by the REUSE

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added a comment. We might want to use Solid instead since it is capable of sending signals when mnttab is updated, rather than like here having a mount point list updated every 5 seconds. With this code we might have issues with potential run condition : when there is a mount within

D27218: Add icon for org.kde.Ikona

ndavis added a comment. JFYI, the 64px versions of app icons are currently unused. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 75216. meven added a comment. Add a enum parameter to findByPath to choose its behavior regarding returning first slow path REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73836=75216 BRANCH arcpatch-D26407

D27185: Use the right translation catalog to show translations

This revision was automatically updated to reflect the committed changes. Closed by commit R304:8f382ef18606: Use the right translation catalog to show translations (authored by yurchor). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27185?vs=75082=75214#toc REPOSITORY R304 KNewStuff

D27104: Convert license statements to SPDX headers

This revision was automatically updated to reflect the committed changes. Closed by commit R243:8c40c6f028b3: Convert license statements to SPDX headers (authored by cordlandwehr). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27104?vs=74862=75213 REVISION

D27091: Convert license statements to SPDX

This revision was automatically updated to reflect the committed changes. Closed by commit R246:857bb8eb4173: Convert license statements to SPDX (authored by cordlandwehr). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27091?vs=74841=75212 REVISION DETAIL

  1   2   >