D27270: Use ecm_qt_install_logging_categories over manual categories files

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R174 KContacts BRANCH generateqtlogcatfile REVISION DETAIL https://phabricator.kde.org/D27270 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n,

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added a comment. In D25495#608582 , @apol wrote: > This patch makes it do all the languages identified by identify + all the languages supported by the script. This could mean lots of languages for some scripts...

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added inline comments. INLINE COMMENTS > apol wrote in guesslanguage.cpp:586 > Shouldn't identify be taking care of the scripts already? `identify()` fails if a certain language is not present in the trigrams. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495

D27272: Add status icons: data-error, data-warning, data-information

ngraham added a comment. I think the emblem icons look great in your "After" screenshot. Wouldn't it be easier to have KDevelop use these emblem icons from their current names rather than symlinking the icons you want to use to new files with different names? Semantically it seems

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. See how KDevelop looks like currently using the `dialog-error` & Co. icons, the icons do not really help here being uncolored and their shape driven by "dialog": F8094659: KDevelop using dialog status icons.png This is how

D27272: Add status icons: data-error, data-warning, data-information

kossebau created this revision. kossebau added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY These are generic icons to use to mark the status of data or other content.

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. Arcpatched and compiled and I was getting an overly transparent Breeze Dark: F8094138: image.png It was only when I turned Contrast Effect off and then on again that I was seeing what's in the test plan. We should

D25495: Fix Sonnet autodetect failing on Indian langs

apol added a comment. This patch makes it do all the languages identified by identify + all the languages supported by the script. This could mean lots of languages for some scripts... INLINE COMMENTS > guesslanguage.cpp:586 > + > +QStringList candidateLanguages = d->identify(text,

D27263: RFC: Accent colour for KColorScheme

cblack added a dependent revision: D27271: [kcms/colors] RFC: Accent Colours. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27197: Add symbolic screenshot icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Please run the icons through an SVG optimizer and remove the `color=` attributes inside the paths. See https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

ngraham added a comment. Actually `audio-volume-muted` also has the same issue. Let's also do that in the same patch. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n,

D27238: Add an option to dynamic-break inside words

dhaumann added subscribers: cullmann, dhaumann. dhaumann added a comment. I think this patch looks good. @cullmann: this originates from https://www.reddit.com/r/kde/comments/ey4158/comment/fgoycn4?context=3 Any opinion? REPOSITORY R39 KTextEditor REVISION DETAIL

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 20:43:39 + Build duration: 1 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.14 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.14/8/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 09 Feb 2020 19:28:28 + Build duration: 1 hr 4 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 302 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/302/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 09 Feb 2020 19:27:07 + Build duration: 56 min and counting BUILD ARTIFACTS

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27270: Use ecm_qt_install_logging_categories over manual categories files. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks,

D27270: Use ecm_qt_install_logging_categories over manual categories files

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R174 KContacts REVISION DETAIL https://phabricator.kde.org/D27270 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack,

D27270: Use ecm_qt_install_logging_categories over manual categories files

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Generated files match entries of existing manual

D27269: Use ecm_qt_install_logging_categories over manual categories file

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27269 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27269: Use ecm_qt_install_logging_categories over manual categories file

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Generated file matches entries of existing manual

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27269: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau updated this revision to Diff 75312. kossebau added a comment. Add support for also generating renamecategories files REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27150?vs=75069=75312 BRANCH addautomaticcategoriesgeneration

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 159 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/159/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 19:28:40 + Build duration: 30 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 294 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/294/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 19:27:07 + Build duration: 26 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 19:27:53 + Build duration: 20 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/54/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 19:27:43 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 19:26:59 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 19:26:26 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D27263: RFC: Accent colour for KColorScheme

cblack edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 75311. cblack added a comment. Expose method to drop accent colours from a KColorScheme object REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75310=75311 BRANCH kcolorscheme-accent (branched from

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/77/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 19:26:16 + Build duration: 9 min 28 sec and counting JUnit Tests Name:

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/69/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 19:25:17 + Build duration: 4 min 48 sec and counting JUnit Tests Name:

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. In D27150#608492 , @mlaurent wrote: > In D27150#608491 , @kossebau wrote: > > > In D27150#608318 , @mlaurent wrote: > > > >

D26888: work around to fully support the windows backend

albertvaka added inline comments. INLINE COMMENTS > notifybysnore.cpp:135-139 > +if (id == -1) { > +emit actionInvoked(0, actionNum); > +} else { > +emit actionInvoked(id, actionNum); > +} This could become: if (id == -1) {

D27263: RFC: Accent colour for KColorScheme

cblack edited the summary of this revision. cblack edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh,

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 75310. cblack added a comment. Load accent colour from kdeglobals instead of colourscheme REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75289=75310 BRANCH kcolorscheme-accent (branched from master)

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > statjob.cpp:97 > + > +void StatJob::setDetails(short int details) > +{ When the declaration is in #if, the definition should be too (with s/ENABLED/BUILD/).

D27268: Fixed handling of relative paths by KUrlNavigator

mdlubakowski added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27268 To: mdlubakowski, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. In D27150#608491 , @kossebau wrote: > In D27150#608318 , @mlaurent wrote: > > > Yep you need to create a file name "foo.renamecategories" where you change the categorie

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. In D27150#608318 , @mlaurent wrote: > Yep you need to create a file name "foo.renamecategories" where you change the categorie name > > 1. old module namenew module name > > for example "log_mailfilteragent

D27268: Fixed handling of relative paths by KUrlNavigator

mdlubakowski created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mdlubakowski requested review of this revision. REVISION SUMMARY Typing a relative path (one that doesn't start with / or protocol) into KUrlNavigator widget currently

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Where are we with this? @bruns are you accepting the proposed solution or do you reject it completely? I think it is at least way better than the current solution and maintains current API. A larger refactoring could be done for KF6 REPOSITORY R286

D25517: Add an option to extract image data and add front cover property

astippich updated this revision to Diff 75306. astippich added a comment. - udpate since tag REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=73097=75306 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517 AFFECTED

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 75304. meven added a comment. This revision is now accepted and ready to land. Fix implementation having a statDetails function to distinguish from the original function, fix and adapt test, in file_unix when using statx reduce the field retrieved for

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#608324 , @ndavis wrote: > Still uses ViewBackground on panels. For panel popups, you wanted to use a header area like the systray mockups, right? If so, the dialog SVG could use ViewBackground and you should

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

mthw updated this revision to Diff 75302. mthw added a comment. color="" removed, also version removed as it wasn't there before. Anything else? REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75294=75302 BRANCH master REVISION DETAIL

D27197: Add symbolic screenshot icons

lnj resigned from this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27197 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27197: Add symbolic screenshot icons

lnj added a comment. This is required for the screenshot action in the panel of the plasma mobile shell. I don't know enough about creating breeze icons to approve this diff, but at least I don't see any problems. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27220: add pix icon

IlyaBizyaev added a comment. The original icon (on my Android device, at least) looks like a framed pixelated painting, so still holds the "picture" association. In your proposal, it looks like a whiteboard with sticky notes, or a window with sunset, or... REPOSITORY R266 Breeze

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

gvgeo added a comment. It could be my broken build. But this is what I see with X11 and scale 1.75. F8093437: Screenshot_20200209_152630.png F8093436: Screenshot_20200209_152557.png REPOSITORY R242 Plasma

D27220: add pix icon

mbruchert added a comment. the Icon is supposed to be just a remake of the original icon which looks similar REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27220 To: mbruchert, camiloh Cc: IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.14/7/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 09 Feb 2020 11:03:25 + Build duration: 1 hr 43 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 111 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/111/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 09 Feb 2020 12:08:34 + Build duration: 35 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 58 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/58/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 09 Feb 2020 11:02:57 + Build duration: 1 hr 28 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/106/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 11:51:38 + Build duration: 31 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/59/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 11:04:58 + Build duration: 1 hr 5 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 110 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/110/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 09 Feb 2020 10:56:42 + Build duration: 1 hr 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 11:04:07 + Build duration: 59 min and counting CONSOLE OUTPUT Started

D8281: Allow to use IcoTool for Windows icons

cullmann abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8281 To: cullmann, dfaure, apol, kfunk, #windows, vpinon Cc: kde-frameworks-devel, kde-buildsystem, cullmann, cgiboudeaux, LeGast00n, cblack, GB_2, bencreasy, michaelh,

D8281: Allow to use IcoTool for Windows icons

cullmann commandeered this revision. cullmann added a reviewer: vpinon. cullmann added a comment. Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. I reviewed the current state and there is now already icotool support in our

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 159 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/159/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 09 Feb 2020 11:51:38 + Build duration: 9 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 11:02:57 + Build duration: 56 min and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/59/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 09 Feb 2020 10:54:59 + Build duration: 1 hr 0 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 180 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/180/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 11:02:11 + Build duration: 51 min and counting JUnit Tests Name:

D26342: Allow overriding to disable auto language detection

cullmann added a comment. @mludwig: ok with the current patch? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks, cullmann, mlaurent Cc: mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26903: allow programLogo property to be a QIcon, too

cullmann closed this revision. cullmann added a comment. done https://commits.kde.org/kcoreaddons/7bc9d98a2144baf3a7aa15778a842a9cba5d2263 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann, apol Cc: kossebau, dhaumann, kde-frameworks-devel,

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a comment. In D24568#563653 , @cullmann wrote: > For the lambda issue, I think we can add: > > # keep lambda formatting multi-line if not empty > AllowShortLambdasOnASingleLine: Empty > > > see

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 11:01:23 + Build duration: 44 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 11:00:48 + Build duration: 42 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 99 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/99/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 09 Feb 2020 11:02:56 + Build duration: 40 min and counting BUILD ARTIFACTS

D24982: Small improvements in some XML files

This revision was automatically updated to reflect the committed changes. Closed by commit R216:02a3fb1d7c39: Small improvements in some XML files (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 293 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/293/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 10:59:15 + Build duration: 41 min and counting JUnit Tests Name: projectroot

D24982: Small improvements in some XML files

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think we can go with this as is. Given we have tests for a lot of stuff, regressions shouldn't be that likely. I will merge this, before we let that rot even more. Thanks for the

D27009: Makefile highlight: add substitutions

This revision was automatically updated to reflect the committed changes. Closed by commit R216:5bd8719d4655: Makefile highlight: add substitutions (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D26957: KateModeMenuList: don't overlap the scroll bar

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6f39d3345273: KateModeMenuList: dont overlap the scroll bar (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D27009: Makefile highlight: add substitutions

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH makefile-substitutions REVISION DETAIL https://phabricator.kde.org/D27009 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D27009: Makefile highlight: add substitutions

cullmann added a comment. Has a test, looks ok, thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27009 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson,

D26957: KateModeMenuList: don't overlap the scroll bar

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. This is a patch for KTextEditor, that is still on phab (for good or bad ;=) I think this is ok, accepting & merging. Btw., for the default arguments: This is a purely internal class,

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 10:57:31 + Build duration: 22 min and counting JUnit Tests Name: projectroot

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

mthw updated this revision to Diff 75294. mthw edited the summary of this revision. mthw added a comment. Work in progress, making recomended changes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75251=75294 BRANCH master REVISION DETAIL

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/59/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 10:57:24 + Build duration: 20 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 10:57:08 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/3/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 09 Feb 2020 10:55:47 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/105/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 10:56:40 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/50/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 10:55:54 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/93/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 09 Feb 2020 10:55:00 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/68/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 10:54:47 + Build duration: 5 min 47 sec and counting JUnit Tests Name:

D26468: Tests: don't build benchmark test by default

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Building is still a good idea, to detect compilation breakage. Otherwise the code just bitrots over time. It's the running that should be made optional. REPOSITORY R241

D27220: add pix icon

IlyaBizyaev added a comment. Hello, Mathis! Pix is a gallery application, right? From the proposed icon, one cannot tell that... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27220 To: mbruchert, camiloh Cc: IlyaBizyaev, kde-frameworks-devel, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Still uses ViewBackground on panels. For panel popups, you wanted to use a header area like the systray mockups, right? If so, the dialog SVG could use ViewBackground and you

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

ahmadsamir requested review of this revision. ahmadsamir added a comment. krununittest fails to pass, I tried to debug it but can't get it to work. Disabling the third row "QTest::newRow("tempfile") << true << false;" in KRunUnitTest::KRunRunService_data, makes it pass... I can't figure it

D26468: Tests: don't build benchmark test by default

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26468 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. Yep you need to create a file name "foo.renamecategories" where you change the categorie name old module namenew module name = for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail What do you need

D27263: RFC: Accent colour for KColorScheme

ndavis added a comment. I know this isn't the final version, but I'm not a fan of this idea. It feels like we'd just piling new stuff on top without properly using the old stuff that is already usable. I think if we're not careful, it'll just make color customization more confusing and