D27223: add kirigami-gallery icon

ndavis added a comment. In D27223#626722 , @ngraham wrote: > Sorry this got lost. > > Still looks kinda jaggy to me though, especially at 48px.: F8172949: Screenshot_20200312_204742.png > > Do you

D27223: add kirigami-gallery icon

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Sorry this got lost. Still looks kinda jaggy to me though, especially at 48px.: F8172949: Screenshot_20200312_204742.png Do you

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added a comment. In D25010#626677 , @mlaurent wrote: > Did you test to compile with flags == 5.68.0 ? > I tested it with kdepim and I need to adapt it. > -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054400 is 5.68.0 ? You also

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in statjob.h:203 > This wants to be "5, 69" now, not "5, 68" Ah, was already fixed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: mlaurent, dalbers,

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann updated this revision to Diff 77526. cullmann added a comment. remove useless output of stray azOffset var REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28015?vs=77525=77526 BRANCH master REVISION DETAIL

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann added reviewers: nibags, dhaumann, vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28015 To: cullmann, nibags, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns,

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY see bug 418778 VHDL highlighting is very slow as close to all regexes are marked as dynamic

D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Zoom is like all view stuff local, yes, I assume that is often not wanted. But that is a orthogonal issue. The same could be said for "dynamic word wrap", very seldom you want to set that for one view. On the other side, for the global config, one has the

D27929: CMake syntax fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:39ad168cf350: CMake syntax fixes (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27929?vs=77200=77524 REVISION DETAIL

D27928: [VIM Mode] Add g g commands

cullmann added a comment. And btw., thanks a lot for taking care! The vimode for sure has more need for love, if you have time ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks, cullmann Cc: cullmann, dhaumann,

D27928: [VIM Mode] Add g g commands

This revision was automatically updated to reflect the committed changes. Closed by commit R39:736844969d2b: [VIM Mode] Add gup gdown commands (authored by gikari, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27928?vs=77355=77523

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added inline comments. INLINE COMMENTS > statjob.h:203 > + > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 68) > /** This wants to be "5, 69" now, not "5, 68" REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: mlaurent,

D27928: [VIM Mode] Add g g commands

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH g-up-g-down-commands (branched from master) REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks, cullmann Cc: cullmann, dhaumann,

D27928: [VIM Mode] Add g g commands

cullmann added a comment. I think, one issue is, that and don't work that way in the test framework. I reformulated the test with \down and \up and moved the asserts to verifies. This works for me, will push this, please take a look if that is ok for you, too. REPOSITORY R39

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

mlaurent added a comment. Did you test to compile with flags == 5.68.0 ? I tested it with kdepim and I need to adapt it. -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054400 is 5.68.0 ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure,

D27986: Allow providing an error message from the application

apol updated this revision to Diff 77522. apol added a comment. Prefer char* REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77451=77522 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27986 AFFECTED FILES src/kcrash.cpp

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krununittest.cpp:245 > +QCOMPARE(KShell::joinArgs(parser.resultingArguments()), > + QStringLiteral("/usr/bin/ktelnetservice5 >

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77521. ahmadsamir added a reviewer: feverfew. ahmadsamir added a comment. Tweak REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27999?vs=77520=77521 BRANCH l-krun-ssh (branched from master) REVISION DETAIL

D28002: [WIP]Allow disabling of data collection

davidedmundson added a comment. > Currently data is collected by default, with no way of disabling it. That's far from true. Things are off by default. Most providers are not run at all. The commit message is either confused or misleading. Some usage stuff is retained regardless,

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77520. ahmadsamir edited the summary of this revision. ahmadsamir removed a reviewer: feverfew. ahmadsamir removed a subscriber: feverfew. ahmadsamir added a comment. Address comments, use QFINDTESTDATA() REPOSITORY R241 KIO CHANGES SINCE LAST

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. @mlaurent compilation is broken because a method got deprecated, and you set -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06 so the use of that method no longer compiles. You can hardly blame other people for deprecating methods, it's a rather natural thing to do at

D27986: Allow providing an error message from the application

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Every other static variable here is a char* so that there's no global constructor being called at application startup. Why not do the same? Just `strdup` the result of the

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

dfaure added a comment. Thanks for the unittest with the fix. INLINE COMMENTS > krununittest.cpp:238 > +{ > +const QString ktelnet = QStringLiteral(CMAKE_SOURCE_DIR) + > QStringLiteral("/src/ioslaves/telnet/ktelnetservice5.desktop"); > +const KService service(ktelnet);

D27965: [KPasswdServer] replace foreach with range/index-based for

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kpasswdserver.cpp:201 > > bool KPasswdServer::hasPendingQuery(const QString , const KIO::AuthInfo > ) > { I wonder why the whole method isn't const >

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

aacid added a comment. Looks reasonable to me, but i'm not a huge expert here either, i guess you can commit given you are the expert. Or maybe wait a few days in case someone else has commits? REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27966 To: dfaure,

D28002: [WIP]Allow disabling of data collection

ngraham added reviewers: Frameworks, apol, vkrause. REPOSITORY R849 User Feedback Collection Framework REVISION DETAIL https://phabricator.kde.org/D28002 To: gvgeo, #frameworks, apol, vkrause Cc: #frameworks

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77511. trmdi added a comment. Minor improvement REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77508=77511 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951

D28002: [WIP]Allow disabling of data collection

gvgeo added a subscriber: Frameworks. gvgeo added a comment. Added Frameworks for visibility. kuserfeedback is not included in the group. REPOSITORY R849 User Feedback Collection Framework REVISION DETAIL https://phabricator.kde.org/D28002 To: gvgeo Cc: #frameworks

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added a dependent revision: D27998: [KCMs/Workspace] Add option for dndToMove. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi edited the summary of this revision. trmdi edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77508. trmdi added a comment. Allow to explicitly show the menu when holding Shift REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77433=77508 BRANCH add-dndToMove (branched from master) REVISION DETAIL

D28014: smb: do not double finish

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY finish() must not be called twice yet previously the case branches

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

mlaurent added a comment. "/compile/kde5/framework/kde/kdegames/kjumpingcube/game.cpp:582:63: erreur: impossible de convertir « KIO::StatJob::DestinationSide » de «  KIO::StatJob::StatSide » vers « KIO::JobFlags » {aka « QFlags »} 582 | KIO::StatJob* statJob = KIO::stat(url,

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 67 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/67/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Mar 2020 10:46:45 + Build duration: 2 hr 7 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 329 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/329/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 12:34:40 + Build duration: 9 min 52 sec and counting JUnit Tests Name:

D21466: Recommend rebooting after installing Samba

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R432 File Sharing (Samba) integration BRANCH recommend-rebooting (branched from master) REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter Cc:

D21466: Recommend rebooting after installing Samba

anthonyfieroni added a comment. Just start services, reboot will not do anything else. REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol Cc: anthonyfieroni, sitter, bruns

D21466: Recommend rebooting after installing Samba

apol added a comment. In D21466#626419 , @sitter wrote: > In D21466#625834 , @apol wrote: > > > So yes, Discover will notify about updates. That doesn't mean it should be shown here too. > > >

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

feverfew added a reviewer: feverfew. feverfew added a comment. I'll review this when I have a chance (sometime this week). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew Cc: feverfew,

D27985: Include s_kcrashErrorMessage in our traces

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM for when the kcrash diff is ready. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27985 To: apol, #frameworks, sitter Cc: plasma-devel,

D27986: Allow providing an error message from the application

sitter added a reviewer: dfaure. sitter added a subscriber: dfaure. sitter added a comment. Paging @dfaure for expert input. Is that global static qbytearray safe? Should we make it a q_global_static to comply with our library policy? Any objections to the diff? REPOSITORY R285 KCrash

D27544: Fix update scenarios with no explicit downloadlink selected

leinir updated this revision to Diff 77494. leinir added a comment. - Merge branch 'master' into fix-update - Update @since REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27544?vs=76096=77494 BRANCH fix-update (branched from master) REVISION DETAIL

D27544: Fix update scenarios with no explicit downloadlink selected

leinir added a comment. In D27544#622575 , @alexde wrote: > In D27544#622272 , @ngraham wrote: > > > (...) there has to be a way to (...) label everything properly etc. > > > > > In

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 167 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/167/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Mar 2020 10:35:20 + Build duration: 1 hr 16 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/70/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Mar 2020 10:35:28 + Build duration: 1 hr 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/68/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:49:55 + Build duration: 56 min and counting JUnit Tests Name: projectroot

D21466: Recommend rebooting after installing Samba

sitter added a comment. In D21466#625834 , @apol wrote: > So yes, Discover will notify about updates. That doesn't mean it should be shown here too. To clarify: are you -1 this diff? > If anything, we should be pushing for such

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/108/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Mar 2020 10:46:46 + Build duration: 40 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/60/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:46:46 + Build duration: 40 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:44:38 + Build duration: 29 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/60/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:43:40 + Build duration: 28 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 328 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/328/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:41:18 + Build duration: 29 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/64/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:38:37 + Build duration: 24 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 170 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/170/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Mar 2020 10:37:48 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:38:57 + Build duration: 18 min and counting JUnit Tests Name: projectroot

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

sitter added a subscriber: feverfew. sitter added a comment. Tested fuse and it works as expected. Code looks reasonable, but I have little expertise with this class. @feverfew probably ought to comment as well since he introduced the fuse code. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/86/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:38:17 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/116/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:37:48 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/103/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Mar 2020 10:35:28 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/60/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:36:39 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 160 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/160/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 10:35:20 + Build duration: 9 min 6 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 274 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/274/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Mar 2020 10:35:20 + Build duration: 8 min 54 sec and counting JUnit Tests Name:

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77482. niccolove added a comment. Added PlasmoidHeading to qmldir REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77418=77482 BRANCH master REVISION DETAIL

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#626135 , @ngraham wrote: > it needs more discussion first... When drop an image to the desktop in the FolderView layout, there would be no menu, so users can not change the wallpaper in this case. How do

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi added a comment. In D27133#625924 , @apol wrote: > The patch and the feature sound good to me, the resulting xml feels a bit weird and could use some clarification. Thank you for your comment. I agree it looks a bit odd,

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. FTR, I don't have access to any smb:// servers, so couldn't test the KIOFuse stuff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Extend krununittest to test ktelnetservice. Use CMake target_compile_definitions() to set the