D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir added a comment. Ping. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28274 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28271: [KFontChooser] More code cleanup

ahmadsamir added a comment. Ping. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28271 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

ngraham added a comment. In D26113#642053 , @meven wrote: > I should go ahead with it in solid and loop back here once it is done. Yeah, that makes sense to me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. The outstanding security issues have been resolved (see T8075 ). We have requested a re-review from the SUSE security team, but have not received it yet. Given that the original schedule for this feature has already slipped by

D28712: Redo api.kde.org to look more like Aether

ochurlaud added a comment. In D28712#645095 , @ognarb wrote: > Not tested yet but I like the style :) Though to be more consistent with the style used in other KDE websites, I would change the background color to #fff and use #f8f9fa for the

D28372: Remove rounded borders to plasmoidHeading

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH merged-plasmoidheading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28372 To: niccolove, #plasma, ngraham Cc: manueljlin, ahiemstra,

D28712: Redo api.kde.org to look more like Aether

ochurlaud accepted this revision. This revision is now accepted and ready to land. REPOSITORY R264 KApiDox BRANCH cblack/aether (branched from master) REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: ngraham, kde-frameworks-devel,

D28712: Redo api.kde.org to look more like Aether

ochurlaud added a comment. Nice work. This is a ship it for me! REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh,

D28712: Redo api.kde.org to look more like Aether

ngraham added a comment. Dang that looks way nicer. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, bruns,

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove updated this revision to Diff 79740. niccolove added a comment. Removed merged look, no longer needed, but kept rounded corners change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28372?vs=78742=79740 BRANCH

D28372: Remove rounded borders to plasmoidHeading

niccolove retitled this revision from "Added a merged look to the plasmoidheading and remove roundedborders" to "Remove rounded borders to plasmoidHeading". niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28712: Redo api.kde.org to look more like Aether

ognarb added a comment. Not tested yet but I like the style :) Though to be more consistent with the style used in other KDE websites, I would change the background color to #fff and use #f8f9fa for the sidebar. I also saw some alignment issues with the method args: F8227657:

D28712: Redo api.kde.org to look more like Aether

ognarb added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

cblack created this revision. cblack added reviewers: VDG, ognarb. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cblack requested review of this revision. TEST PLAN F8227629: image.png

D28682: export done signal in filecontentindexer

astippich added a comment. How about committedBatch so that it's clear that they have been committed to the database? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs,

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir added a comment. hmm... first this is a copy-paste "error" on my part, I personally never use & when the RHS is a temporary (I don't see the point). Anyway; looking at statResult(): const UDSEntry ::statResult() const { return d_func()->m_statResult; } it

D27844: Store and fetch complete view config in and from session config

kossebau added a comment. When it comes to Zoom, I would only expect it adapts to Global zoom settings again only once if I have reset my manual zooming to Default again. Though. seems Zoom is not covered by that config setting object... please not the "not" in "are not yet covered" in

D28701: [WIP] Add KPackage support to KNewStuffCore

ngraham added reviewers: Plasma, KNewStuff, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

ngraham added a comment. Okay thanks, can you update the test plan then? Also I think the diff currently does not actually fix 418466. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

T8349: Improve Places panel usability and presentation

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, fprice, cblack,

T8349: Improve Places panel usability and presentation

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, fprice, cblack,

T8349: Improve Places panel usability and presentation

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, fprice, cblack,

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#644943 , @ngraham wrote: > Am I not testing properly? Correct, that's the bit where i've not added instructions as required for switching to using the kpackage support. Short version, comment out the

D28701: [WIP] Add KPackage support to KNewStuffCore

ngraham added a comment. Even with this patch, every attempt to uninstall a newly-installed global theme still fails with: The uninstallation process failed to successfully run the command kpackagetool5 -t Plasma/LookAndFeel -r /tmp/01-com.github.vinceliuice.McMojave.tar.xz And

D28682: export done signal in filecontentindexer

bruns added a comment. Regarding API, `done` is a little bit vague. Can you rename it to `finishedBatch` (or come up with a better name). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel,

D28682: export done signal in filecontentindexer

bruns added a comment. In D28682#644914 , @astippich wrote: > Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call. Lets keep the API as small as possible ...

D28682: export done signal in filecontentindexer

astippich added a comment. Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien,

D28499: [LauncherJobs] Emit description

ngraham added a comment. Seems sensible and sane to me. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28499 To: broulik, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28673: [PackageUrlInterceptor] Make QRegularExpression static

bruns added a comment. In D28673#644778 , @broulik wrote: > Yeah, can probably be a `startsWith` unlikely for `QUrl::toString()` ... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To:

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 09 Apr 2020 13:13:51 + Build duration: 1 min 35 sec and counting JUnit Tests Name:

D26016: [KeySequenceHelper] Work around Meta modifier behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R296:4306fb8f4e19: [KeySequenceHelper] Work around Meta modifier behavior (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R263:577e8cddde7d: [KKeySequenceWidget] Work around Meta modifier behavior (authored by broulik). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26017?vs=71597=79708

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 79704. leinir added a comment. - Remove a stray newline REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28701?vs=79703=79704 BRANCH add-kpackage-support (branched from master) REVISION DETAIL

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Adding support for KPackage directly to KNewStuff means that we are able to deal more gracefully with things like

D28499: [LauncherJobs] Emit description

broulik updated this revision to Diff 79700. broulik added a comment. - Drop ellipsis REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28499?vs=79105=79700 REVISION DETAIL https://phabricator.kde.org/D28499 AFFECTED FILES src/gui/applicationlauncherjob.cpp

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

meven added a comment. The test is not stable (I reproduce locally) https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/34/testReport/junit/projectroot/autotests/kiocore_jobtest/ ==7022==ERROR: AddressSanitizer: heap-use-after-free on address 0x61099be8 at

D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages

This revision was automatically updated to reflect the committed changes. Closed by commit R289:524bdc640dcc: [KNotificationJobUiDelegate] Append Failed for error messages (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D28673: [PackageUrlInterceptor] Make QRegularExpression static

broulik planned changes to this revision. broulik added a comment. Yeah, can probably be a `startsWith` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: broulik, #plasma Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28669: make CopyJob non-recursive

anthonyfieroni added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:814 > Right. If this loop can really block the main thread for a substantial amount > of time, then it should have a condition like "after 100 symlinks, schedule > coming back here (e.g. QTimer singleshot) and

D28669: make CopyJob non-recursive

dfaure added inline comments. INLINE COMMENTS > anthonyfieroni wrote in copyjob.cpp:814 > > Which threads? There are no threads involved here. > > Yes, i'm afraid of loop that can block the event queue, !isKilled will not > work in single thread environment. Right. If this loop can really

D28699: Add startCapture method

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH startCpature (branched from master) REVISION DETAIL https://phabricator.kde.org/D28699 To: davidre, #frameworks, davidedmundson, broulik, apol Cc: kde-frameworks-devel,

D28669: make CopyJob non-recursive

anthonyfieroni added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:814 > Which threads? There are no threads involved here. > > There is no need to handling killing here. It wasn't any different in the > orig code with the recursion. > As soon as we find actual work to do,

D28699: Add startCapture method

davidre created this revision. davidre added reviewers: Frameworks, davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Starts capturing as if the user clicked on the main

D28669: make CopyJob non-recursive

dfaure added inline comments. INLINE COMMENTS > meven wrote in copyjob.cpp:915 > When reaching here the `while (m_currentStatSrc != m_srcList.constEnd()) {` > means we have nothing left to stat, meaning stating phase is indeed finished. Not if we just launched subjobs and we haven't gotten the

D28669: make CopyJob non-recursive

meven added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:915 > This makes no sense to me. We are finished when the previous phase is > actually finished. When reaching here the `while (m_currentStatSrc != m_srcList.constEnd()) {` means we have nothing left to stat, meaning

D28669: make CopyJob non-recursive

meven added a comment. Currently the code does not handle the other call paths to `statNextSrc()` that would need to be adapted as well. We will need to call `statCurrentSrc()` after `statNextSrc()` basically there. In slotResultRenaming and slotResult. Currently, those code path would

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 09 Apr 2020 09:30:26 + Build duration: 2 min 34 sec and counting JUnit Tests Name:

D28697: Also relase the window in the destructor

This revision was automatically updated to reflect the committed changes. Closed by commit R296:6c5619ffebae: Also relase the window in the destructor (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28697?vs=79688=79690 REVISION

D28697: Also relase the window in the destructor

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH release (branched from master) REVISION DETAIL https://phabricator.kde.org/D28697 To: davidre, broulik, #frameworks, davidedmundson Cc: kde-frameworks-devel,

D28697: Also relase the window in the destructor

davidre created this revision. davidre added reviewers: broulik, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise the keyboard is never released when the item is destroyed while