Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

On Sun, Apr 19, 2020 at 3:13 AM David Faure wrote: > > On Saturday, April 18, 2020 5:06:43 PM CEST Friedrich W. H. Kossebau wrote: > > Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure: > > > On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > > > > Hi all, > > > > > > >

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

poboiko created this revision. poboiko added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. poboiko requested review of this revision. REVISION SUMMARY This patch ensures that everything related to headings is undoable with a single `Ctrl+Z`. It also adds tests for the

D28967: [KRichTextEditor] Add support for headings

poboiko created this revision. poboiko added a reviewer: Frameworks. Herald added a project: Frameworks. poboiko requested review of this revision. REVISION SUMMARY Add new actions introduced in D28854: [KRichTextWidget] Add support for headings to the

D28966: [KRichTextEdit] Fix scroll jumping around when horizontal rule is added

poboiko created this revision. poboiko added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. poboiko requested review of this revision. REVISION SUMMARY Due to Qt bug 83605, it's not a good idea to `setTextCursor` while the cursor is inside `beginEditBlock / endEditBlock`

D28964: [KRichTextWidget] Remove ancient workaround and fix regression (commit 1d1eb6f)

This revision was automatically updated to reflect the committed changes. Closed by commit R310:0494fc4a2838: [KRichTextWidget] Remove ancient workaround and fix regression (commit 1d1eb6f) (authored by poboiko). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. In D28880#651209 , @ahmadsamir wrote: > There are only two places in KDE code where readEntryList() is used, falkon and kwalletmanager; in both cases readEntryList() was used with "*" which means "read all entries",

D28964: [KRichTextWidget] Remove ancient workaround and fix regression (commit 1d1eb6f)

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. In any case it makes sense to remove a workaround for a known-to-be-fixed bug. Good find. REPOSITORY R310 KTextWidgets BRANCH remove-workaround (branched from master) REVISION DETAIL

D28964: [KRichTextWidget] Remove ancient workaround and fix regression (commit 1d1eb6f)

dfaure added a comment. The qt4 task was probably Nokia-internal before the issue tracker was open. But here are more details if you didn't have them: commit 3eb65f48c97dc5e1a8980afa35bea8e4b16f08ba Author: Eskil Abrahamsen Blomfeldt Date: Fri Sep 4 15:05:46 2009 +0200

D28964: [KRichTextWidget] Remove ancient workaround and fix regression (commit 1d1eb6f)

poboiko created this revision. poboiko added reviewers: Frameworks, dfaure, ahmadsamir. Herald added a project: Frameworks. poboiko requested review of this revision. REVISION SUMMARY This patch removes the workaround, which (according to comment) comes from Qt4 times. Although I wasn't even

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a comment. I appreciate work on this issue. I am not sure about how well this "hack" will solve the issue, thought. I will give it a try here in any case. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor,

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport added a comment. Ok I will add a kconfig test REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D6794: assert the testpackage appstream data validates

dfaure added a comment. No, I've seen this error for longer than that. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D6794 To: sitter, sebas, apol Cc: bcooksley, dfaure, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D6794: assert the testpackage appstream data validates

bcooksley added a comment. I wonder if it is a coincidence that the images used to run the CI system we rebuilt in the past 48 hours - could this be an update to appstreamcli that is causing this perhaps? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D6794 To:

D28933: [Coding] Avoid recurrent detach and size checks

This revision was automatically updated to reflect the committed changes. Closed by commit R293:680b75a9a61a: [Coding] Avoid recurrent detach and size checks (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28933?vs=80437=80492 REVISION

D28940: [baloo_file] Remove KAboutData from baloo_file

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a9af3b92b03a: [baloo_file] Remove KAboutData from baloo_file (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28940?vs=80465=80490 REVISION

D28929: [QueryTest] Track if phrase matches in content or filename

This revision was automatically updated to reflect the committed changes. Closed by commit R293:bf2371d56172: [QueryTest] Track if phrase matches in content or filename (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28929?vs=80424=80491

D28956: [QML Monitor] Show remaining time as soon as possible

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The update timer was started when the content indexing started. If a large

D28955: [FileContentIndexer] Fix state update and signal order

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28955

D28954: [Monitor] Fix monitor state and signal ordering

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY fetchTotalFiles() updates the filesIndexedCound and emits newFileIndexed()

D28953: [Extractor] Fix progress reporting

bruns created this revision. bruns added reviewers: Baloo, ngraham, mlaurent. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Commit 125b4db3230b

D28952: [KNewStuff] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN Use kmoretoolstest_interactive test app, close the first dialog, then in the second one "Test the Menu" -> More

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. There are only two places in KDE code where readEntryList() is used, falkon and kwalletmanager; in both cases readEntryList() was used with "*" which means "read all entries", which is logical since in both cases the list is used to fill a "password manager" of

D28947: File protocol: ensure KIO::StatAcl works without implicitely depending on KIO::StatBasic

This revision was automatically updated to reflect the committed changes. Closed by commit R241:01ed87eb50a8: File protocol: ensure KIO::StatAcl works without implicitely depending on KIO… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28947: File protocol: ensure KIO::StatAcl works without implicitely depending on KIO::StatBasic

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fine-grain-stat REVISION DETAIL https://phabricator.kde.org/D28947 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 58 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/58/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 18 Apr 2020 16:52:11 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 66 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/66/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 18 Apr 2020 16:52:11 + Build duration: 8 min 23 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 557 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/557/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 18 Apr 2020 16:52:11 + Build duration: 5 min 46 sec and counting BUILD ARTIFACTS

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28901 To: dfaure, meven, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

meven accepted this revision. meven added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dfaure wrote in global.h:323 > There are bugs in the current kio_file implementation if StatBasic isn't set. > > mode_t type = 0; > if (details & KIO::StatBasic) { >

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. D28947 for the StatAcl fix REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28947: File protocol: ensure KIO::StatAcl works without implicitely depending on KIO::StatBasic

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY KIO::StatAcl needs the type to be returned from the stat call to operate.

D28933: [Coding] Avoid recurrent detach and size checks

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28933 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28940: [baloo_file] Remove KAboutData from baloo_file

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28940 To: bruns, #baloo, ngraham, leszeklesner, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh,

D28929: [QueryTest] Track if phrase matches in content or filename

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28929 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28940: [baloo_file] Remove KAboutData from baloo_file

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28940 To: bruns, #baloo, ngraham, leszeklesner, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D28909: smb: port to Result system to force serialization of error/finish condition

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_smb.cpp:162 > +{ > +#warning this was finishing before but in sftp and fish we do not finish so > I guess not finishing is the way to go > +

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

On Saturday, April 18, 2020 5:06:43 PM CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure: > > On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > > > Hi all, > > > > > > Please see below - any ideas as to why KHelpCenter no longer >

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

poboiko added a comment. In D28819#651007 , @dfaure wrote: > The *ideal* way of proceeding is to submit a Qt bug report with your testcase (after searching for an existing Qt bug report for the same issue), then turn it into a Qt autotest and

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure: > On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > > Hi all, > > > > Please see below - any ideas as to why KHelpCenter no longer successfully > > builds? > > > > It doesn't look like KHelpCenter has changed... > >

D28854: [KRichTextWidget] Add support for headings

poboiko closed this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28854 To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure Cc: abstractdevelop, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure added a comment. Any idea who could review this? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure added a reviewer: ngraham. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 556 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/556/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 18 Apr 2020 14:23:21 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/65/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 18 Apr 2020 14:23:21 + Build duration: 7 min 36 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/57/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 18 Apr 2020 14:23:21 + Build duration: 5 min 25 sec and counting BUILD ARTIFACTS

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > Hi all, > > Please see below - any ideas as to why KHelpCenter no longer successfully > builds? > > It doesn't look like KHelpCenter has changed... No, Qt has. This was fixed today by Johnny Jazeix in commit

D6794: assert the testpackage appstream data validates

dfaure added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. @sitter the error message in this commit shows up now in CI, can you investigate?

D28020: New class ProcessLauncherJob in KIOGui

nicolasfella added a comment. IIRC startup notification is still a big question mark in Wayland, but other Plasma devs know better REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28020 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: jbbgameich,

D28020: New class ProcessLauncherJob in KIOGui

dfaure added a comment. > Would it be possible to expose the finished signal of QProcess in KIO::ApplicationLauncherJob? By design the job finishes before the subprocess finishes (which could be in 3 days, if the user keeps the window open that long). Also this would only help you for

D28020: New class ProcessLauncherJob in KIOGui

jbbgameich added a comment. Sorry for using this diff to ask this question, I couldn't find you in kde-devel. Would it be possible to expose the finished signal of QProcess in KIO::ApplicationLauncherJob? I need something like this to close the startup feedback in the Plasma Mobile

D28745: Skip caching thumbnails on encrypted filesystems

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > thumbnail.cpp:731 > +struct stat baseStat, fileStat; > +if (!lstat(m_thumbBasePath.toStdString().c_str(), ) && >

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. Fair point. For searches made by users, that's arguable, but indeed here if it's a search made by C++ code, then we could very well have a readEntryList(QRegularExpression) overload for that use case [or a method with another name, especially if DBus is involved].

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#651001 , @dfaure wrote: > A Qt change request for something like QRegularExpression::wildcardToRegularExpression(str, QRegularExpression::AllowSlashes) Ah, I see; could be useful, yes.

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

dfaure added a comment. The *ideal* way of proceeding is to submit a Qt bug report with your testcase (after searching for an existing Qt bug report for the same issue), then turn it into a Qt autotest and make a gerrit merge request for Qt with both the test and a fix for it. And then, and

D28934: baloo_file stop throwing ASSERT failure

bruns added a comment. See D28940 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28934 To: leszeklesner, #baloo, bruns Cc: bruns, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28934: baloo_file stop throwing ASSERT failure

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28934 To: leszeklesner, #baloo, bruns Cc: bruns, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28854: [KRichTextWidget] Add support for headings

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I see, thanks for the explanations. I don't mind 6 levels if that's what HTML does. REPOSITORY R310 KTextWidgets BRANCH textwidget-heading (branched from master) REVISION DETAIL

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. A Qt change request for something like QRegularExpression::wildcardToRegularExpression(str, QRegularExpression::AllowSlashes) REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, blaze Cc:

D28940: [baloo_file] Remove KAboutData from baloo_file

bruns created this revision. bruns added reviewers: Baloo, ngraham, leszeklesner. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The data is obsolete, can never be shown, and may even cause

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R311:5bbe2a77a7af: [KWallet] Port last usage of QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#650985 , @dfaure wrote: > This keeps happening so I wonder if we need a QRegularExpression::wildcardToRegularExpression flag... What do you mean by flag? REPOSITORY R311 KWallet BRANCH

D28854: [KRichTextWidget] Add support for headings

mlaurent added inline comments. INLINE COMMENTS > poboiko wrote in krichtextedit.cpp:346 > Yes, that's true. I agree it's a bit confusing, but that's the case with HTML > too, which I had in mind (see screenshot, it's Chrome) > F8241667: scr1.png > > For

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This keeps happening so I wonder if we need a QRegularExpression::wildcardToRegularExpression flag... REPOSITORY R311 KWallet BRANCH l-wildcard (branched from master) REVISION DETAIL

D28934: baloo_file stop throwing ASSERT failure

bruns added a comment. Thanks for the notice. Although moving the QCoreApplication instantiation up fixes the ASSERT failure, the correct fix is even more trivial - the KAboutData is unused, so it should just go away. REPOSITORY R293 Baloo REVISION DETAIL

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#650974 , @dfaure wrote: > And what's the value of `key`? I wonder where/how the use of globbing/regexps comes in... Backend::readEntryList() docs say it supports wildcards, so "key" could be "foo*"

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. And what's the value of `key`? I wonder where/how the use of globbing/regexps comes in... REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, blaze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#650963 , @dfaure wrote: > Annoying feature of QRegularExpression :( They're being "technically" correct; I have to say using "*" to match foo/bar.txt is wrong, it should be */* if we're talking about

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. Annoying feature of QRegularExpression :( *.txt doesn't seem like a good example for wallet search.. any idea how this code is typically used? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure,

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

dfaure resigned from this revision. This revision now requires review to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28647 To: marten, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

dfaure added a comment. Something like that, but in your pseudo-code I'm missing the call to emit self()->reparseSlaveConfiguration(QString()); "Other slaves" confuses me. This is about broadcasting to "other processes" (applications), and that each process/application (this one,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 555 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/555/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 18 Apr 2020 11:13:29 + Build duration: 7 min 28 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/56/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 18 Apr 2020 11:13:30 + Build duration: 7 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/64/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 18 Apr 2020 11:13:29 + Build duration: 7 min 0 sec and counting JUnit Tests Name:

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure added a comment. In D28902#650160 , @meven wrote: > So the `settings:/` , `remote:/` should return UDS_LOCAL_PATH for KIO::StatBasic, but file:/ should not . That's for sure, it's redundant for kio_file. > The code here uses

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure updated this revision to Diff 80462. dfaure added a comment. update comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28902?vs=80338=80462 BRANCH 2020_use_StatDetails REVISION DETAIL https://phabricator.kde.org/D28902 AFFECTED FILES

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28745: Skip caching thumbnails on encrypted filesystems

marcingu marked 2 inline comments as done. marcingu added a comment. I improved check if file is on the same filesystem as thumbnails cache, but don't know if we can get rid of KMountPoint completely. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To:

D28745: Skip caching thumbnails on encrypted filesystems

marcingu updated this revision to Diff 80458. marcingu added a comment. Checking if file is on the same filesystem as thumbnails cache directory using lstsat REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28745?vs=80021=80458 REVISION DETAIL

D28221: Don't write default value to configuration file when default value came from /etc/* file

dfaure added a comment. In D28221#643799 , @bport wrote: > In D28221#641971 , @dfaure wrote: > > > I have a hard time accepting that the documentation was wrong -- and if it was, then this commit

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

anthonyfieroni added a comment. +1, looks great. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullmann, dhaumann Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham,

D28891: Nicaragua Holidays

This revision was automatically updated to reflect the committed changes. Closed by commit R175:97139b80e80b: Nicaragua Holidays (authored by carguello, committed by cgiboudeaux). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28891?vs=80322=80452#toc REPOSITORY R175 KHolidays

D28874: Taiwanese holidays

This revision was automatically updated to reflect the committed changes. Closed by commit R175:4d947fa1ca59: Taiwanese holidays (authored by shrapnel, committed by cgiboudeaux). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80415=80451 REVISION