D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

weisi created this revision. weisi added a reviewer: winterz. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. weisi requested review of this revision. REVISION SUMMARY It's a trivial fix, but this syntax error poped up when I was doing another holiday

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi updated this revision to Diff 81772. weisi added a comment. Renamed "農曆除夕" (//Lunar New Year's eve on Lunar calendar//) to "除夕" (//Lunar New Year's eve//). There's no need to specify "lunar calendar" here. REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi created this revision. weisi added a reviewer: winterz. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. weisi requested review of this revision. REVISION SUMMARY The previous revision put in fixed dates (month/day) for many holidays which are actually

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 23 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/23/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 02 May 2020 23:24:33 + Build duration: 2 hr 19 min and counting JUnit Tests

D28745: Skip caching thumbnails on encrypted filesystems

ngraham accepted this revision. ngraham added a comment. @bruns? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik,

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.14 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.14/13/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 03 May 2020 00:49:54 + Build duration: 3 min 2 sec and counting BUILD ARTIFACTS

D29372: Taiwan: Use "zh_TW" language code

weisi added a reviewer: winterz. weisi added a comment. Adding a reviewer to this diff. Thanks! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29372: Taiwan: Use "zh_TW" language code

weisi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. weisi requested review of this revision. REVISION SUMMARY It was set to `tw_zh` which I think is a typo. According to Wikipedia, > `zh-TW` is the IETF language tag for the

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/23/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 02 May 2020 22:50:34 + Build duration: 1 hr 41 min and counting JUnit Tests

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/13/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 02 May 2020 23:18:07 + Build duration: 34 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/10/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 02 May 2020 23:12:15 + Build duration: 36 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/16/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 23:01:31 + Build duration: 31 min and counting JUnit Tests Name: projectroot

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 01, 2020 at 09:25:18AM -0400, Allen Winter wrote: > On Thursday, April 30, 2020 5:15:43 PM EDT Albert Astals Cid wrote: > > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va > > escriure: > > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > > > We

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/17/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 02 May 2020 22:54:01 + Build duration: 33 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/11/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 22:50:30 + Build duration: 33 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.14 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.14/12/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 02 May 2020 22:52:15 + Build duration: 31 min and counting CONSOLE OUTPUT [...truncated 97

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/16/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 22:47:54 + Build duration: 31 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/12/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 02 May 2020 22:01:20 + Build duration: 1 hr 16 min and counting BUILD ARTIFACTS

Re: Information regarding upcoming Gitlab Migration

On Sun, May 3, 2020 at 2:13 AM Michał Policht wrote: > > Hi all, Hi Michal, > > Sorry for late response, but project "cutehmi" fits into "sdk" category > better than "applications" (technically it's a framework, but I guess > "frameorks" is reserved for well integrated KDE Frameworks). I have

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 02 May 2020 22:00:54 + Build duration: 1 hr 11 min and counting BUILD ARTIFACTS

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please don't remove this, but port it to QEventLoopLocker. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks,

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 22:38:12 + Build duration: 32 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 22:37:18 + Build duration: 32 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/15/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 22:02:32 + Build duration: 58 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/16/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 02 May 2020 21:56:46 + Build duration: 57 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 22 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/22/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 02 May 2020 21:55:59 + Build duration: 54 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 22:00:55 + Build duration: 49 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/15/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 22:01:20 + Build duration: 46 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 22:00:27 + Build duration: 37 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 22:00:05 + Build duration: 37 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 21:56:09 + Build duration: 38 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 21:57:14 + Build duration: 20 min and counting JUnit Tests Name:

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 21:57:24 + Build duration: 17 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 188 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/188/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 May 2020 21:56:46 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/11/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 21:57:02 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/15/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 21:56:46 + Build duration: 14 min and counting JUnit Tests Name:

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

dvratil added a reviewer: Frameworks. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

dvratil created this revision. dvratil added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY There's no sign of KGlobal (obviously, it's been moved to kdelibs4support) or any

D29370: Use UI marker context in more tr() calls

kossebau created this revision. kossebau added reviewers: Frameworks, Localization, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R289 KNotifications BRANCH usemoreuicontextmarker REVISION

D29369: Use UI marker context in more tr() calls

kossebau created this revision. kossebau added reviewers: Frameworks, Localization. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Also fix lowercase "toolbar" in action text to Title

D29368: Use UI marker context in more tr() calls

kossebau created this revision. kossebau added reviewers: Frameworks, Localization. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R284 KCompletion BRANCH usemoreuicontextmarker REVISION DETAIL

D29367: Use UI marker context in more tr() calls

kossebau created this revision. kossebau added reviewers: Frameworks, Localization, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Also align placeholder string of

D29210: [NestedListHelper] Fix indentation of selection, add tests

This revision was automatically updated to reflect the committed changes. Closed by commit R310:7012493410ae: [NestedListHelper] Fix indentation of selection, add tests (authored by poboiko). Herald added a project: Frameworks. REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE

D29101: KNewStuff: Fix file path and process call

This revision was automatically updated to reflect the committed changes. Closed by commit R304:4c6b3afcd80a: KNewStuff: Fix file path and process call (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29101?vs=81467=81753 REVISION DETAIL

D29101: KNewStuff: Fix file path and process call

alex added a comment. Ups, that makes sense ^^ Thanks! REPOSITORY R304 KNewStuff BRANCH arcpatch-D29101 REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir, anthonyfieroni Cc: anthonyfieroni,

D29101: KNewStuff: Fix file path and process call

anthonyfieroni accepted this revision. anthonyfieroni added a comment. KNewstuff is framework, it has only master. REPOSITORY R304 KNewStuff BRANCH arcpatch-D29101 REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven,

D29101: KNewStuff: Fix file path and process call

alex added a comment. Friendly ping regarding the question :-) REPOSITORY R304 KNewStuff BRANCH arcpatch-D29101 REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir Cc: anthonyfieroni,

D29175: DBus Runner: Add service property to request actions once

alex added inline comments. INLINE COMMENTS > meven wrote in dbusrunnertest.cpp:206 > You should have added a QSignalSpy to check prepare was called, and another > for requestAction to check it has been called only once. The concept behind this test is, that the runner is just loaded. If the

D29347: KAuthorized: export method to reload restrictions

dfaure added a comment. Yes declaring the function there, as in the code sample shown here. We do the same for internally-exported variables like KSERVICE_EXPORT int ksycoca_ms_between_checks; Qt does the same kind of things. A _p.h header would have to be installed, which we

D29347: KAuthorized: export method to reload restrictions

dfaure edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D29347 To: dfaure, aacid, apol, mdawson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29363: Use UI marker context in more tr() calls

aacid added a comment. The descriptions seem reasonable. The problem with this is that it makes all strings untranslated and i'm not sure it's worth the effort. My hope is that at this point anything that was actually ambiguous would have been reported by the translators and fixed.

D29363: Use UI marker context in more tr() calls

kossebau updated this revision to Diff 81744. kossebau added a comment. also done for ui files REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29363?vs=81742=81744 BRANCH usemoreuicontextmarker REVISION DETAIL https://phabricator.kde.org/D29363

Re: Information regarding upcoming Gitlab Migration

Hi all, Sorry for late response, but project "cutehmi" fits into "sdk" category better than "applications" (technically it's a framework, but I guess "frameorks" is reserved for well integrated KDE Frameworks). Speaking generally on subject, categorization is always problematic. Categories

D29347: KAuthorized: export method to reload restrictions

aacid added a comment. So how you're going to use it from unittests? declaring the function there? maybe better to declare it to some of the _p.h headers ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D29347 To: dfaure, aacid, apol, mdawson Cc:

D29210: [NestedListHelper] Fix indentation of selection, add tests

dfaure accepted this revision. This revision is now accepted and ready to land. BRANCH change-indent (branched from master) REVISION DETAIL https://phabricator.kde.org/D29210 To: poboiko, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel

D29208: [NestedListHelper] Improve indentation code

This revision was automatically updated to reflect the committed changes. Closed by commit R310:18a2371fe394: [NestedListHelper] Improve indentation code (authored by poboiko). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29208?vs=81738=81743 REVISION

Re: Information regarding upcoming Gitlab Migration

On Fri, May 1, 2020 at 10:14 PM Ben Cooksley wrote: > On Sat, May 2, 2020 at 6:17 AM Alexander Potashev > wrote: > > I have a similar use case. Sometimes I need to share a URL to a > > project. For this purpose I used to share e.g. > > https://cgit.kde.org/releaseme.git/about > > > > Does this

D29363: Use UI marker context in more tr() calls

kossebau added a comment. Given the amounts of changes only to be applied directly after a KF tagging, to give translators as much time as possible to catch up. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29363 To: kossebau, #frameworks, #localization,

D29363: Use UI marker context in more tr() calls

kossebau created this revision. kossebau added reviewers: Frameworks, Localization, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Also fix some tooltip text styles to follow KDE HIG

D29362: [KCharSelect] Initially give focus to the search lineedit

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY If the search lineedit widget is added, give it initial focus, so that you launch the dialogue and start typing

D28932: Store filename terms just once

bruns edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28932 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D28932: Store filename terms just once

bruns added a comment. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28932 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D29361: KCrash: remove debug output which breaks unittests from using ~/.qttest/config for categorized logging

dfaure created this revision. dfaure added reviewers: kossebau, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY kdebugsettings --test-mode allows to tune the categorized logging for

D29208: [NestedListHelper] Improve indentation code

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH unused (branched from master) REVISION DETAIL https://phabricator.kde.org/D29208 To: poboiko, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack,

D29208: [NestedListHelper] Improve indentation code

poboiko updated this revision to Diff 81738. poboiko added a comment. Improve readability as suggested, also const'ify REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29208?vs=81256=81738 BRANCH unused (branched from master) REVISION DETAIL

D29208: [NestedListHelper] Improve indentation code

dfaure added inline comments. INLINE COMMENTS > poboiko wrote in nestedlisthelper.cpp:87 > That's the current block being checked, not the next one. I've just checked > to be sure, last block can be unindented :) > > TBH, I don't really know if it's even possible for the current block to be >

D29358: Implement lock-screen visibility control on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is only the backend part, lacking a proper frontend API this is using a custom hint for now. Android knows three

D29335: Implement notification grouping on Android

vkrause updated this revision to Diff 81731. vkrause added a comment. Replace the simple ref count with a full child id tracking. The ref count got out of sync when an existing notification is updated, using a set fixes that. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

niccolove accepted this revision as: niccolove. niccolove added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R242 Plasma Framework (Library) BRANCH heading-only-if-svg-exists (branched from master) REVISION DETAIL https://phabricator.kde.org/D29352 To:

D29335: Implement notification grouping on Android

vkrause added a comment. Still not good enough, updating existing notfication messes up the refcounter, resulting still in leftover group elements. REPOSITORY R289 KNotifications BRANCH grouping REVISION DETAIL https://phabricator.kde.org/D29335 To: vkrause, nicolasfella Cc:

D29357: Display rich text notification messages on Android (API level 24+)

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29357 AFFECTED FILES

D29357: Display rich text notification messages on Android (API level 24+)

vkrause added a comment. Example: F8278136: Screenshot_20200502_112835.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29357 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:baa38ebee32e: [RenameDialog] Add an arrow indicating direction from src to dest (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28745: Skip caching thumbnails on encrypted filesystems

marcingu added a comment. PING! Is current code fine or should we get rid of KMountPoint completely somehow? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: bruns, meven, ngraham,

D29335: Implement notification grouping on Android

vkrause updated this revision to Diff 81725. vkrause added a comment. Explicitly track if notification groups are still in use. This fixes group summaries staying active when we explicitly close a notification, rather then having the user or system dismiss it. REPOSITORY R289

D29335: Implement notification grouping on Android

vkrause added a comment. This isn't good to go yet, there are corner cases where the group summary item stays around after closing the last notification, working on fixing this. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29335 To:

D29339: Implement updating of notifications on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:c5688295e45f: Implement updating of notifications on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29339?vs=81686=81722#toc REPOSITORY R289 KNotifications

D29323: Handle multi-line and rich-text notifications on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:9bfd98a3d3da: Handle multi-line and rich-text notifications on Android (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE