T13144: Remove deprecated code from Kirigami example

2020-05-12 Thread Nathaniel Graham
ngraham closed this task as "Resolved". ngraham claimed this task. ngraham added a comment. Phabricator is used for task tracking, not bug reporting. Since this is a simple documentation fix, can you submit a patch? That would be lovely. :) TASK DETAIL https://phabricator.kde.org/T13144

D29667: Export metalist to json file

2020-05-12 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R264:c8e125d0860e: Export metalist to json file (authored by cblack). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29667?vs=82608=82692 REVISION DETAIL

D29667: Export metalist to json file

2020-05-12 Thread Olivier Churlaud
ochurlaud accepted this revision. ochurlaud added a comment. This revision is now accepted and ready to land. Alright! Ship it REPOSITORY R264 KApiDox BRANCH cblack/metadata (branched from master) REVISION DETAIL https://phabricator.kde.org/D29667 To: cblack, ochurlaud Cc: bcooksley,

D7563: Add privilegeExecution field to file protocol description

2020-05-12 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-05-12 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, chinmoyr Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel,

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-05-12 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, chinmoyr Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel,

D29667: Export metalist to json file

2020-05-12 Thread Carson Black
cblack added a comment. In D29667#669622 , @ochurlaud wrote: > Don't use file as a variable name as it's a python keyword. >>> import keyword >>> keyword.iskeyword("file") False It's not. > Do you really want to

D29667: Export metalist to json file

2020-05-12 Thread Olivier Churlaud
ochurlaud added a comment. Don't use file as a variable name as it's a python keyword. Do you really want to dump those files everywhere? REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D29667 To: cblack, ochurlaud Cc: bcooksley, kde-frameworks-devel,

T13144: Remove deprecated code from Kirigami example

2020-05-12 Thread Ben Cooksley
bcooksley added a comment. Reassigning from Sysadmin to the Frameworks Developers - we don't maintain the API Documentation. TASK DETAIL https://phabricator.kde.org/T13144 To: bcooksley Cc: bcooksley, kde-frameworks-devel, sanecito, LeGast00n, cblack, michaelh, ngraham, bruns

T13144: Remove deprecated code from Kirigami example

2020-05-12 Thread Ben Cooksley
bcooksley edited projects, added Frameworks; removed Sysadmin. bcooksley edited subscribers, added: kde-frameworks-devel; removed: sysadmin. TASK DETAIL https://phabricator.kde.org/T13144 To: bcooksley Cc: kde-frameworks-devel, sanecito, sysadmin, duffus

T13144: Remove deprecated code from Kirigami example

2020-05-12 Thread Ben Cooksley
bcooksley changed the visibility from "Custom Policy" to "Public (No Login Required)". bcooksley changed the edit policy from "Custom Policy" to "All Users". TASK DETAIL https://phabricator.kde.org/T13144 To: bcooksley Cc: kde-frameworks-devel, sanecito, LeGast00n, cblack, michaelh, ngraham,

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-12 Thread Alexander Lohnau
alex added a comment. Friendly Ping  REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven, broulik, mart Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29680: Fix modified line marker in kate minimap

2020-05-12 Thread Kåre Särs
sars accepted this revision. sars added a comment. This revision is now accepted and ready to land. Thanks for the patch! I had not noticed the problem before :) REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D29680 To: davidedmundson, #kate,

D29680: Fix modified line marker in kate minimap

2020-05-12 Thread David Edmundson
davidedmundson added a comment. What about ktexteditor? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29680 To: davidedmundson, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, bruns, demsking, cullmann, sars,

D29680: Fix modified line marker in kate minimap

2020-05-12 Thread Nathaniel Graham
ngraham added a comment. Ah right, that's still here. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29680 To: davidedmundson, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, bruns, demsking, cullmann, sars,

D29680: Fix modified line marker in kate minimap

2020-05-12 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davidedmundson requested review of this revision. REVISION SUMMARY Our pixmap is the size of the number of lines in

D29680: Fix modified line marker in kate minimap

2020-05-12 Thread Nathaniel Graham
ngraham added a comment. Kate patches are at https://invent.kde.org/kde/kate/-/merge_requests, BTW. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29680 To: davidedmundson, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D29678: Fix incorrect colours in the KNS Quick messagebox

2020-05-12 Thread Dan Leinir Turthra Jensen
leinir edited the test plan for this revision. leinir added reviewers: Frameworks, KNewStuff, Plasma, bugseforuns. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29678 To: leinir, #frameworks, #knewstuff, #plasma, bugseforuns Cc: kde-frameworks-devel, LeGast00n,

D29678: Fix incorrect colours in the KNS Quick messagebox

2020-05-12 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Explicitly set the colours used in the messagebox' content item, as the theme does not propagate to the simpler items,

Re: kcoreaddons_add_plugin executable/plugin directory conflict

2020-05-12 Thread Daniel Vrátil
On Tuesday, 12 May 2020 01:20:02 CEST David Faure wrote: > On lundi 11 mai 2020 14:07:28 CEST Friedrich W. H. Kossebau wrote: > > Am Montag, 11. Mai 2020, 10:21:10 CEST schrieb Daniel Vrátil: > > > Hi all, > > > > > > I'm moving some plugins in kaddressbook and I ran into a problem with > > > >

D29634: sftp: break large writes into multiple requests

2020-05-12 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > meven wrote in kio_sftp.cpp:58 > Why not change it now to 32 * 1024 then ? > I guess you tested this value works at least with openssh. > > I guess the best solution would be to ask/figure out the server buffer size. > > What does gvfs, or other

D29634: sftp: break large writes into multiple requests

2020-05-12 Thread Alexander Saoutkin
feverfew added inline comments. INLINE COMMENTS > meven wrote in kio_sftp.cpp:1831-1832 > Maybe we can deduce the server buffer size based on the `bytesWritten` value > : at init `serv_buffer_size =MAX_XFER_BUF_SIZE; ` and then ` if (length > > bytesWritten) { serv_buffer_size = bytesWritten

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 109 - Fixed!

2020-05-12 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/109/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 May 2020 09:13:22 + Build duration: 4 min 29 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 108 - Failure!

2020-05-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/108/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 May 2020 09:03:45 + Build duration: 1 min 30 sec and counting JUnit Tests Name: (root)

D29409: Add documentation line on KCM translations

2020-05-12 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > cblack wrote in configmodule.h:98 > You probably want to use backticks instead of quotes as this is referring to > something codewise. I don't understand. REPOSITORY R296 KDeclarative REVISION DETAIL

D29634: sftp: break large writes into multiple requests

2020-05-12 Thread Méven Car
meven added inline comments. INLINE COMMENTS > feverfew wrote in kio_sftp.cpp:1831-1832 > AFAICT the size of the buffer never changes so this will easily cause a > buffer overrun if I'm not mistaken? > > Say for example you have a buffer with `buffer.size() == MAX_XFER_BUF_SIZE + > 1`. Then

D29634: sftp: break large writes into multiple requests

2020-05-12 Thread Méven Car
meven requested changes to this revision. meven added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:58 > // you will overflow the 2 byte size variable in a sftp packet. > +// FIXME: this seems too large > +// from the RFC: > +// The maximum