D29793: Rename Perl6 syntax to Raku

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29793 To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson,

D29793: Rename Perl6 syntax to Raku

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, Kate, jpoelen, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In October

D29789: Make text always align with font base line

xuetianweng added a comment. This is my another try as an alternative solution to D25339 . Actually this works surprisingly good IMHO, at least for CJK users for most cases. REPOSITORY R39 KTextEditor REVISION DETAIL

D29789: Make text always align with font base line

xuetianweng edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29789 To: xuetianweng, rjvbb, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann,

D29789: Make text always align with font base line

xuetianweng created this revision. xuetianweng added reviewers: rjvbb, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. xuetianweng requested review of this revision. REVISION SUMMARY When font uses other fallback font,

D25339: update lineHeight if boundingRect indicates a larger value.

xuetianweng added a comment. Actually I was trying to use this approach in the patch because I was afraid that variable line height may need to estimate the whole document height to make scroll work correctly. But during this patching experience I realized that the ktexteditor first

D29787: Fix krununittest

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY After 6452a34cf01d03d316 ,

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir updated this revision to Diff 82974. ahmadsamir retitled this revision from "[StatJob] Change mostLocalUrl to only handle protocols with Class=:local" to "[StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs". ahmadsamir edited the summary of this revision. ahmadsamir

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

ahmadsamir added a comment. In D29385#671987 , @dfaure wrote: > That's the point, a NFS mount *is* a local URL, so we do use QFile for it. And then it takes forever because the kernel has to talk over a socket to answer us. > Yes this is

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure added a comment. That's the point, a NFS mount *is* a local URL, so we do use QFile for it. And then it takes forever because the kernel has to talk over a socket to answer us. Yes this is horrendous. I hate network mounts :-) REPOSITORY R241 KIO REVISION DETAIL

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

ahmadsamir added a comment. In D29385#671980 , @dfaure wrote: > It's 3 times faster on my local SSD. > > Now think of a NFS mount on a server from another country I was thinking mostly of QFile when url.isLocalFile() is true, but

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure added a comment. It's 3 times faster on my local SSD. Now think of a NFS mount on a server from another country REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29385 To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella,

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in openurljob.cpp:261 > LOL we're like an old couple, the explicit discussion doesn't actually need > to happen anymore ;) > > OK for everyone else, we're debating whether it's ok to use blocking > local-file I/O like QFile or

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham updated this revision to Diff 82971. ngraham added a comment. Only open in System Settings or Info Center if systemsettings is installed REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29711?vs=82751=82971 BRANCH

D29782: [StatJob] Change mostLocalUrl to only handle protocols with Class=:local

ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in openurljob.h:120 > You meant, according to > https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members > :) I got the info from a commit in kwidgetsaddons where you "fixed" a

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

kossebau added inline comments. INLINE COMMENTS > openurljob.h:119 > + * a different implementation on Windows. > + * > + * @param b whether to only show the "open with" dialog. Please mention explicit what the default is (false), to remove any ambiguity. Some other setters might

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham added a comment. In D29711#671616 , @mart wrote: > hmm, should probably check before whether systemsettings5 and kinfocenter exist beforehand and fallback to kcmshell if not? Yeah Christoph and Luigi brought that up too. Will do.

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in openurljob.h:120 > It seems that we shouldn't end @param with a ".", according to @kossebau > anyway... You meant, according to

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

ahmadsamir accepted this revision. ahmadsamir added a subscriber: kossebau. ahmadsamir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > openurljob.h:120 > + * > + * @param b whether to only show the "open with" dialog. > + */ It seems that we

Re: Recent breakage in kwallet

On Fri, May 15, 2020 at 3:53 PM Roman Gilg wrote: > > On Fri, May 15, 2020 at 12:44 PM Marco Martin wrote: > > > > Hi all, > > Recently, the package of KWallet framework for neon (devel unstable, > > package built out of current master state) seems to be broken: kwallet > > now can't open

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 82960. arrowd added a comment. I decided to help with this a bit. - Fix detection of header. It requires to be included too. - Implement test helpers for BSD (extattr). At the moment, some tests fail for me, because xattrs don't seem to be

D29782: [StatJob] Change mostLocalUrl to only handle protocols with Class=:local

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Previously mostLocalUrl would check that !url.isLocalFile(), that meant a statjob would be fired for

D17816: Support for xattrs on kio copy/move

arrowd commandeered this revision. arrowd added a reviewer: cochise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns,

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

cullmann added a comment. Sure, thanks for the improvement! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29735 To: bewuethr, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n,

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

This revision was automatically updated to reflect the committed changes. Closed by commit R216:f804af905ef3: Assign Identifier attribute to opening double quote instead of Comment (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Hmm, right, didn't think about that :( Guess if we want to have this, we need to improve the read/writeConfig functions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc:

D29406: Add X-KDE-Original-Executable to Applications properties

meven removed a dependent revision: D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D29406 To: meven, #frameworks, davidedmundson, apol, bport Cc: kde-frameworks-devel,

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

meven added a dependent revision: D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D29774 To: meven, davidedmundson, zzag, #frameworks, #kwin Cc: kde-frameworks-devel,

D29034: Add systemd user service file for kded

This revision was automatically updated to reflect the committed changes. Closed by commit R297:4ae4de9ff469: Add systemd user service file for kded (authored by broulik). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29034?vs=82868=82949 REVISION DETAIL

D29034: Add systemd user service file for kded

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29034 To: broulik, #plasma, #frameworks, davidedmundson Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in file_unix.cpp:1052 > I'm confused. We want to solve renaming 'a' to 'A' when 'A' does *not* exist. > > QFile::rename will not overwrite an existing file, so it will do nothing if > dest exists. const QByteArray dest1 =

Re: Recent breakage in kwallet

On Fri, May 15, 2020 at 12:44 PM Marco Martin wrote: > > Hi all, > Recently, the package of KWallet framework for neon (devel unstable, > package built out of current master state) seems to be broken: kwallet > now can't open anymore wallets previously created (it works if the > local kwallet

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

meven created this revision. meven added reviewers: davidedmundson, zzag, Frameworks, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This added field to Application desktop entries allows to

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

mart added a comment. hmm, should probably check before whether systemsettings5 and kinfocenter exist beforehand and fallback to kcmshell if not? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: ltoscano, cfeck,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 605 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/605/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 May 2020 10:47:00 + Build duration: 6 min 50 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/107/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 15 May 2020 10:47:00 + Build duration: 6 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/115/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 15 May 2020 10:47:00 + Build duration: 5 min 11 sec and counting JUnit Tests Name:

D29767: CopyJob: Check if destination dir is a symlink

meven updated this revision to Diff 82920. meven marked 3 inline comments as done. meven added a comment. review feedback, cleanups REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29767?vs=82902=82920 BRANCH arcpatch-D29767 REVISION DETAIL

D29767: CopyJob: Check if destination dir is a symlink

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8769b6360d87: CopyJob: Check if destination dir is a symlink (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29767?vs=82920=82921 REVISION DETAIL

Recent breakage in kwallet

Hi all, Recently, the package of KWallet framework for neon (devel unstable, package built out of current master state) seems to be broken: kwallet now can't open anymore wallets previously created (it works if the local kwallet data is deleted and recreated) the weird thing is that it seems that

Re: Request for ktexteditor patch release

Am Freitag, 15. Mai 2020, 12:03:08 CEST schrieb David Faure: > On vendredi 15 mai 2020 11:01:04 CEST Friedrich W. H. Kossebau wrote: > > Hi, > > > > I would like to ask for a 5.70 patch release for ktexteditor, with > > 972da14f486a83556e192d09bb18a2500728895a cherry-picked. > > > > Not a

Re: Request for ktexteditor patch release

On vendredi 15 mai 2020 11:01:04 CEST Friedrich W. H. Kossebau wrote: > Hi, > > I would like to ask for a 5.70 patch release for ktexteditor, with > 972da14f486a83556e192d09bb18a2500728895a cherry-picked. > > Not a crasher, but preventing the pickup of any global view setting changes > after a

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/14/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 15 May 2020 08:48:41 + Build duration: 14 min and counting BUILD ARTIFACTS

Request for ktexteditor patch release

Hi, I would like to ask for a 5.70 patch release for ktexteditor, with 972da14f486a83556e192d09bb18a2500728895a cherry-picked. Not a crasher, but preventing the pickup of any global view setting changes after a kate/kdevelop session close & open cycle for existing document views, which has

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/15/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 15 May 2020 08:48:41 + Build duration: 7 min 58 sec and counting JUnit Tests Name:

D29739: Add 48px places icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:a3148c470784: Add 48px places icons (authored by manueljlin). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29739?vs=82904=82910 REVISION DETAIL

D27844: Store and fetch complete view config in and from session config

kossebau added a comment. In D27844#671380 , @dhaumann wrote: > I suggest to revert, and send a notification with the change to kde-distro-packa...@kde.org to avoid that many users break their configuration. Okay, doing now. REPOSITORY

D29739: Add 48px places icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH 48px-places (branched from master) REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg, ngraham, ndavis Cc: ngraham,

D29739: Add 48px places icons

manueljlin updated this revision to Diff 82904. manueljlin added a comment. Changed folder-documents, folder-networks, folder-script, user-desktop. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29739?vs=82873=82904 BRANCH 48px-places (branched

D29743: sftp: map sftp_open error to kio error

This revision was automatically updated to reflect the committed changes. Closed by commit R320:07e44cb1b536: sftp: map sftp_open error to kio error (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29743?vs=82835=82903 REVISION DETAIL

D29767: CopyJob: Check if destination dir is a symlink

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks for the quick fix and for the test! Just minor issues in comments, feel free to push after fixing. INLINE COMMENTS > jobtest.cpp:626 > +// just the same as

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 604 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/604/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 May 2020 07:02:12 + Build duration: 6 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/106/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 15 May 2020 07:02:12 + Build duration: 6 min 25 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/114/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 15 May 2020 07:02:12 + Build duration: 5 min 9 sec and counting JUnit Tests Name:

D29767: CopyJob: Check if destination dir is a symlink

meven updated this revision to Diff 82902. meven added a comment. Remove unrelated change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29767?vs=82901=82902 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29767 AFFECTED FILES

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. Fix at D29767 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29767: CopyJob: Check if destination dir is a symlink

meven created this revision. meven added reviewers: Frameworks, dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 421213 FIXED-IN: 5.71 TEST PLAN ctest REPOSITORY R241 KIO