D29787: Fix krununittest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ef7708d1f5ec: Fix krununittest (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29787?vs=82975=83011 REVISION DETAIL

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bed09e39fe24: [kio_file] Handle renaming file A to a on FAT32 filesystems (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29610?vs=82750=83010

D29789: Make text always align with font base line

dhaumann added a comment. I like this patch. In fact, I observed over the past years again and again that sometimes, especially if chinese or similar letters are included, the baseline is wrong in Kate, leading to much more overpainting that needed. If this patch fixes this, then I'm all

D29800: Fix URL being passed as argument when launching a .desktop file

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks for the unittest and fix! Oversight on my side indeed. INLINE COMMENTS > openurljobtest.h:58 > void takeOverAfterMimeTypeFound(); > +void runDeskopFileDirectly(); >

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

dfaure added a comment. OK, I picked testtrash because kio_trash *is* a :local protocol. If it doesn't use UDS_LOCAL_PATH, at least it means the job will actually go through (no early filtering out). That's at least interesting to test too. Good that http will give no error. That's

D29802: Require out-of-source builds

davidre accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre Cc: ltoscano, davidre,

D29802: Require out-of-source builds

ngraham retitled this revision from "Require in-source build" to "Require out-of-source builds". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack,

D29802: Require in-source build

ltoscano added a comment. I believe a few sentences in the the commit message contradicts each other. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n,

D29802: Require in-source build

davidre requested changes to this revision. davidre added a comment. This revision now requires changes to proceed. I don't think we want to require in source builds REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb,

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

kossebau added a comment. I just applied the diff as-is to the working checkout of kapidox on the server, to see if the patch also works for the setup of the nightly run, other than my separate testing which might have missed any special environment setup. So tomorrow before noon CEST we

D29802: Require in-source build

ognarb accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb Cc: kde-frameworks-devel,

D29802: Require in-source build

ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY In addition to just being a good idea in general, the dynamic icon

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

ognarb added a comment. In D29797#672263 , @kossebau wrote: > Thanks for the (first) review :) > > Open questions I have are these: > a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a

D29800: Fix URL being passed as argument when launching a .desktop file

fvogt created this revision. fvogt added reviewers: dfaure, marten. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY When a .desktop file is executed directly, it doesn't receive a parameter. BUG: 421364 TEST PLAN Test passes, applications open

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

cblack added a comment. In D29797#672263 , @kossebau wrote: > Thanks for the (first) review :) > > Open questions I have are these: > a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

kossebau added a comment. Thanks for the (first) review :) Open questions I have are these: a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallback to load() otherwise? It was only introduced at a certain version of pyyaml b) by

D29201: KCMUtils: Add option to append service file to list of arguments

alex added inline comments. INLINE COMMENTS > meven wrote in kpluginselector.cpp:855 > moduleInfo is part of the ctor here, so the fileName is already available > indirectly. > A good thing would be to avoid having an option for such a niche usage > although legitimate. > moduleInfo is part

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir added a comment. I've just realised, we won't get an error with an http url; in that case we return the url the statjob was called on as-is and cancel the job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven added inline comments. INLINE COMMENTS > kmountpoint.cpp:444 > +// for /dir/link/dir/test will return result for > /destLink/dir/test > +return findByPath(fileinfo.symLinkTarget() + > path.mid(cursor)); > +} Need to pass the flag here.

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir added a comment. In D29782#672157 , @dfaure wrote: > Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work) I don't see where the trash ioslave sets UDS_LOCAL_PATH; I think it

D29201: KCMUtils: Add option to append service file to list of arguments

meven added inline comments. INLINE COMMENTS > alex wrote in kpluginselector.cpp:855 > You could add a field to the KCModule class (thats where you ultimately want > to access the fileName). > But then the downside is that you don't have them as a constructor argument. moduleInfo is part of

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

cblack accepted this revision. REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks, ochurlaud, ognarb, cblack Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh,

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. +1 and also +1 for removing python2 support REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks,

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

kossebau created this revision. kossebau added reviewers: Frameworks, ochurlaud, ognarb. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY This patch makies kapidox work

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

kossebau added inline comments. INLINE COMMENTS > kcolorcombo.cpp:222 > +namedColors.reserve(colors.size()); > +for (auto color : colors) { > +namedColors.append({QString(), color}); `auto& ` as we just want a reference, avoids a copy constructor call each time. >

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

kossebau added a comment. Isn't the recommendation to rather avoid using things like QPair, and instead used properly defined structs? And ideally non-nested ones, to help with cases of forward declarations? Even QPair's API dox says so: "The advent of C++11 automatic variable type

D29795: Add collaboration guide

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Add a file with

Re: Request for ktexteditor patch release

If we're adding stuff to a 5.70 bugfix point release, https://cgit.kde.org/kio.git/commit/?id=8769b6360d87c1b688eac4d0ce97594351bad13c is another good candidate, which fixes a recent regression (https://bugs.kde.org/show_bug.cgi?id=421213). Nate On 5/15/20 4:42 AM, Friedrich W. H. Kossebau

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

dfaure added a comment. OK I'm having second thoughts about this. Because of Windows, and because of the case of multiple URLs. There's "displaying an open with dialog because we couldn't find any app, after a left-click on a file" and there's "displaying an open with dialog because

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29558 To: dfaure, ahmadsamir, broulik, svuorela Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

meven added a comment. It seems it is causing two failures in kiogui_applicationlauncherjobtest : https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/105/testReport/junit/projectroot/autotests/kiogui_applicationlauncherjobtest/ REPOSITORY R241 KIO REVISION DETAIL

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

dfaure updated this revision to Diff 82992. dfaure marked 2 inline comments as done. dfaure added a comment. API docs: remove trailing dot, mention 2 default values REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29558?vs=82358=82992 BRANCH

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

dfaure added a comment. Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work) and another one in jobtest.cpp for a http URL (e.g. to test which error code we're getting, if any?) + call mostLocalUrl() on a "normal" StatJob in

D29397: KPreviewJob : Support for DeviceRatioPixel

meven added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks, ngraham Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Request for ktexteditor patch release

On vendredi 15 mai 2020 15:37:00 CEST Nate Graham wrote: > If we're adding stuff to a 5.70 bugfix point release, > https://cgit.kde.org/kio.git/commit/?id=8769b6360d87c1b688eac4d0ce97594351ba > d13c is another good candidate, which fixes a recent regression >

Re: Recent breakage in kwallet

On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote: > Hi all, > Recently, the package of KWallet framework for neon (devel unstable, > package built out of current master state) seems to be broken: kwallet > now can't open anymore wallets previously created (it works if the > local kwallet

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, at least we'll have moved the code to the right place :-) INLINE COMMENTS > ahmadsamir wrote in file_unix.cpp:1052 > const QByteArray dest1 = "/mnt/fat32/A"; > const QByteArray

D29787: Fix krununittest

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Let's hope the CI has xterm installed I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird. REPOSITORY R241 KIO BRANCH l-terminal (branched from master)

D28874: Taiwanese holidays

shrapnel added a comment. I just wanted to say thank you to everybody for taking the time. Taiwan is available in the clock/calendar settings now, really cool! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: nhiga,

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz added a comment. Could anyone review my patch again? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29258 To: wojnilowicz, broulik, brute4s99, vonreth Cc: vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

meven added a comment. ping reviewers INLINE COMMENTS > previewjob.cpp:754 > thumb.setText(QStringLiteral("Thumb::Mimetype"), > currentItem.item.mimetype()); > +thumb.setText(QStringLiteral("Thumb::DevicePixelRatio"), > QString::number(thumb.devicePixelRatio())); >