KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 29 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/29/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 17 May 2020 22:04:05 + Build duration: 6 hr 29 min and counting JUnit Tests

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.14 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.14/27/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 17 May 2020 22:04:03 + Build duration: 6 hr 13 min and counting JUnit Tests

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/115/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 18 May 2020 00:10:46 + Build duration: 3 hr 50 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/16/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:47:05 + Build duration: 6 hr 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/19/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:47:05 + Build duration: 6 hr 4 min and counting JUnit Tests Name:

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 73 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/73/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:59 + Build duration: 5 hr 58 min and counting JUnit Tests Name:

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:57 + Build duration: 5 hr 57 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/18/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:50 + Build duration: 5 hr 53 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:42 + Build duration: 5 hr 50 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:46 + Build duration: 5 hr 37 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/16/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:45 + Build duration: 5 hr 33 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/12/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:43 + Build duration: 5 hr 30 min and counting JUnit Tests

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/18/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:44 + Build duration: 5 hr 24 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/11/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:41 + Build duration: 5 hr 15 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/11/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 21:46:41 + Build duration: 5 hr 13 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/15/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 22:17:13 + Build duration: 4 hr 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.14 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.14/10/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 22:16:47 + Build duration: 3 hr 49 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.14 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.14/24/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 22:15:48 + Build duration: 3 hr 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 123 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/123/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 20:19:35 + Build duration: 4 hr 31 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 615 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/615/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 23:55:22 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/114/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 20:19:35 + Build duration: 3 hr 51 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 614 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/614/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 22:28:22 + Build duration: 1 hr 26 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 192 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/192/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 21:57:14 + Build duration: 1 hr 42 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 43 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/43/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 21:57:07 + Build duration: 1 hr 30 min and counting BUILD ARTIFACTS

D29810: Don't use setenv after fork

apol added inline comments. INLINE COMMENTS > kcrash.cpp:823 > +char** environ_end; > +for(environ_end = environ; *environ_end; ++environ_end); > + Use {} instead of ; for readability. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek,

D29810: Don't use setenv after fork

jpalecek added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kcrash.cpp:825 > Just use vector, get the size by `environ_end - environ` No, that would be dynamic allocation, which is not safe in signal handlers. The whole purpose was to avoid it. REPOSITORY R285 KCrash REVISION

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 613 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/613/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 20:19:35 + Build duration: 2 hr 8 min and counting BUILD ARTIFACTS

D29397: KPreviewJob : Support for DeviceRatioPixel

elvisangelaccio added a comment. Would it make sense to initialize `devicePixelRatio` to `QGuiApplication::devicePixelRatio()` and add an API to change it (if desired) ? This way we wouldn't need to call a static method in the `main` of every client app (i.e. D29525

D29811: t/simplify-sending-data-through-socket

davidedmundson added a comment. > that would probably mean recompiling most of KDE (Debian has packages for 5.69 only). I will check out your change and see what remains. This isn't a universal rule that always applies, but generally speaking you can just roll back the the frameworks

D29811: t/simplify-sending-data-through-socket

anthonyfieroni added a comment. > But I'm not quite ready for 5.70 yet, that would probably mean recompiling most of KDE That's not need. Check out master of KCrash, CMakeLists.txt lower kf5 version to match your, compile new patch and test. Then create patch without lower version

D29810: Don't use setenv after fork

anthonyfieroni added inline comments. INLINE COMMENTS > kcrash.cpp:825 > + > +std::array environ_data; //hope it's big enough > +if((unsigned)(environ_end - environ) +2 >= environ_data.size()) { Just use vector, get the size by `environ_end - environ` REPOSITORY R285 KCrash REVISION

D29809: Don't invoke QString localized stuff in critical section

jpalecek retitled this revision from "t/dont-invoke-qstring-localized-stuff-in-critical-section" to "Don't invoke QString localized stuff in critical section". jpalecek edited the summary of this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To:

D29810: Don't use setenv after fork

jpalecek retitled this revision from "t/dont-use-setenv-after-fork" to "Don't use setenv after fork". jpalecek edited the summary of this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks Cc: kde-frameworks-devel, LeGast00n,

D29811: t/simplify-sending-data-through-socket

jpalecek added a comment. In D29811#672534 , @davidedmundson wrote: > Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths. It is 5.69. Yeah, now I can see you got

D29811: t/simplify-sending-data-through-socket

davidedmundson added a comment. Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths. Also can you check your commit messages, I don't know if it's phab being weird, but they all start with "t/" in the phab UI,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/113/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 18:26:19 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 122 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/122/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 18:26:19 + Build duration: 7 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 612 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/612/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 18:26:19 + Build duration: 6 min 18 sec and counting BUILD ARTIFACTS

D29811: t/simplify-sending-data-through-socket

jpalecek edited the summary of this revision. jpalecek added a reviewer: Frameworks. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29811 To: jpalecek, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

jpalecek added a reviewer: Frameworks. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: t/dont-use-setenv-after-fork

jpalecek edited the summary of this revision. jpalecek added a reviewer: Frameworks. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29809: t/dont-invoke-qstring-localized-stuff-in-critical-section

jpalecek added a reviewer: Frameworks. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

jpalecek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jpalecek requested review of this revision. REVISION SUMMARY When an application is crashing through KCrash, but has no restart argument list, KCrash itself crashes because

D29809: t/dont-invoke-qstring-localized-stuff-in-critical-section

jpalecek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jpalecek requested review of this revision. REVISION SUMMARY Move the DrKonqi socket name generation out of the signal handler, since it can freeze while locking QTextCodec

D29811: t/simplify-sending-data-through-socket

jpalecek added a dependent revision: D29812: t/handle-errors-from-socket. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29811 To: jpalecek Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29813: t/minimize-allocations-in-crash-handler

jpalecek added a dependent revision: D29814: Fix segfault on no restart args. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29813 To: jpalecek Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29809: t/dont-invoke-qstring-localized-stuff-in-critical-section

jpalecek added a dependent revision: D29810: t/dont-use-setenv-after-fork. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29812: t/handle-errors-from-socket

jpalecek added a dependent revision: D29813: t/minimize-allocations-in-crash-handler. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29812 To: jpalecek Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

jpalecek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jpalecek requested review of this revision. REVISION SUMMARY Simplify sending data through socket, avoid using one large buffer Depends on D29810

D29810: t/dont-use-setenv-after-fork

jpalecek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jpalecek requested review of this revision. REVISION SUMMARY Don't use the setenv function after fork Depends on D29809 Signed-off-by:

D29813: t/minimize-allocations-in-crash-handler

jpalecek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jpalecek requested review of this revision. REVISION SUMMARY Use static allocation in KCrash::defaultCrashHandler to prevent deadlocks Depends on D29812

D29810: t/dont-use-setenv-after-fork

jpalecek added a dependent revision: D29811: t/simplify-sending-data-through-socket. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29812: t/handle-errors-from-socket

jpalecek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jpalecek requested review of this revision. REVISION SUMMARY Handle errors from socket calls when communicating with kdeinit Depends on D29811

D29789: Make text always align with font base line

brauch added a comment. Hmm, consider though that a configuration option should be something that gives a choice to the user. It shouldn't be necessary to set a config option in order to make the program behave correctly. REPOSITORY R39 KTextEditor REVISION DETAIL

D29789: Make text always align with font base line

xuetianweng added a comment. In D29789#672335 , @dhaumann wrote: > I like this patch. In fact, I observed over the past years again and again that sometimes, especially if chinese or similar letters are included, the baseline is wrong in Kate,

D29802: Require out-of-source builds

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7abe60d96609: Require in-source build (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29802?vs=83008=83021 REVISION DETAIL

D29802: Require out-of-source builds

ngraham added a comment. I think this patch meets the world record for number of acceptances! REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol,

D29802: Require out-of-source builds

cblack accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, tfella, filipf, cblack Cc: ltoscano, davidre,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven updated this revision to Diff 83018. meven added a comment. fix indentation REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29805?vs=83014=83018 BRANCH arcpatch-D29805 REVISION DETAIL https://phabricator.kde.org/D29805 AFFECTED FILES

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven retitled this revision from "Thumbnail djvu: avoid to exit(1) when it should not" to "Thumbnail djvu: Avoid a crash when djvu is not installed". meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 611 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/611/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 14:21:03 + Build duration: 7 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/112/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 14:21:03 + Build duration: 5 min 7 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 121 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/121/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 14:21:04 + Build duration: 5 min 9 sec and counting JUnit Tests Name:

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

dfaure added a comment. (Intrusive) fix is up at https://invent.kde.org/frameworks/kio/-/merge_requests/3 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29738 To: marten, #frameworks, dfaure Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29802: Require out-of-source builds

filipf accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, tfella, filipf Cc: ltoscano, davidre,

D29802: Require out-of-source builds

tfella accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, tfella Cc: ltoscano, davidre,

D29802: Require out-of-source builds

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis Cc: ltoscano, davidre, kde-frameworks-devel,

D29802: Require out-of-source builds

nicolasfella accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella Cc: ltoscano, davidre, kde-frameworks-devel,

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

dfaure added a comment. Well spotted. Indeed, when using kioexec (because of the DeleteTemporaryFiles option) we no longer detect non-existing executables. I'll look into fixing this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29738 To: marten, #frameworks,

D29802: Require out-of-source builds

apol accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack,

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

kossebau added reviewers: winterz, francescorios. REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks, ochurlaud, ognarb, cblack, winterz, francescorios Cc: asturmlechner, kde-frameworks-devel,

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

kossebau added a comment. Bah, I patched the wrong kapidox on the server, so last nights run still failed. Oh well... not sure I will have time in the evening for processing this patch, but at least now getting the diff applied also on the right kapidox, so next server check tomorrow.

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/111/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 10:35:43 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 610 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/610/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 10:35:40 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/120/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 10:35:43 + Build duration: 5 min 0 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 609 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/609/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 10:16:15 + Build duration: 11 min and counting BUILD ARTIFACTS

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83016. arrowd added a comment. - Fix tests on FreeBSD. - Fix bug: Move `keylist.squeeze()` call before acquiring an interator. At this stage, all tests in `jobtest` pass on FreeBSD. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/110/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 09:51:55 + Build duration: 26 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 608 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/608/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 09:51:12 + Build duration: 25 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 119 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/119/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 09:51:25 + Build duration: 6 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 205 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/205/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 17 May 2020 09:51:25 + Build duration: 3 min 33 sec and counting

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

dfaure added a comment. Yeah, the full story is that I pushed to git.kde.org, reverted because I changed my mind, then the sysadmins told me I wasn't supposed to push to git.kde.org at all (it was blocked for everyone, but I have sysadmin privileges for historical and bus-factor reasons).

D29800: Fix URL being passed as argument when launching a .desktop file

ahmadsamir added a comment. In D29800#672399 , @fvogt wrote: > Landed to invent - hopefully correctly: https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec LGTM. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 607 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/607/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 09:38:27 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/109/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 09:38:27 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 204 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/204/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 17 May 2020 09:45:50 + Build duration: 41 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 118 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/118/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 09:45:50 + Build duration: 28 sec and counting CONSOLE OUTPUT [...truncated 2

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

ahmadsamir added a comment. In D29558#672395 , @dfaure wrote: > Not committed after all. It was committed, as I had it when I did git pull, but you lucked out, it seemed to have been eaten by the migration to gitlab somehow; I had to

D29800: Fix URL being passed as argument when launching a .desktop file

fvogt marked an inline comment as done. fvogt added a comment. Landed to invent - hopefully correctly: https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29800 To: fvogt, dfaure, marten

D29800: Fix URL being passed as argument when launching a .desktop file

fvogt closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29800 To: fvogt, dfaure, marten Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 117 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/117/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 09:41:02 + Build duration: 2 min 7 sec and counting CONSOLE OUTPUT [...truncated

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

dfaure reopened this revision. dfaure added a comment. This revision is now accepted and ready to land. Not committed after all. REPOSITORY R241 KIO BRANCH 2020_05_displayOpenWithDialog REVISION DETAIL https://phabricator.kde.org/D29558 To: dfaure, ahmadsamir, broulik, svuorela Cc:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 203 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/203/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 17 May 2020 09:38:19 + Build duration: 2 min 40 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/116/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 08:03:30 + Build duration: 1 hr 37 min and counting JUnit Tests Name:

D29787: Fix krununittest

ahmadsamir added a comment. In D29787#672139 , @dfaure wrote: > Let's hope the CI has xterm installed I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird. The CI seems to have xterm available as the unit

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/108/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 08:03:29 + Build duration: 55 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 606 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/606/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 May 2020 08:03:29 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 202 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/202/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 17 May 2020 08:03:29 + Build duration: 3 min 36 sec and counting CONSOLE OUTPUT

D29805: Thumbnail djvu: avoid to exit(1) when it should not

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Please update the text of the revision and the commit message, as they don't make much sense. Please mention that it fixes a crash in case ddjvu is not installed, by avoiding

D29805: Thumbnail djvu: avoid to exit(1) when it should not

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice,

  1   2   >