D26652: Unbreak module imports for Python2

2020-01-14 Thread A. Wilcox
awilcox added a comment. Why should Python 2 continue to be supported, after its EOL on 2020-01-01? What cases would a user be running the latest KDE release, but still have a Python 2 interpreter present as their primary/only Python interpreter? REPOSITORY R264 KApiDox REVISION

D8256: Add _XOPEN_SOURCE to C definitions

2018-08-30 Thread A. Wilcox
awilcox added a comment. rindex was being used in kscreenlocker but that code was removed last year. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh,

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread A . Wilcox
awilcox added a comment. That's fine with me. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11011 To: chinmoyr, dfaure, awilcox Cc: #frameworks, michaelh

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread A . Wilcox
awilcox accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11011 To: chinmoyr, dfaure, awilcox Cc: #frameworks, michaelh

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread A . Wilcox
awilcox added a comment. I can confirm that this patch does fix the build on musl. Thank you! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11011 To: chinmoyr, dfaure, awilcox Cc: #frameworks, michaelh

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

2018-03-03 Thread A . Wilcox
awilcox reopened this revision. awilcox added a comment. This revision is now accepted and ready to land. BUG: 391367 : musl is strictly POSIX conformant

D8256: Add _XOPEN_SOURCE to C definitions

2017-10-11 Thread A . Wilcox
awilcox added a comment. Please do note that `_XOPEN_SOURCE` must be `600` and not `700` because some components of KDE still use `rindex` which is no longer supported in X/Open 7 . REPOSITORY R240 Extra CMake

D8256: Add _XOPEN_SOURCE to C definitions

2017-10-11 Thread A . Wilcox
awilcox created this revision. awilcox added a reviewer: alexmerry. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY (This was reported on the KDE bug tracker as Bug 373175

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-10-11 Thread A . Wilcox
awilcox updated this revision to Diff 20619. awilcox added a comment. This diff was created with `git diff`. REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8064?vs=20125=20619 REVISION DETAIL https://phabricator.kde.org/D8064 AFFECTED FILES

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-09-29 Thread A . Wilcox
awilcox created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY While packaging kinit 5.38.0 for Adélie, I ran in to the following error: -- Installing:

D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

2017-06-14 Thread A. Wilcox
awilcox updated this revision to Diff 15456. awilcox added a comment. This is now a patch made with ```git format-patch``` against current master (https://phabricator.kde.org/R286:6a24cf9d5a2fd83a22ea74d502d24665dcd0b57c). Still passes on both Py2 and Py3. REPOSITORY R286 KFileMetaData

[Differential] [Updated] D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

2017-01-31 Thread A. Wilcox
awilcox updated the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D4377 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: awilcox Cc: #frameworks

[Differential] [Request, 10 lines] D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

2017-01-31 Thread A. Wilcox
awilcox created this revision. awilcox set the repository for this revision to R286 KFileMetaData. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KFileMetaData test scripts are usable in both deprecated Python 2, and

[Differential] [Request, 14 lines] D4335: Fix endianness issues once and for all in Blowfish algorithm

2017-01-29 Thread A. Wilcox
awilcox created this revision. awilcox set the repository for this revision to R311 KWallet. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Attempting to package KWallet 5.29.0 for PowerPC, I ran in to a test failure