D25965: [plasmashell] Add signal for panelTakesFocus changing

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, provided that the rest make sense. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D25965 To: davidedmundson, apol Cc: apol,

D25953: Ignore parent scopes that are in the process of being removed

This revision was automatically updated to reflect the committed changes. Closed by commit R242:208b94365ce0: Ignore parent scopes that are in the process of being removed (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25953: Ignore parent scopes that are in the process of being removed

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY When we destroy a colorscope, all children will try to reparent. This patch makes it so they

D25918: Consistently define the tooltip delay

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c33fcaa8d747: Consistently define the tooltip delay (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25918?vs=71352=71443

D25918: Consistently define the tooltip delay

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Set the right value on the Kirigami.Units and use it from tooltip. REPOSITORY R242 Plasma

D25858: Use QStyle for determining icon sizes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25858 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25824: Support archive installs with adoption commands

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH support-archive-installs-in-use-commands (branched from master) REVISION DETAIL https://phabricator.kde.org/D25824 To: leinir, #frameworks, #plasma, #knewstuff, apol, ngraham

D25827: kcodecs EBN transport protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25827 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25829: kconfig EBN transport protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25829 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25824: Support archive installs with adoption commands

apol added inline comments. INLINE COMMENTS > engine.cpp:744 > +const QDir dir(currentPath); > if (dir.path()==(rootPath+dir.dirName())) { > +qCDebug(KNEWSTUFFCORE) << "Found directory" << dir; Shouldn't we make sure rootPath ends with /? at least with an ASSERT if

D25727: Expose enum to the metaobject compiler

apol added a comment. Had to revert the commit, it broke with GCC. https://commits.kde.org/kpeople/b495b1a260cd15463a03ee47614b783ae8c2203d REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich, davidedmundson Cc: dfaure, lnj,

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

apol added a comment. Plasma master can depend on kf5 master. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25727: Expose enum to the metaobject compiler

This revision was automatically updated to reflect the committed changes. Closed by commit R307:508b1bab207e: Expose enum to the metaobject compiler (authored by apol). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70997=71093 REVISION DETAIL

D25775: Check cursor_open return value

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25775 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, #baloo, hurikhan77,

D14218: Introduce a test to make sure we're not offering duplicated icons

apol abandoned this revision. apol added a comment. Doesn't seem relevant anymore REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #breeze, #frameworks Cc: dfaure, ngraham, andreask, kde-frameworks-devel, LeGast00n,

D25727: Expose enum to the metaobject compiler

apol updated this revision to Diff 70997. apol added a comment. Alternative approach without Q_NAMESPACE_EXPORT, which is too new REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70895=70997 BRANCH arcpatch-D25727 REVISION DETAIL

D25755: Replace iterators with range-based for

apol added a comment. In D25755#572575 , @broulik wrote: > In D25755#572418 , @apol wrote: > > > Do we dislike iterators now? > > > We don't, and they still make sense for when you need the

D25757: EBN purpose constructor cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25757 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

apol added a comment. I see this patch still works and applies. I'd say landing it would still make sense. If nobody disagrees I'll do so in a week. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks,

D22577: Remove unused pnm.desktop file

apol closed this revision. apol added a comment. This patch was already applied REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D22577 To: rempt, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25755: Replace iterators with range-based for

apol added a comment. Do we dislike iterators now? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D25755 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25754: Refactor KHistoryComboBox::insertItems

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH refa REVISION DETAIL https://phabricator.kde.org/D25754 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25752: EBN extra-cmake-modules comments spelling cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-spelling-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25752 To: jhayes, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n,

D25753: EBN extra-cmake-modules transport cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n,

D25746: Adapt to change in KConfigCompiler

This revision was automatically updated to reflect the committed changes. Closed by commit R296:12b3c947a8a4: Adapt to change in KConfigCompiler (authored by apol). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25746?vs=70912=70921 REVISION DETAIL

D25746: Adapt to change in KConfigCompiler

apol added a comment. I'll land this for now because the alternative is to have this not working. Maybe it would make sense to include a KConfigSkeletonItem::propertyName property? Or even a KConfigSkeletonItem::notifySignal(KConfigSkeleton*)? Then here we could just consume the

D25746: Adapt to change in KConfigCompiler

apol created this revision. apol added reviewers: Frameworks, tcanabrava, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Properties need to start with lower-case letters, otherwise QML won't

D25734: MAke it compile without deprecated method

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH make_it_compile_deprecated (branched from master) REVISION DETAIL https://phabricator.kde.org/D25734 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25727: Expose enum to the metaobject compiler

apol updated this revision to Diff 70895. apol added a comment. Export the namespace REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70872=70895 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25727 AFFECTED FILES

D25727: Expose enum to the metaobject compiler

apol created this revision. apol added a reviewer: jbbgameich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Should Help the PersonActionsModel work on QML REPOSITORY R307 KPeople BRANCH master

D25620: Register ActionType enum with metaobject system

apol added a comment. Hi, thanks for your patience. Can you check if this works? https://phabricator.kde.org/D25727 Can you share a test case that uses it? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc:

D25721: EBN kdeclarative transfer protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25721 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

apol added a comment. +1 it doesn't seem to me that shift+delete is used elsewhere. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25719: EBN KActivites transfer protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25719 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24046: Allow triggering sort from QML

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH fo REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: mpyne, jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

apol added a comment. What do you mean by `Can easily be done otherwise.`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25704: [kfilewidget] Load icons by name

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH icco REVISION DETAIL https://phabricator.kde.org/D25704 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

apol added a comment. +1 Makes sense to me REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D25700 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc: plasma-devel, LeGast00n,

D25671: Fix git builds against Qt 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R129:771ed0c4f8c2: Fix git builds against Qt 5.14 (authored by apol). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25671?vs=70706=70734 REVISION

D25673: Deprecate KServiceTypeProfile

apol added inline comments. INLINE COMMENTS > kservicetypeprofile.h:50 > * @param disabledServices List of services which are normally associated > with this serviceType, > * but which should be disabled, i.e. trader queries will not return them. > */ @deprecated 5.65 REPOSITORY R309

D25671: Fix git builds against Qt 5.14

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's not really acceptable to just error on everything since some of the solutions (like in this

D25661: Simplify null check

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH nulll REVISION DETAIL https://phabricator.kde.org/D25661 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Add member for editbookmarks action

apol added a comment. Maybe this is too of an intermediate step? this patch doesn't really do anything. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25659: Add TODO KF6 note

apol added a comment. I'm unsure such comments are useful. :/ Maybe it would work better as a phabricator task or so? REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25659 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25657: Clean up includes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH incl REVISION DETAIL https://phabricator.kde.org/D25657 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25656: Remove unneeded moc include

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH moc REVISION DETAIL https://phabricator.kde.org/D25656 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:72 > add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00) > # Subdirectories > add_definitions(-DTRANSLATION_DOMAIN=\"kxmlgui5\") This comment

D25638: autotests: Find perl executable on all platforms

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:93 > - set(_runner ${CMAKE_CURRENT_SOURCE_DIR}/runsingletestcase.pl) > - if(WIN32) > -set(_runner ${PERL_EXECUTABLE} ${_runner}) maybe it would make sense to check for BSD instead? I don't know much about BSD, but I'd expect the

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R36 Ark BRANCH l-qsortproxy (branched from master) REVISION DETAIL https://phabricator.kde.org/D25631 To: ahmadsamir, #ark, elvisangelaccio, apol Cc: apol,

D25629: Port away from KTextWidgets

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R263 KXmlGui BRANCH tw REVISION DETAIL https://phabricator.kde.org/D25629 To: nicolasfella, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25620: Register ActionType enum with metaobject system

apol added a comment. the Q_ENUM looks good. INLINE COMMENTS > personactionsmodel_p.h:24 > > +#include "widgets/actions.h" > + Why do we need the include? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc: kde-frameworks-devel,

D25605: Port to QRegularExpression

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R243 KArchive BRANCH port_to_qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D25605 To: mlaurent, dfaure, apol Cc: apol,

D25575: remove unused kgesturemap from kaction

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D25575 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25564: Fix conflicts of shortcuts

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R480 Kipi Plugins BRANCH master REVISION DETAIL https://phabricator.kde.org/D25564 To: guoyunhe, #frameworks, apol

D25552: Deprecate top-level UserIcon method, no longer used

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D25552 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25233: [kded] Port plugin metadata to JSON

apol added a comment. +1 REPOSITORY R363 Print Manager REVISION DETAIL https://phabricator.kde.org/D25233 To: nicolasfella, #frameworks, dantti, #kf6 Cc: apol, kde-utils-devel

D25528: Only build activities support if QtSQL is found

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH clean REVISION DETAIL https://phabricator.kde.org/D25528 To: nicolasfella, #frameworks, apol Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D25528: [activities] Clean up cmake

apol added a comment. This patch is changing the logic. I'd recommend changing the commit message to reflect it. INLINE COMMENTS > CMakeLists.txt:150 > add_subdirectory( about ) > -if(KF5Activities_FOUND) > +if(KF5Activities_FOUND AND Qt5Sql_FOUND) >add_subdirectory( activities ) I'd

D25511: Drop unused broken KGesture support

apol added a comment. In D25511#567355 , @vkrause wrote: > Right, kdelibs4support seems to include the deleted private headers, and uses these types in public API in KAction. 臘 REPOSITORY R263 KXmlGui REVISION DETAIL

D25512: Remove unused include

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH incl REVISION DETAIL https://phabricator.kde.org/D25512 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25511: Drop unused broken KGesture support

apol added a comment. In D25511#567036 , @vkrause wrote: > Seems used in KAction in kdelibs4support. how does it make a difference? it's already commented. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25511

D25460: Add a descriptive warning when inotify_add_watch returned ENOSPC

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D25460 To: meven, #frameworks, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25442: Set application name and version on the knshandler tool

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Is the store having a big impact from this handler? REPOSITORY R252 Framework Integration BRANCH set-knshandler-name-and-version (branched from master) REVISION DETAIL

D25448: EBN cleanup of autests transfer protocal

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Do you have a commit account? REPOSITORY R267 Oxygen Icons BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25448 To: jhayes, apol Cc: apol,

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

apol added a comment. +1 LGTM REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25226 To: ngraham, #vdg, #frameworks Cc: apol, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22946: Include API to generically implement --replace arguments

This revision was automatically updated to reflect the committed changes. Closed by commit R271:75cf9e495edd: Include API to generically implement --replace arguments (authored by apol). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22946?vs=70043=70044

D22946: Include API to generically implement --replace arguments

apol updated this revision to Diff 70043. apol added a comment. Remove wrong comment REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22946?vs=69997=70043 BRANCH arcpatch-D22946 REVISION DETAIL https://phabricator.kde.org/D22946 AFFECTED FILES

D22946: Include API to generically implement --replace arguments

apol updated this revision to Diff 69997. apol added a comment. Made the code less "racey" REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22946?vs=69147=69997 BRANCH arcpatch-D22946 REVISION DETAIL https://phabricator.kde.org/D22946 AFFECTED

D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH doc REVISION DETAIL https://phabricator.kde.org/D25396 To: nicolasfella, #plasma, broulik, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25331: Duplicate QML installation for unit tests

apol accepted this revision. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25331 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25331: Duplicate QML installation for unit tests

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Maybe wrap in if(BUILD_TESTING) REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25331 To: davidedmundson, apol Cc: apol, kde-frameworks-devel,

D25270: Correctly set i18n arguments in one pass

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D25270 To: davidedmundson, leinir, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25308 To: sitter, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25265: Support adding a contact to a specific backend

apol added inline comments. INLINE COMMENTS > datasourcemodel.h:43 > +enum RoleNames { > +PluginIdRole = Qt::UserRole + 1, > +}; Use DisplayRole for this? > personpluginmanager.h:91 > + * Creates a contact with the specified @p properties > + * in the requested backend

D25193: use more modern for construct

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D25193 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25192: Replace for with maths with range for

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D25192 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25164 To: meven, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25159: Fix linking to libssh 0.9.1

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Fixes the build for me too, patch looks good. Thanks! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol Cc: apol, asturmlechner,

D25143: Basic cross-compiling support for parsetrigrams

apol accepted this revision. apol added a comment. LGTM, thanks for looking into this! REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D25143 To: vkrause, cullmann, apol Cc: apol, cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella Cc:

D25154: actually set a dependency between kcrashtest and test_crasher

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH test-dep REVISION DETAIL https://phabricator.kde.org/D25154 To: sitter, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25153: disable kcrashtest and its helper executable test_crasher on windows

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D25153 To: sitter, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

apol added a comment. +1 makes a lot of sense overall. INLINE COMMENTS > filecopyjob.h:74 > bool doResume() override; > -bool doKill() override; > I don't think this change is ABI compatible (though after reading the docs, I'm not 100% sure).

D25115: Add guard for missing kirigami

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D25115 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25113: ftp ioslave: remove redundant variable

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25113 To: meven, #frameworks, kossebau, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25107: Add install dir for systemd units

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D25107 To: davidedmundson, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D22946: Include API to generically implement --replace arguments

apol marked an inline comment as done. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D22946 To: apol, #frameworks, davidedmundson Cc: davidedmundson, broulik, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22946: Include API to generically implement --replace arguments

apol updated this revision to Diff 69147. apol added a comment. Rebase and get inspiration from 5bf091ee07ac44ed1bf1e75a4d07847edb86c5d6 as suggested by David REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE

D24726: Fix null pointer reference when extraction fails

apol added a comment. Have you looked into creating a unit test for this? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24726 To: pvuorela, davidllewellynjones, dfaure, aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

apol added a comment. This is really interesting, I can expect this to make the whole thing much faster. INLINE COMMENTS > file_unix.cpp:55 > +// On Linux, write() (and similar system calls) will transfer at most > +// 0x7000 (2,147,479,552) bytes, returning the number of bytes > +//

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

apol accepted this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D25061 To: aacid, ervin, apol Cc: kde-frameworks-devel, ervin, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25025: decodeBCJ2: Fix assert with broken files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D25025 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25023: Make kconfig_compiler generate code with const

apol added a comment. I don't know if we can do that. There's been some changes we've pulled back assuming people could be installing + exporting classes generated from kconfig_compiler. :/ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25023 To: aacid Cc: apol,

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

apol added a comment. Hi Meven, I guess I didn't make myself clear, sorry about that. This is not what I meant. What I meant was here D24956 you can query the desktop entry directly, we don't need to expose access to it. REPOSITORY R237 KConfig

D24736: Grab the keyboard when KeySequenceItem is recording

apol accepted this revision. REPOSITORY R296 KDeclarative BRANCH grabkeyboard (branched from master) REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks, davidedmundson, apol Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

apol added a comment. +1 Makes sense to me. REPOSITORY R296 KDeclarative BRANCH grabkeyboard (branched from master) REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks, davidedmundson Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

apol added a comment. you may want to explain a bit more what you mean there. it could make sense to keep the TODO in the .cpp file, no need to get it on every user REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24999 To: meven, #frameworks, dfaure Cc: apol,

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH enableallqtkfdeprecationwarningsforframeworks REVISION DETAIL https://phabricator.kde.org/D24990 To: kossebau, #frameworks, #build_system, apol Cc:

<    1   2   3   4   5   6   7   8   9   10   >