Re: Review Request 124542: CMake fixes for Windows build

> On July 31, 2015, 8:18 a.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > no-op? > > Kevin Funk wrote: > Not a no-op, this code is written into cmake_install which is used for > the 'inst

Re: Review Request 124542: CMake fixes for Windows build

> On July 31, 2015, 5:19 p.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > I can't see how setting a variable to itself can possibly change > > anything, or make any sense (other than an extrem

Re: Does frameworks allow move semantics unconditionally?

On Friday 31 July 2015 15:11:56 Alex Merry wrote: > So when you say "move semantics", what does that encompass? You can use > rvalue references in 2010 just fine, but someone would need to check that > Qt detects that properly and provides appropriate overloads of various >

Re: Does frameworks allow move semantics unconditionally?

On Thursday 30 July 2015 20:46:24 Mark Gaiser wrote: > On Thu, Jul 23, 2015 at 9:59 PM, Mark Gaiser wrote: > > Hi, > > > > The wiki page doesn't state it explicitly [1]. > > > > The status of move semantics when searching for the status of N3053 on the > > compilers that frameworks support: > >

Re: date + releaseinfo in frameworks docbooks

On Wednesday 29 July 2015 15:40:22 Burkhard Lück wrote: > Hi Frameworks devels, > > a lot of frameworks manpage docbooks have wrong date entries (pre kf5) or > strange release entries like 0.01.01 or missing entry, see comments on > https://techbase.kde.org/Projects/Documentation/KDE4_(health_tabl

Re: Review Request 124525: Add KMessageWidget to designer plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124525/#review83157 --- Ship it! Ship It! - Alex Merry On July 29, 2015, 2:19 p.m

Re: Review Request 124482: Search for required perl modules.

src/CMakeLists.txt:4 (kdoctools_encode_uri) -- Configuring incomplete, errors occurred! With perl-uri installed, the REQUIRED packages found list includes: * PerlModules , <http://www.cpan.org> Thanks, Alex Merry ___ Kde-frameworks-devel m

Review Request 124482: Search for required perl modules.

l-uri installed, the REQUIRED packages found list includes: * PerlModules , <http://www.cpan.org> Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/#review82733 --- Ship it! Ship It! - Alex Merry On May 26, 2015, 8:04 p.m

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

015, 8:04 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123031/ > ------- > &

Re: Review Request 124328: Man pages for kapidox

--- On July 15, 2015, 5:48 a.m., Scott Kitterman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124328/ > -

Re: Review Request 124328: Man pages for kapidox

27;s no need to repeat the destination directory - the second part of the tuple is a list, so all the files can go in a single list. - Alex Merry On July 11, 2015, 9:34 p.m., Scott Kitterman wrote: > > --- > This is an automaticall

Re: This list needs more moderators

On Thursday 18 June 2015 21:44:29 Albert Astals Cid wrote: > I just came back from a 3 week holiday and there's emails (with one dating > back from June 1) that have not been moderated. > > So i guess we need more hands for the next time i decide to go on holiday :D I'm happy to volunteer. Alex

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

tps://git.reviewboard.kde.org/r/124104/#comment56047> A bit late to the party, sorry, but this would be better as message(WARNING "..."). - Alex Merry On June 21, 2015, 12:16 a.m., Aleix Pol Gonzalez wrote: > > --- >

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

for QtWidgets should be omitted only when Kross is built in that way. - Alex Merry On May 26, 2015, 8:04 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Problem using Vc with CMake 3.0 and kf5

On Monday 25 May 2015 15:31:52 Boudewijn Rempt wrote: > http://www.valdyas.org/~boud/vc-cmake-3.tgz is as minimal as I know how to > make it: you still need qt, KDELibs4Support and extra-cmake-modules > installed. After that, running cmake and make VERBOSE=1 will give the > exact problem I've got.

Re: Problem using Vc with CMake 3.0 and kf5

On Monday 25 May 2015 13:50:08 Boudewijn Rempt wrote: > On Mon, 25 May 2015, Alex Merry wrote: > > Ah, yes. You may get somewhere with > > include_directories($) > > > > Basically, this should replace all those semicolons in the generated > > output > > wit

Re: Problem using Vc with CMake 3.0 and kf5

On Monday 25 May 2015 13:03:40 Boudewijn Rempt wrote: > On Mon, 25 May 2015, Alex Merry wrote: > > The issue here is that Vc's macros implicitly assume that all compilation > > flags (including include paths) are done at the directory level (with > > include

Re: Problem using Vc with CMake 3.0 and kf5

On Saturday 23 May 2015 11:51:55 Boudewijn Rempt wrote: > Sorry for the extensive cross-posting in advance, please when replying, do > a reply-all. > > Just so everyone is on the same page: Vc is a template library that makes > it easy to build vectorized code using a single source file. Krita use

Re: Kross module loading is broken since KF5.0.0

On Wednesday 13 May 2015 15:42:42 Alexander Potashev wrote: > 2015-05-12 14:39 GMT+03:00 Vishesh Handa : > > On Mon, May 11, 2015 at 6:37 PM, Alexander Potashev > > > > wrote: > >> 3. Make module names case insensitive. This can be implemented in > >> Kross framework by listing and filtering dire

Re: Install location of myframework_version.h headers

On Wednesday 13 May 2015 08:37:19 Kevin Funk wrote: > Right, and I just noticed a problem I didn't think of before: There's no > $PREFIX/include/KF5/$myframework/ where I could install > ${myframework}_version.h into for some of the frameworks :) > > KConfig for instance has two libs, but only ins

Re: debugfull -> debug

On Thursday 07 May 2015 22:57:47 Jaroslaw Staniek wrote: > Hi, > As with some other bits of knowledge during porting today I just share this > one: > > https://community.kde.org/index.php?title=Calligra/Building/3&diff=42353&old > id=42349 > > When you use Qt4/KF5, debugfull is dead [1] so you'd

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

in e-c-m (which tend to make use of http://api.kde.org/ecm/module/ECMFindModuleHelpers.html) - Alex Merry On May 6, 2015, 8:12 a.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:36 p.m., Alex Merry wrote: > > modules/ECMGeneratePriFile.cmake, lines 178-180 > > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line178> > > > > I think there should be an argument that could be passed to d

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:36 p.m., Alex Merry wrote: > > modules/ECMGeneratePriFile.cmake, lines 178-180 > > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line178> > > > > I think there should be an argument that could be passed to d

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

tps://git.reviewboard.kde.org/r/123491/#comment54301> I think there should be an argument that could be passed to disable this (NO_TESTS?). Not all downstream users may want such a test. - Alex Merry On April 24, 2015, 3:26 p.m., Albert Astals Cid

Re: Syncing ECM release number with KF5

On Monday 06 April 2015 02:57:11 Michael Palimaka wrote: > On 04/04/15 19:44, David Faure wrote: > > But since both Stephen Kelly and Alex Merry (maintainers of ECM) are in > > favour of switching, I'll make the switch. Well, there's a bit of a difference between &qu

Re: cmake CMP0028 & missing targets - what does one do about it?

On Wednesday 01 April 2015 21:39:45 Alex Merry wrote: > This appears to be a regression with the 3.0 branch of CMake. 2.8.12 doesn't > have an issue, and neither does 3.1.3. For reference: http://www.cmake.org/Bug/view.php?id=15101 Alex

Re: cmake CMP0028 & missing targets - what does one do about it?

On Wednesday 01 April 2015 08:59:30 Harald Sitter wrote: > On Tue, Mar 31, 2015 at 9:29 PM, Alex Merry wrote: > > On Thursday 19 March 2015 14:16:35 Harald Sitter wrote: > >> Problem tldr: target A links library B, A doesn't get the includes of > >> link libraries

Re: cmake CMP0028 & missing targets - what does one do about it?

On Tuesday 31 March 2015 20:29:25 Alex Merry wrote: > On Thursday 19 March 2015 14:16:35 Harald Sitter wrote: > > Problem tldr: target A links library B, A doesn't get the includes of > > link libraries of B by default. e.g. A links B, B links karchive, A > > doesn

Re: cmake CMP0028 & missing targets - what does one do about it?

On Thursday 19 March 2015 14:16:35 Harald Sitter wrote: > Problem tldr: target A links library B, A doesn't get the includes of > link libraries of B by default. e.g. A links B, B links karchive, A > doesn't have access to the karchive headers. also if karchive wasn't > found in a super-scope of A

Re: Syncing ECM release number with KF5

On Wednesday 25 March 2015 22:35:24 Stephen Kelly wrote: > Hello, > > ECM release numbers are in sync with KF5 release numbers, except for the > major component. > > This means that if you want to build the 5.x.y release you have to download > the 1.x.y release of ECM. That doubles the complexity

Re: KDE Frameworks 5.8

On Saturday 07 March 2015 19:59:09 David Faure wrote: > On Saturday 07 March 2015 19:32:07 šumski wrote: > > it uses DATA_INSTALL_DIR/$wanted_dir, rest of KF5 uses > > KDE_INSTALL_DATADIR_KF5/$wanted_dir (this is not about variable name, but > > location on the filesystem) > > Hmm, KAuth still use

Re: KDE_INSTALL_USE_QT_SYS_PATHS as default

On Friday 06 March 2015 20:26:40 Albert Astals Cid wrote: > El Dijous, 5 de març de 2015, a les 13:00:50, Aleix Pol va escriure: > > Hi, > > It's been on some occasions already that I've seen reports of people > > trying to get some KDE application installed and complaining (mostly > > the ones bas

Re: Review Request 122754: Remove use of KI18N_MODULE_DIR.

a55f472bdfdebd2e353064f102c1f1372fdf0918 Diff: https://git.reviewboard.kde.org/r/122754/diff/ Testing --- Built, run `make test`. Built and installed ktexteditor (uses ki18n_wrap_ui). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 122754: Remove use of KI18N_MODULE_DIR.

Diff: https://git.reviewboard.kde.org/r/122754/diff/ Testing (updated) --- Built, run `make test`. Built and installed ktexteditor (uses ki18n_wrap_ui). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 122754: Remove use of KI18N_MODULE_DIR.

--- Built, run `make test`. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122751: Let ecm_configure_package_config_file manage path variables.

KF5DocToolsConfig.cmake.in eff3d70ae2dcd8711e340306a7fbd1f2d6ca3ece Diff: https://git.reviewboard.kde.org/r/122751/diff/ Testing --- Ran cmake with and without absolute KDE_INSTALL_DATADIR path set. Checked generated KF5DocToolsConfig.cmake by eye. Thanks, Alex Merry

Review Request 122751: Let ecm_configure_package_config_file manage path variables.

://git.reviewboard.kde.org/r/122751/diff/ Testing --- Ran cmake with and without absolute KDE_INSTALL_DATADIR path set. Checked generated KF5DocToolsConfig.cmake by eye. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 122654: Rework PSD plugin.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122654/ --- Review request for KDE Frameworks and Alex Merry. Repository

Re: Review Request 122650: Make PSD image reader endianess-agnostic.

marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- By using the same strategy as the SoftImage PIC handler (and sharing some code with it), we should avoid reading the image data incorrectly on big-endian architectures. Diffs

Review Request 122650: Make PSD image reader endianess-agnostic.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122650/ --- Review request for KDE Frameworks and Alex Merry. Repository

Re: Web shortcuts context menu

On Sunday 15 February 2015 17:37:01 Eike Hein wrote: > Hi, > > about two years(?) ago I wrote a Web Shortcuts context > menu for Konversation: > > http://wstaw.org/m/2015/02/15/ctx.png That link doesn't work - could you attach it to an email, please? Alex ___

Re: C++11 policy in frameworks?

On Sunday 08 February 2015 18:18:48 Aleix Pol wrote: > On Sun, Feb 8, 2015 at 5:55 PM, Jeremy Whiting wrote: > > Hey all, > > > > In trying to get kf5 built on an older machine with clang 3.7 I've hit an > > isuse with kdeclarative. A few days ago some code was checked into it that > > uses std::

Re: Review Request 122359: Create an uninstall target by default in KDE projects.

/ecm_uninstall.cmake.in PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122359/diff/ Testing --- Checked with KCoreAddons. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: reviving make uninstall?

On Friday 30 January 2015 10:08:09 Alex Merry wrote: > Well, if there's demand for it, I don't personally have any objections to > adding it back in. It could go in KDECMakeSettings in e-c-m, although I > think I'd want to check with the kde-core-devel and/or kde-deve

Re: reviving make uninstall?

On Thursday 29 January 2015 13:29:35 Mark Gaiser wrote: > On Thu, Jan 29, 2015 at 12:46 PM, Sebastian Kügler wrote: > > On Thursday, January 29, 2015 00:32:08 Martin Klapetek wrote: > > > > It's only used by developers anyways, so why bother? If it makes life > > > > simpler > > > > for devs, it s

Re: reviving make uninstall?

On Wednesday 28 January 2015 17:10:41 Milian Wolff wrote: > Hello all, > > why was the uninstall target removed from make files in frameworks? I cannot > find any discussion regarding that on the web. > > As a developer, I find it highly frustrating that I now have to do this job > manually by go

Re: Review Request 122178: kdbusaddons: add KDEDModule::moduleForMessage for code sharing between kded and kiod.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122178/#review74655 --- Ship it! Ship It! - Alex Merry On Jan. 21, 2015, 9:03 a.m

Re: Review Request 121448: Introduce ECMAddAppIcon.

nd module. I've improved the documentation as well, and refactored the code so that more is run on all platforms (which makes debugging easier for users of the module and for developers of e-c-m). It is, however, completely untested for now. - Alex Merry On Dec. 15, 2014, 8:01 a.m.,

Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

, 1 failed, 0 skipped, 0 blacklisted * Finished testing of KSycocaDictTest * With the patch, it succeeds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

> On Jan. 11, 2015, 1:03 a.m., David Faure wrote: > > Can you explain to me what the patch really changes? AFAICS this is a > > no-op. The same logic with a different syntax. > > Alex Merry wrote: > Lazy evaluation of || means that if KSycoca::isAvailable() return

Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

t; KServiceTypeFactory::KServiceTypeFactory(): "Could not open sycoca database, > you must run kbuildsycoca first!", file > /home/kde-devel/src/frameworks/kservice/src/services/kservicetypefactory.cpp, > line 38 > FAIL! : KSycocaDictTest::initTestCase() Received a fatal error. &

Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

rst!", file /home/kde-devel/src/frameworks/kservice/src/services/kservicetypefactory.cpp, line 38 FAIL! : KSycocaDictTest::initTestCase() Received a fatal error. Loc: [Unknown file(0)] Totals: 0 passed, 1 failed, 0 skipped, 0 blacklisted * Finished testing of KSycoca

[kde-dev-scripts] kf5: Add script to convert to new KDEInstallDirs variable names.

Git commit 98d6363ad17559b87e8b203954381727ebd305d8 by Alex Merry. Committed on 10/01/2015 at 16:23. Pushed by alexmerry into branch 'master'. Add script to convert to new KDEInstallDirs variable names. This is a separate script to adapt_cmakelists_file.pl, because it produces CMak

Re: KF 5.6 changelog

On Thursday 08 January 2015 17:07:40 Daniel Vrátil wrote: > On Saturday, January 03, 2015 02:16:30 PM David Faure wrote: > > With cookies to Kai Uwe Broulik for using "CHANGELOG:" in most of his > > commits! > > The KPackage frameworks is Tier 2 and depends on KDocTools, which is also > Tier 2, wh

Re: Infopage in frameworkintegration

On Monday 07 July 2014 23:49:50 David Faure wrote: > On Saturday 26 April 2014 13:26:31 Alex Merry wrote: > > FrameworkIntegration installs a bunch of images and css files to > > ${DATA_INSTALL_DIR}/kf5/infopage. LXR suggests nothing ever references > > an "infopage&quo

Re: KF 5.6 changelog

On Thursday 08 January 2015 17:07:40 Daniel Vrátil wrote: > On Saturday, January 03, 2015 02:16:30 PM David Faure wrote: > > With cookies to Kai Uwe Broulik for using "CHANGELOG:" in most of his > > commits! > > The KPackage frameworks is Tier 2 and depends on KDocTools, which is also > Tier 2, wh

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

On Wednesday 07 January 2015 20:15:54 Christoph Cullmann wrote: > Hi, > > I see why KDE_INSTALL_TARGETS_DEFAULT_ARGS and INSTALL_TARGETS_DEFAULT_ARGS > fail on Mac, typo: > > # on the Mac support an extra install directory for application bundles > if(APPLE) > set(KDE_INSTALL_TARGETS_DEFAULT_

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > P.P.S.: I realised by now that there are no changes on the production > branch, which probably means that there was some change in ECM or wherever > provoking these issues... I'm somewhat puzzled, as INSTALL_TARGET_DEFAULT_ARGS should still

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

On Wednesday 07 January 2015 08:38:27 Kevin Funk wrote: > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > > Hi Christoph, > > > > I’ve found that these projects do not make use of > > > > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: > > - systemsettings > > - muon > > - rocs > >

Re: KF 5.6 changelog

On Saturday 03 January 2015 14:16:30 David Faure wrote: > With cookies to Kai Uwe Broulik for using "CHANGELOG:" in most of his > commits! Oh, yes, that would have been a good idea - I'd forgotten about that keyword. Can you change the first buildsystem log to: * ECM's KDEInstallDirs now support

Re: qca-qt5 package name

On Saturday 27 December 2014 12:24:25 Harald Sitter wrote: > I think(tm) the way to fix this properly (which I have not ever seen > done by us :P) is fiddling with the find_package related variables > (supposedly PACKAGE_VERSION_COMPATIBLE would be used) to indicate that > a given candidate package

Re: Review Request 121448: Introduce ECMAddAppIcon.

> On Dec. 12, 2014, 2:08 p.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > <https://git.reviewboard.kde.org/r/121448/diff/1/?file=332663#file332663line15> > > > > Would this actually work? The code looks to me like pattern_rx would >

Re: Review Request 121448: Introduce ECMAddAppIcon.

> On Dec. 12, 2014, 2:08 p.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > <https://git.reviewboard.kde.org/r/121448/diff/1/?file=332663#file332663line15> > > > > Would this actually work? The code looks to me like pattern_rx would >

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

://git.reviewboard.kde.org/r/121400/#comment50087> Why not: string(REGEX REPLACE "^([0-9]+)\.([0-9]+)\.([0-9]+).*" "\1,\2,\3,0" RC_VERSION_COMMAS "${RC_VERSION}") ? - Alex Merry On Dec. 10, 2014, 11:57 p.m., Nicolás Alvarez wrote: > >

Re: Review Request 121448: Introduce ECMAddAppIcon.

x would just be the filename again, so fn would be empty, and the icon would never be appended to _list. - Alex Merry On Dec. 12, 2014, 1:34 p.m., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

> On Dec. 10, 2014, 8:38 p.m., Alex Merry wrote: > > What happens if you miss out an argument (ie: you put an empty string in > > the file)? Is that the same as not including the corresponding VALUE line > > in the file at all? > > > > Also, it would be nice

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

some reason. The default should still be PROJECT_VERSION, of course (but your function should check it is set and cause a fatal error otherwise). - Alex Merry On Dec. 9, 2014, 5:01 a.m., Nicolás Alvarez wrote: > > --- > This is an

Re: Review Request 120947: Define for ecm_create_qm_loader

iable and not using it. - Alex Merry On Nov. 2, 2014, 7:54 p.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On Oct. 21, 2014, 9:08 p.m., Alex Merry wrote: > > Ship It! > > Marko Käning wrote: > Hi Alex, did you test this successfully on Windows? No, I'm expecting Luigi to interpret my shipit as approval of the CMake code in principle, and to exercise his own judgement i

Re: Review Request 120648: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68855 --- Ship it! Ship It! - Alex Merry On Oct. 20, 2014, 12:12

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On Oct. 19, 2014, 10:52 a.m., Alex Merry wrote: > > src/CMakeLists.txt, line 19 > > <https://git.reviewboard.kde.org/r/120648/diff/1/?file=320540#file320540line19> > > > > You've already included it above... > > Luigi Toscano wrote: > Th

Re: Review Request 120648: Encode the URIs which end up in DTD files

the perl script. src/CMakeLists.txt <https://git.reviewboard.kde.org/r/120648/#comment47897> You've already included it above... - Alex Merry On Oct. 18, 2014, 3:50 p.m., Luigi Toscano wrote: > > --- > T

Re: Review Request 120648: Encode the URIs which end up in DTD files

tes in the URIs? It's probably not worth making it more reslient, given the extra complexity that would entail (you'd either have to do some pre-escaping or write it out to a temporary file, given the lack of an INPUT_VARIABLE option to execute_process. - Alex Merry On Oct. 18, 20

Solid compilation issue

Hey, I'm running into an issue compiling Solid: [ 96%] Building CXX object autotests/CMakeFiles/logindinhibitionargument.dir/logindinhibitionargumenttest.cpp.o In file included from /home/kde- devel/src/frameworks/solid/autotests/logindinhibitionargumenttest.cpp:22:0: /home/kde- devel/src/framew

Re: frameworks' cmake configs looking for other things

On Friday 10 Oct 2014 17:49:10 Harald Sitter wrote: > Alohas > > as described in [1] I think there is a bit of a problem how we track > inter-dependencies in cmake configs right now (that is: the configs > frameworks install to be found by 3rd party bits). > > If I write a 3rd party software that

tier 1 optional dependencies on kdoctools? (was: Re: desktoptojson man page)

On 2014-10-03 13:36, Burkhard Lück wrote: Am Freitag, 3. Oktober 2014, 12:22:03 schrieb Alex Merry: On 2014-09-16 09:55, Sune Vuorela wrote: > On 2014-09-15, Alexander Richardson wrote: >> However, is this even possible? Building manpages seems to require >> KDocTools >>

Re: Problem with kdeinit and StartupInfo

On 2014-10-04 10:08, David Faure wrote: On Friday 03 October 2014 12:15:09 Alex Merry wrote: Note that KDBusService has a known limitation where it just doesn't work with startup notifications in unique mode - the necessary information is never passed to the main application by the seco

Re: Review Request 119805: Use "svn export" to fetch KDE identities if possible, and cache them

y present. Also ran kgenframeworksapidox (python2), and checked that David Faure was correctly listed as the maintainer of KArchive, with an email address. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.

Re: Review Request 119805: Use "svn export" to fetch KDE identities if possible, and cache them

committing this. - Alex Merry On Aug. 17, 2014, 10:10 a.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 119808: Move module metadata to after class picker

ttachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2014/08/18/66921e40-9e30-4231-a01e-da2d3c26d979__about_below_class_picker.png Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde

Re: Review Request 119808: Move module metadata to after class picker

> On Aug. 19, 2014, 10:19 a.m., Aleix Pol Gonzalez wrote: > > I think it's disputable that the developers will want to interact with the > > "File List" more often. I think this shows we want a new design after all. > > > > For the moment, I won&#x

Re: kio_trash

On 2014-09-22 21:26, David Faure wrote: On Saturday 13 September 2014 20:29:18 Luigi Toscano wrote: Luigi Toscano ha scritto: > Nicolás Alvarez ha scritto: >> 2014-09-13 15:13 GMT-03:00 Nicolás Alvarez : >>> Done. The resulting history looks kind of weird though, because we >>> have the full his

Re: baloo fails to compile

On 2014-09-28 18:04, Andriy Rysin wrote: I cleaned all build and install files but baloo refuses to compile in master: -- Found Gettext: /usr/bin/msgmerge (found version "0.18.3") -- Found PythonInterp: /usr/bin/python (found version "2.7.5") -- Found KF5I18n: /home/kde5dev/kde5/install/lib64/cm

Re: desktoptojson man page

On 2014-09-16 09:55, Sune Vuorela wrote: On 2014-09-15, Alexander Richardson wrote: However, is this even possible? Building manpages seems to require KDocTools and kcoreaddons is a tier1 framework which would make this impossible. Do we really need a manpage for it? It seems to me that it is

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

On 2014-09-17 10:47, Martin Gräßlin wrote: Hi all, I just prepared moving kglobalacceld from plasma-workspace into kglobalaccel. You can find the code in my personal clone of kglobalaccel at [1] in branch master. The following steps were performed so far: * filter-branch on plasma-workspace

Re: Problem with kdeinit and StartupInfo

On 2014-09-11 10:46, Christoph Cullmann wrote: Hi, for Kate, the startup info doesn't work atm in frameworks. If you launch dolphin KF5 version and open one file => fine, second file => dolphin blocks and startup info doesn't happen. If you look at the logs, you see: (1975)/(default) KXMessa

Re: Review Request 120196: Find-Module to detect libgit2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66594 --- Ship it! Ship It! - Alex Merry On Sept. 15, 2014, 6:56

Re: Review Request 120196: Find-Module to detect libgit2

cially once you remove VERSION_STRING). find-modules/FindLibGit2.cmake <https://git.reviewboard.kde.org/r/120196/#comment46412> Don't need this one in a completely new module. - Alex Merry On Sept. 15, 2014, 6:

Re: Review Request 119798: Generating PkgConfig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review66143 --- Ship it! Ship It! - Alex Merry On Sept. 7, 2014, 7:57 a.m

Re: Review Request 119798: Generating PkgConfig files from ECM

nder if that should even be a separate argument. modules/ECMGeneratePkgConfigFile.cmake <https://git.reviewboard.kde.org/r/119798/#comment46000> space (receivethe) modules/ECMGeneratePkgConfigFile.cmake <https://git.reviewboard.kde.org/r/119798/#comment46001> missing y (sub

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65740 --- Ship it! Ship It! - Alex Merry On Sept. 1, 2014, 10:24

Re: Review Request 119798: Generating PkgConfig files from ECM

IR to be set, and this will be used in any subsequent calls." modules/ECMGeneratePkgConfigFile.cmake <https://git.reviewboard.kde.org/r/119798/#comment45949> "use the project() (CMake 3.0) or" - Alex Merry On Sept. 1, 2014, 1:53 p.m., Aleix Pol Gonzalez wrote: > >

Re: Review Request 119798: Generating PkgConfig files from ECM

mment45783> You need to document that this is necessary (well, that or using CMake 3 and the version argument of project(), I guess). - Alex Merry On Aug. 26, 2014, 11:51 a.m., Aleix Pol Gonzalez wrote: > > --- > Th

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote: > > modules/ECMQueryQmake.cmake, line 2 > > <https://git.reviewboard.kde.org/r/119901/diff/6/?file=307834#file307834line2> > > > > CMake macros/functions that take a variable name usually take it first. >

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote: > > modules/ECMQueryQmake.cmake, line 1 > > <https://git.reviewboard.kde.org/r/119901/diff/6/?file=307834#file307834line1> > > > > I think we need to be a bit more clever here. I'd go for a cache > &g

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

ault to just "qmake". modules/ECMQueryQmake.cmake <https://git.reviewboard.kde.org/r/119901/#comment45688> CMake macros/functions that take a variable name usually take it first. Swapping the argument order would make it more consistent with

Re: Review Request 119808: Move module metadata to after class picker

le info section visible without scrolling). - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119808/#review64831 ----

Re: Review Request 119798: Generating PkgConfig files from ECM

> On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote: > > modules/ECMGeneratePkgConfigFile.cmake, line 47 > > <https://git.reviewboard.kde.org/r/119798/diff/1/?file=305638#file305638line47> > > > > This belongs in KDEInstallDirs.cmake, not here (as > &

<    1   2   3   4   5   6   7   8   9   10   >